if (ch->flags & IEEE80211_CHAN_DISABLED)
continue;
so it should not been an ERROR. WARN looks fine to me.
you can add me acked-by in v2.
Okay, thanks for explanation and having a look at it.
-Caesar
Regards,
Simon
From: Caesar Wang [mailto:w...@rock-chips.com]
Se
ISABLED)
continue;
So it should not been an ERROR, use the WARN level to instead it for now.
Signed-off-by: Caesar Wang
Acked-by: Xinming Hu
---
Changes in v2:
- Fixes the commit and title as Kalle and Xinming comments on
https://patchwork.kernel.org/patch/9786047/
- Add the Acked
在 2017年06月13日 15:04, Kalle Valo 写道:
Caesar Wang writes:
Kalle,
在 2017年06月13日 14:28, Kalle Valo 写道:
Caesar Wang writes:
We have always met the unused log be printed as following.
...
[23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
cannot find cfp by band 2& channel=13
Kalle,
在 2017年06月13日 14:28, Kalle Valo 写道:
Caesar Wang writes:
We have always met the unused log be printed as following.
...
[23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
cannot find cfp by band 2& channel=13 freq=0
[23378.633684] mwifiex_pcie :01:00.0: mwifiex_get
dBm)
* 2447 MHz [8] (30.0 dBm)
* 2452 MHz [9] (30.0 dBm)
* 2457 MHz [10] (30.0 dBm)
* 2462 MHz [11] (30.0 dBm)
* 2467 MHz [12] (disabled)
* 2472 MHz [13] (disabled)
* 2484 MHz [14] (disabled)
Signed-off-by: Caesar Wang
---
drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
1 file changed, 1 insert
This patch supports the gmac pd to save power consumption.
Even though some boards not need Ethernet support, the driver
core can also take care of powering up the pd before probe.
Signed-off-by: Caesar Wang
---
Changes in v4:
- remove the Roger signed-off for domain patch.
Changes in v3
From: David Wu
Add the gmac power domain support for rk3399, in order to save more
power consumption.
Signed-off-by: David Wu
Signed-off-by: Caesar Wang
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- fixes the build error on next kernel.
drivers/net/ethernet/stmicro/stmmac
From: Roger Chen
We add the required and optional properties for evb board.
See the [0] to get the detail information.
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
Changes in v4: None
Changes in v3: None
Changes in v2
From: Roger Chen
GMAC Power Domain(PD) will be disabled during suspend.
That will causes GRF registers reset.
So corresponding GRF registers for GMAC must be setup again.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
Changes in v4: None
Changes in v3: None
Changes in v2
From: Roger Chen
Add constants and callback functions for the dwmac on rk3228/rk3229 socs.
As can be seen, the base structure is the same, only registers and the
bits in them moved slightly.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
Reviewed-by: Heiko Stuebner
---
Changes in v4
atch/9306339/.
Changes in v2:
- rk_gmac_powerup instead of the rk_gmac_init.
- fixes the build error on next kernel.
- Fixes the order, ss Heiko commnets on
https://patchwork.kernel.org/patch/9305991/
Caesar Wang (1):
arm64: dts: rockchip: add the gmac power domain on rk3399
David Wu (1):
.: interrupts, grf, clocks, pinctrl and so on.
The full details are in [0].
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
Changes in v4:
- The Roger had posted patch on https://patchwork.kernel.org/patch/9274561/.
- re
, clocks, pinctrl and so on.
The full details are in [0].
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Caesar Wang
---
Changes in v3:
- generate a patch from https://patchwork.kernel.org/patch/9306339/.
Changes in v2: None
arch/arm64/boot/dts/rockchip/rk3399.dtsi
We add the required and optional properties for evb board.
See the [0] to get the detail information.
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
Changes in v3: None
Changes in v2: None
arch/arm64/boot/dts/rockchip
://patchwork.kernel.org/patch/9306339/
- generate a patch from https://patchwork.kernel.org/patch/9306339/.
Changes in v2:
- rk_gmac_powerup instead of the rk_gmac_init.
- fixes the build error on next kernel.
- Fixes the order, ss Heiko commnets on
https://patchwork.kernel.org/patch/9305991/
Caesar
This patch supports the gmac pd to save power consumption.
Even though some boards not need Ethernet support, the driver
core can also take care of powering up the pd before probe.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
Changes in v3:
- leave into two patches based on patchv2
From: David Wu
Add the gmac power domain support for rk3399, in order to save more
power consumption.
Signed-off-by: David Wu
Signed-off-by: Caesar Wang
---
Changes in v3: None
Changes in v2:
- fixes the build error on next kernel.
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 9
From: Roger Chen
GMAC Power Domain(PD) will be disabled during suspend.
That will causes GRF registers reset.
So corresponding GRF registers for GMAC must be setup again.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
Changes in v3: None
Changes in v2:
- rk_gmac_powerup instead of
This patch adds needed gamc information for rk3399,
also support the gmac pd.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90
1 file changed, 90 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip
We add the required and optional properties for evb board.
See the [0] to get the detail information.
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 31
This patch add to handle the gmac pd issue, and support
the rk3399 gmac for devicetree.
Caesar Wang (2):
arm64: dts: rockchip: support gmac for rk3399
arm64: dts: rockchip: enable the gmac for rk3399 evb board
David Wu (1):
net: stmmac: dwmac-rk: add pd_gmac support for rk3399
Roger
From: Roger Chen
GMAC Power Domain(PD) will be disabled during suspend.
That will causes GRF registers reset.
So corresponding GRF registers for GMAC must be setup again.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 19
From: David Wu
Add the gmac power domain support for rk3399, in order to save more
power consumption.
Signed-off-by: David Wu
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet
From: Roger Chen
GMAC Power Domain(PD) will be disabled during suspend.
That will causes GRF registers reset.
So corresponding GRF registers for GMAC must be setup again.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 20
From: David Wu
Add the gmac power domain support for rk3399, in order to save more
power consumption.
Signed-off-by: David Wu
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/stmicro
We add the required and optional properties for evb board.
See the [0] to get the detail information.
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 31
This patch add to handle the gmac pd issue, and support
the rk3399 gmac for devicetree.
Caesar Wang (2):
arm64: dts: rockchip: support gmac for rk3399
arm64: dts: rockchip: enable the gmac for rk3399 evb board
David Wu (1):
net: stmmac: dwmac-rk: add pd_gmac support for rk3399
Roger
This patch adds needed gamc information for rk3399,
also support the gmac pd.
Signed-off-by: Roger Chen
Signed-off-by: Caesar Wang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90
1 file changed, 90 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip
] r4:
...
Signed-off-by: Shuyu Wei
Tested-by: Michael Niewoehner
Tested-by: Xing Zheng
Cc: "David S. Miller"
Cc: Alexander Kochetkov
Cc: netdev@vger.kernel.org
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/arc/emac_main.c | 14 +++---
1 file changed, 7 i
Hi Sergei,
在 2016年03月16日 21:57, Sergei Shtylyov 写道:
Hello.
On 3/14/2016 11:01 AM, Caesar Wang wrote:
This patch adds the following property for arc_emac.
1) phy-reset-gpios:
The phy-reset-gpio is an optional property for arc emac device tree
boot.
Change the binding document to match the
From: Xing Zheng
Add the node-id for the emac hclk to the binding header.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
Cc: Xing Zheng
Cc: Michael Turquette
Cc: Heiko Stuebner
Cc: Stephen Boyd
Cc: linux-...@vger.kernel.org
Cc: linux-rockc...@lists.infradead.org
---
Changes in v3
phy-reset-duration for device tree probe, so that the boards that need
a longer reset duration can specify it in their device tree.
Anyway, we can add the above property for arc emac.
Signed-off-by: Caesar Wang
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: "
: Caesar Wang
Cc: "David S. Miller"
Cc: netdev@vger.kernel.org
Cc: Alexander Kochetkov
Cc: Sergei Shtylyov
---
Changes in v3:
- Caused the build error since the missing include head file.
- %s/reset/phy-reset to match the device tree.
- Add the Cc people
Changes in v2:
- As the pervio
From: Xing Zheng
Suitable PLLs for the emac on the rk3036 are difficult to find
and one of them is the (continuously changing) APLL. So in most
cases it will be necessary to select a PLL manually.
So add a clock-id for it.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
Cc: Xing Zheng
This patch will make the driver more readability
The emac has the error and warnings if you run
'scripts/checkpatch.pl -f --subjective xxx' to check.
Let's clean up such trivial details.
Signed-off-by: Caesar Wang
Cc: Jiri Kosina
Cc: "David S. Miller"
Cc: Alexan
ng on set_rate calls.
Signed-off-by: Heiko Stuebner
Cc: Michael Turquette
Cc: Heiko Stuebner
Cc: Stephen Boyd
Cc: linux-...@vger.kernel.org
Signed-off-by: Caesar Wang
---
Changes in v3:
- Add the Cc people.
Changes in v2: None
drivers/clk/rockchip/clk-rk3036.c | 2 +-
1 file changed, 1 inse
From: Xing Zheng
This patch adds the emac device node for rk3036 SoCs.
We need to let mac clock under the DPLL which is able to provide
the accurate 50MHz what mac_ref need, since that will cause some
unstable things if the cpufreq is working.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar
From: Xing Zheng
Associate the new clock id the clock.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
Cc: Xing Zheng
Cc: Michael Turquette
Cc: Heiko Stuebner
Cc: Stephen Boyd
Cc: linux-...@vger.kernel.org
Cc: linux-rockc...@lists.infradead.org
---
Changes in v3:
- Add the Cc
Add the rk3036 SoCs to match driver for document since the emac driver
has supported the rk3036 SoCs.
This patch adds the rk3036/rk3066/rk3188 SoCS to compatible for rockchip
emac ducument. Also, that will suit for other SoCs in the future.
Signed-off-by: Caesar Wang
Cc: Rob Herring
Cc
1c508dfa8c79f1709aa5775e
:)
- As the robot notice the build error since overflow in implicit
constant conversion.
- rename phy-reset-gpio to reset-gpios.
Caesar Wang (4):
net: arc_emac: make the rockchip emac document more compatible
net: arc_emac: add phy reset is optional for devi
在 2016年03月14日 02:02, David Miller 写道:
When you submit a new version of a patch that's part of a series,
you must submit the entire series anew, not just the patch which is
changing.
Thanks for reminding me.
I think it's not good to respin-respin since the build error.
So that just send a bit
: Caesar Wang
---
Changes in v2.1:
- missing the include head file.
Changes in v2:
- As the pervious version, Sergei and Heiko comments on
https://patchwork.kernel.org/patch/8564571/.
- Nevermind, add signed-off since Heiko the original patch,
refer the Heiko's test patch on
https://githu
This patch will make the driver more readability
The emac has the error and warnings if you run
'scripts/checkpatch.pl -f --subjective xxx' to check.
Let's clean up such trivial details.
Signed-off-by: Caesar Wang
---
Changes in v2:
- As the robot notice the build error si
: Caesar Wang
---
Changes in v2:
- As the pervious version, Sergei and Heiko comments on
https://patchwork.kernel.org/patch/8564571/.
- Nevermind, add signed-off since Heiko the original patch,
refer the Heiko's test patch on
https://github.com/mmind/linux-rockchip/c
From: Xing Zheng
Add the node-id for the emac hclk to the binding header.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
---
Changes in v2: None
include/dt-bindings/clock/rk3036-cru.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/clock/rk3036-cru.h
b
From: Xing Zheng
Suitable PLLs for the emac on the rk3036 are difficult to find
and one of them is the (continuously changing) APLL. So in most
cases it will be necessary to select a PLL manually.
So add a clock-id for it.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
---
Changes in
From: zhengxing
This patch adds the emac device node for rk3036.
We need to let mac clock under the DPLL which is able to provide
the accurate 50MHz what mac_ref need, since that will cause some
unstable things if the cpufreq is working.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
ng on set_rate calls.
Signed-off-by: Heiko Stuebner
Signed-off-by: Caesar Wang
---
Changes in v2: None
drivers/clk/rockchip/clk-rk3036.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk-rk3036.c
b/drivers/clk/rockchip/clk-rk3036.c
index cc66e5f..7c
otice the build error since overflow in implicit
constant conversion.
Caesar Wang (4):
net: arc_emac: make the rockchip emac document more compatible
net: arc_emac: add phy reset is optional for device tree
net: arc_emac: support the phy reset for emac driver
net: arc: trivial: cleanup the
-reset-duration for device tree probe, so that the boards that need
a longer reset duration can specify it in their device tree.
Anyway, we can add the above property for arc emac.
Signed-off-by: Caesar Wang
---
Changes in v2: None
Documentation/devicetree/bindings/net/arc_emac.txt | 7
Add the rk3036 SoCs to match driver for document since he emac driver
has supported the rk3036 SoCs.
This patch adds the rk3036/rk3066/rk3188 SoCS to compatible for rockchip
emac ducument. Also, that will suit for other SoCs in the future.
Signed-off-by: Caesar Wang
---
Changes in v2
From: Xing Zheng
Associate the new clock id the clock.
Signed-off-by: Xing Zheng
Signed-off-by: Caesar Wang
---
Changes in v2: None
drivers/clk/rockchip/clk-rk3036.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk-rk3036.c
b/drivers/clk
在 2016年03月12日 02:46, Sergei Shtylyov 写道:
Hello.
On 03/11/2016 05:48 PM, Caesar Wang wrote:
[...]
Hi Rob, David:
PATCH[1/6-2/6]: >
net: arc_emac: make the rockchip emac document more compatible
net: arc_emac: add phy-reset-* are optional for device tree
The patches change the rockc
Hi Sergei,
在 2016年03月12日 02:35, Sergei Shtylyov 写道:
On 03/11/2016 01:55 PM, Caesar Wang wrote:
This patch adds to support the emac phy reset.
1) phy-reset-gpios:
The phy-reset-gpios is an optional property for arc emac device tree
boot.
Change the binding document to match the driver code
Hi Sergei,
在 2016年03月11日 21:46, Sergei Shtylyov 写道:
Hello.
On 3/11/2016 1:55 PM, Caesar Wang wrote:
This series patches are based on kernel 4.5-rc7+ version.
Linux version 4.5.0-rc7-next-20160310+ (wxt@nb) (...) #23 SMP Fri Mar
11 15:55:53
[...]
1) This series has 6 patches: (1---&g
://patchwork.kernel.org/patch/8186801/.
In some cases, the emac couldn't work if you don't have reset the phy.
Let's add it to happy work.
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/arc/emac_main.c | 41
1 file changed, 41 insertions(+)
diff --git a/drive
This patch will make the driver more readability
The emac has the error and warnings if you run
'scripts/checkpatch.pl -f --subjective xxx' to check.
Let's clean up such trivial details.
Signed-off-by: Caesar Wang
---
drivers/net/ethernet/arc/emac.
: dts: rockchip: add support emac for RK3036
Add the emac node info for rk3036 dts/dtsi.
---
Thanks your reviewing! :)
Caesar Wang (4):
net: arc_emac: make the rockchip emac document more compatible
net: arc_emac: add phy-reset-* are optional for device tree
net: arc_emac: support the phy
58 matches
Mail list logo
