Re: [PATCH bpf-next v4 0/3] add batched ops for percpu array

Sorry I missed this. I don't recall why I didn't add the array percpu variant, but LGTM. Acked-by: Brian Vazquez On Fri, Apr 16, 2021 at 3:09 PM Martin KaFai Lau wrote: > > On Thu, Apr 15, 2021 at 02:46:16PM -0300, Pedro Tammela wrote: > > This patchset introduces batc

Re: [PATCH net-next 1/2] net: add EXPORT_INDIRECT_CALLABLE wrapper

Yeah, I'm also not seeing it on patchwork. But I did get the email on both corp and personal email. So maybe something is failing at patchwork? On Thu, Feb 4, 2021 at 9:50 AM George McCollister wrote: > > I don't see the second patch. > > Regards, > George McCollister

Re: [PATCH net-next] net/dst: use a smaller percpu_counter batch for dst entries accounting

On Fri, May 8, 2020 at 11:17 AM Eric Dumazet wrote: > > On Fri, May 8, 2020 at 11:06 AM Eric Dumazet wrote: > > > > On Fri, May 8, 2020 at 10:30 AM Brian Vazquez > > wrote: > > > > > > On Thu, May 7, 2020 at 7:00 PM Eric Dumazet wrote: > > >

Re: [PATCH net-next] net/dst: use a smaller percpu_counter batch for dst entries accounting

On Thu, May 7, 2020 at 7:00 PM Eric Dumazet wrote: > > percpu_counter_add() uses a default batch size which is quite big > on platforms with 256 cpus. (2*256 -> 512) > > This means dst_entries_get_fast() can be off by +/- 2*(nr_cpus^2) > (131072 on servers with 256 cpus) > > Reduce the batch size

Re: [RFC PATCH bpf-next v2 1/2] bpf: adding map batch processing support

Hi Yonghong, thanks for working on this! I have some concerns about this implementation but overall I think this might work for our use case too! On Sun, Sep 8, 2019 at 1:11 AM Yonghong Song wrote: > > Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one > map en

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

On Tue, Sep 3, 2019 at 3:30 PM Stanislav Fomichev wrote: > > On 09/03, Alexei Starovoitov wrote: > > On Fri, Aug 30, 2019 at 02:18:09PM -0700, Stanislav Fomichev wrote: > > > > > > > > > > I personally like Jakub's/Quentin's proposal more. So if I get to > > > > > choose > > > > > between this se

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

On Thu, Aug 29, 2019 at 11:40 AM Jakub Kicinski wrote: > > On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote: > > Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one > > map entries per syscall. > > > > https://lore.ker

Re: [PATCH bpf-next 05/13] bpf: adding map batch processing support

Hi Yonghong! Thanks for sending this series of patches and starting the discussion. On Wed, Aug 28, 2019 at 11:45 PM Yonghong Song wrote: > > Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one > map entries per syscall. > > https://lore.kernel.org/bpf/cab

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

On Thu, Jul 25, 2019 at 11:10 PM Yonghong Song wrote: > > > > On 7/25/19 6:47 PM, Alexei Starovoitov wrote: > > On Thu, Jul 25, 2019 at 6:24 PM Brian Vazquez > > wrote: > >> > >> On Thu, Jul 25, 2019 at 4:54 PM Alexei Starovoitov > >> wrote: &

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

On Thu, Jul 25, 2019 at 4:54 PM Alexei Starovoitov wrote: > > On Thu, Jul 25, 2019 at 04:25:53PM -0700, Brian Vazquez wrote: > > > > > If prev_key is deleted before map_get_next_key(), we get the first key > > > > > again. This is pretty weird. > >

[PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

1 entry at the time, meaning that the returned buf might or might not be consistent. Suggested-by: Stanislav Fomichev Signed-off-by: Brian Vazquez --- include/uapi/linux/bpf.h | 9 +++ kernel/bpf/syscall.c | 117 +++ 2 files changed, 126 insertions(+) diff