Re: [PATCHv2] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-16 Thread Brendan McGrath
CHECKSUM --checksum-fill So I think this patch can be withdrawn in favour of one of these two workarounds. On 16/12/17 05:27, David Miller wrote: From: Brendan McGrath Date: Thu, 14 Dec 2017 22:37:03 +1100 Currently, when forwarding a multicast packet originating from a Virtual Interface

[PATCHv2] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-14 Thread Brendan McGrath
therefore rejected by the receiving machine(s). This patch ensures the checksum is recalculated before forwarding. Signed-off-by: Brendan McGrath --- Changes since PATCH v1: - fixed formatting - clarified in git comment that issue is with packet originating on multicast router - check value of

Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Brendan McGrath
orrect (packet accepted) ip_summed = 1 (CHECKSUM_UNNECESSARY) On 14/12/17 04:52, Eric Dumazet wrote: On Wed, 2017-12-13 at 22:20 +1100, Brendan McGrath wrote: Currently, when forwarding from a Virtual Interface to a Physical Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and the UDP checksum h

[PATCH] ipv6: icmp6: Allow icmp messages to be looped back

2017-12-13 Thread Brendan McGrath
to ensure a looped back packet is delivered to the Multicast Router. Signed-off-by: Brendan McGrath --- I considered putting this in mld_sendpack after the call to icmp6_dst_alloc but it looks like igmp6_send could use this fix too. In the end I followed the example set by addrconf_dst_alloc

[PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-13 Thread Brendan McGrath
receiving machine(s). This patch ensures the checksum is recalculated before forwarding. Signed-off-by: Brendan McGrath --- It's a bit ugly putting UDP specific code in this spot - but I'm not aware of any other protocols that are: a) multicast; b) forwarded; and c) checksummed net/ip