Re: linux-next: build failure after merge of the tip tree

2021-03-26 Thread Borislav Petkov
On Fri, Mar 26, 2021 at 09:57:43AM +0100, Sedat Dilek wrote: > The commit b90829704780 "bpf: Use NOP_ATOMIC5 instead of > emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG" is now in Linus Git > (see [1]). > > Where will Stephen's fixup-patch be carried? > Linux-next? > net-next? > ? I guess we'll re

Re: linux-next: build failure after merge of the tip tree

2021-03-22 Thread Borislav Petkov
On Mon, Mar 22, 2021 at 02:37:14PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > arch/x86/net/bpf_jit_comp.c: In function 'arch_prepare_bpf_trampoline': > arch/x86/net/bpf_jit_comp.c:2015:16: error:

Re: [PATCH v2 1/2] x86: make VMware support optional

2020-12-02 Thread Borislav Petkov
On Wed, Dec 02, 2020 at 10:19:48PM +0100, Enrico Weigelt, metux IT consult wrote: > Make it possible to opt-out from VMware support, for minimized kernels > that never will be run under Vmware (eg. high-density virtualization > or embedded systems). > > Average distro kernel will leave it on, the

Re: [PATCH 1/2] x86: make vmware support optional

2020-12-02 Thread Borislav Petkov
On Wed, Dec 02, 2020 at 08:17:23PM +0100, Enrico Weigelt, metux IT consult wrote: > Reducing the kernel size. Think of very high density virtualization > (w/ specially stripped-down workloads) or embedded systems. > > For example, I'm running bare minimum kernels w/ only kvm and virtio > (not eve

Re: [PATCH 1/2] x86: make vmware support optional

2020-11-17 Thread Borislav Petkov
On Tue, Nov 17, 2020 at 09:23:07PM +0100, Enrico Weigelt, metux IT consult wrote: > Make it possible to opt-out from vmware support Why? I can think of a couple of reasons but maybe yours might not be the one I'm thinking of. > Signed-off-by: Enrico Weigelt, metux IT consult > --- > arch/x86/

Re: [PATCH 5/8] edac: ghes: use krealloc_array()

2020-10-27 Thread Borislav Petkov
GFP_KERNEL); > + new = krealloc_array(hw->dimms, hw->num_dimms + 16, > + sizeof(struct dimm_info), GFP_KERNEL); > if (!new) { > WARN_ON_ONCE(1); >

Re: [RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

2020-08-02 Thread Borislav Petkov
On Sun, Aug 02, 2020 at 02:14:06PM -0500, Bjorn Helgaas wrote: > Wait, I'm not convinced yet. I know that if a PCI read fails, you > normally get ~0 data because the host bridge fabricates it to complete > the CPU load. > > But what guarantees that a PCI config register cannot contain ~0? Well,

Re: [RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

2020-08-02 Thread Borislav Petkov
On Sun, Aug 02, 2020 at 07:28:00PM +0200, Saheed Bolarinwa wrote: > Because the value ~0 has a meaning to some drivers and only No, ~0 means that the PCI read failed. For *every* PCI device I know. Here's me reading from 0xf0 offset of my hostbridge: # setpci -s 00:00.0 0xf0.l 0100 That dev

Re: [RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

2020-08-01 Thread Borislav Petkov
On Sat, Aug 01, 2020 at 01:24:29PM +0200, Saheed O. Bolarinwa wrote: > The return value of pci_read_config_*() may not indicate a device error. > However, the value read by these functions is more likely to indicate > this kind of error. This presents two overlapping ways of reporting > errors and

Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

2019-09-30 Thread Borislav Petkov
On Mon, Sep 30, 2019 at 05:45:35PM +0200, Michal Kubecek wrote: > On Mon, Sep 30, 2019 at 04:13:17PM +0200, Borislav Petkov wrote: > > I'm seeing this on i386 allyesconfig builds of current Linus master: > > > > ERROR: "__umoddi3" [drivers/net/ethe

Re: [PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8()

2019-02-18 Thread Borislav Petkov
On Mon, Feb 18, 2019 at 09:20:46PM +0200, Kalle Valo wrote: > So Masahiro, could you hold your x86 patch for a while until the mt76 > patch will be in Linus' tree? That should not take more than two weeks, > I think. No hurry - I won't take it into the x86 now and queue it for 5.1 because it is no

Re: [PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto

2018-05-10 Thread Borislav Petkov
On Thu, May 10, 2018 at 10:58:35AM -0700, Alexei Starovoitov wrote: > libbcc is a library. It's not only used by bcc scripts, but by production > services that compile bpf programs with clang. Let me get this straight: libbcc fails to compile because it includes (through some long include chain) t

Re: [PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto

2018-05-10 Thread Borislav Petkov
On Thu, May 10, 2018 at 08:52:42AM -0700, Alexei Starovoitov wrote: > That makes me wonder what happened with "we do not break user space" rule? As someone already pointed out on IRC, arch/x86/include/asm/cpufeature.h is solely a kernel header so nothing but kernel should include it. So forget the

Re: [PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto

2018-05-10 Thread Borislav Petkov
On Thu, May 03, 2018 at 08:31:19PM -0700, Yonghong Song wrote: > Commit d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS") > removed X86_FAST_FEATURE_TESTS and make macro static_cpu_has() always > use __always_inline function _static_cpu_has() funciton. > The static_cpu_has() uses gcc feature asm goto

Re: NETDEV WATCHDOG: eth0 (tg3): transmit queue 0 timed out

2018-03-26 Thread Borislav Petkov
On Tue, Mar 20, 2018 at 11:41:06AM +0530, Satish Baddipadige wrote: > Can you please test the attached patch? Well, the network connection just died with it. It didn't fire the netdev watchdog but I still had to down and up eth0 in order to continue using it. ssh connection into the box survived s

Re: NETDEV WATCHDOG: eth0 (tg3): transmit queue 0 timed out

2018-03-20 Thread Borislav Petkov
On Tue, Mar 20, 2018 at 11:41:06AM +0530, Satish Baddipadige wrote: > Can you please test the attached patch? Sure, will do when I get back next week. Thx. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. Srsly.

NETDEV WATCHDOG: eth0 (tg3): transmit queue 0 timed out

2018-02-24 Thread Borislav Petkov
Hi, this didn't happen before but after 4.16-rc1 my tg3 nic stops for whatever reason and the connection to the machine is dead. It didn't show anything in dmesg until today. The IO pagefaults look like it is trying to access something it shouldn't and maybe that's why it times out. It triggers

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

2017-12-19 Thread Borislav Petkov
On Tue, Dec 19, 2017 at 10:51:14AM -0800, Joe Perches wrote: > > The reason for the code churn being? > > Consistency for easier grep by use-type. Please explain that in the commit message so that we know why it was changed. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid to

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

2017-12-19 Thread Borislav Petkov
On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IWUSR\s*

WARNING: CPU: 0 PID: 0 at net/sched/sch_generic.c:316 dev_watchdog

2017-06-14 Thread Borislav Petkov
Hi, when I run a small CPU hotplugging script while I'm logged into the machine over ssh, I see the dev watchdog timeout below. Driver is e1000e. After the eth0 reset, I ifdown/ifup the eth0 interface and it comes back up again just fine. Any ideas? Kernel is -rc5 + tip/master. ... [ 48.9543

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

2017-03-12 Thread Borislav Petkov
On Thu, Mar 09, 2017 at 03:26:02PM -0800, Linus Torvalds wrote: > Maybe it's the lguest games with PGE that need to be removed? Btw, tglx suggested something else the other day: warn when we're changing boot_cpu_data x86_capability bits *after* alternatives have run. The reasoning behind it being

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

2017-03-09 Thread Borislav Petkov
On Thu, Mar 09, 2017 at 03:26:02PM -0800, Linus Torvalds wrote: > So should all of commit ("c109bf95992b x86/cpufeature: Remove > cpu_has_pge") just be reverted (and then marked for stable)? > > Or do we have some alternate plan? I think we want to do this: diff --git a/arch/x86/include/asm/tlbf

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

2017-03-09 Thread Borislav Petkov
On Thu, Mar 09, 2017 at 11:11:17PM +0100, Daniel Borkmann wrote: > Yeah, I just tried that out and it had no effect unfortunately, the > static_cpu_has() was still 1. Right, just as I thought. I guess we could return to doing boot_cpu_has() in __flush_tlb_all() then. I mean, the timing-sensitivit

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

2017-03-09 Thread Borislav Petkov
On Thu, Mar 09, 2017 at 10:32:12PM +0100, Daniel Borkmann wrote: > get_online_cpus(); > if (boot_cpu_has(X86_FEATURE_PGE)) { /* We have a broader idea of > "global". */ > /* Remember that this was originally set (for cleanup). */ > cpu_had_pge = 1; >

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

2017-03-09 Thread Borislav Petkov
On Thu, Mar 09, 2017 at 10:55:47PM +0100, Borislav Petkov wrote: > Can you make that: > > setup_clear_cpu_cap(X86_FEATURE_PGE); > > and see if it fixes your issue? Hmm, in reading the thread a bit more, that might not work. If I see it correctly, lguest does clear_cpu_cap

Re: [PATCH v3 4/8] x86: stop exporting msr-index.h to userland

2017-01-13 Thread Borislav Petkov
s - and as such it's part of the UAPI. I don't think you can > > remove it unless you can guarantee there are no userspace users. > I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks > me > to un-export it. > > I will follow the maintainer de

Re: [PATCH v2 4/7] x86: put msr-index.h in uapi

2017-01-06 Thread Borislav Petkov
On Fri, Jan 06, 2017 at 10:43:56AM +0100, Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. It should rather not be exported - please remove it from arch/x86/include/uapi/asm/Kbuild instead. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid t

Re: linux-next: manual merge of the net-next tree with the net tree

2016-11-29 Thread Borislav Petkov
On Tue, Nov 29, 2016 at 11:22:32AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/amd/xgbe/xgbe-main.c > > between commit: > > 91eefaabf102 ("amd-xgbe: Fix unused suspend handlers build warning") > > fr

[PATCH] amd-xgbe: Fix unused suspend handlers build warning

2016-11-26 Thread Borislav Petkov
From: Borislav Petkov Fix: drivers/net/ethernet/amd/xgbe/xgbe-main.c:835:12: warning: ‘xgbe_suspend’ defined but not used [-Wunused-function] drivers/net/ethernet/amd/xgbe/xgbe-main.c:855:12: warning: ‘xgbe_resume’ defined but not used [-Wunused-function] I see it during

Re: Kernel 4.8.7 crashing down cleanup_net()

2016-11-13 Thread Borislav Petkov
Hmm, there's cleanup_net() namespaces fun in there, adding netdev@. On Sat, Nov 12, 2016 at 02:17:03PM -0800, Ashton Holmes wrote: > I upgraded to 4.8.7 and the system boots and my root partition gets > decrypted but right after that both of my monitors turn off and > looking at syslog from 4.8.6

Re: WARNING: CPU: 1 PID: 2485 at drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1752 iwl_trans_pcie_grab_nic_access+0x110/0x120 [iwlwifi]

2016-04-16 Thread Borislav Petkov
On Fri, Apr 15, 2016 at 04:16:02AM +, Grumbach, Emmanuel wrote: > [1] https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/backport-iwlwi > fi.git/ It is very strange to pull from this repo, git fetch is doing something for a while now without any forward progress. In any case, 4.5 is bad too

WARNING: CPU: 1 PID: 2485 at drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1752 iwl_trans_pcie_grab_nic_access+0x110/0x120 [iwlwifi]

2016-04-14 Thread Borislav Petkov
Hi, so I'm seeing this when wlan0 tries to associate. On 4.6-rc2 + tip. After that, wifi is dead in the water. Anyone have a clue? And 4.5 seems fine, I'm typing from it as we speak. ... [2.111418] iwlwifi :02:00.0: loaded firmware version 21.302800.0 op_mode iwlmvm ... [2.220954] i

conntrack.c:(.text+0x3d8075): undefined reference to `nf_nat_icmp_reply_translation'

2016-04-03 Thread Borislav Petkov
Hi people, I'm seeing this while doing randconfig builds on rc1 + tip: net/built-in.o: In function `__ovs_ct_lookup': conntrack.c:(.text+0x3d8075): undefined reference to `nf_nat_icmp_reply_translation' make: *** [vmlinux] Error 1 .config attached. -- Regards/Gruss, Boris. ECO tip #101:

Re: [PATCH] bus: subsys: update return type of ->remove_dev() to void

2015-07-30 Thread Borislav Petkov
On Thu, Jul 30, 2015 at 03:04:01PM +0530, Viresh Kumar wrote: > Its return value is not used by the subsys core and nothing meaningful > can be done with it, even if we want to use it. The subsys device is > anyway getting removed. I'm assuming sysfs paths covered by it, will remain intact... ? Fo

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Borislav Petkov
On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote: > The problem comes from the new macro UDPX_INC_STATS_BH introduced > by Herbert, which was a nice addition to increment the correct > UDP MIB depending on the socket family, but unfortunately > the use of this macro from kernel code

[PATCH] Olympic (IBM PCI tokenring): handle return codes of register_netdev

2007-04-19 Thread Borislav Petkov
Handle return codes of register_netdev(). Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> Index: 21-rc7/drivers/net/tokenring/olympic.c === --- 21-rc7.orig/drivers/net/tokenring/olympic.c +++ 21-rc7/drivers/net/tok

[PATCH] fix comments for register_netdev()

2007-04-18 Thread Borislav Petkov
Correct the function name in the comments supplied with register_netdev() Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> Index: 21-rc7/net/core/dev.c === --- 21-rc7.orig/net/core/dev.c +++ 21-rc7/net/core/dev.c @@ -