Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-19 Thread Boris Sukholitko
On Mon, May 18, 2020 at 08:59:56AM -0700, Eric Dumazet wrote: > > Please provide a Fixes: tag for such a scary patch. Done in v2. Thanks, Boris.

Re: [PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-19 Thread Boris Sukholitko
On Mon, May 18, 2020 at 05:20:13PM +0100, Edward Cree wrote: > Firstly, please add a Fixes: tag; I expect the relevant commit will be >  88eb1944e18c ("net: core: propagate SKB lists through packet_type lookup") >  but I'm not 100% sure so do check that yourself. You are right, this is the right c

[PATCH net v2] __netif_receive_skb_core: pass skb by reference

2020-05-19 Thread Boris Sukholitko
to unpleasant effects. The solution is to pass skb by reference into __netif_receive_skb_core. v2: Added Fixes tag and comment regarding ppt_prev and skb invariant. Fixes: 88eb1944e18c ("net: core: propagate SKB lists through packet_type lookup") Signed-off-by: Boris Sukholitko ---

[PATCH net] __netif_receive_skb_core: pass skb by reference

2020-05-18 Thread Boris Sukholitko
to unpleasant effects. The solution is to pass skb by reference into __netif_receive_skb_core. Signed-off-by: Boris Sukholitko --- net/core/dev.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 6d327b7aa813..0c2bbf479f19

[RFC, PATCH] Purging local routes on NETDEV_DOWN event

2006-11-05 Thread Boris Sukholitko
er on NETDEV_DOWN we do not delete them. The attached (for a fear of GMail tab munging :)) patch tries to change it. What do you think? Thanks, Boris. Signed-off-by: Boris Sukholitko ([EMAIL PROTECTED]) --- Index: linux-2.6.18/net/ipv4/fib_front