Re: [PATCH v2 00/25] at24: remove

2018-11-19 Thread Boris Brezillon
On Mon, 19 Nov 2018 09:58:46 +0100 Bartosz Golaszewski wrote: > niedz., 18 lis 2018 o 17:03 Boris Brezillon > napisaƂ(a): > > > > On Tue, 13 Nov 2018 15:01:08 +0100 > > Bartosz Golaszewski wrote: > > > > > As far as merging of this series goes: I'

Re: [PATCH v2 06/29] mtd: Add support for reading MTD devices via the nvmem API

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 20:50:55 +0200 Bartosz Golaszewski wrote: > 2018-08-20 20:20 GMT+02:00 Boris Brezillon : > > On Mon, 20 Aug 2018 11:43:34 +0100 > > Srinivas Kandagatla wrote: > > > >> > >> Overall am still not able to clear visualize on how MTD bindi

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Boris Brezillon
On Wed, 04 Apr 2018 21:49:26 +0200 Robert Jarzmik wrote: > Ulf Hansson writes: > > > On 2 April 2018 at 16:26, Robert Jarzmik wrote: > >> Hi, > >> > >> This serie is aimed at removing the dmaengine slave compat use, and > >> transfer > >> knowledge of the DMA requestors into architecture co

Re: [PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

2018-03-18 Thread Boris Brezillon
On Mon, 12 Feb 2018 22:03:07 +0100 Boris Brezillon wrote: > mtd_erase() can return an error before ->fail_addr is initialized to > MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning > of the function. Applied the patchset after addressing Miquel's comments.

Re: [PATCH 00/47] arch-removal: device drivers

2018-03-14 Thread Boris Brezillon
o take the mtd patches through the MTD tree. As you've probably noticed, nand code has been moved around and it's easier for me to carry those 2 simple changes in my tree than creating an immutable branch. Let me know if this is a problem. Regards, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-13 Thread Boris Brezillon
e->state = MTD_ERASE_DONE; > > - } > > - mtd_erase_callback(erase); > > + > > return rc; > > } > > > > diff --git a/drivers/mtd/devices/slram.c b/drivers/mtd/devices/slram.c > > index 0ec85f316d24..2f05e1801047 100644 > > --- a/drivers/mtd/devices/slram.c > > +++ b/drivers/mtd/devices/slram.c > > @@ -88,8 +88,6 @@ static int slram_erase(struct mtd_info *mtd, struct > > erase_info *instr) > > * I don't feel at all ashamed. This kind of thing is possible anyway > > * with flash, but unlikely. > > */ > > Same with this comment. Actually, I'm not sure I understand that comment, but I guess it's talking about races between read/write and erase paths, so nothing related to the changed I'm doing here. > > > - instr->state = MTD_ERASE_DONE; > > - mtd_erase_callback(instr); > > Space ? > > > return(0); > > } > > > > > > -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com

[PATCH 3/5] mtd: Stop assuming mtd_erase() is asynchronous

2018-02-12 Thread Boris Brezillon
None of the mtd->_erase() implementations work in an asynchronous manner, so let's simplify MTD users that call mtd_erase(). All they need to do is check the value returned by mtd_erase() and assume that != 0 means failure. Signed-off-by: Boris Brezillon --- drivers/mtd/devices/bcm47xx

[PATCH 2/5] mtd: Get rid of unused fields in struct erase_info

2018-02-12 Thread Boris Brezillon
Some fields are not used by MTD drivers, users or core code. Moreover, those fields are not documented, so get rid of them to avoid any confusion. Signed-off-by: Boris Brezillon --- include/linux/mtd/mtd.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/mtd/mtd.h b/include

[PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-12 Thread Boris Brezillon
>state field, all MTD_ERASE_XXX definitions and the mtd_erase_callback() function. Signed-off-by: Boris Brezillon --- drivers/mtd/chips/cfi_cmdset_0001.c | 16 ++-- drivers/mtd/chips/cfi_cmdset_0002.c | 26 +++--- drivers/mtd/chips/cfi_cmdset_0020.c

[PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

2018-02-12 Thread Boris Brezillon
rase_info->callback() and are thus only taking the ->addr_fail and ->addr fields into account after part_erase() has returned. While we're at it, get rid of the erase_info->mtd field which was only needed to let mtd_erase_callback() get the partition device back. Signed-off-by: Boris B

[PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

2018-02-12 Thread Boris Brezillon
mtd_erase() can return an error before ->fail_addr is initialized to MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning of the function. Signed-off-by: Boris Brezillon --- drivers/mtd/mtdcore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 0/5] mtd: Simplify erase handling

2018-02-12 Thread Boris Brezillon
sistent and allows us to get rid of a few hundred lines of code. Regards, Boris Boris Brezillon (5): mtd: Initialize ->fail_addr early in mtd_erase() mtd: Get rid of unused fields in struct erase_info mtd: Stop assuming mtd_erase() is asynchronous mtd: Unconditionally update ->fail_a

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Boris Brezillon
ep reduce the > overall stack size. > > Signed-off-by: Arnd Bergmann Acked-by: Boris Brezillon > --- > drivers/mtd/chips/cfi_cmdset_0020.c | 8 > include/linux/mtd/map.h | 8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > d

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Boris Brezillon
On Fri, 4 Aug 2017 11:09:53 +0200 Arnd Bergmann wrote: > On Fri, Aug 4, 2017 at 9:42 AM, Boris Brezillon > wrote: > > On Wed, 14 Jun 2017 23:15:40 +0200 > > Arnd Bergmann wrote: > > > >> When CONFIG_KASAN is used, we consume a lot of extra stack s

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Boris Brezillon
On Wed, 14 Jun 2017 23:15:40 +0200 Arnd Bergmann wrote: > When CONFIG_KASAN is used, we consume a lot of extra stack space: > > drivers/mtd/chips/cfi_cmdset_0020.c: In function 'do_write_buffer': > drivers/mtd/chips/cfi_cmdset_0020.c:603:1: error: the frame size of 2184 > bytes is larger than 1

Re: [PATCH] dt-bindings: gpmc: Correct location of generic gpmc binding

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 08:14:54 -0400 Tom Rini wrote: > The binding bus/ti-gpmc.txt has been moved to > memory-controllers/omap-gpmc.txt. Update all references to this in > order to make reading and understanding a given binding easier. > > Cc: David Woodhouse > Cc: Brian Norris > Cc:Boris Brezi

Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk

2015-09-14 Thread Boris Brezillon
a clk driver for the internal clk case? This way you'll be able to use the clk API (including the clk_get_rate() function) instead of introducing a new way to retrieve a clk frequency. Best Regards, Boris [1]http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/clock/fixed-clock.t