From: Bongsu Jeon
This is the NCI test suite. It tests the NFC/NCI module using virtual NCI
device. Test cases consist of making the virtual NCI device on/off and
controlling the device's polling for NCI1.0 and NCI2.0 version.
Signed-off-by: Bongsu Jeon
---
MAINTA
From: Bongsu Jeon
NCI virtual device simulates a NCI device to the user. It can be used to
validate the NCI module and applications. This driver supports
communication between the virtual NCI device and NCI module.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/Kconfig | 11 ++
drivers
From: Bongsu Jeon
1/2 is the Virtual NCI device driver.
2/2 is the NCI selftest suite
v4:
1/2
- flip the condition for the ioctl.
- refactor some code.
- remove the unused function after refactoring.
v3:
1/2
- change the Kconfig help comment.
- remove the mutex init code.
- remove the
On Wed, Jan 27, 2021 at 10:42 AM Jakub Kicinski wrote:
>
> On Sat, 23 Jan 2021 18:24:24 +0900 Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > NCI virtual device simulates a NCI device to the user. It can be used to
> > validate the NCI module and appl
From: Bongsu Jeon
This is the NCI test suite. It tests the NFC/NCI module using virtual NCI
device. Test cases consist of making the virtual NCI device on/off and
controlling the device's polling for NCI1.0 and NCI2.0 version.
Signed-off-by: Bongsu Jeon
---
MAINTA
From: Bongsu Jeon
NCI virtual device simulates a NCI device to the user. It can be used to
validate the NCI module and applications. This driver supports
communication between the virtual NCI device and NCI module.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/Kconfig | 11 ++
drivers
From: Bongsu Jeon
A NCI virtual device can be made to simulate a NCI device in user space.
Using the virtual NCI device, The NCI module and application can be
validated. This driver supports to communicate between the virtual NCI
device and NCI module. To test the basic features of NCI module
From: Bongsu Jeon
A NCI virtual device can be made to simulate a NCI device in user space.
Using the virtual NCI device, The NCI module and application can be
validated. This driver supports to communicate between the virtual NCI
device and NCI module. To test the basic features of NCI module
From: Bongsu Jeon
This is the NCI test suite. It tests the NFC/NCI module using virtual NCI
device. Test cases consist of making the virtual NCI device on/off and
controlling the device's polling for NCI1.0 and NCI2.0 version.
Signed-off-by: Bongsu Jeon
---
MAINTA
From: Bongsu Jeon
A NCI virtual device can be made to simulate a NCI device in user space.
Using the virtual NCI device, The NCI module and application can be
validated. This driver supports to communicate between the virtual NCI
device and NCI module.
Signed-off-by: Bongsu Jeon
---
drivers
On Wed, Jan 20, 2021 at 10:00 AM wrote:
>
> Hello:
>
> This patch was applied to netdev/net.git (refs/heads/master):
>
> On Tue, 19 Jan 2021 05:55:22 +0900 you wrote:
> > From: Bongsu Jeon
> >
> > Fix the code because NCI_CORE_INIT_CMD includes two para
On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski wrote:
>
> On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0
> > but there is no parameters in NCI1.x.
>
From: Bongsu Jeon
Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0
but there is no parameters in NCI1.x.
Signed-off-by: Bongsu Jeon
---
net/nfc/nci/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index
On Thu, Jan 7, 2021 at 2:01 AM Jakub Kicinski wrote:
>
> On Wed, 6 Jan 2021 08:16:47 +0900 Bongsu Jeon wrote:
> > On Tue, Jan 5, 2021 at 4:48 AM Jakub Kicinski wrote:
> > > > thank you for your answer.
> > > > I think that neard(NFC deamon) is
On Tue, Jan 5, 2021 at 4:48 AM Jakub Kicinski wrote:
>
> On Thu, 31 Dec 2020 14:22:45 +0900 Bongsu Jeon wrote:
> > On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote:
> > >
> > > On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote:
> > > > From:
On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote:
>
> On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > A NCI virtual device can be made to simulate a NCI device in user space.
> > Using the virtual NCI device, The NCI
From: Bongsu Jeon
If there is a NCI command in work queue after closing the NCI device at
nci_unregister_device, The NCI command timer starts at flush_workqueue
function and then NCI command timeout handler would be called 5 second
after flushing the NCI command work queue and destroying the
From: Bongsu Jeon
A NCI virtual device can be made to simulate a NCI device in user space.
Using the virtual NCI device, The NCI module and application can be
validated. This driver supports to communicate between the virtual NCI
device and NCI module.
Signed-off-by: Bongsu Jeon
From: Bongsu Jeon
Change the NCI close sequence because the NCI Command timer should be
deleted after flushing the NCI command work queue.
Signed-off-by: Bongsu Jeon
---
net/nfc/nci/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/nfc/nci/core.c b/net/nfc/nci
From: Bongsu Jeon
Remove the unused NCI prop commands that s3fwrn5 driver doesn't use.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/nci.c | 25 -
drivers/nfc/s3fwrn5/nci.h | 22 --
2 files changed, 47 deletions(-)
diff --git a/driver
From: Bongsu Jeon
Refactor the s3fwrn5 module.
1/2 is to remove the unneeded delay for NFC sleep.
2/2 is to remove the unused NCI prop commands.
ChangeLog:
v2:
- Update the commit messages.
Bongsu Jeon (2):
nfc: s3fwrn5: Remove the delay for NFC sleep
nfc: s3fwrn5: Remove unused NCI
From: Bongsu Jeon
Remove the delay for NFC sleep because the delay is only needed to
guarantee that the NFC is awake.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/phy_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/phy_common.c b
On Tue, Dec 15, 2020 at 1:02 AM Krzysztof Kozlowski wrote:
>
> On Mon, Dec 14, 2020 at 08:46:58PM +0900, Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > remove the unused nci prop commands that samsung driver doesn't use.
>
> Don't send patches
On Tue, Dec 15, 2020 at 12:44 AM Krzysztof Kozlowski wrote:
>
> On Mon, Dec 14, 2020 at 09:28:23PM +0900, Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > add an email to look after the SAMSUNG NFC driver.
>
> Hi Bongsu,
>
> Review and testing is always a
From: Bongsu Jeon
add an email to look after the SAMSUNG NFC driver.
Signed-off-by: Bongsu Jeon
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c1a6ba5ef26..cb1634eb010d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15425,6 +15425,7 @@ F
From: Bongsu Jeon
remove the unused nci prop commands that samsung driver doesn't use.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/nci.c | 25 -
drivers/nfc/s3fwrn5/nci.h | 22 --
2 files changed, 47 deletions(-)
diff --git a/driver
From: Bongsu Jeon
remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/phy_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers/nfc/s3fwrn5/phy_com
From: Bongsu Jeon
add the code to release the nfc firmware when the firmware image size is
wrong.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/firmware.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5
From: Bongsu Jeon
For the flexible control of interrupt trigger type, remove the hard coded
interrupt trigger type in the i2c module. The trigger type will be loaded
from a dts.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/i2c.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion
From: Bongsu Jeon
Change interrupt trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING
for stable NFC I2C interrupt handling.
Samsung's NFC Firmware sends an i2c frame as below.
1. NFC Firmware sets the GPIO(interrupt pin) high when there is an i2c
frame to send.
2. If the CPU&
From: Bongsu Jeon
For stable Samsung's I2C interrupt handling, I changed the interrupt
trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING and removed
the hard coded interrupt trigger type in the i2c module for the flexible
control.
1/2 is the changed dt binding for the edge r
On Mon, Dec 7, 2020 at 11:13 PM Krzysztof Kozlowski wrote:
>
> On Mon, Dec 07, 2020 at 10:39:01PM +0900, Bongsu Jeon wrote:
> > On Mon, Dec 7, 2020 at 8:51 PM Krzysztof Kozlowski wrote:
> > >
> > > On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wr
On Mon, Dec 7, 2020 at 8:51 PM Krzysztof Kozlowski wrote:
>
> On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stable
> > Samsung's nfc interrupt handli
From: Bongsu Jeon
change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stable
Samsung's nfc interrupt handling.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/driver
From: Bongsu Jeon
If there isn't a proper NFC firmware image, Bootloader mode will be
skipped.
Signed-off-by: Bongsu Jeon
---
ChangeLog:
v2:
- change the commit message.
- change the skip handling code.
drivers/nfc/s3fwrn5/core.c | 23 +--
driver
From: Bongsu Jeon
If there isn't proper NFC firmware image,
Bootloader mode will be skipped.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/core.c | 44 --
drivers/nfc/s3fwrn5/firmware.c | 11 +
drivers/nfc/s3fwrn5/firmware.h | 1 +
3
From: Bongsu Jeon
implement the NCI 2.x initial sequence to support NCI 2.x NFCC.
Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed.
If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work.
In NCI 1.0, Initial sequence and payloads are as below:
(DH
On Tue, Dec 1, 2020 at 11:48 AM Jakub Kicinski wrote:
>
> On Fri, 27 Nov 2020 22:36:31 +0900 bongsu.je...@gmail.com wrote:
> > From: Bongsu Jeon
> >
> > implement the NCI 2.x initial sequence to support NCI 2.x NFCC.
> > Since NCI 2.0, CORE_RESET and CORE_INIT sequ
On Thu, Dec 3, 2020 at 2:16 AM Krzysztof Kozlowski wrote:
>
> On Wed, Dec 02, 2020 at 08:47:38PM +0900, Bongsu Jeon wrote:
> > From: Bongsu Jeon
> >
> > Since S3FWRN82 NFC Chip, The UART interface can be used.
> > S3FWRN82 supports I2C and UART interface.
>
From: Bongsu Jeon
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 uses NCI protocol and supports I2C and UART interface.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/Kconfig | 12 +++
drivers/nfc/s3fwrn5/Makefile | 2
From: Bongsu Jeon
Extract the common phy blocks to reuse it.
The UART module will use the common blocks.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/Makefile | 2 +-
drivers/nfc/s3fwrn5/i2c.c| 117
From: Bongsu Jeon
The delay of 20ms is enough to enable and
wake up the Samsung's nfc chip.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/driver
From: Bongsu Jeon
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 31 +++---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a
From: Bongsu Jeon
S3FWRN82 is the Samsung's NFC chip that supports the UART communication.
Before adding the UART driver module, I did refactoring the s3fwrn5_i2c module
to reuse the common blocks.
1/4 is the dt bindings for the RN82 UART interface.
2/4..3/4 are refactoring the s3fwrn
From: Bongsu Jeon
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 uses NCI protocol and supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/Kconfig | 12 +++
drivers/nfc/s3fwrn5/Makefile | 2 +
drivers/nfc/s3fwrn5/phy_common.c
From: Bongsu Jeon
Extract the common phy blocks to reuse it.
The UART module will use the common blocks.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/Makefile | 2 +-
drivers/nfc/s3fwrn5/i2c.c| 117 +--
drivers/nfc/s3fwrn5/phy_common.c
From: Bongsu Jeon
The delay of 20ms is enough to enable and
wake up the Samsung's nfc chip.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/driver
From: Bongsu Jeon
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 32 --
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a
From: Bongsu Jeon
S3FWRN82 is the Samsung's NFC chip that supports the UART communication.
Before adding the UART driver module, I did refactoring the s3fwrn5_i2c module
to reuse the common blocks.
1/4 is the dt bindings for the RN82 UART interface.
2/4..3/4 are refactoring the s3fwrn
From: Bongsu Jeon
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 uses NCI protocol and supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
Changes in v2:
- remove the kfree(phy) because of duplicated free.
- use the phy_common blocks.
- wrap lines
From: Bongsu Jeon
Extract the common phy blocks to reuse it.
The UART module will use the common blocks.
Signed-off-by: Bongsu Jeon
---
Changes in v3:
- move the phy_common object to s3fwrn.ko to avoid duplication.
- include the header files to include everything which is used inside
From: Bongsu Jeon
The delay of 20ms is enough to enable and
wake up the Samsung's nfc chip.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index ae
From: Bongsu Jeon
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
Changes in v2:
-change the compatible name.
-change the const to enum for compatible.
-change the node name to nfc.
.../bindings/net/nfc
On Sat, Nov 28, 2020 at 9:49 PM Krzysztof Kozlowski wrote:
>
> On Fri, Nov 27, 2020 at 08:22:18PM +0900, bongsu.je...@gmail.com wrote:
> > From: Bongsu Jeon
> >
> > Extract the common phy blocks to reuse it.
> > The UART module will use the common blocks.
>
On 11/27/20, Bongsu Jeon wrote:
> On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski
> wrote:
>>
>> On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.je...@gmail.com wrote:
>> > From: Krzysztof Kozlowski
>> >
>> > GPIOs - as returned by of_get_na
On Fri, Nov 27, 2020 at 2:13 AM Krzysztof Kozlowski wrote:
>
> On Fri, Nov 27, 2020 at 12:33:39AM +0900, bongsu.je...@gmail.com wrote:
> > From: Bongsu Jeon
> >
> > Extract the common phy blocks to reuse it.
> > The UART module will use the common blocks.
>
>
On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski wrote:
>
> On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.je...@gmail.com wrote:
> > From: Krzysztof Kozlowski
> >
> > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are
> > signed integers, where negative number indicate
On Wed, Nov 25, 2020 at 9:03 AM Jakub Kicinski wrote:
>
> On Mon, 23 Nov 2020 19:12:08 +0900 Bongsu Jeon wrote:
> > implement the NCI 2.x initial sequence to support NCI 2.x NFCC.
> > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed.
> > If NFCEE suppor
On 11/25/20, Bongsu Jeon wrote:
> On 11/24/20, k...@kernel.org wrote:
>> On Tue, Nov 24, 2020 at 09:05:52PM +0900, Bongsu Jeon wrote:
>>> On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote:
>>> > > +static enum s3fwrn5_mode s3fwrn82_uart_get_mode(void *phy_id
On 11/24/20, k...@kernel.org wrote:
> On Tue, Nov 24, 2020 at 09:05:52PM +0900, Bongsu Jeon wrote:
>> On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote:
>> > > +static enum s3fwrn5_mode s3fwrn82_uart_get_mode(void *phy_id)
>> > > +{
>> > >
On 11/24/20, k...@kernel.org wrote:
> On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote:
>> On Mon, Nov 23, 2020 at 5:02 PM k...@kernel.org wrote:
>> >
>> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > > examples
On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote:
>
> On Mon, Nov 23, 2020 at 04:56:58PM +0900, Bongsu Jeon wrote:
> > Since S3FWRN82 NFC Chip, The UART interface can be used.
> > S3FWRN82 uses NCI protocol and supports I2C and UART interface.
> >
> > Signed-o
On Mon, Nov 23, 2020 at 5:02 PM k...@kernel.org wrote:
>
> On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > Since S3FWRN82 NFC Chip, The UART interface can be used.
> > S3FWRN82 supports I2C and UART interface.
> >
> > Signed-off-by: Bongsu Jeon
>
load Size of the Static HCI Connection,
Number of Credits of the Static HCI Connection,
Max NFC-V RF Frame Size, Number of Supported RF Interfaces,
Supported RF Interfaces.
Signed-off-by: Bongsu Jeon
---
Changes in v2:
- fix the warning of type casting.
- changed the __u8 type to unsig
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 uses NCI protocol and supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/Kconfig | 12 ++
drivers/nfc/s3fwrn5/Makefile | 2 +
drivers/nfc/s3fwrn5/uart.c | 250
Since S3FWRN82 NFC Chip, The UART interface can be used.
S3FWRN82 supports I2C and UART interface.
Signed-off-by: Bongsu Jeon
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree
On 11/18/20, Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 14:37:59 +0900 Bongsu Jeon wrote:
>> implement the NCI 2.x initial sequence to support NCI 2.x NFCC.
>> Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed.
>> If NFCEE supports NCI 2.x, then NCI 2.x
On Tue, Nov 17, 2020 at 5:39 PM Krzysztof Kozlowski wrote:
>
> On Tue, 17 Nov 2020 at 09:14, Bongsu Jeon wrote:
> >
> > 2020-11-17 16:42 GMT+09:00, k...@kernel.org :
> > > On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote:
> > >> max_payload is
2020-11-17 16:42 GMT+09:00, k...@kernel.org :
> On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote:
>> max_payload is unused.
>
> Why did you resend the patch ignoring my review? I already provided you
> with a tag, so you should include it.
>
> https://www.ke
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/s3fwrn5.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h
index
max_payload is unused.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/core.c| 3 +--
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/s3fwrn5/s3fwrn5.h | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/core.c
stucture should be replaced by structure.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index ec930ee2c847
load Size of the Static HCI Connection,
Number of Credits of the Static HCI Connection,
Max NFC-V RF Frame Size, Number of Supported RF Interfaces,
Supported RF Interfaces.
Signed-off-by: Bongsu Jeon
---
include/net/nfc/nci.h | 39 ++
net/nfc/nci/core.c| 23 +
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/s3fwrn5.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h
index 9d5f34759225..bb8f936d13a2 100644
max_payload is unused.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/core.c| 3 +--
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/s3fwrn5/s3fwrn5.h | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c
stucture should be replaced by structure.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index ec930ee2c847..4cde6dd5c019 100644
--- a/drivers/nfc
Changes from v1:
- Remove the trailing dot from subject.
- Remove an empty line at beginning of commit message.
- Add a commit message.
Bongsu Jeon (3):
nfc: s3fwrn5: Remove the max_payload
nfc: s3fwrn5: Fix the misspelling in a comment
nfc: s3fwrn5: Change the error code
drivers/nfc
On Fri, Nov 13, 2020, 4:26 PM Krzysztof Kozlowski wrote:
> On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon wrote:
> >
> >
> > Add driver for Samsung S3FWRN82 NFC controller.
> > S3FWRN82 is using NCI protocol and I2C communication interface.
> >
> > Signed-of
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/s3fwrn5.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h
index 9d5f34759225..bb8f936d13a2 100644
stucture should be replaced by structure.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index ec930ee2c847..4cde6dd5c019 100644
--- a/drivers/nfc
max_payload is unused.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/core.c| 3 +--
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/s3fwrn5/s3fwrn5.h | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c
On Fri, Nov 13, 2020 at 4:26 PM Krzysztof Kozlowski wrote:
>
> On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon wrote:
> >
> >
> > Add driver for Samsung S3FWRN82 NFC controller.
> > S3FWRN82 is using NCI protocol and I2C communication interface.
> >
> > Signed
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/s3fwrn5.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h
index 9d5f34759225..bb8f936d13a2 100644
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index ec930ee2c847..4cde6dd5c019 100644
--- a/drivers/nfc/s3fwrn5/firmware.c
+++ b/drivers/nfc
max_payload is unused.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/core.c| 3 +--
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/s3fwrn5/s3fwrn5.h | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c
Add the device tree bindings for Samsung S3FWRN82 NFC controller.
S3FWRN82 is using NCI protocol and I2C communication interface.
Signed-off-by: Bongsu Jeon
---
.../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 +++
1 file changed, 30 insertions(+)
create mode 100644
Add driver for Samsung S3FWRN82 NFC controller.
S3FWRN82 is using NCI protocol and I2C communication interface.
Signed-off-by: Bongsu Jeon
---
drivers/nfc/Kconfig | 1 +
drivers/nfc/Makefile| 1 +
drivers/nfc/s3fwrn82/Kconfig| 15 ++
drivers/nfc/s3fwrn82
+obj-$(CONFIG_NFC_S3FWRN82) += s3fwrn82.o
+obj-$(CONFIG_NFC_S3FWRN82_I2C) += s3fwrn82_i2c.o
diff --git a/drivers/nfc/s3fwrn82/core.c b/drivers/nfc/s3fwrn82/core.c
new file mode 100644
index ..7ba60ec37fe3
--- /dev/null
+++ b/drivers/nfc/s3fwrn82/core.c
@@ -0,0 +1,133 @@
+// SPDX-License
+obj-$(CONFIG_NFC_S3FWRN82) += s3fwrn82.o
+obj-$(CONFIG_NFC_S3FWRN82_I2C) += s3fwrn82_i2c.o
diff --git a/drivers/nfc/s3fwrn82/core.c b/drivers/nfc/s3fwrn82/core.c
new file mode 100644
index ..7ba60ec37fe3
--- /dev/null
+++ b/drivers/nfc/s3fwrn82/core.c
@@ -0,0 +1,133 @@
+// SPDX-License
89 matches
Mail list logo
