Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC

2021-04-18 Thread Bjørn Mork
Ilya Lipnitskiy writes: > Add missing binding documentation for SoC support that has been in place > since v5.1 > > Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet > hardware") > Cc: Bjørn Mork > Signed-off-by: Ilya Lipnitskiy &g

Re: [PATCH 1/1] net: usb: qmi_wwan: allow qmimux add/del with master up

2021-03-04 Thread Bjørn Mork
me > logical interfaces. > > Fixes: c6adf77953bc ("net: usb: qmi_wwan: add qmap mux protocol support") > Reported-by: Aleksander Morgado > Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork

Re: [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem

2021-02-06 Thread Bjørn Mork
If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan > E: Ad=87(I) Atr=03(Int.) MxPS= 8 Ivl=32ms > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) > E: Ad=88

Re: [PATCH net-next 3/3] net: mhi: Add mbim proto

2021-01-30 Thread Bjørn Mork
Loic Poulain writes: > MBIM has initially been specified by USB-IF for transporting data (IP) > between a modem and a host over USB. However some modern modems also > support MBIM over PCIe (via MHI). In the same way as QMAP(rmnet), it > allows to aggregate IP packets and to perform context multi

Re: [PATCH net-next 1/2] net: usb: qmi_wwan: add qmap id sysfs file for qmimux interfaces

2021-01-26 Thread Bjørn Mork
Jakub Kicinski writes: > On Mon, 25 Jan 2021 17:14:28 +0100 Bjørn Mork wrote: >> Daniele Palmas writes: >> >> > Add qmimux interface sysfs file qmap/mux_id to show qmap id set >> > during the interface creation, in order to provide a method for >> > u

Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

2021-01-25 Thread Bjørn Mork
gt; 3. Create a rmnet device with qmi_wwan device as real device using netlink > > Signed-off-by: Subash Abhinov Kasiviswanathan Thanks! Looks good, and takes us at least one small step closer to a shared wwan userspace ABI Acked-by: Bjørn Mork

Re: [PATCH net-next 1/2] net: usb: qmi_wwan: add qmap id sysfs file for qmimux interfaces

2021-01-25 Thread Bjørn Mork
Daniele Palmas writes: > Add qmimux interface sysfs file qmap/mux_id to show qmap id set > during the interface creation, in order to provide a method for > userspace to associate QMI control channels to network interfaces. > > Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork

Re: [PATCH net-next 2/2] net: qmi_wwan: document qmap/mux_id sysfs file

2021-01-25 Thread Bjørn Mork
Daniele Palmas writes: > Document qmap/mux_id sysfs file showing qmimux interface id > > Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork

Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

2021-01-25 Thread Bjørn Mork
Dan Williams writes: > On Mon, 2021-01-25 at 00:33 -0700, Subash Abhinov Kasiviswanathan > wrote: >> Pass through mode is to allow packets in MAP format to be passed >> on to the stack. rmnet driver can be used to process and demultiplex >> these packets. >> >> Pass through mode can be enabled wh

Re: [PATCH v2] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-22 Thread Bjørn Mork
Jakub Kicinski writes: > Bjorn, I think this was posted before you pointed out the missing CCs > and Giacinto didn't repost. > > Looks good? Yes, LGTM Acked-by: Bjørn Mork

Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-20 Thread Bjørn Mork
Giacinto Cifelli writes: > Hi Bjørn, > I have fixed and resent, but from your comment I might not have > selected the right line from maintaner.pl? > what I have is this: > $ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c > "Bjørn Mork" (maintainer

Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-18 Thread Bjørn Mork
Reinhard Speyerer writes: >> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c >> index af19513a9f75..262d19439b34 100644 >> --- a/drivers/net/usb/qmi_wwan.c >> +++ b/drivers/net/usb/qmi_wwan.c >> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = { >> {Q

Re: [PATCH 17/18] net: iosm: readme file

2021-01-17 Thread Bjørn Mork
Sorry about being much too late into this discussion. I'm not having the bandwidth to read netdev anymore, and just stumbled across this now. Andrew Lunn writes: > So, this is what all the Ethernet nonsense is all about. You have a > session ID you need to somehow represent to user space. And y

Re: [PATCH net-next] qmi_wwan: Increase headroom for QMAP SKBs

2021-01-06 Thread Bjørn Mork
n't when we put an IP packet there without any L2 header? In any case: Acked-by: Bjørn Mork

Re: [PATCH net,stable] net: cdc_ncm: correct overhead in delayed_ndp_size

2021-01-03 Thread Bjørn Mork
me to fixup this rather messy piece of code. Reviewed-by: Bjørn Mork

[PATCH net,stable] net: usb: qmi_wwan: add Quectel EM160R-GL

2020-12-30 Thread Bjørn Mork
(Int.) MxPS= 8 Ivl=32ms E: Ad=8e(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms E: Ad=0f(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms Signed-off-by: Bjørn Mork --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index d166c321ee9b

Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400

2020-11-17 Thread Bjørn Mork
05c6, 0x9026, 3)}, > {QMI_FIXED_INTF(0x05c6, 0x902e, 5)}, > {QMI_FIXED_INTF(0x05c6, 0x9031, 5)}, Acked-by: Bjørn Mork This fix should probably go to net+stable. Thanks, Bjørn

Re: [PATCH net-next 5/5] net: usb: switch to dev_get_tstats64 and remove usbnet_get_stats64 alias

2020-11-11 Thread Bjørn Mork
net/usb/sr9700.c | 2 +- > drivers/net/usb/sr9800.c | 2 +- > drivers/net/wireless/rndis_wlan.c | 2 +- > include/linux/usb/usbnet.h| 2 -- > 18 files changed, 19 insertions(+), 21 deletions(-) For the qmi_wwan part: Acked-by: Bjørn Mork

Re: [PATCH net-next 2/5] qmi_wwan: switch to core handling of rx/tx byte/packet counters

2020-11-11 Thread Bjørn Mork
Heiner Kallweit writes: > Use netdev->tstats instead of a member of qmimux_priv for storing > a pointer to the per-cpu counters. This allows us to use core > functionality for statistics handling. > > Signed-off-by: Heiner Kallweit Acked-by: Bjørn Mork

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit LE910Cx 0x1230 composition

2020-11-02 Thread Bjørn Mork
Daniele Palmas writes: > dd support for Telit LE910Cx 0x1230 composition: > > 0x1230: tty, adb, rmnet, audio, tty, tty, tty, tty > > Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork

Re: [PATCH net-next 04/12] net: usb: qmi_wwan: use new function dev_fetch_sw_netstats

2020-10-11 Thread Bjørn Mork
Heiner Kallweit writes: > Simplify the code by using new function dev_fetch_sw_netstats(). > > Signed-off-by: Heiner Kallweit Acked-by: Bjørn Mork

Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-08 Thread Bjørn Mork
Jakub Kicinski writes: > I'm guessing that I'm supposed to take this patch into the networking > tree, correct? Correct. > Is this net or net-next candidate? Bjørn? Sorry, should have made that explicit. This is for net + stable Thanks. Bjørn

Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-08 Thread Bjørn Mork
MI_GOBI1K_DEVICE(0x05c6, 0x9212)},/* Acer Gobi Modem Device */ Thanks. Looks nice now. Acked-by: Bjørn Mork

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-05 Thread Bjørn Mork
Wilken Gottwalt writes: > Oh sorry, looks like I got it mixed up a bit. It was my first attempt to > submit > a patch set. Which is the best way to resubmit an update if the other part of > the patch set gets accepted? The documentation about re-/submitting patch sets > is a bit thin. I see tha

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-04 Thread Bjørn Mork
Wilken Gottwalt writes: > Add usb ids of the Cellient MPL200 card. > > Signed-off-by: Wilken Gottwalt > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 07c42c0719f5..0bf2b19d5d54 100644 > -

Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

2020-09-09 Thread Bjørn Mork
ult value to > guarantee a minimum number if rx_qlen is < than a threshold?). And > this is also a change affecting all the drivers using usbnet, so it > requires additional care. I'm not sure we want to do that. We haven't done it for other aggregating usbnet protocols.

Re: [PATCH] net: usb: qmi_wwan: Fix for packets being rejected in the ring buffer used by the xHCI controller.

2020-09-07 Thread Bjørn Mork
Kristian Evensen writes: > Hi all, > > I was able to trigger the same issue as reported by Paul, and came > across this patch (+ Daniele's other patch and thread on the libqmi > mailing list). Applying Paul's fix solved the problem for me, changing > the MTU of the QMI interface now works fine. T

Re: [PATCH] net: cdc_ncm: Fix build error

2020-08-26 Thread Bjørn Mork
YueHaibing writes: > If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails: > > drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to > `usbnet_cdc_update_filter' > > Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this. Ouch. For some reason I assumed that was always s

Re: [gluon] Re: [RFC PATCH net-next] bridge: Implement MLD Querier wake-up calls / Android bug workaround

2020-08-17 Thread Bjørn Mork
Sven Eckelmann writes: > On Monday, 17 August 2020 10:39:00 CEST Bjørn Mork wrote: >> Linus Lüssing writes: > [...] >> This is not a bug. They are deliberately breaking IPv6 because they >> consider this a feature. You should not try to work around such issues. >>

Re: [RFC PATCH net-next] bridge: Implement MLD Querier wake-up calls / Android bug workaround

2020-08-17 Thread Bjørn Mork
Linus Lüssing writes: > Currently there are mobile devices (e.g. Android) which are not able > to receive and respond to MLD Queries reliably because the Wifi driver > filters a lot of ICMPv6 when the device is asleep - including > MLD. This in turn breaks IPv6 communication when MLD Snooping is

Re: 答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
"Carl Yin(殷张成)" writes: > Hi Bjørn, > You can check cdc_ncm.c. > cdc ncm driver set 'rx_urb_size' on driver probe time, and the value > read from' cdc_ncm_bind_common() 's USB_CDC_GET_NTB_FORMAT '. > and also allow the userspace to modify 'rx_urb_size' by ' > /sys/class/net/w

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 11:49 Greg KH > ha scritto: >> >> Where does QMI_WDA_SET_DATA_FORMAT come from? >> > > This is a request of Qualcomm proprietary protocol used, among other > things, to configure data aggregation for modems. There's an open > source users

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > ha scritto: > >> Actually, no, this all should be done "automatically", do not change the >> urb size on the fly. Change it at probe time based on the device you >> are using, do not force userspace to "know" what to do h

Re: [PATCH v5 net-next 2/5] net: cdc_ether: export usbnet_cdc_update_filter

2020-07-24 Thread Bjørn Mork
On July 21, 2020 11:00:08 AM GMT+02:00, Oliver Neukum wrote: >Am Mittwoch, den 15.07.2020, 20:40 +0200 schrieb Bjørn Mork: >> >> @@ -90,6 +90,7 @@ static void usbnet_cdc_update_filter(struct usbnet >*dev) >>

[PATCH v5 net-next 1/5] net: cdc_ether: use dev->intf to get interface information

2020-07-15 Thread Bjørn Mork
the problem. Signed-off-by: Miguel Rodríguez Pérez Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ether.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index a657943c9f01..2afe258e3648 100644 --- a/drivers/net/

[PATCH v5 net-next 2/5] net: cdc_ether: export usbnet_cdc_update_filter

2020-07-15 Thread Bjørn Mork
From: Miguel Rodríguez Pérez This makes the function available to other drivers, like cdc_ncm. Signed-off-by: Miguel Rodríguez Pérez Acked-by: Oliver Neukum Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ether.c | 3 ++- include/linux/usb/usbnet.h | 1 + 2 files changed, 3 insertions

[PATCH v5 net-next 4/5] net: cdc_ncm: add .ndo_set_rx_mode to cdc_ncm_netdev_ops

2020-07-15 Thread Bjørn Mork
ssing callback to usbnet_set_rx_mode in net_device_ops. Signed-off-by: Miguel Rodríguez Pérez Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ncm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 8929669b5e6d..f5d7b933792b 100644

[PATCH v5 net-next 5/5] net: cdc_ncm: hook into set_rx_mode to admit multicast traffic

2020-07-15 Thread Bjørn Mork
From: Miguel Rodríguez Pérez We set set_rx_mode to usbnet_cdc_update_filter provided by cdc_ether that simply admits all multicast traffic if there is more than one multicast filter configured. Signed-off-by: Miguel Rodríguez Pérez Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ncm.c | 3

[PATCH v5 net-next 0/5] usbnet: multicast filter support for cdc ncm devices

2020-07-15 Thread Bjørn Mork
es v5: - added missing symbol export - formatted patch subjects with subsystem Bjørn Mork (1): net: usbnet: export usbnet_set_rx_mode() Miguel Rodríguez Pérez (4): net: cdc_ether: use dev->intf to get interface information net: cdc_ether: export usbnet_cdc_update_filter

[PATCH v5 net-next 3/5] net: usbnet: export usbnet_set_rx_mode()

2020-07-15 Thread Bjørn Mork
This function can be reused by other usbnet minidrivers. Signed-off-by: Bjørn Mork --- drivers/net/usb/usbnet.c | 3 ++- include/linux/usb/usbnet.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 5ec97def3513

Re: [PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

2020-07-07 Thread Bjørn Mork
TF(0x2c7c, 0x0296, 4)},/* Quectel BG96 */ > {QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */ > {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)},/* Foxconn T77W968 LTE */ Acked-by: Bjørn Mork

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit LE910C1-EUX composition

2020-05-26 Thread Bjørn Mork
Daniele Palmas writes: > Add support for Telit LE910C1-EUX composition > > 0x1031: tty, tty, tty, rmnet > Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork

Re: [PATCH] net: usb: qmi_wwan: remove redundant assignment to variable status

2020-05-10 Thread Bjørn Mork
Adding Fixes for documentation only, not as a stable hint. This is cleanup only and not suitable for stable IMHO. Acked-by: Bjørn Mork Fixes: 8492ed45aa5d ("qmi-wwan: use common parser")

Re: [PATCH] net: usb: qmi_wwan: add support for DW5816e

2020-05-03 Thread Bjørn Mork
,/* Dell Wireless 5821e */ > {QMI_FIXED_INTF(0x413c, 0x81d7, 1)},/* Dell Wireless 5821e > preproduction config */ > {QMI_FIXED_INTF(0x413c, 0x81e0, 0)},/* Dell Wireless 5821e with > eSIM support*/ Looks fine to me. Please add to the stable queue as well, Thanks. Acked-by: Bjørn Mork

Re: [PATCH] qmi_wwan: add support for Cinterion CLS8 devices

2019-10-03 Thread Bjørn Mork
Reinhard Speyerer writes: > Add support for Cinterion CLS8 devices. > Use QMI_QUIRK_SET_DTR as required for Qualcomm MDM9x07 chipsets. Acked-by: Bjørn Mork

Re: [PATCH 0/4] qmi_wwan: fix QMAP handling

2019-06-13 Thread Bjørn Mork
Reinhard Speyerer writes: > This series addresses the following issues observed when using the > QMAP support of the qmi_wwan driver: Really nice work! Thanks. Acked-by: Bjørn Mork

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1260 and 0x1261 compositions

2019-05-15 Thread Bjørn Mork
Daniele Palmas writes: > Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. Thanks. Acked-by: Bjørn Mork

[PATCH net] qmi_wwan: new Wistron, ZTE and D-Link devices

2019-04-24 Thread Bjørn Mork
ics Device MI_01 ZTE UI AT Interface MI_02 ZTE Modem Device MI_03 ZTE Mobile Broadband Network Adapter MI_04 ZTE Composite ADB Interface Reported-by: Lars Melin Signed-off-by: Bjørn Mork --- drivers/net/usb/qmi_wwan.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/

Re: cellular modem driver APIs

2019-04-12 Thread Bjørn Mork
Johannes Berg writes: > On Wed, 2019-04-10 at 21:54 -0600, Subash Abhinov Kasiviswanathan wrote: > >> These packets will be processed as raw IP muxed frames on the PC as >> well, not as ethernet though. > > But in order to transport them, they're always encapsulated in ethernet? No. There is no

Re: [PATCH net-next] qmi_wwan: Add quirk for Quectel dynamic config

2019-04-07 Thread Bjørn Mork
e you directed it to net-next for more thorough testing first? Acked-by: Bjørn Mork

Re: cellular modem driver APIs

2019-04-04 Thread Bjørn Mork
Johannes Berg writes: > Hi all, > > I've been looking at modem drivers, to see what the APIs are to interact > with them, and while I originally thought I had the story sorted out ... > not at all. Thanks a lot for doing this! Being responsible for most of the issues you point out, I can only s

Re: [PATCH net] qmi_wwan: Add support for Quectel EG12/EM12

2019-03-02 Thread Bjørn Mork
s it's acceptable for two devices when it was ok for one, so Acked-by: Bjørn Mork But I assume this isn't the last device we've seen with this issue. Someone has already mention Quectel EM20. Maybe convert this code to a quirk for the next device and leave all the device specific magic

Re: [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607

2019-02-15 Thread Bjørn Mork
like it's time to consider applying this unconditionally to all devices. Feel free to propose something like that the next time this issue comes up. Acked-by: Bjørn Mork

[PATCH] cdc_ether: trivial whitespace readability fix

2019-01-05 Thread Bjørn Mork
This function is unreadable enough without indenting mismatches and unnecessary line breaks. Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ether.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb

Re: [PATCH 1/1] qmi_wwan: add MTU default to qmap network interface

2019-01-04 Thread Bjørn Mork
alue makes sense, but hard coding 1500 feels wrong. Should this relate to the real device mtu somehow? Do we need a ndo_change_mtu to enforce this relationship? Should qmimux_rx_fixup() respect the qmap device mtu? I'm fine with this patch as a first step and immediate fix, so Acked-by: Bjørn Mork

Re: [PATCH 1/1] Fix qmap header retrieval in qmimux_rx_fixup

2018-12-21 Thread Bjørn Mork
Daniele Palmas writes: > This patch fixes qmap header retrieval when modem is configured for > dl data aggregation. > > Signed-off-by: Daniele Palmas > --- > Hi Bjørn and all, > > I'm facing an issue when using qmi_wwan with modem configured with dl data > aggregation and qmap multiplexing, e.g

Re: [PATCH] qmi_wwan: Added support for Telit LN940 series

2018-12-13 Thread Bjørn Mork
IRK_SET_DTR(0x1bc7, 0x1900, 1)}, /* Telit LN940 series */ > {QMI_FIXED_INTF(0x1c9e, 0x9801, 3)},/* Telewell TW-3G HSPA+ */ > {QMI_FIXED_INTF(0x1c9e, 0x9803, 4)},/* Telewell TW-3G HSPA+ */ > {QMI_FIXED_INTF(0x1c9e, 0x9b01, 3)},/* XS Stick W100-2 from 4G > Systems */ looking good. Acked-by: Bjørn Mork

Re: [PATCH v3] qmi_wwan: Added support for Fibocom NL668 series

2018-12-11 Thread Bjørn Mork
o amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. Don't know if that matters though. The commit message still looks fine in utf8, so I guess not. Acked-by: Bjørn Mork

Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series

2018-12-11 Thread Bjørn Mork
Jörgen Storvist writes: > Should be correct now as above if I understood you correctly. Yup, the sorting part looks fine. But you need to drop the additional text below the patch. It will mess up the result. Any extra text which isn't part of the patch or the commit message should go inside th

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-11 Thread Bjørn Mork
NeilBrown writes: > I got your patch working on 4.20-rc5 and did a performance comparison. > With the staging driver (using iperf3) I get > 220 MBit/sec in > 680 MBit/sec out > > with the patched mainline driver I get > 190 MBit/sec in >93 MBit/sec out > > (numbers are a bit rubbery, bu

Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series

2018-12-10 Thread Bjørn Mork
Jörgen Storvist writes: > Added support for Fibocom NL668 series QMI WWAN interface in default USB > mode: AT+GTUSBMODE=17. > Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets. > > Signed-off-by: Jörgen Storvist > > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-03 Thread Bjørn Mork
[ fixed Johns address - the openwrt.org email was apparently never restored? ] Greg Ungerer writes: > The following change helped alot, but I still get some problems under > sustained load and some types of port setups. Still trying to figure > out what exactly is going on. > > --- a/linux/drive

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-11-30 Thread Bjørn Mork
g...@kernel.org writes: > I have been working towards supporting the MT7530 switch as used in the > MediaTek MT7621 SoC. Unlike the MediaTek MT7623 the MT7621 is built around > a dual core MIPS CPU architecture. But underneath it is what appears to > be the same 7530 switch. Great! Good to see s

Re: Can decnet be deprecated?

2018-11-25 Thread Bjørn Mork
David Miller writes: > From: David Ahern > Date: Sat, 24 Nov 2018 17:12:48 -0700 > >> IPX was moved to staging at the end of last year. Can decnet follow >> suit? git log seems to indicate no active development in a very long time. > > Last time I tried to do that someone immediately said on the

Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-25 Thread Bjørn Mork
Josh Elsasser writes: > Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers") Not that it matters much I guess, but I think LX SFPs were unsupported at that time. The LX support appears to have been added under the radar while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f

[PATCH] net/{ipv4,ipv6}: Do not put target net if input nsid is invalid

2018-10-25 Thread Bjørn Mork
ils due to bad attributes") Cc: David Ahern Signed-off-by: Bjørn Mork --- net/ipv4/devinet.c | 1 + net/ipv6/addrconf.c | 1 + 2 files changed, 2 insertions(+) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 9250b309c742..a34602ae27de 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/

Re: [net-next][PATCH] net/ipv4: fix a net leak

2018-10-25 Thread Bjørn Mork
David Ahern writes: > On 10/24/18 9:02 AM, David Ahern wrote: >> On 10/24/18 3:36 AM, Li RongQing wrote: >>> put net when input a invalid ifindex, otherwise it will be leaked >>> >>> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a >>> specific device") >>> Cc: David Ahern

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion ALASxx WWAN interface

2018-10-10 Thread Bjørn Mork
Giacinto Cifelli writes: > Added support for Gemalto's Cinterion ALASxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > Signed-off-by: Giacinto Cifelli Acked-by: Bjørn Mork

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-09-08 Thread Bjørn Mork
enabled? Are you sure there can't be any other type of serial function with 3 endpoints and ff/ff/ff? Well, I guess no one knows for sure... And this is more than good enough until it breaks. Thanks for solving the puzzle. Looks good to me. Acked-by: Bjørn Mork

Re: [PATCH net-next] net: qmi_wwan: Add pass through mode

2018-06-27 Thread Bjørn Mork
Subash Abhinov Kasiviswanathan writes: > Pass through mode is to allow packets in MAP format to be passed > on to the stack. rmnet driver can be used to process and demultiplex > these packets. Note that pass through mode can be enabled when the > device is in raw ip mode only. The concepte look

Re: Qualcomm rmnet driver and qmi_wwan

2018-06-11 Thread Bjørn Mork
Subash Abhinov Kasiviswanathan writes: >> thanks, I will test it on Monday. >> >> Just a question for my knowledge: is the new sysfs attribute really >> needed? I mean, is there not any other way to understand from qmi_wwan >> without user intervention that there is the rmnet device attached? >>

Re: Qualcomm rmnet driver and qmi_wwan

2018-06-08 Thread Bjørn Mork
Subash Abhinov Kasiviswanathan writes: >> I followed Dan's advice and prepared a very basic test patch >> (attached) for testing it through ip link. >> >> Basically things seem to be properly working with qmicli, but I needed >> to modify a bit qmi_wwan, so I'm adding Bjørn that maybe can help. >

Re: ANNOUNCE: Enhanced IP v1.4

2018-06-05 Thread Bjørn Mork
Willy Tarreau writes: > I agree on these points, but I'd like to figure what can be done to put > a bit more pressure on ISPs to *always* provide IPv6. Most ISPs are in it for the money. So what you can do is either to make it more expensive to provide IPv4-only services or more profitable to p

Re: [PATCH] net: qmi_wwan: Add Netgear Aircard 779S

2018-05-28 Thread Bjørn Mork
Josh Hill writes: > Add support for Netgear Aircard 779S > > Signed-off-by: Josh Hill Acked-by: Bjørn Mork Please queue this for stable too. Thanks. Bjørn

[PATCH net-next] qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID

2018-05-25 Thread Bjørn Mork
: add QMI_QUIRK_SET_DTR for Telit PID 0x1201") Initial testing on an older SIM7100 modem shows no immediate side effects. Reported-by: Sebastian Sjoholm Cc: Reinhard Speyerer Signed-off-by: Bjørn Mork --- I propose this for net-next for now to get some extra testing exposure before going into sta

[PATCH net,stable] qmi_wwan: do not steal interfaces from class drivers

2018-05-02 Thread Bjørn Mork
MBIM, without the device ID changing either. Fix by requiring the vendor-specific class for interface number based matching. Functions of other classes can and should use class based matching instead. Fixes: 03304bcb5ec4 ("net: qmi_wwan: use fixed interface number matching") Signed-off

Re: [PATCH] NET: usb: qmi_wwan: add support for ublox R410M PID 0x90b2

2018-04-26 Thread Bjørn Mork
"SZ Lin (林上智)" writes: > This patch adds support for PID 0x90b2 of ublox R410M. Acked-by: Bjørn Mork

Re: [PATCH] net: qmi_wwan: add Wistron Neweb D19Q1

2018-04-18 Thread Bjørn Mork
one) > E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us > > Tested on openwrt distribution > > Signed-off-by: Pawel Dembicki Acked-by: Bjørn Mork

[PATCH v3 net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
Capturing on 'out' ff ff ff ff ff ff 76 cf 76 37 d5 0a 81 00 00 14 ..v.v7.. 0010 08 06 00 01 08 00 06 04 00 01 76 cf 76 37 d5 0a ..v.v7.. 0020 0a 09 09 09 00 00 00 00 00 00 .. Fixes: aff3d70a07ff ("tun: allow to attach ebp

[PATCH v2 net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
Capturing on 'out' ff ff ff ff ff ff 76 cf 76 37 d5 0a 81 00 00 14 ..v.v7.. 0010 08 06 00 01 08 00 06 04 00 01 76 cf 76 37 d5 0a ..v.v7.. 0020 0a 09 09 09 00 00 00 00 00 00 .. Fixes: aff3d70a07ff ("tun: allow to attach ebp

Re: [PATCH net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
David Miller writes: > The VLAN business might be bogus, and needs to be removed. > > However, the pskb_trim() has to stay in some form. I think this is what > Jason is trying to say. > > The semantics of running a BPF program is that the program returns the > desired packet length. We must tru

Re: [PATCH net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
Jason Wang writes: > Good catch, Thanks. I guess I am "lucky" as I apparently use configs no one else are using, and therefore often experience breakage ;-) I have been using tagged interfaces over tap for an occasional virtual "lab" of kvm machines for years. It's a simple way to have a fle

[PATCH net,stable] tun: fix vlan packet truncation

2018-04-16 Thread Bjørn Mork
Capturing on 'out' ff ff ff ff ff ff 76 cf 76 37 d5 0a 81 00 00 14 ..v.v7.. 0010 08 06 00 01 08 00 06 04 00 01 76 cf 76 37 d5 0a ..v.v7.. 0020 0a 09 09 09 00 00 00 00 00 00 .. Fixes: aff3d70a07ff ("tun: allow to attach ebpf

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

2018-02-27 Thread Bjørn Mork
Bassem Boubaker writes: > +#define GEMALTO_VENDOR_ID0x1e2d This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c. I have no idea which defintion is most correct, but I believe the macros should be kept identical whatever you decide. Anything else is just unnecessarily confus

Re: [PATCH net,stable] qmi_wwan: Add support for Quectel EP06

2018-01-30 Thread Bjørn Mork
Kristian Evensen writes: > The Quectel EP06 is a Cat. 6 LTE modem. It uses the same interface as > the EC20/EC25 for QMI, and requires the same "set DTR"-quirk to work. > > Signed-off-by: Kristian Evensen Acked-by: Bjørn Mork

Re: [PATCH] usbnet: silence an unnecessary warning

2018-01-11 Thread Bjørn Mork
Oliver Neukum writes: > That a kevent could not be scheduled is not an error. > Such handlers must be able to deal with multiple events anyway. > As the successful scheduling of a work is a debug event, make > the failure debug priority, too. > > Signed-off-by: Oliver Neukum > Reported-by: Crist

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

2017-12-29 Thread Bjørn Mork
c6, 0x920d, 5)}, > + {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */ > {QMI_FIXED_INTF(0x0846, 0x68a2, 8)}, > {QMI_FIXED_INTF(0x12d1, 0x140c, 1)},/* Huawei E173 */ > {QMI_FIXED_INTF(0x12d1, 0x14ac, 1)},/* Huawei E1820 */ Perfect. Thanks Acked-by: Bjørn Mork

Re: [PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-14 Thread Bjørn Mork
Vamsi Samavedam writes: > On Thu, Dec 14, 2017 at 07:55:50PM +0100, Bjørn Mork wrote: >> It has been reported that the dummy byte we add to avoid >> ZLPs can be forwarded by the modem to the PGW/GGSN, and that >> some operators will drop the connection if this happens.

[PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-14 Thread Bjørn Mork
latter assumption failed. Let's test out the first. Signed-off-by: Bjørn Mork --- I am a bit worried about the effect of this change on all the devices I can't test myself. But trying it is the only way we can ever find out drivers/net/usb/qmi_wwan.c | 4 ++-- 1 file changed, 2

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit ME910 PID 0x1101 support

2017-12-14 Thread Bjørn Mork
Daniele Palmas writes: > This patch adds support for Telit ME910 PID 0x1101. > > Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork > bInterfaceSubClass254 Just curious: Is there some meaning hidden here? Bjørn

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread Bjørn Mork
100V LTE) */ > {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},/* Alcatel L800MA */ > {QMI_FIXED_INTF(0x2357, 0x0201, 4)},/* TP-LINK HSUPA Modem MA180 */ Looks good except for the duplicate 'From' line. Drop that and you can add Acked-by: Bjørn Mork

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-07 Thread Bjørn Mork
David Miller writes: > From: Bjørn Mork > Date: Wed, 6 Dec 2017 20:21:24 +0100 > >> The qmi_wwan minidriver support a 'raw-ip' mode where frames are >> received without any ethernet header. This causes alignment issues >> because the skbs allocated by u

[PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-06 Thread Bjørn Mork
d using a per-device flag, since the same minidriver also supports 'ethernet' mode. Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode") Reported-and-tested-by: Jay Foster Signed-off-by: Bjørn Mork --- drivers/net/usb/qmi_wwan.c | 2 ++ drivers/net/usb/us

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

2017-11-24 Thread Bjørn Mork
Reinhard Speyerer writes: > before posting this problem report > https://developer.gemalto.com/threads/ipv6dualstack-problems-pls8-e-revision-03017 > in the Gemalto developer forum I tested the qmi_wwan/cdc_ether changes > you suggested above and apart from having two working QMI interfaces > the

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

2017-11-23 Thread Bjørn Mork
Oliver Graute writes: > On 23/11/17, Bjørn Mork wrote: >> Oliver Graute writes: >> >> > When the PLS8 devices show up with PID 0x0061 they will expose both a >> > QMI port and a WWAN interface. >> >> >> Please remove the indentat

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

2017-11-23 Thread Bjørn Mork
Oliver Graute writes: > When the PLS8 devices show up with PID 0x0061 they will expose both a > QMI port and a WWAN interface. Please remove the indentation. > Signed-off-by: Oliver Graute > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dri

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-11-20 Thread Bjørn Mork
-off-by: Sebastian Sjoholm Perfect. Thanks. Acked-by: Bjørn Mork

Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819

2017-11-20 Thread Bjørn Mork
Shrirang Bagul writes: > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 > series modems which will by default boot with vid 0x413c and pid's > 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support > qmi_wwan on the usb interface #12. NAK, Interace #12 is

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-11-19 Thread Bjørn Mork
On November 20, 2017 5:19:21 AM GMT+01:00, ssjoh...@mac.com wrote: >From: ssjoholm > >Signed-off-by: ssjoholm > >Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both >CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel >development board (EVB). >The USB id is added to q

[PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

2017-11-15 Thread Bjørn Mork
constant by converting the constant to LE. Reported-by: Ben Hutchings Fixes: 2b02c20ce0c2 ("cdc_ncm: Set NTB format again after altsetting switch for Huawei devices") Cc: Enrico Mioso Cc: Christian Panton Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ncm.c | 4 ++-- 1 file changed, 2

  1   2   3   >