[PATCH v1 net] stmmac: fix DMA channel hang in half-duplex mode

2018-06-17 Thread Bhadram Varka
HW does not support Half-duplex mode in multi-queue scenario. Fix it by not advertising the Half-Duplex mode if multi-queue enabled. Signed-off-by: Bhadram Varka --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net

Re: [PATCH v1 net-next] stmmac: fix DMA channel hang in half-duplex mode

2018-06-15 Thread Bhadram Varka
Hi, On 6/15/2018 5:36 AM, David Miller wrote: From: Bhadram Varka Date: Wed, 13 Jun 2018 10:00:48 +0530 HW does not support Half-duplex mode in multi-queue scenario. Fix it by not advertising the Half-Duplex mode if multi-queue enabled. Signed-off-by: Bhadram Varka Bug fixes should be

[PATCH v1 net-next] stmmac: fix DMA channel hang in half-duplex mode

2018-06-12 Thread Bhadram Varka
HW does not support Half-duplex mode in multi-queue scenario. Fix it by not advertising the Half-Duplex mode if multi-queue enabled. Signed-off-by: Bhadram Varka --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net

Re: STMMAC driver with TSO enabled issue

2018-05-29 Thread Bhadram Varka
Hi Jose, On 5/28/2018 4:26 PM, Jose Abreu wrote: Hi Bhadram, On 28-05-2018 10:15, Bhadram Varka wrote: Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram

Re: STMMAC driver with TSO enabled issue

2018-05-28 Thread Bhadram Varka
Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram

Re: [PATCH] net: stmmac: Use mutex instead of spinlock

2018-05-25 Thread Bhadram Varka
, convert it to a mutex instead. Fixes: e6ea2d16fc61 ("net: stmmac: dwc-qos: Add Tegra186 support") Reported-by: Jon Hunter Signed-off-by: Thierry Reding --- Tested on P3310 Tegra186 platform. Tested-by: Bhadram Varka -- Bhadram

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Bhadram Varka
Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Bhadram Varka
Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 index 025 and 026 descriptors processed but

Re: STMMAC driver with TSO enabled issue

2018-05-23 Thread Bhadram Varka
Hi Jose, On 5/17/2018 7:43 PM, Jose Abreu wrote: Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: Hi Jose, On 5/10/2018 9:15 PM, Jose Abreu wrote: On 10-05-2018 16:08, Bhadram Varka wrote: Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose

Re: STMMAC driver with TSO enabled issue

2018-05-14 Thread Bhadram Varka
Hi Jose, On 5/10/2018 9:15 PM, Jose Abreu wrote: On 10-05-2018 16:08, Bhadram Varka wrote: Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: ++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Bhadram Varka
Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: ++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Tried below suggested way. Still observing the issue - It seems stmmac has a bug in the RX side

Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
HI David, On 5/2/2018 10:51 PM, David Miller wrote: Please remove the email footer from your postings here that talks about confidential information and whatnot. That is expressly inappropriate for this mailing list, and any such postings shall be ignored in their entirety. I Understand thi

[PATCH v2 1/2] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 10 ++ include/linux/brcmphy.h| 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/net/phy

Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
On 5/2/2018 6:59 PM, Andrew Lunn wrote: On Wed, May 02, 2018 at 03:54:36PM +0530, Bhadram Varka wrote: It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11

Re: [PATCH 1/2] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
Hi, On 5/2/2018 3:48 PM, Bhadram Varka wrote: It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11 +++ include/linux/brcmphy.h| 1 + 2 files changed

[PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11 +++ include/linux/brcmphy.h| 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/net/phy

[PATCH 1/2] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11 +++ include/linux/brcmphy.h| 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/net/phy

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-26 Thread Bhadram Varka
Hi Andrew/Jisheng, On 4/26/2018 6:10 PM, Andrew Lunn wrote: hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel requires WOL should be "stick". I see two different cases: Suspend/resume: The WoL state in the kernel is probably kept across such a cycle. If so, you would expect

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-26 Thread Bhadram Varka
Hi, On 4/26/2018 11:56 AM, Bhadram Varka wrote: Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-25 Thread Bhadram Varka
Hi, On 4/26/2018 11:45 AM, Jisheng Zhang wrote: Hi, On Thu, 26 Apr 2018 11:10:21 +0530 Bhadram Varka wrote: Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-25 Thread Bhadram Varka
Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin will not be cleared unless reading the CSISR register. So clear the WOL event before enabling it. Signed-off-by: J

Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Bhadram Varka
HiJisheng, On 4/19/2018 2:39 PM, Jisheng Zhang wrote: On Thu, 19 Apr 2018 09:00:40 + Bhadram Varka wrote: Hi, -Original Message- From: Jisheng Zhang Sent: Thursday, April 19, 2018 2:24 PM To: Bhadram Varka Cc: Andrew Lunn ; Florian Fainelli ; David S. Miller ; netdev

RE: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Bhadram Varka
Hi, > -Original Message- > From: Jisheng Zhang > Sent: Thursday, April 19, 2018 2:24 PM > To: Bhadram Varka > Cc: Andrew Lunn ; Florian Fainelli ; > David S. Miller ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Jingju Hou > Subject: Re: [PATCH] net:

RE: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-19 Thread Bhadram Varka
Hi, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jisheng Zhang > Sent: Thursday, April 19, 2018 1:33 PM > To: Andrew Lunn ; Florian Fainelli ; > David S. Miller > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Jingju Hou > > Subject: [PATCH] net: p

RE: [PATCH] net: phy: marvell: Enable interrupt function on LED2 pin

2018-04-05 Thread Bhadram Varka
Hi Esben, -Original Message- From: netdev-ow...@vger.kernel.org On Behalf Of Esben Haabendal Sent: Thursday, April 05, 2018 7:05 PM To: netdev@vger.kernel.org Cc: Esben Haabendal ; Rasmus Villemoes ; Andrew Lunn ; Florian Fainelli ; open list Subject: [PATCH] net: phy: marvell: Enable

RE: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

2017-12-01 Thread Bhadram Varka
Hi Lars, > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Lars P (Mailing List Account) > Sent: Friday, December 01, 2017 9:05 PM > To: Bhadram Varka > Cc: joao.pi...@synopsys.com; peppe.cavall...@st

RE: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

2017-12-01 Thread Bhadram Varka
Hi Giuseppe, I don't see any issue with if we execute "ping -s 1400" case. I believe in this case TSO not triggered. Thanks, Bhadram. -Original Message- From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com] Sent: Thursday, November 23, 2017 11:58 AM To: Bhadram

RE: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

2017-11-20 Thread Bhadram Varka
, Bhadram. -Original Message- From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com] Sent: Monday, November 20, 2017 6:37 PM To: Bhadram Varka ; joao.pi...@synopsys.com Cc: linux-netdev Subject: Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out Hello Bhadram there

RE: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

2017-11-19 Thread Bhadram Varka
Hi Joao/Peppe, Observed this issue more frequently with multi-channel case. Am I missing something in DT ? Please help here to understand the issue. Thanks, Bhadram -Original Message- From: Bhadram Varka Sent: Thursday, November 16, 2017 9:41 AM To: linux-netdev Subject: NETDEV

NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

2017-11-15 Thread Bhadram Varka
Hi, I am trying to enable multi-queue in Tegra186 EQOS (which has support for 4 channels). Observed below netdev watchdog warning. Its easily reproable with iperf test. In normal ping scenario this is not observed. I did not observe any issue if we disable TSO. Looks like issue in stmmac_tso_x

[PATCH] stmmac: use of_property_read_u32 instead of read_u8

2017-11-02 Thread Bhadram Varka
Numbers in DT are stored in “cells” which are 32-bits in size. of_property_read_u8 does not work properly because of endianness problem. This causes it to always return 0 with little-endian architectures. Fix it by using of_property_read_u32() OF API. Signed-off-by: Bhadram Varka --- drivers

[PATCH net-next] stmmac: copy unicast mac address to MAC registers

2017-10-26 Thread Bhadram Varka
Currently stmmac driver not copying the valid ethernet MAC address to MAC registers. This patch takes care of updating the MAC register with MAC address. Signed-off-by: Bhadram Varka --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16 +++- 1 file changed, 15 insertions(+), 1

RE: [PATCH net] net: stmmac: First Queue must always be in DCB mode

2017-10-26 Thread Bhadram Varka
Hi Jose, > -Original Message- > From: Jose Abreu [mailto:jose.ab...@synopsys.com] > Sent: Thursday, October 26, 2017 5:19 PM > To: Bhadram Varka ; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Joao Pinto ; David S. Miller > ; Giuseppe Cavallaro

RE: [PATCH net] net: stmmac: First Queue must always be in DCB mode

2017-10-26 Thread Bhadram Varka
Hi Jose, > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jose Abreu > Sent: Thursday, October 26, 2017 2:37 PM > To: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Jose Abreu ; Joao Pinto > ; David S. Miller ; > Gi

RE: netdev carrier changes is one even after ethernet link up.

2017-09-03 Thread Bhadram Varka
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Saturday, September 02, 2017 7:25 AM > To: Bhadram Varka ; and...@lunn.ch > Cc: linux-netdev > Subject: Re: netdev carrier changes is one even after ethernet link up. > > On 08/3

RE: netdev carrier changes is one even after ethernet link up.

2017-09-03 Thread Bhadram Varka
Hi Florian, > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Saturday, September 02, 2017 7:25 AM > To: Bhadram Varka ; and...@lunn.ch > Cc: linux-netdev > Subject: Re: netdev carrier changes is one even after ethernet link up. >

RE: netdev carrier changes is one even after ethernet link up.

2017-08-31 Thread Bhadram Varka
Thanks for responding. Now responding inline > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Friday, September 01, 2017 5:53 AM > To: Bhadram Varka ; and...@lunn.ch > Cc: linux-netdev > Subject: Re: netdev carrier changes is one e

RE: netdev carrier changes is one even after ethernet link up.

2017-08-31 Thread Bhadram Varka
Thanks for responding. -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Friday, September 01, 2017 5:53 AM To: Bhadram Varka ; and...@lunn.ch Cc: linux-netdev Subject: Re: netdev carrier changes is one even after ethernet link up. On 08/30/2017 10:53 PM

RE: netdev carrier changes is one even after ethernet link up.

2017-08-30 Thread Bhadram Varka
+ netdev From: Bhadram Varka Sent: Thursday, August 31, 2017 11:24 AM To: 'and...@lunn.ch' ; 'f.faine...@gmail.com' Cc: linux-netdev Subject: netdev carrier changes is one even after ethernet link up. Hi, I have observed that carrier_changes is one even in case of the