Re: bnx2 breaks Dell R815 BMC IPMI since 4.8

2016-11-28 Thread Baoquan He
Sorry, Brice. This has been reported by people, and it has been fixed by later post. The commits within linus's tree are: commit 6df77862f63f389df3b1ad879738e04440d7385d Author: Baoquan He Date: Sun Nov 13 13:01:33 2016 +0800 bnx2: Wait for in-flight DMA to complete at probe stage c

Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-14 Thread Baoquan He
On 11/14/16 at 09:25am, Paul Menzel wrote: > Dear Baoquan, > > On 11/13/16 06:01, Baoquan He wrote: > > This is v2 post. > > > > In commit 3e1be7a ("bnx2: Reset device during driver initialization"), > > firmware requesting code was moved from open

[PATCH v2 1/2] Revert "bnx2: Reset device during driver initialization"

2016-11-12 Thread Baoquan He
way in the later patch. Signed-off-by: Baoquan He Acked-by: Paul Menzel --- drivers/net/ethernet/broadcom/bnx2.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index b3791b3..c557972

[PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
ew way accordingly. Baoquan He (2): Revert "bnx2: Reset device during driver initialization" bnx2: Wait for in-flight DMA to complete at probe stage drivers/net/ethernet/broadcom/bnx2.c | 48 +++- 1 file changed, 36 insertions(+), 12 deletions(-) -- 2.5.5

[PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
Signed-off-by: Baoquan He --- drivers/net/ethernet/broadcom/bnx2.c | 38 ++-- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index c557972..1f7034d 100644 --- a/drivers/net

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
On 11/12/16 at 11:40pm, David Miller wrote: > From: Baoquan He > Date: Sun, 13 Nov 2016 12:15:24 +0800 > > > In-flight DMA from 1st kernel could continue going in kdump kernel. > > New io-page table has been created before bnx2 does reset at open stage. > > We have to

[PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
Signed-off-by: Baoquan He --- v1->v2: Michael suggested to wait for the in-flight DMA to complete at probe stage. So give up the old method of trying to reset chip at probe stage, take the new way accordingly. drivers/net/ethernet/broadcom/bnx2.c |

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

2016-11-12 Thread Baoquan He
Hi Michael, On 11/11/16 at 09:37am, Michael Chan wrote: > On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote: > > On 11/11/16 at 09:46pm, Baoquan He wrote: > >> Hi bnx2 experts, > >> > >> In commit 3e1be7a ("bnx2: Reset device during driver initializa

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

2016-11-11 Thread Baoquan He
On 11/11/16 at 09:46pm, Baoquan He wrote: > Hi bnx2 experts, > > In commit 3e1be7a ("bnx2: Reset device during driver initialization"), > firmware requesting code was moved from open stage to probe stage. > The reason is in kdump kernel hardware iommu need device be rese

[PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

2016-11-11 Thread Baoquan He
welcomed and much appreciated! Baoquan He (2): Revert "bnx2: Reset device during driver initialization" bnx2: Hard reset bnx2 chip at probe stage drivers/net/ethernet/broadcom/bnx2.c | 70 +--- 1 file changed, 65 insertions(+), 5 deletions(-) -- 2.5.5

[PATCH 2/2] bnx2: Hard reset bnx2 chip at probe stage

2016-11-11 Thread Baoquan He
d in kdump kernel. Signed-off-by: Baoquan He --- drivers/net/ethernet/broadcom/bnx2.c | 62 1 file changed, 62 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index c557972..84e3f12 100644 --- a/d

[PATCH 1/2] Revert "bnx2: Reset device during driver initialization"

2016-11-11 Thread Baoquan He
way in the later patch. Signed-off-by: Baoquan He --- drivers/net/ethernet/broadcom/bnx2.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index b3791b3..c557972 100644 --- a/drivers/net

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-31 Thread Baoquan He
On 10/31/16 at 11:43am, Paul Menzel wrote: > Dear Baoquan, > > > On 10/31/16 11:09, Baoquan He wrote: > > > On 10/26/16 at 12:31pm, Paul Menzel wrote: > > > Baoquan, could you please fix this regression. My suggestion is, that you > > > add the old code b

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-31 Thread Baoquan He
Hi Paul, On 10/26/16 at 12:31pm, Paul Menzel wrote: > Baoquan, could you please fix this regression. My suggestion is, that you > add the old code back, but check if the firmware has been loaded. If it > hasn’t, load it again. > > That way, people can update their Linux kernel, and it continues w

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-30 Thread Baoquan He
On 10/31/16 at 11:59am, Baoquan He wrote: > Hi Paul, > > On 10/30/16 at 12:05pm, Paul Menzel wrote: > > Dear Baoquan, > > > > > > Am Samstag, den 29.10.2016, 10:55 +0800 schrieb Baoquan He: > > > On 10/27/16 at 03:21pm, Paul Menzel wrote: > >

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-30 Thread Baoquan He
Hi Paul, On 10/30/16 at 12:05pm, Paul Menzel wrote: > Dear Baoquan, > > > Am Samstag, den 29.10.2016, 10:55 +0800 schrieb Baoquan He: > > On 10/27/16 at 03:21pm, Paul Menzel wrote: > > > > > > Baoquan, could you please fix this regression. My suggestion i

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-28 Thread Baoquan He
On 10/27/16 at 03:21pm, Paul Menzel wrote: > Dear Baoquan, > > > Baoquan, could you please fix this regression. My suggestion is, that you > > > add the old code back, but check if the firmware has been loaded. If it > > > hasn’t, load it again. > > > > > > That way, people can update their Linux

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-26 Thread Baoquan He
Hi Paul, Sorry for this. On 10/26/16 at 12:31pm, Paul Menzel wrote: > > > dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | > > > @@ -8607,6 +8608,7 @@ bnx2_init_one(struct pci_dev *pdev, const struct > > > pci_device_id *ent) > > > return 0; > > > > > > error: > > > + bn

Re: [PATCH v2] bnx2: Reset device during driver initialization

2016-09-13 Thread Baoquan He
On 09/13/16 at 11:25am, David Miller wrote: > > Just to be clear, I did actually apply this v2 of the patch > rather than the initial version.:) Thanks a lot!

[PATCH v2] bnx2: Reset device during driver initialization

2016-09-09 Thread Baoquan He
net device up stage. This will cause hardware iommu handling failure on bnx2 device. And its resetting relies on firmware. So in this patch move the firmware requesting code to earlier bnx2_init_one(), then next call bnx2_reset_chip to reset device. Signed-off-by: Baoquan He --- v1->

Re: [PATCH] bnx2: Reset device during driver initialization

2016-09-09 Thread Baoquan He
On 09/09/16 at 04:11pm, Baoquan He wrote: > When system enters into kdump kernel because of kernel panic, it won't > shutdown devices. On-flight DMA will continue transferring data until > device driver initializes. All devices are supposed to reset during > driver initial

Re: [PATCH] bnx2: Reset device during driver initialization

2016-09-09 Thread Baoquan He
Hi Joerg, On 09/09/16 at 10:41am, Joerg Roedel wrote: > > Hi Baoquan, > > On Fri, Sep 09, 2016 at 04:22:25PM +0800, Baoquan He wrote: > > Recently I tried to fix the kdump failure in amd iommu system again, and > > now the latest code works, IO_PAGE_FAULT can&#x

Re: [PATCH] bnx2: Reset device during driver initialization

2016-09-09 Thread Baoquan He
On 09/09/16 at 10:41am, Joerg Roedel wrote: > > Hi Baoquan, > > On Fri, Sep 09, 2016 at 04:22:25PM +0800, Baoquan He wrote: > > Recently I tried to fix the kdump failure in amd iommu system again, and > > now the latest code works, IO_PAGE_FAULT can't be seen any

Re: [PATCH] bnx2: Reset device during driver initialization

2016-09-09 Thread Baoquan He
ntry calling to __map_single calling, the principal should be similar. Thanks Baoquan On 09/09/16 at 04:11pm, Baoquan He wrote: > When system enters into kdump kernel because of kernel panic, it won't > shutdown devices. On-flight DMA will continue transferring data until > device driver

[PATCH] bnx2: Reset device during driver initialization

2016-09-09 Thread Baoquan He
red to net device up stage. This will cause hardware iommu handling failure on bnx2 device. And its resetting relies on firmware. So in this patch move the firmware requesting code to earlier bnx2_init_one(), then next call bnx2_reset_chip to reset device. Signed-off-by: Baoquan He --- drivers/net/et