Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-10 Thread Bandan Das
Bandan Das writes: > "Michael S. Tsirkin" writes: > >> On Mon, Jul 13, 2015 at 12:07:32AM -0400, Bandan Das wrote: >>> vhost threads are per-device, but in most cases a single thread >>> is enough. This change creates a single thread that is used to >

Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-10 Thread Bandan Das
"Michael S. Tsirkin" writes: > On Mon, Jul 13, 2015 at 12:07:32AM -0400, Bandan Das wrote: >> vhost threads are per-device, but in most cases a single thread >> is enough. This change creates a single thread that is used to >> serve all guests. >>

Re: [RFC PATCH 0/4] Shared vhost design

2015-08-10 Thread Bandan Das
"Michael S. Tsirkin" writes: > On Sat, Aug 08, 2015 at 07:06:38PM -0400, Bandan Das wrote: >> Hi Michael, ... >> >> > - does the design address the issue of VM 1 being blocked >> > (e.g. because it hits swap) and blocking VM 2? >> Good question

Re: [RFC PATCH 0/4] Shared vhost design

2015-08-08 Thread Bandan Das
Hi Michael, "Michael S. Tsirkin" writes: > On Mon, Jul 13, 2015 at 12:07:31AM -0400, Bandan Das wrote: >> Hello, >> >> There have been discussions on improving the current vhost design. The first >> attempt, to my knowledge was Shirley Ma's patch

Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-08 Thread Bandan Das
licated, and there's a good chance that it's impossible to migrate the vhost thread since it's serving other guests. I will address this in v2. > Eyal Moscovici > HL-Cloud Infrastructure Solutions > IBM Haifa Research Lab > > > > From: Bandan Das > To: k.

Re: [RFC PATCH 0/4] Shared vhost design

2015-08-01 Thread Bandan Das
Eyal Moscovici writes: ... > > We can start to implement polling, but I am unsure if the cgroups > integration > will be sufficient. The polling vhost thread should be scheduled all > the time and just moving it from one cgroup to the other wont be > sufficient. > I think it needs a deeper int

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Bandan Das
lts. Eyal, I think it makes sense to add polling on top of these patches and get numbers for them too. Thoughts ? Bandan > Eyal Moscovici > HL-Cloud Infrastructure Solutions > IBM Haifa Research Lab > > > > From: Bandan Das > To: k...@vger.kernel.org > Cc: ne

[RFC PATCH 4/4] vhost: Add cgroup-aware creation of worker threads

2015-07-12 Thread Bandan Das
d the devs_per_worker threshold Signed-off-by: Bandan Das --- drivers/vhost/vhost.c | 47 +++ 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 6a5d4c0..dc0fa37 100644 --- a/drivers/vhost/vh

[RFC PATCH 3/4] cgroup: Introduce a function to compare cgroups

2015-07-12 Thread Bandan Das
workers. Signed-off-by: Bandan Das --- include/linux/cgroup.h | 1 + kernel/cgroup.c| 40 2 files changed, 41 insertions(+) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index b9cb94c..606fb5b 100644 --- a/include/linux/cgroup.h +++ b

[RFC PATCH 0/4] Shared vhost design

2015-07-12 Thread Bandan Das
ion mechanism to work with the new model. Ccing cgroups for input/comments. Many thanks to Razya Ladelsky and Eyal Moscovici, IBM for the initial patches, the helpful testing suggestions and discussions. Bandan Das (4): vhost: Introduce a universal thread to serve all users vhost: Limit the

[RFC PATCH 2/4] vhost: Limit the number of devices served by a single worker thread

2015-07-12 Thread Bandan Das
roups work. We still keep moving around the worker thread to the cgroups of the device we are serving at the moment. Signed-off-by: Razya Ladelsky Signed-off-by: Bandan Das --- drivers/vhost/net.c | 6 +-- drivers/vhost/scsi.c | 3 +- drivers/vhost/vhost.c

[RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-07-12 Thread Bandan Das
Signed-off-by: Bandan Das --- drivers/vhost/scsi.c | 15 +++-- drivers/vhost/vhost.c | 150 -- drivers/vhost/vhost.h | 19 +-- 3 files changed, 97 insertions(+), 87 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index