[PATCH net] cxgb4/chtls/cxgbit: Keeping the max ofld immediate data size same in cxgb4 and ulds

2021-02-15 Thread Ayush Sawal
data value for ofld packets is changed to MAX_IMM_OFLD_TX_DATA_WR_LEN. Using the same in cxgbit also. Fixes: 36bedb3f2e5b8 ("crypto: chtls - Inline TLS record Tx") Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 3 +++ drivers/net/ethernet/chel

Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data

2021-01-14 Thread Ayush Sawal
Hi Jakub, On 1/15/2021 12:12 AM, Jakub Kicinski wrote: On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote: Removing initialization of nrxq and rxq_size in uld_info. As ipsec uses nic queues only, there is no need to create uld rx queues for ipsec. Why is this a fix? Does it break something

[PATCH net] ch_ipsec: Remove initialization of rxq related data

2021-01-12 Thread Ayush Sawal
Removing initialization of nrxq and rxq_size in uld_info. As ipsec uses nic queues only, there is no need to create uld rx queues for ipsec. Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") Signed-off-by: Ayush Sawal --- .../net/e

[PATCH net V3] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-11 Thread Ayush Sawal
in chtls_set_quiesce_ctrl(). V2->V3: - As kfree_skb() has a check for null skb, so removed this check before calling kfree_skb() in func chtls_send_reset(). Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- drivers/net/

[PATCH net V2] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-08 Thread Ayush Sawal
in chtls_set_quiesce_ctrl(). Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chelsio/cxgb4/t4_tcb.h | 7 .../chelsio/inline_crypto/chtls/chtls.h | 4 ++ .../chelsio/inline_crypto/chtls/chtls

[PATCH net] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-08 Thread Ayush Sawal
ition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chelsio/cxgb4/t4_tcb.h | 7 .../chelsio/inline_crypto/chtls/chtls.h | 4 ++ .../chelsio/inline_crypto/chtls/chtls_cm.c| 35 ++-- .../chelsio/inline_crypto/chtls/chtls_hw

[PATCH net 6/7] chtls: Added a check to avoid NULL pointer dereference

2021-01-05 Thread Ayush Sawal
In case of server removal lookup_stid() may return NULL pointer, which is used as listen_ctx. So added a check before accessing this pointer. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Vinay Kumar Yadav Signed-off-by: Ayush Sawal --- drivers/ne

[PATCH net 5/7] chtls: Replace skb_dequeue with skb_peek

2021-01-05 Thread Ayush Sawal
ndler definition") Signed-off-by: Vinay Kumar Yadav Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethern

[PATCH net 7/7] chtls: Fix chtls resources release sequence

2021-01-05 Thread Ayush Sawal
umar Yadav Signed-off-by: Ayush Sawal --- .../net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_

[PATCH net 4/7] chtls: Avoid unnecessary freeing of oreq pointer

2021-01-05 Thread Ayush Sawal
In chtls_pass_accept_request(), removing the chtls_reqsk_free() call to avoid oreq freeing twice. Here oreq is the pointer to struct request_sock. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- drivers/ne

[PATCH net 3/7] chtls: Fix panic when route to peer not configured

2021-01-05 Thread Ayush Sawal
If route to peer is not configured, we might get non tls devices from dst_neigh_lookup() which is invalid, adding a check to avoid it. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- .../chelsio/inline_cr

[PATCH net 0/7] Bug fixes for chtls driver

2021-01-05 Thread Ayush Sawal
chtls resources release sequence. Ayush Sawal (7): chtls: Fix hardware tid leak chtls: Remove invalid set_tcb call chtls: Fix panic when route to peer not configured chtls: Avoid unnecessary freeing of oreq pointer chtls: Replace skb_dequeue with skb_peek chtls: Added a check to avoid

[PATCH net 2/7] chtls: Remove invalid set_tcb call

2021-01-05 Thread Ayush Sawal
) Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/c

[PATCH net 1/7] chtls: Fix hardware tid leak

2021-01-05 Thread Ayush Sawal
Maheshwari Signed-off-by: Ayush Sawal --- .../chelsio/inline_crypto/chtls/chtls_cm.c| 39 ++- 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_

[PATCH net-next V3] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr

2020-10-14 Thread Ayush Sawal
continuation line of the function arguments. V2->V3: Fix the checkpatch.pl warnings. Fixes: 1b77be463929 ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_core.h| 2 -

[PATCH net-next V2] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr

2020-10-11 Thread Ayush Sawal
continuation line of the function arguments. Fixes: 1b77be463929 ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_core.h| 2 - .../inline_crypto/ch_ipsec/chcr_ipsec.c | 147 ++

[PATCH net-next] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr

2020-10-08 Thread Ayush Sawal
This patch changes the module name to "ch_ipsec" and prepends "ch_ipsec" string instead of "chcr" in all debug messages and function names. Fixes: 1b77be463929 ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") Signed-off

[PATCH net-next] cxgb4/ch_ipsec: Registering xfrmdev_ops with cxgb4

2020-09-09 Thread Ayush Sawal
: Add support for Inline IPSec") Signed-off-by: Ayush Sawal --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 5 + .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 184 -- .../net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 3 + .../inline_crypto/ch_ipsec/chcr_ipsec.c |

Re: [PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops

2020-07-27 Thread Ayush Sawal
On 7/27/2020 2:46 PM, Steffen Klassert wrote: On Sat, Jul 25, 2020 at 04:20:34PM +1000, Herbert Xu wrote: On Fri, Jul 24, 2020 at 05:01:08PM -0700, David Miller wrote: Please start submitting chcr patches to the crypto subsystem, where it belongs, instead of the networking GIT trees. Hi Dave

[PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops

2020-07-24 Thread Ayush Sawal
rivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:6088:35: error: >> 'struct cxgb4_uld_info' has no member named 'xfrmdev_ops' 6088 | if (!adap->uld[CXGB4_ULD_CRYPTO].xfrmdev_ops) { Fixes: 6dad4e8ab3ec ("chcr: Add support for Inline IPSec") Report

[PATCH net] Crypto/chcr: Registering cxgb4 to xfrmdev_ops

2020-07-23 Thread Ayush Sawal
chcr_xfrmdev_ops with cxgb4. Fixes: 6dad4e8ab3ec ("chcr: Add support for Inline IPSec") Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_core.c| 35 ++-- drivers/crypto/chelsio/chcr_core.h| 7 + drivers/crypto/chelsio/chcr_ipsec.c | 41 + d

Re: [PATCH net-next 2/2] Crypto/chcr: Checking cra_refcnt before unregistering the algorithms

2020-06-10 Thread Ayush Sawal
Hi Herbert, On 6/11/2020 9:18 AM, Herbert Xu wrote: On Wed, Jun 10, 2020 at 02:54:32AM +0530, Ayush Sawal wrote: This patch puts a check for algorithm unregister, to avoid removal of driver if the algorithm is under use. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c

[PATCH net-next 2/2] Crypto/chcr: Checking cra_refcnt before unregistering the algorithms

2020-06-09 Thread Ayush Sawal
This patch puts a check for algorithm unregister, to avoid removal of driver if the algorithm is under use. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/chelsio

[PATCH net-next 1/2] Crypto/chcr: Calculate src and dst sg lengths separately for dma map

2020-06-09 Thread Ayush Sawal
This patch calculates src and dst sg lengths separately for dma mapping in case of aead operation. This fixes a panic which occurs due to the accessing of a zero length sg. Panic: [ 138.173225] kernel BUG at drivers/iommu/intel-iommu.c:1184! Signed-off-by: Ayush Sawal --- drivers/crypto

[PATCH net-next 0/2] Fixing issues in dma mapping and driver removal

2020-06-09 Thread Ayush Sawal
Patch 1: This fixes the kernel panic which occurs due to the accessing of a zero length sg. Patch 2: Avoiding unregistering the algorithm if cra_refcnt is not 1. Ayush Sawal (2): Crypto/chcr: Calculate src and dst sg lengths separately for dma map Crypto/chcr: Checking cra_refcnt before

Re: linux-next: Fixes tag needs some work in the net-next tree

2020-06-02 Thread Ayush Sawal
On 6/2/2020 3:48 PM, Stephen Rothwell wrote: Hi Ayush, On Tue, 2 Jun 2020 13:01:09 +0530 Ayush Sawal wrote: On 6/2/2020 4:42 AM, Stephen Rothwell wrote: In commit 055be6865dea ("Crypto/chcr: Fixes a coccinile check error") Fixes tag Fixes: 567be3a5d227 ("cry

Re: linux-next: Fixes tag needs some work in the net-next tree

2020-06-02 Thread Ayush Sawal
Hi Stephen & David, On 6/2/2020 4:42 AM, Stephen Rothwell wrote: Hi all, In commit 055be6865dea ("Crypto/chcr: Fixes a coccinile check error") Fixes tag Fixes: 567be3a5d227 ("crypto: has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading b

[PATCH net-next V2 1/2] Crypto/chcr: Fixes compilations warnings

2020-06-01 Thread Ayush Sawal
om u32 variable to the original u8 key stream, put_aligned_be32() is used. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 10 -- drivers/crypto/chelsio/chcr_ipsec.c | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_alg

[PATCH net-next V2 0/2] Fixing compilation warnings and errors

2020-06-01 Thread Ayush Sawal
ed_be32() and put_unaligned_be16/32() functions. patch2: Modified subject of the patch. Ayush Sawal (2): Crypto/chcr: Fixes compilations warnings Crypto/chcr: Fixes a coccinile check error drivers/crypto/chelsio/chcr_algo.c | 11 +-- drivers/crypto/chelsio/chcr_ipsec.c | 2 +- 2 fil

[PATCH net-next V2 2/2] Crypto/chcr: Fixes a coccinile check error

2020-06-01 Thread Ayush Sawal
ss the requests"). Fixes: 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). V1->V2 -Modified subject. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/chelsio/chcr_a

[PATCH net-next 2/2] Crypto/chcr: Fixes a cocci check error

2020-05-14 Thread Ayush Sawal
ss the requests"). Fixes: 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypt

[PATCH net-next 0/2] Fixing compilation warnings and errors

2020-05-14 Thread Ayush Sawal
Patch 1: Fixes the warnings seen when compiling using sparse tool. Patch 2: Fixes a cocci check error introduced after commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). Ayush Sawal (2): Crypto/chcr: Fixes compilations warnings Crypto/c

[PATCH net-next 1/2] Crypto/chcr: Fixes compilations warnings

2020-05-14 Thread Ayush Sawal
This patch fixes the compilation warnings displayed by sparse tool for chcr driver. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 8 drivers/crypto/chelsio/chcr_ipsec.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio

[PATCH net-next] Revert "crypto: chelsio - Inline single pdu only"

2020-05-06 Thread Ayush Sawal
driver_xmit is called, which receives a segmented mtu sized packet which is what the driver expects for ipsec offload. So this case becomes unnecessary here, therefore removing it. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_ipsec.c | 3 --- 1 file changed, 3 deletions(-) diff