%s/dest_mac_filter/dmac_filter/g
Fixes: e78ab164591f ("devlink: Add DMAC filter generic packet trap")
Signed-off-by: Aya Levin
Reported-by: Ido Schimmel
Reviewed-by: Tariq Toukan
---
include/net/devlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/i
etfilter: ipv6: move POSTROUTING invocation before
fragmentation")
Signed-off-by: Aya Levin
Reviewed-by: Tariq Toukan
---
net/ipv6/ip6_output.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
Hi,
Please queue to -stable >= v2.6.35.
Than
led in the same manner in IPv4 output finish.
This patch aligns the behavior of IPv6 and the one of IPv4.
Fixes: 9e50849054a4 ("netfilter: ipv6: move POSTROUTING invocation before
fragmentation")
Signed-off-by: Aya Levin
Reviewed-by: Tariq Toukan
---
n
led in the same manner in IPv4 output finish.
This patch aligns the behavior of IPv6 and IPv4.
Fixes: 9e50849054a4 ("netfilter: ipv6: move POSTROUTING invocation before
fragmentation")
Signed-off-by: Aya Levin
Reviewed-by: Tariq Toukan
---
net/ipv6/ip6_output.c | 41 +++
On 11/22/2020 1:58 AM, Jakub Kicinski wrote:
On Fri, 20 Nov 2020 15:03:32 -0800 Saeed Mahameed wrote:
From: Aya Levin
Expose FW indication that it supports stateless offloads for IP over IP
tunneled packets per direction. In some HW like ConnectX-4 IP-in-IP
support is not symmetric, it
Bundle the trap related lists: trap_list, trap_group_list and
trap_policer_list in a dedicated struct. This will be handy in the
coming patches in the set introducing traps in devlink port context.
With trap_lists, code reuse is much simpler.
Signed-off-by: Aya Levin
---
Changelog:
v1->v2:
Pa
From: Aya Levin
Register MTU error trap to allow visibility of oversize packets. Display
a naive use of devlink trap in devlink port context.
Signed-off-by: Aya Levin
---
Changelog:
v1->v2:
-Minor changes in trap's definition
-Adjustments to trap API and ops
drivers/net/ethernet/
djustments to trap API and ops
Aya Levin (3):
devlink: Wrap trap related lists a trap_lists struct
devlink: Add devlink traps under devlink_ports context
net/mlx5e: Add devlink trap to catch oversize packets
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
drivers/net/ethernet/
There are some cases where we would like to trap dropped packets only
for a single port on a device without affecting the others. For that
purpose:
- Add trap lists and trap ops to devlink_port
- Add corresponding trap API to manage traps
- Add matching netlink commands
Signed-off-by: Aya Levin
From: Aya Levin
Register MTU error trap to allow visibility of oversize packets. Display
a naive use of devlink trap in devlink port context.
Signed-off-by: Aya Levin
---
Changelog:
v1->v2:
-Minor changes in trap's definition
-Adjustments to trap API and ops
drivers/net/ethernet/
djustments to trap API and ops
Aya Levin (3):
devlink: Wrap trap related lists a trap_lists struct
devlink: Add devlink traps under devlink_ports context
net/mlx5e: Add devlink trap to catch oversize packets
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
drivers/net/ethernet/
There are some cases where we would like to trap dropped packets only
for a single port on a device without affecting the others. For that
purpose:
- Add trap lists and trap ops to devlink_port
- Add corresponding trap API to manage traps
- Add matching netlink commands
Signed-off-by: Aya Levin
Bundle the trap related lists: trap_list, trap_group_list and
trap_policer_list in a dedicated struct. This will be handy in the
coming patches in the set introducing traps in devlink port context.
With trap_lists, code reuse is much simpler.
Signed-off-by: Aya Levin
---
Changelog:
v1->v2:
Pa
On 9/8/2020 5:04 PM, Jiri Pirko wrote:
Sun, Sep 06, 2020 at 05:44:28PM CEST, ido...@idosch.org wrote:
On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote:
[...]
I understand how this struct allows you to re-use a lot of code between
per-device and per-port traps, but it's m
On 9/6/2020 6:44 PM, Ido Schimmel wrote:
On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote:
There are some cases where we would like to trap dropped packets only
for a single port on a device without affecting the others. For that
purpose trap_mngr was added to devlink_port and
On 9/6/2020 6:58 PM, Ido Schimmel wrote:
On Wed, Sep 02, 2020 at 06:32:13PM +0300, Aya Levin wrote:
Managing large scale port's traps may be complicated. This patch
introduces a shortcut: when setting a trap on a device and this trap is
not registered on this device, the action will
simpler.
Signed-off-by: Aya Levin
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 4 +
include/net/devlink.h | 59 ---
net/core/devlink.c | 255 +
3 files changed, 188 insertions(+), 130 deletions(-)
diff --git a/drivers
Register MTU error trap to allow visibility of oversize packets. Display
a naive use of devlink trap in devlink port context.
Signed-off-by: Aya Levin
---
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 ++
drivers/net/ethernet
There are some cases where we would like to trap dropped packets only
for a single port on a device without affecting the others. For that
purpose trap_mngr was added to devlink_port and corresponding Trap API
with devlink_port were added too.
Signed-off-by: Aya Levin
---
drivers/net/ethernet
Managing large scale port's traps may be complicated. This patch
introduces a shortcut: when setting a trap on a device and this trap is
not registered on this device, the action will take place on all related
ports that did register this trap.
Signed-off-by: Aya Levin
---
net/core/devl
registered this trap.
Patch 4: Display a use in devlink traps in port context in mlx5
ethernet driver.
Aya Levin (4):
devlink: Wrap trap related lists and ops in trap_mngr
devlink: Add devlink traps under devlink_ports context
devlink: Add hiererchy between traps in device level and port level
net
On 7/9/2020 2:16 AM, Bjorn Helgaas wrote:
On Sun, Jul 08, 2040 at 11:22:12AM +0300, Aya Levin wrote:
On 7/6/2020 10:49 PM, David Miller wrote:
From: Aya Levin
Date: Mon, 6 Jul 2020 16:00:59 +0300
Assuming the discussions with Bjorn will conclude in a well-trusted
API that ensures relaxed
On 7/6/2020 10:49 PM, David Miller wrote:
From: Aya Levin
Date: Mon, 6 Jul 2020 16:00:59 +0300
Assuming the discussions with Bjorn will conclude in a well-trusted
API that ensures relaxed ordering in enabled, I'd still like a method
to turn off relaxed ordering for performance debu
On 6/24/2020 11:30 PM, Jakub Kicinski wrote:
On Wed, 24 Jun 2020 20:15:14 + Saeed Mahameed wrote:
On Wed, 2020-06-24 at 10:22 -0700, Jakub Kicinski wrote:
On Wed, 24 Jun 2020 10:34:40 +0300 Aya Levin wrote:
I think Michal will rightly complain that this does not belong
in
private flags
On 6/30/2020 10:32 AM, Ding Tianhong wrote:
在 2020/6/30 3:57, Raj, Ashok 写道:
Hi Bjorn
On Mon, Jun 29, 2020 at 02:33:16PM -0500, Bjorn Helgaas wrote:
[+cc Ashok, Ding, Casey]
On Mon, Jun 29, 2020 at 12:32:44PM +0300, Aya Levin wrote:
I wanted to turn on RO on the ETH driver based on
On 6/26/2020 11:12 PM, Bjorn Helgaas wrote:
On Wed, Jun 24, 2020 at 10:22:58AM -0700, Jakub Kicinski wrote:
On Wed, 24 Jun 2020 10:34:40 +0300 Aya Levin wrote:
I think Michal will rightly complain that this does not belong in
private flags any more. As (/if?) ARM deployments take a foothold
On 6/24/2020 9:56 AM, Saeed Mahameed wrote:
On Tue, 2020-06-23 at 14:31 -0700, Jakub Kicinski wrote:
On Tue, 23 Jun 2020 12:52:29 -0700 Saeed Mahameed wrote:
From: Aya Levin
The concept of Relaxed Ordering in the PCI Express environment
allows
switches in the path between the Requester
ctionality")
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
---
net/core/devlink.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 80f97722f31f..4a802b9377e3 100644
--- a/net/core/devlink.c
On 9/17/2019 6:23 PM, Stephen Hemminger wrote:
> On Thu, 5 Sep 2019 15:43:07 +0300
> Tariq Toukan wrote:
>
>> From: Aya Levin
>>
>> Prior to this patch both the reporter's name and the grace period
>> attributes shared the same bit. This caused zer
On 8/30/2019 2:27 AM, Stephen Hemminger wrote:
> On Thu, 22 Aug 2019 14:05:42 +0300
> Aya Levin wrote:
>
>> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
>> index fc195cbd66f4..3f8532711315 100644
>> --- a/include/uapi/linux/devlink.h
On 8/30/2019 2:25 AM, Stephen Hemminger wrote:
> On Thu, 22 Aug 2019 14:05:41 +0300
> Aya Levin wrote:
>
>> Add pr_out_dump_reporter prefix to the helper function's name and
>> encapsulate the print in it.
>>
>> Fixes: 2f1242efe9d0 ("devlink: Add dev
e time-stamp in
timespec (current time) instead of jiffies. When the new attribute is
present try and translate the time-stamp according to 'current time'.
Aya Levin (2):
devlink: Print health reporter's dump time-stamp in a helper function
devlink: Add a new time-stamp for
Add pr_out_dump_reporter prefix to the helper function's name and
encapsulate the print in it.
Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command")
Signed-off-by: Aya Levin
Acked-by: Jiri Pirko
---
devlink/devlink.c | 26 ++
1 file changed
Introduce a new attribute representing a new time-stamp format: current
time instead of jiffies. If the new attribute was received, translate
the time-stamp accordingly.
Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command")
Signed-off-by: Aya Levin
Acked-by: Jiri Pirko
--
gt;} db;
>>>>>>>>} wq_ctrl;
>>>>>>>>} cq;
>>>>>>>>struct mlx5_wq_cyc {
>>>>>>>> struct mlx5_frag_buf_ctrl {
>>>&g
10010 ;
>>>>>> short unsigned int sz0xc ;
>>>>>> short unsigned int wqe_ctr 0x0 ;
>>>>>> short unsigned int cur_sz0x0 ;
>>>>>> } wq;
>>>>>> unsigned int
state 0x0 ;
>>>>struct hwtstamp_config * tstamp0x0 ;
>>>>struct mlx5_clock *clock 0x8881b1aa6f88 ;
>>>>struct mlx5_wq_ctrl {
>>>>struct mlx5_core_dev * mdev 0x3f03ff ;
>>>
>> unsigned char page_shift 0x0 ;
>> } buf;
>> struct mlx5_db {
>> __be32 * db 0xfff ;
>> union {
>> struct mlx5_db_pgdir * pgdir
On 4/30/2019 3:54 AM, Jakub Kicinski wrote:
> On Mon, 29 Apr 2019 17:17:39 +0300, Aya Levin wrote:
>> In order to offline translate the raw memory into a human readable
>> format, the user can use some out-of-kernel scripts which receives as an
>> input the following:
&
On 4/29/2019 9:32 PM, Saeed Mahameed wrote:
> On Mon, 2019-04-29 at 17:17 +0300, Aya Levin wrote:
>> TX reporter reports an error on two scenarios:
>> - TX timeout on a specific tx queue
>> - TX completion error on a specific send queue
>> Prior to this patch, no dum
0x9 ;
} recover_work;
} ;
Signed-off-by: Aya Levin
---
.../ethernet/mellanox/mlx5/core/en/reporter_tx.c | 100 +
1 file changed, 100 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c
b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c
x27;s request.
The dump's output is defined by the reporter. The command uses the
infra structure for flexible format output introduced in previous patch.
Example:
$ devlink health dump show pci/:00:09.0 reporter tx
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by:
Add a man page describing devlink health's command set. Also add a
reference link from devlink main man page.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
man/man8/devlink-health.8 | 197 ++
man/man8/devl
},
{
"sqn":4413,
"HW state":1,
"stopped":false
},
{
"sqn":4418,
"HW state":1,
"stopped":false
},
{
"sqn":4423,
"HW st
quot;,
"state":"healthy",
"error":0,
"recover":1,
"last_dump_date":"2019-Feb-14",
"last_dump_time":"10:10:10",
"grace_period":600,
&q
Add a new helper functions which outputs only values (without name
label) for different types: boolean, uint, uint64, string and binary.
In addition add a helper function which prints only the name label.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink
Introducing argument's metadata structure matching a bitmap flag per
required argument and an error message if missing. Using this static
array to refactor validation of finding required arguments in devlink
command line and to ease further maintenance.
Signed-off-by: Aya Levin
Review
-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 37eb2054ef06..c77f80c87adc 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
This patch prints uint64_t with its corresponding format and avoid implicit
cast to uint32_t.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/devlink/devlink.c b/devlink
Add devlink dump clear command which deletes the last saved dump file.
Clearing the last saved dump enables a new dump file to be saved.
Example:
$ devlink health dump clear pci/:00:09.0 reporter tx
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink
(5-10)
by command.
-Patch #1 Changed function's name dl_args_finding_required_validate
and a small refactor.
-Modify show command's output.
v3:
-Add blank row that was wrongly added patch #4
-Rephrase commit message patch #5
-Some refactoring in patch #5
v4:
-Rebase: fix conflict with pat
function to retrieve a boolean value as an input parameter.
Example:
$ devlink health set pci/:00:09.0 reporter tx grace_period 3500
$ devlink health set pci/:00:09.0 reporter tx auto_recover false
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c
This patch removes the inverted commas from boolean values in JSON
format: true/false instead of "true"/"false".
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
On 2/24/2019 8:40 PM, Michal Kubecek wrote:
> On Sun, Feb 24, 2019 at 05:47:51PM +0100, Andrew Lunn wrote:
>> On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote:
>>> From: Aya Levin
>>> index 5a26cff5fb33..64ce0711ad5f 100644
>>> --- a/ethtool.8.in
Add a new helper functions which outputs only values (without name
label) for different types: boolean, uint, uint64, string and binary.
In addition add a helper function which prints only the name label.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink
This patch removes the inverted commas from boolean values in JSON
format: true/false instead of "true"/"false".
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index a53db32952e8..ff1d2fcf97bb 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
Add a man page describing devlink health's command set. Also add a
reference link from devlink main man page.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
man/man8/devlink-health.8 | 197 ++
man/man8/devl
Introducing argument's metadata structure matching a bitmap flag per
required argument and an error message if missing. Using this static
array to refactor validation of finding required arguments in devlink
command line and to ease further maintenance.
Signed-off-by: Aya Levin
Review
function to retrieve a boolean value as an input parameter.
Example:
$ devlink health set pci/:00:09.0 reporter tx grace_period 3500
$ devlink health set pci/:00:09.0 reporter tx auto_recover false
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c
This patch prints uint64_t with its corresponding format and avoid implicit
cast to uint32_t.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/devlink/devlink.c b/devlink
x27;s request.
The dump's output is defined by the reporter. The command uses the
infra structure for flexible format output introduced in previous patch.
Example:
$ devlink health dump show pci/:00:09.0 reporter tx
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by:
Add devlink dump clear command which deletes the last saved dump file.
Clearing the last saved dump enables a new dump file to be saved.
Example:
$ devlink health dump clear pci/:00:09.0 reporter tx
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink
quot;,
"state":"healthy",
"error":0,
"recover":1,
"last_dump_date":"2019-Feb-14",
"last_dump_time":"10:10:10",
"grace_period":600,
&q
d on) can be applied after aligning
include/uapi/linux/devlink.h with its corresponding kernel's version.
Aya Levin (11):
devlink: Refactor validation of finding required arguments
devlink: Fix print of uint64_t
devlink: Fix boolean JSON print
devlink: Add helper functions for name and v
},
{
"sqn":4413,
"HW state":1,
"stopped":false
},
{
"sqn":4418,
"HW state":1,
"stopped":false
},
{
"sqn":4423,
"HW st
function which prints only the name label.
>>
>> Signed-off-by: Aya Levin
>> Reviewed-by: Moshe Shemesh
>> ---
>> devlink/devlink.c | 66
>> ++-
>> 1 file changed, 65 insertions(+), 1 deletion(-)
&g
(5-10)
by command.
-Patch #1 Changed function's name dl_args_finding_required_validate
and a small refactor.
-Modify show command's output.
Note: this series (patch 0005 and on) can be applied after aligning
include/uapi/linux/devlink.h with its corresponding kernel's version.
},
{
"sqn":4413,
"HW state":1,
"stopped":false
},
{
"sqn":4418,
"HW state":1,
"stopped":false
},
{
"sqn":44
Add a new helper functions which outputs only values (without name
label) for different types: boolean, uint, uint64, string and binary.
In addition add a helper function which prints only the name label.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
---
devlink/devlink.c | 66
e":"tx",
"state":"healthy",
"error":0,
"recover":1,
"last_dump_date":"2019-Feb-14",
"last_dump_time":"10:10:10",
"grace_per
This patch prints uint64_t with its corresponding format and avoid implicit
cast to uint32_t.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/devlink/devlink.c b/devlink
-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 5685f1e5113a..3ec0ef4b95b2 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
Add devlink dump clear command which deletes the last saved dump file.
Clearing the last saved dump enables a new dump file to be saved.
Example:
$ devlink health dump clear pci/:00:09.0 reporter tx
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink
This patch removes the inverted commas from boolean values in JSON
format: true/false instead of "true"/"false".
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Introducing argument's metadata structure matching a bitmap flag per
required argument and an error message if missing. Using this static
array to refactor validation of finding required arguments in devlink
command line and to ease further maintenance.
Signed-off-by: Aya Levin
Review
Add a man page describing devlink health's command set. Also add a
reference link from devlink main man page.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
man/man8/devlink-health.8 | 197 ++
man/man8/devl
x27;s request.
The dump's output is defined by the reporter. The command uses the
infra structure for flexible format output introduced in previous patch.
Example:
$ devlink health dump show pci/:00:09.0 reporter tx
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by:
:09.0 reporter tx auto_recover false
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/devlink.c | 66 +++
1 file changed, 66 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index f36bbec
functionality.
Aya Levin (4):
devlink: refactor validation of finding required arguments
devlink: fix print of uint64_t
devlink: fix boolean JSON print
devlink: add health command support
devlink/devlink.c| 721 ---
include/uapi/linux
dump data
$devlink health dump clear pci/:00:09.0 reporter tx
$devlink health set pci/:00:09.0 reporter tx grace_period 3500
$devlink health set pci/:00:09.0 reporter tx auto_recover false
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
---
devlink/devlink.c
This patch removes the inverted commas from boolean values in JSON
format: true/false instead of "true"/"false".
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
---
devlink/devlink.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/devlink
This patch prints uint64_t with its corresponding format and avoid implicit
cast to uint32_t.
Signed-off-by: Aya Levin
Reviewed-by: Moshe Shemesh
Reported-by: Maria Pasechnik
---
devlink/devlink.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/devlink/devlink.c
functionality.
Aya Levin (4):
devlink: refactor validation of finding required arguments
devlink: fix print of uint64_t
devlink: fix boolean JSON print
devlink: add health command support
devlink/devlink.c| 721 ---
include/uapi/linux
Introducing argument's metadata structure matching a bitmap flag per
required argument and an error message if missing. Using this static
array to refactor validation of finding required arguments in devlink
command line and to ease further maintenance.
Signed-off-by: Aya Levin
Review
נכתב על ידי David Ahern, ב־1/23/2019 בשעה 5:37 AM:
> On 1/20/19 2:27 AM, Aya Levin wrote:
>> diff --git a/devlink/devlink.c b/devlink/devlink.c
>> index 3651e90c1159..9fc19668ccd0 100644
>> --- a/devlink/devlink.c
>> +++ b/devlink/devlink.c
>> @@ -1,4 +1,5 @@
00:00:09.0 reporter TX grace_period 3500
$devlink health set pci/:00:09.0 reporter TX auto_recover false
Signed-off-by: Aya Levin
Signed-off-by: Eran Ben Elisha
---
devlink/devlink.c| 536 ++-
include/uapi/linux/devlink.h | 29 +++
man/ma
00:00:09.0 reporter TX grace_period 3500
$devlink health set pci/:00:09.0 reporter TX auto_recover false
Change-Id: Iaa58e70db360cb134d8384965a795eca4c1b09ef
Signed-off-by: Aya Levin
Signed-off-by: Eran Ben Elisha
---
devlink/devlink.c| 533 ++
00:00:09.0 reporter TX
$devlink health set pci/:00:09.0 reporter TX grace_period 3500
$devlink health set pci/:00:09.0 reporter TX auto_recover false
Signed-off-by: Aya Levin
---
devlink/devlink.c| 531 ++-
include/uapi/linux/devlink.h | 29 +++
89 matches
Mail list logo
