Re: [PATCH] IPv6 support for NFS server

OK Bruce I have added this comment before the patch. I have also done the changes pointed by Brian. Please let me know if there is still something to change. Regards, Aurélien J. Bruce Fields wrote: On Thu, Jan 17, 2008 at 06:04:35PM +0100, Aurélien Charbon wrote: Hi Bruce. Thanks for

Re: [PATCH] IPv6 support for NFS server

Hi Bruce. Thanks for your comments. Here is the patch with some cleanups. Regards, Aurélien -- Aurelien Charbon Linux NFSv4 team Bull SAS Echirolles - France http://nfsv4.bullopensource.org/ >From 517

Re: [PATCH] IPv6 support for NFS server

Brian Haley wrote: In an email back on October 29th I sent-out a similar patch with a new ipv6_addr_set_v4mapped() inline - it might be useful to pull that piece into your patch since it cleans it up a bit to get rid of the ipv6_addr_set() calls. I can re-send you that patch off-line if you

Re: [PATCH] IPv6 support for NFS server

J. Bruce Fields wrote: On Mon, Dec 10, 2007 at 07:34:41PM +0100, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and

[PATCH] IPv6 support for NFS server

Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) - Signed-off-by: Aurelien Charbon <[EMAIL PROTECTED]> diff -p -u -r -N linux-

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Hi Neil, Thank you for the reply. Neil Brown wrote: I think this patch is unnecessary and hence not wanted. The getfs / getfs calls should be considered legacy calls. Adding functionality to them is not appropriate. I agree with that. But I don't think we really add functionality here. Mo

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Thank you Brian Sorry, I did not see what you sent. I have tested it with an IPv4 configuration. It's OK. So Neil, Bruce, you can take this one for review. fs/nfsd/export.c |9 ++- fs/nfsd/nfsctl.c | 42 -- include/linux/sunrpc/svcauth.h |5 + inclu

[PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Applies on a kernel including ip_map cache modifications Tests: tested with only IPv4 network and basic nfs ops (mount, file

[PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

Hi, Here is the IPv6 support patch for the ip_map caching code part in nfs server. I have ported it on 2.6.24-rc1 (in which Brian Haley's ipv6_addr_v4mapped function is included) In case of bad formatting due to my mailer, you can also find the patch in attachment. Tests: tested with onl

[PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

Here is a patch for the ip_map caching code part in nfs server. I have updated the code to use Brian Haley's ipv6_addr_v4mapped function, and corrected pointed out mistakes. So the first patch in attachment must be applied on a vanilla kernel before. In case of bad formatting due to my mailer,

[PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. I've updated it according to Brian's comments, and removed some unused code. Applies on a kernel including ip_map cache modifi

[PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Applies on a kernel including ip_map cache modifications Tests: tested with only IPv4 network and basic nfs ops (mount, file c

[PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

Here is a patch for the ip_map caching code part in nfs server. I have updated the code to use Brian Haley's ipv6_addr_v4mapped function, and corrected pointed out mistakes. So the first patch in attachment must be applied on a vanilla kernel before to include IPv4 mapping functions that are use

Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

Thanks Chuck and Brian for your comments. Here is some correction for the ip_map caching code part. I have updated the code to use Brian's ipv6_addr_v4mapped function, and corrected some mistake you pointed out. I have checked this patch with the checkpatch.pl script and i do not understand wh

[PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

According to Neil's comments, I have tried to correct the mistakes of my first sending Thank you for these comments Neil. This is a small part of missing pieces of IPv6 support for the server. It deals with the ip_map caching code part. It changes the ip_map structure to be able to store INET6

Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

Thanks for these comments. Chuck Lever wrote: Some naive questions: 1. If IPv6 support is not configured into the kernel, how does an IPv6-only cache work? Yes it should work. The INET6 structures are only used as containers for both type of address. I have tested by unabling IPv6 options

[PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

Here is a small part of missing pieces of IPv6 support for the server. It deals with the ip_map caching code part. It changes the ip_map structure to be able to store INET6 addresses. It adds also the changes in address hashing, and mapping to test it with INET addresses. Signed-off-by: Aureli