Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread Aubrey Li
On 4/20/07, David Howells <[EMAIL PROTECTED]> wrote: Aubrey Li <[EMAIL PROTECTED]> wrote: > as checked in packet_set_ring, buffer size must be a multiple of PAGE_SIZE, > packet_set_ring > if (unlikely(req->tp_block_size &

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread Aubrey Li
On 4/20/07, David Howells <[EMAIL PROTECTED]> wrote: Aubrey Li <[EMAIL PROTECTED]> wrote: > The patch works properly on my side. But > 1) I'm not sure why you re-wrote alloc/free_pg_vec function, doesn't > the current implement work for NOMMU? I know you wan

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-19 Thread Aubrey Li
On 4/18/07, David Howells <[EMAIL PROTECTED]> wrote: Aubrey Li <[EMAIL PROTECTED]> wrote: > Here, in the attachment I wrote a small test app. Please correct if > there is anything wrong, and feel free to improve it. Okay... I have that working... probably. I don'

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-18 Thread Aubrey Li
On 4/18/07, David Howells <[EMAIL PROTECTED]> wrote: Aubrey Li <[EMAIL PROTECTED]> wrote: > Here, in the attachment I wrote a small test app. Please correct if > there is anything wrong, and feel free to improve it. Okay... I have that working... probably. I don'

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-17 Thread Aubrey Li
code snippets if you wanted to make something lightweight... Does anyone else on netdev have a small test app? Here, in the attachment I wrote a small test app. Please correct if there is anything wrong, and feel free to improve it. -Aubrey packet-mmap.tar.gz Description: GNU Zip compressed data

[PATCH] Fix UDP checksum issue in net poll mode.

2007-04-16 Thread Aubrey Li
In net poll mode, the current checksum function doesn't consider the kind of packet which is padded to reach a specific minimum length. I believe that's the problem causing my test case failed. The following patch fixed this issue. Signed-off-by: Aubrey.Li <[EMAIL PROTECTED]> --- net/core/netpoll

Re: udp checksum issue in netpoll mode.

2007-04-16 Thread Aubrey Li
On 4/12/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: Aubrey Li wrote: > I think we discussed this issue before. > > The current checksum function doesn't consider the kind of packet > which is padded to reach a specific minimum length. I believe that's >

udp checksum issue in netpoll mode.

2007-04-12 Thread Aubrey Li
ating this kind of packet? Thanks, -Aubrey === static __sum16 checksum_udp(struct sk_buff *skb, struct udphdr *uh, unsigned short ulen, __be32 saddr, __be32 daddr) { __wsum psum; if (uh->check == 0 || s

[PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-08 Thread Aubrey Li
The option CONFIG_PACKET_MMAP should depend on MMU. Signed-off-by: Aubrey.Li <[EMAIL PROTECTED]> --- net/packet/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/packet/Kconfig b/net/packet/Kconfig index 34ff93f..959c272 100644 --- a/net/packet/Kconfig +++ b/net

Re: Netpoll checksum issue

2006-04-27 Thread Aubrey
Hi Herbert, Is there any update of this issue? Regards, - Aubrey On 4/24/06, Aubrey <[EMAIL PROTECTED]> wrote: > On 4/24/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > > On Mon, Apr 24, 2006 at 01:42:12PM +0800, Aubrey wrote: > > > > > > dev->

Re: Netpoll checksum issue

2006-04-24 Thread Aubrey
On 4/24/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Mon, Apr 24, 2006 at 01:42:12PM +0800, Aubrey wrote: > > > > dev->last_rx = jiffies; > > skb->dev = dev; > > skb->protocol = eth_type_trans(skb, dev); > > skb->ip_summed = CHECKSUM

Re: Netpoll checksum issue

2006-04-24 Thread Aubrey
Hi Herbert, The following change works properly on my side, it just do the same thing as the driver not in netpoll mode. Let me know it's acceptable, please. Thanks, -Aubrey == int __netpoll_rx(struct sk_buff *skb) { snip

Re: Netpoll checksum issue

2006-04-24 Thread Aubrey
ecksum algorithm wrong? or should we add one line -- skb->ip_summed = CHECKSUM_UNNECESSARY; -- after/into the routine "ip_fast_csum"? Regards, -Aubrey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Netpoll checksum issue

2006-04-23 Thread Aubrey
On 4/23/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Thu, Apr 20, 2006 at 09:54:54AM +0800, Aubrey wrote: > Please send me a copy of the driver source that you were using when > this happened. The driver is attached. > Could you please add a printk in checksum_udp to print

Re: Netpoll checksum issue

2006-04-19 Thread Aubrey
ww.blackfin.uclinux.org My driver didn't assign any value to skb->ip_summed, and didn't define tx/rx checksum routine like "e1000_rx_checksum", but it did work before on 2.6.12. I'm trying to find what's broken. Thanks, -Aubrey - To unsubscribe from this list: send