[PATCH 4/4] gianfar: use DT more consistently when selecting PHY connection type

. Signed-off-by: Arseny Solokha --- drivers/net/ethernet/freescale/gianfar.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 17fb412e4bb4..24bf7f68375f 100644 --- a

Re: [RFC PATCH 1/2] gianfar: convert to phylink

> Hi Arseny. > > On Tue, 30 Jul 2019 at 17:40, Arseny Solokha wrote: >> >> > Hi Arseny, >> > >> > Nice project! >> >> Vladimir, Russell, thanks for your review. I'm on vacation now, so won't >> fully >> address your com

[PATCH 1/4] gianfar: remove forward declarations

change any functionality. Signed-off-by: Arseny Solokha --- drivers/net/ethernet/freescale/gianfar.c | 2849 - drivers/net/ethernet/freescale/gianfar.h |7 - .../net/ethernet/freescale/gianfar_ethtool.c | 13 - 3 files changed, 1404 insertions(+), 1465 deletions

[PATCH 3/4] gianfar: cleanup gianfar.h

Remove now unused macro and structure definitions from gianfar.h that have accumulated there over time. Signed-off-by: Arseny Solokha --- drivers/net/ethernet/freescale/gianfar.h | 38 1 file changed, 38 deletions(-) diff --git a/drivers/net/ethernet/freescale

Re: [RFC PATCH 1/2] gianfar: convert to phylink

Hi, >> @@ -1964,7 +1966,7 @@ void stop_gfar(struct net_device *dev) >> /* disable ints and gracefully shut down Rx/Tx DMA */ >> gfar_halt(priv); >> >> - phy_stop(dev->phydev); >> + phylink_stop(priv->phylink); >> >> free_skb_resources(priv); >> } >> @@ -2219,1

[PATCH 0/4] gianfar: some assorted cleanup

call instead of open-coding the lookup half-way correctly. [1] https://lore.kernel.org/netdev/ca+h21hruqt6ngg5ksdswrgh_w5gtgf4fjamcwjne7qjrjus...@mail.gmail.com/ Arseny Solokha (4): gianfar: remove forward declarations gianfar: make five functions static gianfar: cleanup gianfar.h gi

[PATCH 2/4] gianfar: make five functions static

Make functions that do not have callers outside the translation unit they are defined in static. Signed-off-by: Arseny Solokha --- drivers/net/ethernet/freescale/gianfar.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b

Re: [RFC PATCH 1/2] gianfar: convert to phylink

> Hi Arseny, > > Nice project! Vladimir, Russell, thanks for your review. I'm on vacation now, so won't fully address your comments in a few weeks: while I can build the code, I won't have access to hardware to test. So it seems this patch will turn into a series where we'll have some cleanup pat

[PATCH v2] net: phylink: don't start and stop SGMII PHYs in SFP modules twice

are not affected. Place explicit calls to phy_start() and phy_stop() before enabling or after disabling an attached SFP module, where phydev is not yet set (or is already unset), so they will be made only from the inside of sfp-bus, if needed. Signed-off-by: Arseny Solokha --- Changes i

Re: [RFC PATCH 1/2] gianfar: convert to phylink

>>-Original Message- >>From: Arseny Solokha >>Sent: Tuesday, July 23, 2019 6:17 PM >>To: Claudiu Manoil ; Ioana Ciornei >>; Russell King ; Andrew Lunn >> >>Cc: netdev@vger.kernel.org; Arseny Solokha >>Subject: [RFC PATCH 1/2] gianfar: co

[RFC PATCH 1/2] gianfar: convert to phylink

s = <&i2c1>; + mod-def0-gpios = <&gpio 4 GPIO_ACTIVE_LOW>; + rate-select0-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>; + tx-disable-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; + tx-fault-gpios = <&gpio 12 GPIO_ACTIVE

[RFC PATCH 2/2] net: phylink: don't start and stop SGMII PHYs in SFP modules twice

4c095aeaf6ea999 ]--- SFP modules with the 1000Base-X interface are not affected. So, skip explicit calls to phy_start() and phy_stop() when phylink has just enabled or disabled an attached SFP module. Signed-off-by: Arseny Solokha --- drivers/net/phy/phylink.c | 6 +++--- 1 file changed, 3 in

[RFC PATCH 0/2] convert gianfar to phylink

start() or phy_stop() twice in a row for such modules. It doesn't look like a proper fix to me, though, thus the second reason for RFC. Arseny Solokha (2): gianfar: convert to phylink net: phylink: don't start and stop SGMII PHYs in SFP modules twice drivers/net/ethernet/freescale/

[PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page

From: Arseny Solokha In spite of switching to paged allocation of Rx buffers, the driver still called dma_unmap_single() in the Rx queues tear-down path. The DMA region unmapping code in free_skb_rx_queue() basically predates the introduction of paged allocation to the driver. While being