When using a Python script to send max sized vlan packets
on a BCM4401 nic (driver: b44), the Intel I217-V nic (driver: e1000e) only
receives packets with a maximum size of 1514 bytes and reports a
length error for the 1518 bytes sized packet.
When sending the packet from the I217-V and receiving
When waking up from suspend, r8169 fails to restart the phy, preventing
any form of networking until a complete reboot. This bug was introduced
in commit
e80bd76fbf563cc7ed8c9e9f3bbcdf59b0897f69 r8169: work around power-saving
bug on some chip versions
and could be reproduced with
- the latest ne
<20201120120235.1925e...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
I would indeed like to become the maintainer of this driver,
as I do in fact still have working hardware using this code
(a Realtek 8029AS).
Unfortunately, i am still considering myself too inexperienced in
kernel development
Replace variables associated with the former padding
solution with skb->* expressions. They are not needed
anymore.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/8
According to Joe Perches, this bit seems less than optimal
because it overwrites already zeroed content. But instead of
fixing the custom padding solution, replace them entirely
with generic eth_skb_pad().
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 18
scratch area altogether.
v2 changes:
- split cleanup of variables in seperate patch
- revise commit description
Armin Wolf (2):
lib8390: Use eth_skb_pad()
lib8390: Cleanup variables
drivers/net/ethernet/8390/lib8390.c | 25 +++--
1 file changed, 11 insertions(+), 14
Use eth_skb_pad() instead of a custom padding solution
and replace associated variables with skb->* expressions.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ether
Correct a typo in ne.c and ne2k-pci.c which
prevented activation of the RW-Bugfix.
Signed-off-by: Armin Wolf
---
v3 changes:
- do not enable the Bugfix by default
- change patch name
The reason for activating the Bugfix by default
was that a RealTek 8029AS nic caused symptoms
described in the
Correct a typo in ne.c and ne2k-pci.c which
prevented activation of the RW-Bugfix.
Also enable the RW-Bugfix by default since
not doing so could (according to the Datasheet)
cause the system to lock up with some chips.
Signed-off-by: Armin Wolf
---
v2 changes:
- change NE8390_RW_BUGFIX to
Enable the ne2k-pci Read-before-Write Bugfix
since not doing so could (according to the Datasheet)
cause the system to lock up with some chips.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
Use netif_msg_init() to process param settings
and use only the proper initialized value of
ei_local->msg_enable for later processing;
Signed-off-by: Armin Wolf
---
v2 changes:
- confused ei_local-> msg_enable with default_msg_level
---
drivers/net/ethernet/8390/lib8390.c | 14 ---
Use netif_msg_init() to process param settings
and use only the proper initialized value of
ei_local->msg_level for later processing;
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/
Replace panic() call in lib8390.c with BUILD_BUG_ON()
since checking the size of struct e8390_pkt_hdr should
happen at compile-time.
Signed-off-by: Armin Wolf
---
v2 changes:
- remove __packed from struct e8390_pkt_hdr
---
drivers/net/ethernet/8390/lib8390.c | 4 ++--
1 file changed, 2
Replace panic() call in lib8390.c with BUILD_BUG_ON()
since checking the size of struct e8390_pkt_hdr should
happen at compile-time. Also add __packed to e8390_pkt_hdr
to prevent padding.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.h| 2 +-
drivers/net/ethernet/8390/lib8390
Fix two minor coding style issues.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/8390/8390.c b/drivers/net/ethernet/8390/8390.c
index 911fad7af3bd..735d5e84f73b 100644
--- a/drivers/net
Replace pr_cont() with SMP-safe construct.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 31 +++--
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/drivers/net/ethernet/8390/lib8390.c
b/drivers/net/ethernet/8390/lib8390.c
index
Remove unused version string in modules which are
including lib8390 and replace him with MODULE_* macros
if necessary.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390p.c | 15 ---
drivers/net/ethernet/8390/ax88796.c | 3 ---
drivers/net/ethernet/8390/etherh.c
Fix various checkpatch warnings.
Remove version printing so modules including lib8390 do not
have to provide a global version string for successful
compilation.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 402 +---
1 file changed, 186 insertions
Include necessary libraries.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/8390/8390.c b/drivers/net/ethernet/8390/8390.c
index 318f827cc085..911fad7af3bd 100644
--- a/drivers/net/ethernet/8390/8390
Replace version string with MODULE_* macros.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/8390/8390.c b/drivers/net/ethernet/8390/8390.c
index 0e0aa4016858..318f827cc085 100644
arys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c
Armin Wolf (6):
lib8390: Fix coding style issues and remove version printing
lib8390: Rep
Remove unused version string in modules which are
including lib8390 and replace him with MODULE_* macros
if necessary.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390p.c | 18 +++---
drivers/net/ethernet/8390/ax88796.c | 3 ---
drivers/net/ethernet/8390/etherh.c
Replace version string with MODULE_* macros.
Include necessary libraries.
Fix two minor coding-style issues.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/8390/8390
Fix various checkpatch warnings.
Remove version printing so modules including lib8390 do not
have to provide a global version string for successful
compilation.
Replace pr_cont() with SMP-safe construct.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 590
MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c
v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8
Replace version string with MODULE_* macros.
Include necessary libraries.
Fix two minor coding-style issues.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/8390/8390
Fix various checkpatch warnings.
Remove version printing so modules including lib8390 do not
have to provide a global version string for successful
compilation.
Replace pr_cont() with SMP-safe construct.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 590
changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c
Armin Wolf (2):
lib8390: Fix coding-style issues and re
On Sat, Aug 01, 2020 at 09:32:04PM -0700, Jakub Kicinski wrote:
> On Sat, 1 Aug 2020 22:52:42 +0200 Armin Wolf wrote:
> > Replace version string with MODULE_* macros.
> >
> > Include necessary libraries.
> >
> > Fix two minor coding-style issues.
> >
> >
Fix various checkpatch warnings.
Remove version printing so modules including lib8390 do not
have to provide a global version string for successful
compilation.
Replace pr_cont() with SMP-safe construct.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 606
Replace version string with MODULE_* macros.
Include necessary libraries.
Fix two minor coding-style issues.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/8390
age (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c
Armin Wolf (2):
8390: Miscellaneous cleanups
lib8390: Fix coding-style issues and remove verion printing
drivers/net/ethernet/8390/8390.c| 25 +-
drivers/net/ethernet/
Fix various checkpatch warnings.
Remove version printing so modules including lib8390 do not
have to provide a global version string for successful
compilation.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/lib8390.c | 639 ++--
1 file changed, 312 insertions
Replace version string with MODULE_* macros.
Include necessary librarys.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/8390/8390.c b/drivers/net/ethernet/8390
do
not need a global version-string in order to compile
successfully.
Patches do compile and run flawless on 5.8.0-rc4 with
a RTL8029AS using ne2k-pci.
Armin Wolf (2):
8390: Miscellaneous cleanups
lib8390: Fix coding-style issues and remove verion printing
drivers/net/ethernet/8390/8390.c
Use netif_msg_enable() to process param settings.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/ne2k-pci.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c
b/drivers/net/ethernet/8390/ne2k-pci.c
index e500f0c05725
Replace version string with MODULE_* macros.
Include necessary librarys formerly present in lib8390.c.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/8390/8390.c
support the cleaned-up lib8390.
And since 8390.c is not a full nic driver, the missing
param was omited.
All patches compile successfully and appear to function
normaly under 5.8.0-rc2 and a RTL8029AS card.
Armin Wolf (2):
lib8390: Miscellaneous cleanups
8390: Miscellaneous cleanups
drivers/net
Fix a bunch of checkpatch issues.
Rework alloc_ei_netdev() to be a wrapper for
alloc_etherdev().
Remove version printing and the module-param
for msg_enable to avoid conflicts with real
modules using this library.
Remove unnecessary librarys.
Signed-off-by: Armin Wolf
---
drivers/net
Fix some coding-style issues, including one which
made the function pointers in the struct ei_device
hard to understand.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/8390.h | 61 +++-
1 file changed, 36 insertions(+), 25 deletions(-)
diff --git a/drivers
Hi,
while browsing the sourcefile of lib8390.c in
drivers/net/ethernet/8390/, i noticed that inside
of ei_rx_overrun(), which is called from inside
a Interrupt handler, mdelay() is being used.
So i wonder if the usage of mdelay() inside the
Interrupt handler may cause problems since waiting
~10ms
thout
problems on a RTL8029AS-based NE2000 clone card with kernel 5.7.0-rc6.
Signed-off-by: Armin Wolf
---
Cganges in v3:
- Improve patch format
Changes in v2:
- Remove version printing and use MODULE_VERSION instead
---
drivers/net/ethernet/8390/ne2k-pci.c
thout
problems on a RTL8029AS-based NE2000 clone card with kernel 5.7.0-rc6.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/ne2k-pci.c | 345 ++-
1 file changed, 182 insertions(+), 163 deletions(-)
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c
b/driver
not stated anywhere inside the file, its
impossible to add such a tag at the moment.
The kernel module containing this patch compiles and runs without
problems on a RTL8029AS-based NE2000 clone card with kernel 5.7.0-rc6.
Signed-off-by: Armin Wolf
---
drivers/net/ethernet/8390/ne2k-pci.c | 334
44 matches
Mail list logo
