Guo
Reviewed-by: Arend van Spriel
---
.../wireless/broadcom/brcm80211/brcmfmac/of.c | 57 ++-
1 file changed, 55 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index a7554265f
On 09-04-2021 20:46, Rob Herring wrote:
On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote:
Add optional brcm,ccode-map property to support translation from ISO3166
country code to brcmfmac firmware country code and revision.
Signed-off-by: Shawn Guo
---
.../devicetree/bindings/net/wir
On 13-04-2021 09:45, Shawn Guo wrote:
On Mon, Apr 12, 2021 at 10:09:38AM +0200, Arend van Spriel wrote:
On 08-04-2021 13:30, Shawn Guo wrote:
With any regulatory domain requests coming from either user space or
802.11 IE (Information Element), the country is coded in ISO3166
standard. It
On 07-03-2021 12:35, Konrad Dybcio wrote:
Add support for BCM43596 dual-band AC chip, found in
SONY Xperia X Performance, XZ and XZs smartphones (and
*possibly* other devices from other manufacturers).
The chip doesn't require any special handling and seems to work
just fine OOTB.
PCIe IDs taken
On 08-04-2021 13:30, Shawn Guo wrote:
With any regulatory domain requests coming from either user space or
802.11 IE (Information Element), the country is coded in ISO3166
standard. It needs to be translated to firmware country code and
revision with the mapping info in settings->country_codes t
des table.
Support populate country_codes table by parsing the mapping from DT.
comment below, but you may add...
Reviewed-by: Arend van Spriel
Signed-off-by: Shawn Guo
---
.../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++
1 file changed, 53 insertions(+)
diff --gi
On 08-04-2021 13:30, Shawn Guo wrote:
Add optional brcm,ccode-map property to support translation from ISO3166
country code to brcmfmac firmware country code and revision.
Reviewed-by: Arend van Spriel
Signed-off-by: Shawn Guo
---
.../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt
and signal monitoring purposes.
Reviewed-by: Arend van Spriel
Signed-off-by: Alvin Šipraga
---
v1 -> v2:
- clarify firmware behaviour in a comment
- fix detection of upper bound RSSI transition
- improve clamping of min/max RSSI values
- remove unnecessary check on last RSSI value
---
.../broad
On 12-01-2021 12:13, 'Alvin Šipraga' via BRCM80211-DEV-LIST,PDL wrote:
Add support for CQM RSSI measurement reporting and advertise the
NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace
supplicant such as iwd to be notified of changes in the RSSI for roaming
and signal monitorin
On November 7, 2020 6:25:15 PM Taehee Yoo wrote:
If THIS_MODULE is not set, the module would be removed while debugfs is
being used.
It eventually makes kernel panic.
Is this really a valid concern in the context of debugs? I tend to say it
is not. Whenever I am using debugs to debug my driv
On November 2, 2020 6:46:12 PM Kalle Valo wrote:
Arend Van Spriel writes:
On November 2, 2020 6:15:32 PM Kalle Valo wrote:
Seung-Woo Kim writes:
There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
by adding missed brcmf_free().
Reported-by: Jaehoon Chung
Fixes: commit
On November 2, 2020 6:15:32 PM Kalle Valo wrote:
Seung-Woo Kim writes:
There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
by adding missed brcmf_free().
Reported-by: Jaehoon Chung
Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and
brcmf_detach() functions")
Th
On 10/27/2020 11:47 AM, Seung-Woo Kim wrote:
There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
by adding missed brcmf_free().
Probably should add Fixes: tag for commit a1f5aac1765af. See this link
[1] about the proper format.
Reviewed-by: Arend van Spriel
Reported-by
+ Jes
On 10/5/2020 4:12 PM, Kalle Valo wrote:
Greg Kroah-Hartman writes:
On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior wrote:
On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote:
Is it possible to end up here in softirq context or is this a relic?
I think it's a
ns will be detected by the
memory allocator for all GFP_KERNEL allocations.
Reviewed-by: Arend van Spriel
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Thomas Gleixner
---
V2: Adopt to the 'inirq' changes
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 10
_rx_frame(isirq = true)
brcmf_rx_frame()
brcmf_proto_rxreorder()
brcmf_proto_bcdc_rxreorder()
brcmf_fws_rxreorder()
brcmf_netif_rx()
brcmf_netif_rx()
Thanks for taking the dive.
Reviewed-by: Arend van Spriel
Signed-off-by: Thomas Gleixner
Cc: Arend van Spriel
Cc: K
On 9/28/2020 12:04 PM, Dmitry Vyukov wrote:
On Mon, Sep 28, 2020 at 11:31 AM Arend Van Spriel
wrote:
On 9/27/2020 10:47 AM, Dmitry Vyukov wrote:
On Sun, Sep 27, 2020 at 10:38 AM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit:748d1c8a Merge branch 'devlin
, so add an argument `in_isr' to brcmf_sdio_isr() and let
the callers pass the information about the calling context.
After getting confirmation here is my ...
Reviewed-by: Arend van Spriel
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Thomas Gleixner
Cc: Arend van Spriel
Cc: F
On 9/28/2020 11:19 AM, Ulf Hansson wrote:
On Mon, 28 Sep 2020 at 09:35, Arend Van Spriel
wrote:
+ Uffe
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
@@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st
brcmf_dbg(INTR, "IB intr triggered\n");
- brcmf_sdio_isr(sd
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior
The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be seperated or the context be conveyed in an argument passed by the
On 9/27/2020 10:47 AM, Dmitry Vyukov wrote:
On Sun, Sep 27, 2020 at 10:38 AM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit:748d1c8a Merge branch 'devlink-Use-nla_policy-to-validate-..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior
The usage of in_interrupt() in non-core code is phased out. Ideally the
information of the calling context should be passed by the callers or the
functions be split as appropriate.
brcmfmac uses in_interupt() to selec
+ Uffe
On 9/27/2020 9:49 PM, Thomas Gleixner wrote:
@@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st
brcmf_dbg(INTR, "IB intr triggered\n");
- brcmf_sdio_isr(sdiodev->bus);
+ brcmf_sdio_isr(sdiodev->bus, false);
}
Hi Uffe,
I assume the above code is okay, but want
On September 13, 2020 4:35:44 PM t...@redhat.com wrote:
From: Tom Rix
clang static analysis flags this problem
sdio.c:3265:13: warning: Branch condition evaluates to
a garbage value
} else if (pending) {
^~~
brcmf_sdio_dcmd_resp_wait() only sets pending to true.
On 9/8/2020 2:02 PM, Keita Suzuki wrote:
Thank you for your comment. I am relatively new to the Linux
kernel community, so I am more than happy to receive comments.
Please let me know if I'm violating any other rules.
Sure ;-)
Here a useful link that Kalle (wireless drivers maintainer) is alwa
On 9/8/2020 2:13 AM, Keita Suzuki wrote:
When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy,
the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be
freed in the caller function.
Fix this by calling wlc_phy_detach_lcnphy in the error handler of
wlc_phy_txpwr_srom_
On 9/7/2020 6:22 PM, Keita Suzuki wrote:
When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy,
the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be
freed in the caller function.
Fix this by calling wlc_phy_detach_lcnphy in the error handler of
wlc_phy_txpwr_sr
driver and it's the same as the
value used for the BCM4339 chip, hence let's re-use it for BCM4329.
one comment, but when fixed you can add my
Reviewed-by: Arend van Spriel
Signed-off-by: Dmitry Osipenko
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
1 fi
On 8/17/2020 11:06 AM, Allen Pais wrote:
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Acked-by: Arend van Spriel
one was
even paying attention to the return value.
Cc: Arend van Spriel
Cc: Franky Lin
Cc: Hante Meuleman
Cc: Chi-Hsien Lin
Cc: Wright Feng
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Pieter-Paul Giesberts
Cc: Greg Kroah-Hartman
Cc: "Rafał Miłecki"
Cc: linux-wirel..
/brcm80211/brcmfmac/cfg80211.c:4227:2:
warning: 'strncpy' output truncated before terminating nul copying 3 bytes from
a string of the same length [-Wstringop-truncation]
strncpy(iebuf, add_del_cmd, VNDR_IE_CMD_LEN - 1);
^~~~
Acked-
Op 2 maart 2019 04:52:46 schreef "David R. Bergstein"
:
Larry,
Sorry about all these extra replies. Shortly after I sent my last
message my access point started recognizing the connection as 802.11ac
with PHY Rate / Modulation Rate of 866.6 Mbps. What is somewhat
misleading is the informatio
d_state' set but not used [-Wunused-but-set-variable]
It's never used and can be removed.
Acked-by: Arend van Spriel
Signed-off-by: YueHaibing
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 2 --
1 file changed, 2 deletions(-)
On 1/18/2019 4:32 AM, YueHaibing wrote:
remove unneeded semicolon
Acked-by: Arend van Spriel
Signed-off-by: YueHaibing
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
On 1/8/2019 5:43 PM, Kalle Valo wrote:
Kangjie Lu writes:
usb_register() may fail, so let's check its status and issue an error
message if it fails.
Signed-off-by: Kangjie Lu
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +-
The title prefix should be "brcmfmac: " but
failed -52
So add the missing mgmt_stypes for AP mode to fix this.
Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
Suggested-by: Arend van Spriel
Thanks for submitting this patch.
Acked-by: Arend van Spriel
Signed-off-by: Stefan Wahren
---
drivers/net/wireless/br
On 5/28/2018 9:50 AM, Michael Trimarchi wrote:
Watchdog need to be stopped in brcmf_sdio_remove to avoid
i
The system is going down NOW!
[ 1348.110759] Unable to handle kernel NULL pointer dereference at virtual
address 02f8
Sent SIGTERM to all processes
[ 1348.121412] Mem abort info:
[ 1348
On 4/5/2018 3:10 PM, Kalle Valo wrote:
Ulf Hansson writes:
On 20 March 2018 at 10:55, Kalle Valo wrote:
Arend van Spriel writes:
If I get it right, you mean something like this:
mmc3: mmc@1c12000 {
...
broken-sg-support;
sd-head-align = 4;
sd-sgentry-align
Acked-by: Arend van Spriel
Signed-off-by: Joe Perches
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 --
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 --
drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c | 8
3 files changed, 4 inser
On 3/28/2018 1:20 PM, Himanshu Jha wrote:
Hello everyone,
You added everyone, but me :-(
Not really a problem, but it would help if the driver name was mentioned
in the subject.
I recently found that a local variable in passed uninitialised to the
function at
drivers/net/wireless/broadcom
n and these do not describe the wifi device. They are
applicable to the wifi device because it is a limitation of the host
controller and as such should be described in the DT binding of the host
controller.
Regards,
Arend
Regards,
Alex
On 20 March 2018 at 06:16, Arend van Spriel
wrote:
+
if
it does make any difference.
Are you using some chromebook. I have some lying around here so I could
also look into it. What broadcom chipset do you have?
Regards,
Arend
All the best,
Alex.
On 19 March 2018 at 16:31, Arend van Spriel
wrote:
On 3/19/2018 2:40 AM, Alexey Roslyakov wrote:
On 3/19/2018 2:40 AM, Alexey Roslyakov wrote:
In case if the host has higher align requirements for SG items, allow
setting device-specific aligns for scatterlist items.
Signed-off-by: Alexey Roslyakov
---
Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 5 +
1 file
ns (check for module param
and check for Ethernet packet length) for 99.9% of packets. Its overhead
should be very minimal.
Hi Rafał,
Thanks for this patch.
Acked-by: Arend van Spriel
Signed-off-by: Rafał Miłecki
---
.../wireless/broadcom/brcm80211/brcmfmac/common.c | 5 ++
.../wireles
On 3/14/2018 5:10 PM, Kalle Valo wrote:
Rafał Miłecki writes:
+ unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN;
+#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
#ifndef?
I followed what is used in the include/linux/etherdevice.h. Is that a
good exceuse? Could it be the
On 3/14/2018 4:57 PM, Rafał Miłecki wrote:
On 2018-03-14 16:39, Rafał Miłecki wrote:
On 2018-03-14 13:58, Arend van Spriel wrote:
On 3/14/2018 12:01 PM, Rafał Miłecki wrote:
From: Rafał Miłecki
Testing brcmfmac with more recent firmwares resulted in AP interfaces
not working in some
On 3/14/2018 3:24 PM, Kalle Valo wrote:
+config BRCMFMAC_IAPP
>+ bool "Partial support for obsoleted Inter-Access Point Protocol"
>+ depends on BRCMFMAC
>+ ---help---
>+ Most of Broadcom's firmwares can send 802.11f ADD frame every
>+ time new STA connects to the AP interface. Some
added
Kconfig option.
Thanks for taking this approach. Looks fine except for (see below)
Reviewed-by: Arend van Spriel
Signed-off-by: Rafał Miłecki
---
drivers/net/wireless/broadcom/brcm80211/Kconfig| 20 +++
.../wireless/broadcom/brcm80211/brcmfmac/core.c| 39 ++
On 3/13/2018 8:20 AM, Felix Fietkau wrote:
[resent with fixed typo in linux-wireless address]
On 2018-02-27 11:08, Rafał Miłecki wrote:
I've problem when using OpenWrt/LEDE on a home router with Broadcom's
FullMAC WiFi chipset.
First of all OpenWrt/LEDE uses bridge interface for LAN network w
On 3/10/2018 10:33 PM, SF Markus Elfring wrote:
From: Markus Elfring
Date: Sat, 10 Mar 2018 22:18:45 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
You call this an issue?
On 3/9/2018 1:30 PM, Andreas Christoforou wrote:
The kernel would like to have all stack VLA usage removed.
I think there was a remark made earlier to give more explanation here.
It should explain why we want "VLA on stack" removed.
Signed-off-by: Andreas Christoforou
---
drivers/net/wir
On 2/27/2018 11:14 AM, Rafał Miłecki wrote:
Sending with a fixed linux-wireless ML address. Please kindly send your
replies using linux-wireless@
On 02/27/2018 11:08 AM, Rafał Miłecki wrote:
I've problem when using OpenWrt/LEDE on a home router with Broadcom's
FullMAC WiFi chipset.
First of a
On 1/15/2018 6:10 PM, Bjorn Andersson wrote:
The presence of a CLM file is described as optional, but missing the clm
blob causes the preinit to return unsuccessfully. Fix this by ignoring
the return value of the brcmf_c_process_clm_blob().
Also remove the extra debug print, as brcmf_c_process_c
On 1/9/2018 10:47 AM, Jia-Ju Bai wrote:
On 2018/1/9 17:07, Arend van Spriel wrote:
On 1/9/2018 9:39 AM, Jia-Ju Bai wrote:
On 2018/1/9 16:35, Greg KH wrote:
On Tue, Jan 09, 2018 at 09:40:06AM +0800, Jia-Ju Bai wrote:
b43_radio_2057_init_post is not called in an interrupt handler
nor
On 1/9/2018 9:39 AM, Jia-Ju Bai wrote:
On 2018/1/9 16:35, Greg KH wrote:
On Tue, Jan 09, 2018 at 09:40:06AM +0800, Jia-Ju Bai wrote:
b43_radio_2057_init_post is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with usleep_range,
to reduce bu
On 12/7/2017 11:20 AM, Colin King wrote:
From: Colin Ian King
Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine
size of the array. Improvement suggested by coccinelle.
Acked-by: Arend van Spriel
Signed-off-by: Colin Ian King
---
drivers/net/wireless/broadcom/brcm80211
parse struct or union!
scripts/Makefile.build:310: recipe for target
'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed
Seems like something happened with W=1 and wrong kernel doc format.
As a quick fix remove dubious /** in the code.
Acked-by: Arend van Spriel
Sig
On 11/24/2017 3:28 AM, Andrew Lunn wrote:
On Thu, Nov 23, 2017 at 08:27:48PM +0100, Arend Van Spriel wrote:
+ Arnd
On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel
wrote:
On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote:
On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote
+ Arnd
On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel
wrote:
> On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote:
>> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote:
>>> Compilation fails building on x86_64 platform which does not
>>> have CONFIG
On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote:
> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote:
>> Compilation fails building on x86_64 platform which does not
>> have CONFIG_OF enabled.
>>
>> Signed-off-by: Arend van Spriel
>> ---
>&
+ Johannes
On 22-11-17 18:43, Florian Fainelli wrote:
Hi,
(sorry for the cross post)
I am at v4.14-12995-g0c86a6bd85ff and just met the following, attached
is my .config file. Is this a known problem? Thanks!
[1.798714] cfg80211: Loading compiled-in X.509 certificates for
regulatory datab
On 10/4/2017 11:03 AM, Icenowy Zheng wrote:
于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到:
Icenowy Zheng writes:
Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to
use
an out-of-band interrupt pin instead of SDIO in-band interrupt.
Add the device tree binding of this
data bss dec hex filename
39482564 0 400469c6e phy_cmn.o
After
text data bss dec hex filename
39326620 0 399469c0a phy_cmn.o
(gcc 6.3.0, x86-64)
Acked-by: Arend van Spriel
Signed-off-by: Colin Ia
On 10-08-17 07:39, Kalle Valo wrote:
Hi Mahesh and Andy,
James Feeney reported that there's a serious regression in bonding
module since v4.12, it doesn't work with wireless drivers anymore as
wireless drivers don't report the link speed via ethtool:
https://bugzilla.kernel.org/show_bug.cgi?i
t; let's try our fallback code first. If that fails as well, then it's a
> right moment to print an error.
>
> This should reduce amount of false reports from users seeing this
> warning while having wireless working perfectly fine with the platform
> NVRAM.
Reviewed-by
On 17-07-17 20:16, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by work with
> const pci_device_id. So mark the non-const structs as const.
Acked-by: Arend van Spriel
> Signed-off-by:
On 7/7/2017 10:09 PM, Arend van Spriel wrote:
The lower level nl80211 code in cfg80211 ensures that "len" is between
25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HDR_LEN (24) from
"len" so thats's max of 2280. However, the action_fra
On 10-07-17 19:02, Russell Joyce wrote:
>> 1) I think most of it should be some cfg80211 shareable code.
>
> I’m not sure exactly what you mean by this, could you please clarify?
What I think Rafał is saying is that it would be better to have this
code in cfg80211 so other drivers including mac80
es long so this memcpy() can
overflow.
memcpy(action_frame->data, &buf[DOT11_MGMT_HDR_LEN],
le16_to_cpu(action_frame->len));
Cc: sta...@vger.kernel.org # 3.9.x
Fixes: 18e2f61db3b70 ("brcmfmac: P2P action frame tx.")
Reported-by: "freenerguo(郭大兴)"
On 23-06-17 23:53, Luis R. Rodriguez wrote:
> On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote:
>> On 16-5-2017 1:13, Luis R. Rodriguez wrote:
>>> Since no upstream delta is needed for firmwared I'd like to first encourage
>>> evaluating the above.
mac: add wowl gtk rekeying offload support")
Acked-by: Arend van Spriel
> Signed-off-by: Christophe JAILLET
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
On 13-06-17 12:23, Enric Balletbo Serra wrote:
> Hello Kalle,
>
> 2017-06-13 7:54 GMT+02:00 Kalle Valo :
>> Enric Balletbo i Serra wrote:
>>
>>> When request firmware fails, brcmf_ops_sdio_remove is being called and
>>> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle
>>>
On 6/11/2017 11:30 PM, Emil Lenngren wrote:
2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach :
On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote:
On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
"Jason A. Donenfeld" writes:
Whenever you're comparing two MACs, it's important to do this using
On 11-06-17 02:18, Peter Housel wrote:
>
>> On Jun 10, 2017, at 12:27 PM, Arend van Spriel
>> wrote:
>>
>> On 03-06-17 17:36, Andy Shevchenko wrote:
>>> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote:
>>>> An earlier change to this funct
On 03-06-17 17:36, Andy Shevchenko wrote:
> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote:
>> An earlier change to this function (3bdae810721b) fixed a leak in the
>> case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the
>> glom_skb buffer, used for emulating a scattering read
On 01-06-17 09:44, Hegr, Jiri wrote:
> Dears,
> We use small WiFi evaluation board WM-BN-BM-04_EVB_V1.2 with BCM43362 chip
> (Broadcom).
> This board is connected to OMAP-L138 via SDIO interface with Linux 4.9.10
> containing WiFi driver brcmfmac.
> Our problem is in OOB interrupt. The driver (an
On 31-05-17 12:26, Kalle Valo wrote:
> Jia-Ju Bai writes:
>
>> The driver may sleep under a spin lock, and the function call path is:
>> b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave)
>> b43legacy_synchronize_irq
>> synchronize_irq --> may sleep
>>
>> To fix it, the l
On 23-5-2017 9:22, Johannes Berg wrote:
> On Tue, 2017-05-23 at 09:19 +0200, Arend Van Spriel wrote:
>>
>>> WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
>>
>> Thought about something like this after sending the email. So there
>>
On 22-5-2017 23:04, Johannes Berg wrote:
> Hi Arend,
>
> Sorry, I forgot that the original message wasn't Cc'ed to the wireless
> list, only netdev.
That explains. Not subscribed to that.
>> +++ b/net/wireless/scan.c
>> @@ -322,9 +322,7 @@ static void cfg80211_del_sched_scan_req(struct
>> cfg802
On 22-5-2017 14:09, Arend van Spriel wrote:
> On 5/22/2017 12:57 PM, Johannes Berg wrote:
>> On Mon, 2017-05-22 at 12:36 +0200, Sander Eikelenboom wrote:
>>> Hi,
>>>
>>> I encountered this splat with 4.12-RC2.
>>
>> Ugh, yeah, I should've see
On 5/22/2017 12:57 PM, Johannes Berg wrote:
On Mon, 2017-05-22 at 12:36 +0200, Sander Eikelenboom wrote:
Hi,
I encountered this splat with 4.12-RC2.
Ugh, yeah, I should've seen that in the review.
Arend, please take a look at this. cfg80211_sched_scan_results() cannot
sleep, so you can't rtn
On 5/21/2017 4:19 PM, Andreas Färber wrote:
Hi,
Am 16.05.2017 um 21:56 schrieb Martin Blumenstingl:
On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel
wrote:
On 15-5-2017 22:13, Martin Blumenstingl wrote:
The example in the BCM43xx documentation uses "brcmf" as node name.
However
On 16-5-2017 1:13, Luis R. Rodriguez wrote:
> On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote:
>> try again.. replacing email address from Michał
>> On 12-5-2017 22:55, Arend Van Spriel wrote:
>>> Let me explain the idea to refresh your memory (and mine)
pecific bits).
Please feel free to add my...
Acked-by: Arend van Spriel
> Signed-off-by: Martin Blumenstingl
> ---
> Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentatio
On 4-5-2017 4:28, Luis R. Rodriguez wrote:
> On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote:
>> On 3-1-2017 18:59, Luis R. Rodriguez wrote:
>>> On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote:
>>>>
>>>> Right question is &
On 5/12/2017 10:54 AM, Kalle Valo wrote:
Arend van Spriel writes:
On 5/12/2017 10:19 AM, Kalle Valo wrote:
Xie Qirong writes:
The combination of init_timer and setting up the data and function field
manually is equivalent to calling setup_timer(). This is an api
consolidation only and
On 5/12/2017 10:19 AM, Kalle Valo wrote:
Xie Qirong writes:
The combination of init_timer and setting up the data and function field
manually is equivalent to calling setup_timer(). This is an api
consolidation only and improves readability.
Acked-by: Arend van Spriel
Signed-off-by: Xie
On 5/10/2017 1:03 AM, Bjorn Andersson wrote:
On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote:
Bjorn Andersson writes:
The SMD channel is not the primary WCNSS channel and must explicitly be
closed as the device is removed, or the channel will already by open on
a subsequent probe call in e.g.
On 9-5-2017 7:33, Kalle Valo wrote:
> "Gustavo A. R. Silva" writes:
>
>> The name of an array used by itself will always return the array's address.
>> So these tests will always evaluate as false and therefore the _return_
>> will never be executed.
>>
>> Signed-off-by: Gustavo A. R. Silva
>
>
On 3-1-2017 18:59, Luis R. Rodriguez wrote:
> On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote:
>>
>> Right question is "should we solve it without user-space help"?
>>
>> Answer is no, too. Way too complex. Yes, it would be nice if hardware
>> was designed in such a way that getting
it will end up in the git
commit message.
When done you may also add my acknowledgement, ie.:
Acked-by: Arend van Spriel
Regards,
Arend
Kalle,
This one should go on 4.12 queue as well.
Thanks,
Arend
> Signed-off-by: James Hughes
>
> Acked-by: Arend van Spriel
> ---
On 25-4-2017 9:38, Arend Van Spriel wrote:
> On 24-4-2017 15:03, James Hughes wrote:
>> The driver was making changes to the skb_header without
>> ensuring it was writable (i.e. uncloned).
>> This patch also removes some boiler plate header size
>> checking/adjustment c
On 24-4-2017 15:03, James Hughes wrote:
> The driver was making changes to the skb_header without
> ensuring it was writable (i.e. uncloned).
> This patch also removes some boiler plate header size
> checking/adjustment code as that is also handled by the
> skb_cow_header function used to make head
ents but apart from that:
Acked-by: Arend van Spriel
> Signed-off-by: James Hughes
> ---
> Changes in v2
> Makes the _cow_ call at the entry point of the skb in to the
> stack, means only needs to be done once, and error handling
> is easier.
> Split a separate minor bu
On 24-4-2017 20:09, Eric Dumazet wrote:
> On Mon, 2017-04-24 at 14:03 +0100, James Hughes wrote:
>> The driver was making changes to the skb_header without
>> ensuring it was writable (i.e. uncloned).
>> This patch also removes some boiler plate header size
>> checking/adjustment code as that is
Minor nit below...
You may add my acknowledgement:
Acked-by: Arend van Spriel
Signed-off-by: James Hughes
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
b
On 21-4-2017 11:22, James Hughes wrote:
> On 20 April 2017 at 20:48, Arend van Spriel
> wrote:
>> + linux-wireless
>>
>> On 4/20/2017 1:16 PM, James Hughes wrote:
>>>
>>> The driver was adding header information to incoming skb
>>> withou
+ linux-wireless
On 4/20/2017 1:16 PM, James Hughes wrote:
The driver was adding header information to incoming skb
without ensuring the head was uncloned and hence writable.
skb_cow_head has been used to ensure they are writable, however,
this required some changes to error handling to ensure
On 4/20/2017 2:09 PM, James Hughes wrote:
On 20 April 2017 at 12:31, Kalle Valo wrote:
+ linux-wireless
James Hughes writes:
The driver was adding header information to incoming skb
without ensuring the head was uncloned and hence writable.
skb_cow_head has been used to ensure they are wri
1 - 100 of 198 matches
Mail list logo
