[iproute2] bridge: Fix garbled json output seen if a vlan filter is specified

2016-10-07 Thread Anuradha Karuppiah
uot;: 111, "master": "br0", "state": "permanent" } ] $ bridge -j fdb show vlan 100 [] $ Signed-off-by: Anuradha Karuppiah --- bridge/fdb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bridge/fdb.c b/bridge/fdb.c in

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Anuradha Karuppiah
we can't separate CPU and HW stats there. In some cases (or ASICs) HW counters do not include CPU generated packetsyou will have to add CPU generated pkt counters to the hw counters for such virtual device stats. >>> Can you please provide and example how that could hap

Re: [PATCH iproute2 net-next v3 1/5] json_writer: allow base json data type to be array or object

2016-06-21 Thread Anuradha Karuppiah
On Tue, Jun 21, 2016 at 9:12 AM, Stephen Hemminger wrote: > On Mon, 20 Jun 2016 23:39:43 -0700 > Roopa Prabhu wrote: > >> From: Anuradha Karuppiah >> >> This patch adds a type qualifier to json_writer. Type can be a >> json object or array. This can be ext

Re: [PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

2016-06-17 Thread Anuradha Karuppiah
On Fri, Jun 17, 2016 at 12:04 PM, Stephen Hemminger wrote: > On Fri, 17 Jun 2016 11:04:54 -0700 > Anuradha Karuppiah wrote: > >> On Tue, May 31, 2016 at 12:22 PM, Anuradha Karuppiah >> wrote: >> > On Tue, May 31, 2016 at 11:59 AM, Stephen Hemminger >> >

Re: [PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

2016-06-17 Thread Anuradha Karuppiah
On Tue, May 31, 2016 at 12:22 PM, Anuradha Karuppiah wrote: > On Tue, May 31, 2016 at 11:59 AM, Stephen Hemminger > wrote: >> On Fri, 27 May 2016 21:37:14 -0700 >> Roopa Prabhu wrote: >> >>> Sample output: >>> $bridge -j fdb show >>> [{ >&

Re: [PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

2016-05-31 Thread Anuradha Karuppiah
On Tue, May 31, 2016 at 11:59 AM, Stephen Hemminger wrote: > On Fri, 27 May 2016 21:37:14 -0700 > Roopa Prabhu wrote: > >> Sample output: >> $bridge -j fdb show >> [{ >> "mac": "44:38:39:00:69:88", >> "dev": "swp2s0", >> "vlan": 2, >> "master": "br0", >> "s

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Anuradha Karuppiah
On Wed, Jul 15, 2015 at 11:46 AM, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 11:36 AM, Anuradha Karuppiah > wrote: >> On Wed, Jul 15, 2015 at 11:29 AM, Scott Feldman wrote: >>> On Wed, Jul 15, 2015 at 8:53 AM, Anuradha Karuppiah >>> wrote: >>>&g

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Anuradha Karuppiah
On Wed, Jul 15, 2015 at 11:29 AM, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 8:53 AM, Anuradha Karuppiah > wrote: >> On Tue, Jul 14, 2015 at 10:08 PM, Scott Feldman wrote: >>> On Tue, Jul 14, 2015 at 1:43 PM, wrote: >>>> From: Anuradha Karuppiah >&g

Re: [PATCH net-next v4 1/4] net core: Add protodown support.

2015-07-15 Thread Anuradha Karuppiah
On Wed, Jul 15, 2015 at 10:31 AM, Stephen Hemminger wrote: > On Wed, 8 Jul 2015 14:04:22 -0700 > anurad...@cumulusnetworks.com wrote: > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index e20979d..99ebb01 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/

RE: [PATCH net-next v7 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-15 Thread Anuradha Karuppiah
...@cumulusnetworks.com Subject: Re: [PATCH net-next v7 2/4] netlink: changes for setting and clearing protodown via netlink. On Tue, 14 Jul 2015 13:43:20 -0700 anurad...@cumulusnetworks.com wrote: > From: Anuradha Karuppiah > > Signed-off-by: Anuradha Karuppiah > Signed-off-by: Andy Gospodarek

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Anuradha Karuppiah
On Tue, Jul 14, 2015 at 10:08 PM, Scott Feldman wrote: > On Tue, Jul 14, 2015 at 1:43 PM, wrote: >> From: Anuradha Karuppiah >> >> User space daemons can detect errors in the network that need to be >> notified to the switch device drivers. >> >> Drivers

Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread Anuradha Karuppiah
On Tue, Jul 14, 2015 at 9:42 AM, Sergei Shtylyov wrote: > Hello. > > On 07/14/2015 06:32 PM, anurad...@cumulusnetworks.com wrote: > >> From: Anuradha Karuppiah > > >> protodown can be set by user space applications like MLAG on detecting >> errors on a swi

Re: [PATCH net-next v5 1/4] net core: Add protodown support.

2015-07-13 Thread Anuradha Karuppiah
On Mon, Jul 13, 2015 at 2:34 PM, David Miller wrote: > From: anurad...@cumulusnetworks.com > Date: Thu, 9 Jul 2015 15:35:27 -0700 > >> +/* proto_flags - port state information can be passed to the switch driver >> and >> + * used to determine the phys state of the switch port */ >> +enum { >> +

Re: [PATCH net-next v4 4/4] ip link: proto_down config and display.

2015-07-08 Thread Anuradha Karuppiah
On Wed, Jul 8, 2015 at 6:01 PM, Stephen Hemminger wrote: > On Wed, 8 Jul 2015 14:04:25 -0700 > anurad...@cumulusnetworks.com wrote: > >> From: Anuradha Karuppiah >> >> This patch adds support to set and display the IF_PROTOF_DOWN proto_flag. >> One example us

Re: [PATCH net-next v4 1/4] net core: Add protodown support.

2015-07-08 Thread Anuradha Karuppiah
On Wed, Jul 8, 2015 at 4:07 PM, Jonathan Toppins wrote: > On 7/8/15 5:04 PM, anurad...@cumulusnetworks.com wrote: >> >> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h >> index 9cf2394..8d60fe7 100644 >> --- a/include/uapi/linux/if.h >> +++ b/include/uapi/linux/if.h >> @@ -156,6 +15

Re: [RFC PATCH net-next v3 1/4] net core: Add IFF_PROTO_DOWN support.

2015-04-29 Thread Anuradha Karuppiah
On Wed, Apr 29, 2015 at 4:07 PM, Anuradha Karuppiah wrote: > On Wed, Apr 29, 2015 at 3:13 PM, Stephen Hemminger > wrote: >> On Mon, 27 Apr 2015 10:38:21 -0700 >> anurad...@cumulusnetworks.com wrote: >> >>> From: Anuradha Karuppiah >>> >>> This

Re: [RFC PATCH net-next v3 3/4] rocker: Handle IFF_PROTODOWN by doing a PHYS-DOWN on the switch port.

2015-04-28 Thread Anuradha Karuppiah
On Tue, Apr 28, 2015 at 12:48 PM, Scott Feldman wrote: > On Tue, Apr 28, 2015 at 8:49 AM, Anuradha Karuppiah > wrote: >> On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman wrote: >>> On Mon, Apr 27, 2015 at 10:38 AM, wrote: >>>> From: Anuradha Karuppiah >

Re: [RFC PATCH net-next v3 0/4] net: Introduce IFF_PROTO_DOWN flag.

2015-04-28 Thread Anuradha Karuppiah
On Tue, Apr 28, 2015 at 12:37 PM, Scott Feldman wrote: > On Tue, Apr 28, 2015 at 8:39 AM, Anuradha Karuppiah > wrote: >> >> >> On Mon, Apr 27, 2015 at 10:45 PM, Scott Feldman wrote: >>> >>> On Mon, Apr 27, 2015 at 10:38 AM, wrote: >>> > Fr

Re: [RFC PATCH net-next v3 3/4] rocker: Handle IFF_PROTODOWN by doing a PHYS-DOWN on the switch port.

2015-04-28 Thread Anuradha Karuppiah
On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman wrote: > On Mon, Apr 27, 2015 at 10:38 AM, wrote: >> From: Anuradha Karuppiah >> >> IFF_PROTODOWN can be set by user space applications like MLAG on detecting >> errors on a switch port. This patch provides sample s

Re: [RFC PATCH net-next v3 1/4] net core: Add IFF_PROTO_DOWN support.

2015-04-28 Thread Anuradha Karuppiah
On Mon, Apr 27, 2015 at 11:05 PM, Scott Feldman wrote: > On Mon, Apr 27, 2015 at 10:38 AM, wrote: >> From: Anuradha Karuppiah >> >> This patch introduces an IFF_PROTO_DOWN flag that can be used by >> user space applications to notify drivers that errors have bee

Re: [RFC PATCH net-next v3 0/4] net: Introduce IFF_PROTO_DOWN flag.

2015-04-28 Thread Anuradha Karuppiah
On Mon, Apr 27, 2015 at 10:45 PM, Scott Feldman wrote: > On Mon, Apr 27, 2015 at 10:38 AM, wrote: >> From: Anuradha Karuppiah >> >> User space daemons can detect errors in the network that need to be >> notified to the switch device drivers. >> >> Drivers