tches, commit numbers
06393009000779b00a558fd2f280882cc7dc2008
227b60f5102cda4e4ab792b526a59c8cb20cd9f8
1. Allows using a port range of one single port.
2. Gives back sense of 'remaining' variable.
Signed-off-by: Anton Arapov <[EMAIL PROTECTED]>
---
drivers/infiniband/core/cma.c |
David Miller <[EMAIL PROTECTED]> writes:
> From: Anton Arapov <[EMAIL PROTECTED]>
> Date: Wed, 10 Oct 2007 11:56:23 +0200
>
>> Yep, that's exactly I'm talking about. I'm sure that
>> [...] % (high - low) [...] erroneous from the begining
David Miller <[EMAIL PROTECTED]> writes:
>> Ok, I've got it, so we have to do the same with the following:
>> quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
>> patch.
>>
>> And just a curious, does the /* Treat low > high as high == low */
>> idea will keep after the sysctl
remaining = 1;
> + rover = low;
> + } else
> + rover = net_random() % (high - low) + low;
>
> do {
> head = &hashinfo->bhash[inet_bhashfn(rover,
> hashinfo->bhash_size)];
--
Anton Arapov, <[EMAIL PROTECTED]>
Kernel Development, Red Hat
GPG Key ID: 0x6FA8C812
pgp4C9bqqJZFq.pgp
Description: PGP signature
"Denis V. Lunev" <[EMAIL PROTECTED]> writes:
> Anton Arapov wrote:
>> "Denis V. Lunev" <[EMAIL PROTECTED]> writes:
>>> This code is broken from the very beginning.
>>>
>>> iris den # cat /proc/sys/net/ipv4/ip_local_port_rang
xists in inet_connection_socket.c, and must be
fixed for sure because the situation with the same min and max port
numbers in sysctl are possible and not prohibited.
Cheers!
--
Anton Arapov, <[EMAIL PROTECTED]>
GPG Key ID: 0x6FA8C812
pgpltcnDPkAOC.pgp
Description: PGP signature
Kernel always panics
[PATCH] ipv4: kernel panic when only one unsecured port available
Patch prevents division by zero. Kernel panics if only one
unsecured port available.
Signed-off-by: Anton Arapov <[EMAIL PROTECTED]>
---
net/ipv4/inet_connection_sock.c |2 +-
1 file