On Tue, 2021-04-13 at 17:51 -0400, Willem de Bruijn wrote:
> On Mon, Apr 12, 2021 at 5:25 PM Andreas Roeseler
> wrote:
> >
> > The current icmp_rcv function drops all unknown ICMP types,
> > including
> > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Ec
incoming RFC 8335 ICMP Extended Echo Reply packets to the ping_rcv
handler instead of discarding the packet.
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Add ICMPV6 to patch
---
net/ipv4/icmp.c | 5 +
net/ipv6/icmp.c | 4
2 files changed, 9 insertions(+)
diff --git a/
On Mon, 2021-04-12 at 15:28 -0400, Willem de Bruijn wrote:
> On Mon, Apr 12, 2021 at 3:09 PM Andreas Roeseler
> wrote:
> >
> > The current icmp_rcv function drops all unknown ICMP types,
> > including
> > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Ec
incoming RFC 8335 ICMP Extended Echo Reply packets to the ping_rcv
handler instead of discarding the packet.
Signed-off-by: Andreas Roeseler
---
net/ipv4/icmp.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index 76990e13a2f9..8bd988fbcb31 100644
--- a
identifier to query the probed host. An example usage would be
<./ping -4 -e 1 [destination]> to send a PROBE request of ifindex 1 to the
destination node.
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Reorder variable declarations to follow coding style
- Switch t
Modify the ping_supported function to support PROBE message types. This
allows tools such as the ping command in the iputils package to be
modified to send PROBE requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1
Add ipv6_dev_find to ipv6_stub to allow lookup of net_devices by IPV6
address in net/ipv4/icmp.c.
Signed-off-by: Andreas Roeseler
---
include/net/ipv6_stubs.h | 2 ++
net/ipv6/addrconf_core.c | 7 +++
net/ipv6/af_inet6.c | 1 +
3 files changed, 10 insertions(+)
diff --git a/include
Add definitions for the ICMPV6 type of Extended Echo Request and
Extended Echo Reply, as defined by sections 2 and 3 of RFC 8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and that
responses MUST be disabled by default
Signed-off-by: Andreas Roeseler
---
Changes:
v1 ->
Identification Object
(IIO) section of an incoming PROBE packet
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Add AFI_IP and AFI_IP6 definitions
v2 -> v3:
Suggested by Willem de Bruijn
- Add prefix for PROBE specific defined variables
- Create struct icmp_ext_echo_iio for parsing in
t robot
v5 -> v6:
- Add documentation for icmp_echo_enable_probe sysctl
- Remove RCU locking around ipv6_dev_find()
- Assign iio based on ctype
Andreas Roeseler (6):
icmp: add support for RFC 8335 PROBE
ICMPV6: add support for RFC 8335 PROBE
net: add sysctl for enabling RFC 8335
On Sun, 2021-03-28 at 13:00 -0400, Willem de Bruijn wrote:
> On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler
> wrote:
> >
>
> > + if (!ext_hdr || !iio)
> > + goto send_mal_query;
> > + if (ntohs(iio->extobj_hdr.le
On Wed, 2021-03-24 at 20:47 +0100, Eric Dumazet wrote:
>
>
> On 3/24/21 7:18 PM, Andreas Roeseler wrote:
> > Modify the icmp_rcv function to check PROBE messages and call
> > icmp_echo
> > if a PROBE request is detected.
> >
>
>
> ...
>
&g
identifier to query the probed host. An example usage would be
<./ping -4 -e 1 [destination]> to send a PROBE request of ifindex 1 to the
destination node.
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Reorder variable declarations to follow coding style
- Switch t
Add ipv6_dev_find to ipv6_stub to allow lookup of net_devices by IPV6
address in net/ipv4/icmp.c.
Signed-off-by: Andreas Roeseler
---
include/net/ipv6_stubs.h | 2 ++
net/ipv6/addrconf_core.c | 7 +++
net/ipv6/af_inet6.c | 1 +
3 files changed, 10 insertions(+)
diff --git a/include
Add definitions for the ICMPV6 type of Extended Echo Request and
Extended Echo Reply, as defined by sections 2 and 3 of RFC 8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and that
responses MUST be disabled by default
Signed-off-by: Andreas Roeseler
---
Changes:
v1 ->
Modify the ping_supported function to support PROBE message types. This
allows tools such as the ping command in the iputils package to be
modified to send PROBE requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1
Identification Object
(IIO) section of an incoming PROBE packet
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Add AFI_IP and AFI_IP6 definitions
v2 -> v3:
Suggested by Willem de Bruijn
- Add prefix for PROBE specific defined variables
- Create struct icmp_ext_echo_iio for parsing in
en accessing i6_ptr in net_device
- Add ipv6_find_dev into ipv6_stub for use in icmp.c
Andreas Roeseler (6):
icmp: add support for RFC 8335 PROBE
ICMPV6: add support for RFC 8335 PROBE
net: add sysctl for enabling RFC 8335 PROBE messages
net: add support for sending RFC 8335 PROBE messages
On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote:
> On 3/17/21 9:19 PM, David Miller wrote:
> > From: Andreas Roeseler
> > Date: Wed, 17 Mar 2021 22:11:47 -0500
> >
> > > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote:
> > > Is there som
On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote:
> Hi Andreas,
>
> [FYI, it's a private test report for your RFC patch.]
> [auto build test ERROR on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Andreas-Roeseler/add-support-for-RFC-
On Mon, 2021-03-15 at 11:50 -0400, Willem de Bruijn wrote:
> On Sun, Mar 14, 2021 at 12:50 PM Andreas Roeseler
> wrote:
> >
> > Modify the icmp_rcv function to check PROBE messages and call
> > icmp_echo
> > if a PROBE request is detected.
> >
> >
Modify the ping_supported function to support PROBE message types. This
allows tools such as the ping command in the iputils package to be
modified to send PROBE requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1
name, ifindex, and probing by
both IPV4 and IPV6 addresses. It currently does not support responding
to probes off the proxy node (see RFC 8335 Section 2).
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Reorder variable declarations to follow coding style
- Switch to functions such
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and that
responses MUST be disabled by default
Signed-off-by: Andreas Roeseler
---
Changes:
v1 ->
Add definitions for the ICMPV6 type of Extended Echo Request and
Extended Echo Reply, as defined by sections 2 and 3 of RFC 8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
Identification Object
(IIO) section of an incoming PROBE packet
Signed-off-by: Andreas Roeseler
---
Changes:
v1 -> v2:
- Add AFI_IP and AFI_IP6 definitions
v2 -> v3:
Suggested by Willem de Bruijn
- Add prefix for PROBE specific defined variables
- Create struct icmp_ext_echo_iio for parsing in
ove check for ICMPV6 PROBE types
Andreas Roeseler (5):
icmp: add support for RFC 8335 PROBE
ICMPV6: add support for RFC 8335 PROBE
net: add sysctl for enabling RFC 8335 PROBE messages
net: add support for sending RFC 8335 PROBE messages
icmp: add response to RFC 8335 PROBE messages
in
On Sun, 2021-02-21 at 23:49 -0500, Willem de Bruijn wrote:
On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler
wrote:
>
> Modify the icmp_rcv function to check for PROBE messages and call
> icmp_echo if a PROBE request is detected.
>
> Modify the existing icmp_echo function to respo
Modify the ping_supported function to support PROBE message types. This
allows tools such as the ping command in the iputils package to be
modified to send PROBE requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1
probing by name, ifindex, and probing by both IPV4
and IPV6
addresses. It currently does not support responding to probes off the proxy node
(See RFC 8335 Section 2).
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Reorder variable declarations to follow coding style
- Switch to functions
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and it is
disabled by default.
Add sysctl to enable responses to PROBE messages.
Signed-off-by: Andreas
Add definitions for the ICMPV6 type of Extended Echo Request and
Extended Echo Reply, as defined in sections 2 and 3 of RFC 8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
Andreas Roeseler (5):
icmp: add support for RFC 8335 PROBE
ICMPV6: add support for RFC 8335 PROBE
net: add sysctl for enabling RFC 8335 PROBE messages
net: add support for sending RFC 8335 PROBE messages
icmp: add response to RFC 8335 PROBE messages
include/net/netns/ipv4.h| 1
Identification Object
(IIO) section of an incoming PROBE packet
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Add AFI_IP and AFI_IP6 definitions
Changes since v2:
Suggested by Willem de Brujin
- Add prefix for PROBE specific defined variables
- Create struct icmp_ext_echo_iio for parsing
On Thu, 2021-02-04 at 14:52 -0500, Willem de Bruijn wrote:
> On Wed, Feb 3, 2021 at 6:30 PM Andreas Roeseler
> wrote:
> >
> > Modify the icmp_rcv function to check for PROBE messages and call
> > icmp_echo if a PROBE request is detected.
> >
> > Modify the ex
probing by name, ifindex, and probing by both IPV4
and IPV6
addresses. It currently does not support responding to probes off the proxy node
(See RFC 8335 Section 2).
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Reorder variable declarations to follow coding style
- Switch to functions
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and it is
disabled by default.
Add sysctl to enable responses to PROBE messages.
Signed-off-by: Andreas
Add definitions for the ICMPV6 type of Extended Echo Request and
Extended Echo Reply, as defined in sections 2 and 3 of RFC 8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
Modify the ping_supported function to support PROBE message types. This
allows tools such as the ping command in the iputils package to be
modified to send PROBE requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1
to accommodate PROBE types, and adds functionality to respond to PROBE
requests.
Changes since v1:
- Add AFI definitions
- Switch to functions such as dev_get_by_name and ip_dev_find to lookup
net devices
Andreas Roeseler (5):
icmp: add support for RFC 8335 PROBE
ICMPV6: add support for
Add definitions for PROBE ICMP types and codes.
Add AFI definitions for IP and IPV6 as specified by IANA
Add a struct to represent the additional header when probing by IP
address (ctype == 3) for use in parsing incoming PROBE messages.
Signed-off-by: Andreas Roeseler
---
Changes since v1
probing by name, ifindex, and probing by both IPV4
and IPV6
addresses. It currently does not support responding to probes off the proxy node
(See RFC 8335 Section 2).
Signed-off-by: Andreas Roeseler
---
net/ipv4/icmp.c | 135
1 file changed, 125
Modify the ping_supported function to support PROBE message types. This
allows tools such as the ping command in the iputils package to be
modified to send PROBE requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and it is
disabled by default.
Add sysctl to enable responses to PROBE messages.
Signed-off-by: Andreas
Section 8 of RFC 8335 specifies potential security concerns of
responding to PROBE requests, and states that nodes that support PROBE
functionality MUST be able to enable/disable responses and it is
disabled by default.
Add sysctl to enable responses to PROBE messages.
Signed-off-by: Andreas
Add definitions for the ICMPV6 type of Extended Echo Request and
Extended Echo Reply, as defined in sections 2 and 3 of RFC 8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
to accommodate PROBE types, and adds functionality to respond to PROBE
requests.
Andreas Roeseler (6):
icmp: support for RFC 8335
ICMPv6: support for RFC 8335
net: add sysctl for enabling RFC 8335 PROBE messages
net: add sysctl for enabling RFC 8335 PROBE messages
net: add support for
Add definitions for PROBE ICMP types and codes.
Add a struct to represent the additional header when probing by IP
address (ctype == 3) for use in parsing incoming PROBE messages.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmp.h | 22 ++
1 file changed, 22
On Thu, 2020-11-19 at 21:01 -0700, David Ahern wrote:
> On 11/19/20 8:51 PM, David Ahern wrote:
> > On 11/17/20 5:46 PM, Andreas Roeseler wrote:
> > > The popular utility ping has several severe limitations such as
> > > the
> > > inability to query specific
Modifying the ping_supported function to support probe message types
allows the user to send probe requests through the existing framework
for sending ping requests.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree
The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply
are defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are
defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Changes
:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Changes since v3:
- Reorder patches to add defines first
Andreas Roeseler (3):
icmp: define PROBE message types
ICMPv6: define PROBE message types
net: add support for
:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Andreas Roeseler (3):
net: add support for sending RFC8335 PROBE
icmp: define PROBE message types
ICMPv6: define PROBE message types
include/uapi/linux/icmp.h | 3
Modifying the ping_supported function to support probe message types
allows the user to send probe requests through the existing framework
for sending ping requests.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are
defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply
are defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are
defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
---
include/linux/icmp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux
The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply
are defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
---
include/linux/icmpv6.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include
Modifying the ping_supported function to support probe message types
allows the user to send probe requests through the existing framework
for sending ping requests.
Signed-off-by: Andreas Roeseler
---
Changes since v1:
- Switch to correct base tree
---
net/ipv4/ping.c | 2 +-
1 file changed
:
- Switch to correct base tree
Andreas Roeseler (3):
net: add support for sending probe messages
icmp: define probe message types
ICMPv6: define probe message types
include/linux/icmp.h | 3 +++
include/linux/icmpv6.h | 6 ++
net/ipv4/ping.c| 2 +-
3 files changed, 10
Modifying the ping_supported function to support probe message types allows the
user to send probe requests through the existing framework for
sending ping requests.
Signed-off-by: Andreas Roeseler
---
net/ipv4/ping.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net
The types of ICMPv6 Extended Echo Request and ICMPv6 Extended Echo Reply
messages are defined by sections 2 adn 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmpv6.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/linux/icmpv6.h b/include/uapi
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are
defined in sections 2 and 3 of RFC8335.
Signed-off-by: Andreas Roeseler
---
include/uapi/linux/icmp.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/icmp.h b/include/uapi/linux/icmp.h
index
specialized ICMP message that makes use of
the ICMP Extension Struction outlined in RFC4884.
This patchset adds definitions for the probe ICMP message request and
reply types for both IPv4 and IPv6. It also expands the list of
supported ICMP messages to accommodate PROBEs.
Andreas Roeseler (3):
net
On Thu, 2020-11-12 at 21:02 -0800, Andreas Roeseler wrote:
> Types of ICMP Extended Echo Request and ICMP Extended Echo Reply are
> defined in sections 2 and 3 of RFC 8335.
>
> Signed-off-by: Andreas Roeseler
> ---
> include/uapi/linux/icmp.h | 4
> 1 file
On Thu, 2020-11-12 at 21:02 -0800, Andreas Roeseler wrote:
> From: Andreas Roeseler
>
> Types of ICMPv6 Extended Echo Request and ICMPv6 Extended Echo Reply
> are
> defined by sections 2 and 3 of RFC 8335.
>
> Signed-off-by: Andreas Roeseler
> ---
> include/uapi/lin
On Thu, 2020-11-12 at 21:02 -0800, Andreas Roeseler wrote:
> Modifying the ping_supported function to support probe messages
> allows
> users to send probe messages while using the existing framework for
> sending ping messages.
>
> Signed-off-by: Andreas Roeseler
> ---
&
On Fri, 2020-11-13 at 07:32 -0800, Jakub Kicinski wrote:
> On Thu, 12 Nov 2020 21:02:27 -0800 Andreas Roeseler wrote:
> > The popular utility ping has several severe limitations such as
> > an inability to query specific interfaces on a node and requiring
> > bidirectional con
71 matches
Mail list logo
