Re: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-10-27 Thread Andreas Noever
create mode 100644 drivers/thunderbolt/icm/net.c >> create mode 100644 drivers/thunderbolt/icm/net.h >> >> -- >> 2.7.4 > > Hi Amir, > > I've tested your v8 series on Dell hardware with Thunderbolt > Controllers again between a Linux and Windows box. > Functionally it's working well. > > Tested-By: Mario Limonciello > > Andreas, > > Following the history of this thread, I believe Greg was still looking for > an ack from you that Amir is using the interface properly. > > Thanks, That I don't know, but this driver does the inverse dmi_match of the current apple driver (dmi_match(DMI_BOARD_VENDOR, "Apple Inc.")), and therefore there should be no interaction between the two. Acked-by: Andreas Noever Cheers, Andreas

Re: [PATCH v6 2/8] thunderbolt: Updating the register definitions

2016-09-10 Thread Andreas Noever
On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote: > Adding more Thunderbolt(TM) register definitions > and some helper macros. Thinking about this again I would prefer it if you would put your definitions into a separate file under icm/ (even if there is some duplication). The style (bitfields vs.

Re: [PATCH v6 1/8] thunderbolt: Macro rename

2016-09-10 Thread Andreas Noever
; - * Thunderbolt Cactus Ridge driver - NHI registers > + * Thunderbolt driver - NHI registers > * > * Copyright (c) 2014 Andreas Noever > */ > > -#ifndef DSL3510_REGS_H_ > -#define DSL3510_REGS_H_ > +#ifndef NHI_REGS_H_ > +#define NHI_REGS_H_ > > #include > > -- > 2.7.4 Signed-off-by: Andreas Noever

Re: [PATCH v6 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

2016-09-10 Thread Andreas Noever
On Wed, Aug 31, 2016 at 1:28 PM, Greg KH wrote: > On Mon, Aug 01, 2016 at 03:23:45PM +0300, Amir Levy wrote: >> This is version 6 of Thunderbolt(TM) driver for non-Apple hardware. >> >> Changes since v5: >> - Removed the padding of short packets in receive >> - Replaced RW semaphore with mutex >

Re: [PATCH v4 2/7] thunderbolt: Updating the register definitions

2016-07-26 Thread Andreas Noever
On Mon, Jul 18, 2016 at 12:00 PM, Amir Levy wrote: > Adding more Thunderbolt(TM) register definitions > and some helper macros. > > Signed-off-by: Amir Levy > --- > drivers/thunderbolt/nhi_regs.h | 109 > + > 1 file changed, 109 insertions(+) > > diff --g

Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-26 Thread Andreas Noever
On Wed, Jul 20, 2016 at 12:02 AM, Bjorn Helgaas wrote: > On Mon, Jul 18, 2016 at 01:00:33PM +0300, Amir Levy wrote: >> This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. >> >> Changes since v3: >> - Moved new Thunderbolt device IDs from pci_ids.h to icm_nhi.h. >> - Cleanup and a

Re: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-12 Thread Andreas Noever
On Tue, Jul 12, 2016 at 12:50 PM, Levy, Amir (Jer) wrote: > On Wed, Jun 29 2016, 11:35 AM, Levy, Amir (Jer) wrote: >> This is version 2 of Thunderbolt(TM) driver for non-Apple hardware. >> >> Changes since v1: >> - Separation to 2 modules. >> - Moved ICM specific registers definition to ICM head