[PATCH] net: phy: allow for reset line to be tied to a sleepy GPIO controller

2019-10-04 Thread Andrea Merello
gpiod_set_value_cansleep() in mdio_device_reset(). This is relevant if e.g. the PHY reset line is tied to a I2C GPIO controller. This has been tested on a ZynqMP board running an upstream 4.19 kernel and then hand-ported on current kernel tree. Signed-off-by: Andrea Merello --- drivers/net/phy

Re: [PATCH resend] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-01-30 Thread Andrea Merello
Thanks for pointing this out! At a first look I'd propose to merge the two identical pci_fee_consistent() in a single one, and place it in an error exit path at the end of function. BTW, looking at the code, it seems there is another leak here that your patch does not address: we still leaks allo

Re: [PATCH] rtl818x_pci: Disable pci device in error handling code

2016-01-30 Thread Andrea Merello
Acked-by: Andrea Merello On Sat, Jan 16, 2016 at 2:02 PM, Jia-Ju Bai wrote: > When pci_request_regions in rtl8180_probe fails, pci_disable_device is not > called to disable the device which is enabled by pci_enbale_device. > > This patch fixes the problem by adding a new lable in er