("smsc95xx: add phylib support")
Signed-off-by: Andre Edich
---
drivers/net/phy/smsc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index ddb78fb4d6dc..d8cac02a79b9 100644
--- a/drivers/net/phy/smsc.c
+++ b/drive
Using `void *driver_priv` instead of `unsigned long data[]` is more
straightforward way to recover the `struct smsc95xx_priv *` from the
`struct net_device *`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 61 +-
1 file changed, 28 insertions
the 'devices'
(5.7.8-1-ARCH, Raspberry Pi 3 Model B).
Andre Edich (3):
smsc95xx: remove redundant function arguments
smsc95xx: use usbnet->driver_priv
smsc95xx: add phylib support
drivers/net/phy/smsc.c | 67 ++
drivers/net/usb/Kconfig| 2 +
drivers/net/usb/smsc9
internal PHYs moves from
drivers/net/usb/smsc95xx.c to drivers/net/phy/smsc.c.
Signed-off-by: Andre Edich
---
drivers/net/phy/smsc.c | 67 +++
drivers/net/usb/Kconfig| 2 +
drivers/net/usb/smsc95xx.c | 399 +
3 files changed, 203 insertions
This patch removes arguments netdev and phy_id from the functions
smsc95xx_mdio_read_nopm and smsc95xx_mdio_write_nopm. Both removed
arguments are recovered from a new argument `struct usbnet *dev`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 35
internal PHYs moves from
drivers/net/usb/smsc95xx.c to drivers/net/phy/smsc.c.
Signed-off-by: Andre Edich
---
drivers/net/phy/smsc.c | 67 +++
drivers/net/usb/Kconfig| 2 +
drivers/net/usb/smsc95xx.c | 389 +
3 files changed, 203 insertions
Using `void *driver_priv` instead of `unsigned long data[]` is more
straightforward way to recover the `struct smsc95xx_priv *` from the
`struct net_device *`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 61 +-
1 file changed, 28 insertions
This patch removes arguments netdev and phy_id from the functions
smsc95xx_mdio_read_nopm and smsc95xx_mdio_write_nopm. Both removed
arguments are recovered from a new argument `struct usbnet *dev`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 35
7;,
as they only need for the internal PHY;
- To be sure, that this set of patches is git-bisectable, tested each
sub-set of patches to be functional for both, internal and external
PHYs, including suspend/resume test for the 'devices'
(5.7.8-1-ARCH, Raspberry Pi 3 Model B).
A
internal PHYs moves from
drivers/net/usb/smsc95xx.c to drivers/net/phy/smsc.c.
Signed-off-by: Andre Edich
---
drivers/net/phy/smsc.c | 67 +++
drivers/net/usb/Kconfig| 2 +
drivers/net/usb/smsc95xx.c | 389 +
3 files changed, 203 insertions
Using `void *driver_priv` instead of `unsigned long data[]` is more
straightforward way to recover the `struct smsc95xx_priv *` from the
`struct net_device *`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 61 +-
1 file changed, 28 insertions
This patch removes arguments netdev and phy_id from the functions
smsc95xx_mdio_read_nopm and smsc95xx_mdio_write_nopm. Both removed
arguments are recovered from a new argument `struct usbnet *dev`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 35
e, that this set of patches is git-bisectable, tested each
sub-set of patches to be functional for both, internal and external
PHYs, including suspend/resume test for the 'devices'
(5.7.8-1-ARCH, Raspberry Pi 3 Model B).
Andre Edich (3):
smsc95xx: remove redundant function argum
Use functions phy_read and phy_write instead of smsc95xx_mdio_read and
smsc95xx_mdio_write respectively.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 43 +++---
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/net/usb
Since the PHY framework is used anyway, replace the rest of the calls to
the MII library, including those from the USB Network driver
infrastructure, by the calls to the PHY framework.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 78 +++---
1 file
Using `void *driver_priv` instead of `unsigned long data[]` is more
straightforward way to recover the `struct smsc95xx_priv *` from the
`struct net_device *`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 61 +-
1 file changed, 28 insertions
-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 201 -
1 file changed, 132 insertions(+), 69 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index f200684875fb..9d2710f6d396 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b
Current driver supports PAL that does link status checking anyway.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 55 --
1 file changed, 55 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 9d2710f6d396
as they only need for the internal PHY;
- To be sure, that this set of patches is git-bisectable, tested each
sub-set of patches to be functional for both, internal and external
PHYs, including suspend/resume test for the 'devices'
(5.7.8-1-ARCH, Raspberry Pi 3 Model B).
Andre Edich
This patch removes arguments netdev and phy_id from the functions
smsc95xx_mdio_read_nopm and smsc95xx_mdio_write_nopm. Both removed
arguments are recovered from a new argument `struct usbnet *dev`.
Signed-off-by: Andre Edich
---
drivers/net/usb/smsc95xx.c | 35
In a case where the ID_REV register read is failed, the memory for a
private data structure has to be freed before returning error from the
function smsc95xx_bind.
Fixes: bbd9f9ee69242 ("smsc95xx: add wol support for more frame types")
Signed-off-by: Andre Edich
Signed-off-by:
The patchset fixes two problems in the function smsc95xx_bind:
- return of false success
- memory leak
Changes in v2:
- added "Fixes" tags to both patches
Andre Edich (2):
smsc95xx: check return value of smsc95xx_reset
smsc95xx: avoid memory leak in smsc95xx_bind
drive
The return value of the function smsc95xx_reset() must be checked
to avoid returning false success from the function smsc95xx_bind().
Fixes: 2f7ca802bdae2 ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter
driver")
Signed-off-by: Andre Edich
Signed-off-by: Parthiban V
In a case where the ID_REV register read is failed, the memory for a
private data structure has to be freed before returning error from the
function smsc95xx_bind.
Signed-off-by: Andre Edich
Signed-off-by: Parthiban Veerasooran
---
drivers/net/usb/smsc95xx.c | 3 ++-
1 file changed, 2
The return value of the function smsc95xx_reset() must be checked
to avoid returning false success from the function smsc95xx_bind().
Signed-off-by: Andre Edich
Signed-off-by: Parthiban Veerasooran
---
drivers/net/usb/smsc95xx.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers
The patchset fixes two problems in the function smsc95xx_bind:
- return of false success
- memory leak
Andre Edich (2):
smsc95xx: check return value of smsc95xx_reset
smsc95xx: avoid memory leak in smsc95xx_bind
drivers/net/usb/smsc95xx.c | 9 -
1 file changed, 8 insertions(+), 1
26 matches
Mail list logo
