[PATCH] net: mv643xx_eth: disable clk on error path in mv643xx_eth_shared_probe()

If mv643xx_eth_shared_of_probe() fails, mv643xx_eth_shared_probe() leaves clk undisabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/marvell/mv643xx_eth.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH] net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup()

If phy_power_on() fails in rk_gmac_powerup(), clocks are left enabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

net: hns: question regarding ae_node device node refcounting

probe() or in hns_nic_dev_remove()? Or may be it is managed by fwnode somehow? -- Alexey Khoroshilov Linux Verification Center, ISPRAS web: http://linuxtesting.org

[PATCH] tun: fix mismatch in mutex lock-unlock in tun_get_user()

There is a single error path where tfile->napi_mutex is left unlocked. It can lead to a deadlock. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/tun.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/tun.

[PATCH] net: phy: xgene: disable clk on error paths

There are several error paths in xgene_mdio_probe(), where clk is left undisabled. The patch fixes them. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/phy/mdio-xgene.c | 21 +++-- 1 file changed, 15 insertions

[PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API

Make use the dma_*() interfaces rather than the pci_*() interfaces. Signed-off-by: Alexey Khoroshilov --- drivers/net/wan/dscc4.c | 96 ++--- 1 file changed, 51 insertions(+), 45 deletions(-) diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan

[PATCH v3 net-next 1/2] wan: dscc4: add checks for dma mapping errors

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- v2: Fix issues noted by David Miller and Francois Romieu. v3: Improve code per Francois

[PATCH net-next v2] wan: dscc4: add checks for dma mapping errors

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- v2: Fix issues noted by David Miller and Francois Romieu. drivers/net/wan/dscc4.c | 52

[PATCH] wan: dscc4: add checks for dma mapping errors

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wan/dscc4.c | 52 +++-- 1 file

[PATCH] smsc911x: Add check for ioremap_nocache() return code

There is no check for return code of smsc911x_drv_probe() in smsc911x_drv_probe(). The patch adds one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/smsc/smsc911x.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH] net: atheros: atl2: don't return zero on failure path in atl2_probe()

If dma mask checks fail in atl2_probe(), it breaks off initialization, deallocates all resources, but returns zero. The patch adds proper error code return value and make error code setup unified. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

[PATCH v2] net: natsemi: ns83820: add checks for dma mapping error

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/ns83820.c | 42 +++--- 1 file

[PATCH] net: natsemi: ns83820: add checks for dma mapping error

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/ns83820.c | 13 +++-- 1 file changed, 11 insertions

[PATCH] irda: vlsi_ir: fix check for dma mapping errors

vlsi_alloc_ring() checks for dma mapping errors by comparison returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/irda/vlsi_ir.c | 8 1 file changed

[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- net/sched/act_skbmod.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c index 3b7074e23024..c736627f8f4a 100644 --- a/net/sched/act_skbmod.c

net/sched: act_skbmod: rcu_read_unlock in tcf_skbmod_dump?

Hello! rcu_read_unlock() in tcf_skbmod_dump() looks suspicious to me. What does it mean there? -- Thank you, Alexey Khoroshilov Linux Verification Center, ISPRAS web: http://linuxtesting.org

[PATCH v2] net: adaptec: starfire: add checks for dma mapping errors

init_ring(), refill_rx_ring() and start_tx() don't check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/adaptec/starfire.c

[PATCH] net: adaptec: starfire: add checks for dma mapping errors

init_ring() and refill_rx_ring() don't check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/adaptec/starfire.c | 12 1

[PATCH] adm80211: add checks for dma mapping errors

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wireless/admtek/adm8211.c | 24 ++-- 1 file changed, 22

[PATCH] net: macb: add check for dma mapping error in start_xmit()

at91ether_start_xmit() does not check for dma mapping errors. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/cadence/macb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb.c

[PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

Driver Verification project (linuxtesting.org). v2: use "bool" and "true"/"false" for boolean variables. Signed-off-by: Alexey Khoroshilov --- drivers/net/vmxnet3/vmxnet3_drv.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/dri

[PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/vmxnet3/vmxnet3_drv.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index b5554f2ebee4..5ee059eafe9c 100644

[PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock

There is no need to clk_disable_unprepare(dev->clk) before it was initialized. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/marvell/mvmdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

Re: [BUG] act_ife: sleeping functions called in atomic context

On 17.06.2016 08:38, Cong Wang wrote: > On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >> >> I think we can just remove that tcf_lock, I am testing a patch now. > > Please try the attached patch, I will do more tests tomorrow. > > Thanks! > Looks good with two notes: 1. add_metainfo() still

[BUG] act_ife: sleeping functions called in atomic context

ry_module_get(o->owner) -> kzalloc(sizeof(*mi), GFP_KERNEL); -> ops->alloc(mi, metaval); -> module_put(ops->owner); _tcf_ife_cleanup() -> module_put() The same problem is actual for tcf_ife_cleanup() as well. Found by Linux Driver Verification pr

Suspicious code in tun_flow_update()

Hello, If tun_flow_find() successfully finds tun_flow_entry, tun_flow_update() updates the entry in place. Is such usage of RCU safe here? Found by Linux Driver Verification project (linuxtesting.org). -- Alexey Khoroshilov Linux Verification Center, ISPRAS

[PATCH] ipw2x00: add checks for dma mapping errors

ipw2100_alloc_skb() and ipw2100_tx_send_data() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wireless/ipw2x00/ipw2100.c | 11

[PATCH] prism54: fix checks for dma mapping errors

prism54 checks for dma mapping errors by comparison returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wireless/prism54/islpci_dev.c | 4 +++- drivers/net

[PATCH v2] natsemi: add checks for dma mapping errors

refill_rx() and start_tx() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/natsemi.c | 12 1 file changed

Re: [PATCH] natsemi: add checks for dma mapping errors

On 19.12.2015 05:36, David Miller wrote: > From: Alexey Khoroshilov > Date: Sat, 19 Dec 2015 00:55:37 +0300 > >> @@ -2093,6 +2099,10 @@ static netdev_tx_t start_tx(struct sk_buff *skb, struct net_device *dev) >> np->tx_skbuff[entry] = skb; >> np->

[PATCH] natsemi: add checks for dma mapping errors

refill_rx() and start_tx() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/natsemi.c | 10 ++ 1 file changed, 10

[PATCH] vmxnet3: fix checks for dma mapping errors

vmxnet3_drv does check dma_addr with dma_mapping_error() after mapping dma memory. The patch adds the checks and tries to handle failures. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/vmxnet3/vmxnet3_drv.c | 71

[PATCH] irda: ali-ircc: Fix deadlock in ali_ircc_sir_change_speed()

up() ali_ircc_sir_interrupt() ali_ircc_interrupt() under spin_lock(&self->lock); The patch removes spin_lock/unlock from ali_ircc_sir_change_speed(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/irda/ali-ircc.c |

Re: [PATCH] rsi: Fix failure to load firmware after memory leak fix and fix the leak

Reviewed-by: Alexey Khoroshilov with small suggestion. If we restore kmemdup() call, we have to handle ENOMEM situations: fw = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL); if (!fw) return -ENOMEM; On 27.07.2015 12:43, Mike Looijmans wrote: > Fix

[PATCH] pxa168: fix double deallocation of managed resources

ouble free can happen. The patch removes explicit resource deallocation. Also it converts clk_disable() to clk_disable_unprepare() to make it symmetrical with clk_prepare_enable(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/ne