[PATCH] net: phy: adin: add signal mean square error registers to phy-stats

2020-12-03 Thread Alexandru Ardelean
change implements support for these registers using the PHY statistics mechanism. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index 55a0b91816e2

[PATCH net-next v2 2/2][RESEND] net: phy: adin: implement cable-test support

2020-11-02 Thread Alexandru Ardelean
implements support for this using phylib's cable-test support. Reviewed-by: Andrew Lunn Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 138 + 1 file changed, 138 insertions(+) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c

[PATCH net-next v2 1/2][RESEND] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-11-02 Thread Alexandru Ardelean
e the downshift retry value and the ADIN1300_LINKING_EN are in the same register. And the ADIN1300_DIAG_CLK_EN bit (13) is cleared, to disable the diagnostics clock. Reviewed-by: Andrew Lunn Signed-off-by: Alexandru Ardelean --- This is a re-send of: https://lore.kernel.org/netdev/2020102

Re: [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-10-31 Thread Alexandru Ardelean
On Sat, Oct 24, 2020 at 1:43 AM Andrew Lunn wrote: > > On Thu, Oct 22, 2020 at 10:45:50AM +0300, Alexandru Ardelean wrote: > > When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in > > register PHY_CTRL_1 (0x0012)). > > Also, the PHY is not in standby

Re: [PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-23 Thread Alexandru Ardelean
On Fri, Oct 23, 2020 at 3:02 AM Jakub Kicinski wrote: > > On Thu, 22 Oct 2020 10:45:51 +0300 Alexandru Ardelean wrote: > > The ADIN1300/ADIN1200 support cable diagnostics using TDR. > > > > The cable fault detection is automatically run on all four pairs looking at >

[PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-10-22 Thread Alexandru Ardelean
e the downshift retry value and the ADIN1300_LINKING_EN are in the same register. And the ADIN1300_DIAG_CLK_EN bit (13) is cleared, to disable the diagnostics clock. Signed-off-by: Alexandru Ardelean --- Changelog v1 -> v2: * updated title; updated description to better describe the d

[PATCH v2 2/2] net: phy: adin: implement cable-test support

2020-10-22 Thread Alexandru Ardelean
implements support for this using phylib's cable-test support. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 138 + 1 file changed, 138 insertions(+) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index 619d36685b5d..3e66f97

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:28 PM Andrew Lunn wrote: > > > Actually, I'd also be interested [for this PHY], to report a > > "significance impedance" detection, which is similar to the > > short-detection that is already done. > > You can add that as just another element of the enum. > > > At first,

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:13 PM Andrew Lunn wrote: > > > The frame-generator is an interesting feature of the PHY, that's not > > useful for the current phylib; the PHY can send packages [like a > > signal generator], and then these can be looped back, or sent over the > > wire. > removed my typo

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:09 PM Andrew Lunn wrote: > > > Signed-off-by: Alexandru Ardelean > removed my typo-ed email > Hi Alexandru > > Overall, this looks good. > > > +static int adin_cable_test_report_trans(int result) > > +{ > >

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 4:58 PM Andrew Lunn wrote: > > On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote: > > The LINKING_EN bit is always cleared during reset. Initially it was set > > during the downshift setup, because it's in the same register as the &g

[PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
alled). During this call, the diagnostics clock should be disabled, and the LINKING_EN bit set in the PHY_CTRL1 register. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/adin.c b/driver

[PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
implements support for this using phylib's cable-test support. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 138 + 1 file changed, 138 insertions(+) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index 619d36685b5d..3e66f97

[PATCH v2 1/2][ethtool] ethtool: sync ethtool-copy.h: adds support for EDPD

2019-09-19 Thread Alexandru Ardelean
Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net Pull in bug fixes from 'net' tree for the merge window. Signed-off-by: David S. Miller Signed-off-by: Alexandru Ardelean --- Changelog v1 -> v2: * reworked the parse_named_uint() function to avoid casting to typ

[PATCH v2 2/2][ethtool] ethtool: implement support for Energy Detect Power Down

2019-09-19 Thread Alexandru Ardelean
This change adds control for enabling/disabling Energy Detect Power Down mode, as well as configuring wake-up intervals for TX pulses, via the new ETHTOOL_PHY_EDPD control added in PHY tunable, in the kernel. Signed-off-by: Alexandru Ardelean --- Changelog v1 -> v2: * reworked

[PATCH 1/2][ethtool] ethtool: sync ethtool-copy.h: adds support for EDPD

2019-09-19 Thread Alexandru Ardelean
2019 +0200 Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net Pull in bug fixes from 'net' tree for the merge window. Signed-off-by: David S. Miller Signed-off-by: Alexandru Ardelean --- ethtool-copy.h | 30 ++ 1 file changed, 26 insert

[PATCH 2/2][ethtool] ethtool: implement support for Energy Detect Power Down

2019-09-19 Thread Alexandru Ardelean
This change adds control for enabling/disabling Energy Detect Power Down mode, as well as configuring wake-up intervals for TX pulses, via the new ETHTOOL_PHY_EDPD control added in PHY tunable, in the kernel. Signed-off-by: Alexandru Ardelean --- ethtool.8.in | 28 + ethtool.c

[PATCH 15/16] video: fbdev: pxafb: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
The `lcd_types` array is a static array of strings. Using match_string() (which computes the array size via ARRAY_SIZE()) is possible. This reduces the array by 1 element, since the NULL (at the end of the array) is no longer needed. Signed-off-by: Alexandru Ardelean --- drivers/video/fbdev

[PATCH 16/16] sched: debug: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
The `sched_feat_names` array is a static array of strings. Using match_string() (which computes the array size via ARRAY_SIZE()) is possible. The change is mostly cosmetic. No functionality change. Signed-off-by: Alexandru Ardelean --- kernel/sched/debug.c | 2 +- 1 file changed, 1 insertion

[PATCH 10/16] pinctrl: armada-37xx: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
-by: Alexandru Ardelean --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 07a5bcaa0067..68b0db5ef5e9 100644 --- a/drivers/pinc

[PATCH 14/16] staging: gdm724x: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
The `DRIVER_STRING` array is a static array of strings. Using match_string() (which computes the array size via ARRAY_SIZE()) is possible. The change is mostly cosmetic. No functionality change. Signed-off-by: Alexandru Ardelean --- drivers/staging/gdm724x/gdm_tty.c | 3 +-- 1 file changed, 1

[PATCH] net: xilinx: emaclite: add minimal ethtool ops

2019-04-08 Thread Alexandru Ardelean
-by: Alexandru Ardelean Reviewed-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0aea05ac6dcc

[PATCH] net: xilinx: emaclite: add minimal ndo_do_ioctl hook

2019-04-08 Thread Alexandru Ardelean
This hook only implements a minimal set of ioctl hooks to be able to access MII regs by using phytool. When using this simple MAC controller, it's pretty difficult to do debugging of the PHY chip without checking MII regs. Signed-off-by: Alexandru Ardelean Reviewed-by: Radhey Shyam P

Re: [PATCH] net/fsl: remove func xgmac_wait_until_free() as duplicate

2017-05-08 Thread Alexandru Ardelean
On Mon, May 8, 2017 at 10:34 PM, David Miller wrote: > From: Alexandru Ardelean > Date: Mon, 8 May 2017 14:31:18 +0300 > >> Looking at xgmac_wait_until_done() and xgmac_wait_until_free() >> functions, they seem to have turned out completely identical. >> >> Tho

[PATCH] net/fsl: remove func xgmac_wait_until_free() as duplicate

2017-05-08 Thread Alexandru Ardelean
Looking at xgmac_wait_until_done() and xgmac_wait_until_free() functions, they seem to have turned out completely identical. Though, judging from the git history it seems they initially weren't. Remove xgmac_wait_until_free() in favor of xgmac_wait_until_done(). Signed-off-by: Alex