Re: [PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-02-01 Thread Alexander Popov
On 01.02.2021 11:26, Stefano Garzarella wrote: > On Sun, Jan 31, 2021 at 01:59:14PM +0300, Alexander Popov wrote: >> There are multiple similar bugs implicitly introduced by the >> commit c0cfa2d8a788fcf4 ("vsock: add multi-transports support") and >> commit 6a

[PATCH v2 1/1] vsock: fix the race conditions in multi-transport support

2021-02-01 Thread Alexander Popov
88fcf4 ("vsock: add multi-transports support") Reviewed-by: Stefano Garzarella Signed-off-by: Alexander Popov --- net/vmw_vsock/af_vsock.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index d109

[PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-01-31 Thread Alexander Popov
able, [2] lock_sock() is called, [3] the local variable is used. VSOCK multi-transport support introduced the race condition: vsock_sock.transport value may change between [1] and [2]. Let's copy vsock_sock.transport pointer to local variables after the lock_sock() call. Signed-off-by:

Re: [PATCH 0/3] gcc-plugins: Introduce stackinit plugin

2019-01-28 Thread Alexander Popov
On 23.01.2019 14:03, Kees Cook wrote: > This adds a new plugin "stackinit" that attempts to perform unconditional > initialization of all stack variables Hello Kees! Hello everyone! I was curious about the performance impact of the initialization of all stack variables. So I did a very brief test

Re: BUG at net/sctp/socket.c:7425

2017-01-30 Thread Alexander Popov
On 29.01.2017 13:40, Marcelo Ricardo Leitner wrote: > On Sun, Jan 29, 2017 at 03:35:31AM +0300, Alexander Popov wrote: >> Hello, >> >> I'm running the syzkaller fuzzer for v4.10-rc4 >> (0aa0313f9d576affd7747cc3f179feb097d28990) >> and have such a crash in s

BUG at net/sctp/socket.c:7425

2017-01-28 Thread Alexander Popov
Hello, I'm running the syzkaller fuzzer for v4.10-rc4 (0aa0313f9d576affd7747cc3f179feb097d28990) and have such a crash in sctp code: [ 38.423932] [ cut here ] [ 38.424298] kernel BUG at net/sctp/socket.c:7425! [ 38.424583] invalid opcode: [#1] SMP KASAN [ 38.

[PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for Freescale MPC5121

2015-06-20 Thread Alexander Popov
_skb_align_workaround() and use skb_linearize() in it. Signed-off-by: Alexander Popov --- .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b

Re: [PATCH 1/1] net: fs_enet: Disable NETIF_F_SG feature for Freescale MPC5121

2015-06-14 Thread Alexander Popov
10.06.2015 03:14, David Miller пишет: From: Alexander Popov Date: Wed, 10 Jun 2015 02:57:42 +0300 skb_copy_from_linear_data() which doesn't work well for non-linear sk_buff: The correct fix is to use an SKB copy routine which can handle non-linear data. Thanks, David. I'll p

[PATCH 1/1] net: fs_enet: Disable NETIF_F_SG feature for Freescale MPC5121

2015-06-09 Thread Alexander Popov
cale MPC5121 might be better than handling improper alignment for sk_buff.data and all the fragments. Signed-off-by: Alexander Popov --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-