Re: [PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
On Sun, Jun 21, 2020 at 4:56 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sun, Jun 21, 2020: > > Fix rcu not being dereferenced cleanly by using the task > > helpers (un)lock_task_sighand instead of spin_lock_irqsave and > > spin_unlock_irqrestore to ensu

[PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
Fix rcu not being dereferenced cleanly by using the task helpers (un)lock_task_sighand instead of spin_lock_irqsave and spin_unlock_irqrestore to ensure current->sighand is a valid pointer as suggested in the email referenced below. Signed-off-by: Alexander Kapshuk Link: https://lore.kernel.

Re: [PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
On Sun, Jun 21, 2020 at 1:57 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sun, Jun 21, 2020: > > Thanks for your feedback. > > Shall I simply resend the v2 patch with the commit message reworded as > > you suggested, or should I make it a v3 patch instead? &

Re: [PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
On Sun, Jun 21, 2020 at 11:45 AM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sat, Jun 20, 2020: > > Use (un)lock_task_sighand instead of spin_lock_irqsave and > > spin_unlock_irqrestore to ensure current->sighand is a valid pointer as > > suggested in

[PATCH] net/9p: Validate current->sighand in client.c

2020-06-20 Thread Alexander Kapshuk
Use (un)lock_task_sighand instead of spin_lock_irqsave and spin_unlock_irqrestore to ensure current->sighand is a valid pointer as suggested in the email referenced below. Signed-off-by: Alexander Kapshuk Link: https://lore.kernel.org/lkml/20200618190807.GA20699@nautica/ --- net/9p/clien

Re: [PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Alexander Kapshuk
On Thu, Jun 18, 2020 at 10:08 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Thu, Jun 18, 2020: > > Address sparse nonderef rcu warnings: > > net/9p/client.c:790:17: warning: incorrect type in argument 1 (different > > address spaces) > > net/9p/clien

Re: [PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Alexander Kapshuk
On Thu, Jun 18, 2020 at 10:09 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Thu, Jun 18, 2020: > > Address sparse endian warning: > > net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different > > base types) > > net/9p/trans_fd.c:

[PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Alexander Kapshuk
Address sparse endian warning: net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different base types) net/9p/trans_fd.c:932:28:expected restricted __be32 [addressable] [assigned] [usertype] s_addr net/9p/trans_fd.c:932:28:got unsigned long Signed-off-by: Alexander

[PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Alexander Kapshuk
spinlock [noderef] * Signed-off-by: Alexander Kapshuk --- net/9p/client.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index fc1f3635e5dd..807e0e2e2e5a 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -787,9 +787,15