The region field was not added to the devlink man page.
Fixes: 8b4fbf0bed8e6 ("devlink: Add support for devlink-region access")
Signed-off-by: Alex Vesker
---
man/man8/devlink.8 | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/man/man8/devlink.8 b/man/man8
x5 firmware snapshot support via devlink: (Alex Vesker)
Last three patches, add the support for capturing region snapshot
of the
firmware crspace during critical errors, using devlink region_snapshot
parameter.
-Saeed.
----
Alex Vesker
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
devlink/devlink.c | 485 +-
man/man8/devlink-region.8 | 131 +
man/man8/devlink.8| 1 +
3 files changed, 616 insertions(+), 1 deletion(-)
create mode 100644 man/man8
On 7/13/2018 3:51 AM, Jakub Kicinski wrote:
On Thu, 12 Jul 2018 15:13:09 +0300, Alex Vesker wrote:
To restrict the driver with the snapshot ID selection a new callback
is introduced for the driver to get the snapshot ID before creating
a new snapshot. This will also allow giving the same ID
Add support for DEVLINK_CMD_REGION_DEL used
for deleting a snapshot from a region. The snapshot ID is required.
Also added notification support for NEW and DEL of snapshots.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 2 +
net/core/devlink.c
address regions are registered on init and snapshots are attached
once a new snapshot is collected by the driver.
Signed-off-by: Alex Vesker
Signed-off-by: Tariq Toukan
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx4/Makefile | 2 +-
drivers/net/ethernet/mellanox/mlx4/catas.c
This parameter enables capturing region snapshot of the crspace
during critical errors. The default value of this parameter is
disabled, it can be enabled using devlink param commands.
It is possible to configure during runtime and also driver init.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri
provided a snapshot read
will done.
This is used for both snapshot access and will be used in the same
way to access current data on the region.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 7 ++
net/core/devlink.c | 182
To restrict the driver with the snapshot ID selection a new callback
is introduced for the driver to get the snapshot ID before creating
a new snapshot. This will also allow giving the same ID for multiple
snapshots taken of different regions on the same time.
Signed-off-by: Alex Vesker
Signed
region_snapshot - When set enables capturing region snapshots
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
Reviewed-by: Moshe Shemesh
---
include/net/devlink.h | 4
net/core/devlink.c| 5 +
2 files changed, 9 insertions(+)
diff --git a/include/net/devlink.h b/include/net
readable data followed by a
lock which is used to block volatile CR space access.
Signed-off-by: Alex Vesker
Signed-off-by: Tariq Toukan
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 5 -
drivers/net/ethernet/mellanox/mlx4/fw.h | 1 +
drivers/net/ethernet/mellanox
Add support for DEVLINK_CMD_REGION_GET command which is used for
querying for the supported DEV/REGION values of devlink devices.
The support is both for doit and dumpit.
Reply includes:
BUS_NAME, DEVICE_NAME, REGION_NAME, REGION_SIZE
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
Extend the support for DEVLINK_CMD_REGION_GET command to also
return the IDs of the snapshot currently present on the region.
Each reply will include a nested snapshots attribute that
can contain multiple snapshot attributes each with an ID.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
be deleted using the destructor function
when destroying a region or when a snapshot delete command
from devlink user tool.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/net/devlink.h | 13 +++
net/core/devlink.c| 95
Add a parameter to enable devlink region snapshot
-Allocate snapshot memory using kvmalloc
-Introduce destructor function devlink_snapshot_data_dest_t to avoid
double allocation
v2->v3:
-Fix incorrect comment in devlink.h for DEVLINK_ATTR_REGION_SIZE
from u32 to u64
Alex Vesker (11):
devlin
, register-space.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/net/devlink.h | 22 ++
net/core/devlink.c| 84 +++
2 files changed, 106 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index
This parameter enables capturing region snapshot of the crspace
during critical errors. The default value of this parameter is
disabled, it can be enabled using devlink param commands.
It is possible to configure during runtime and also driver init.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri
Add support for DEVLINK_CMD_REGION_GET command which is used for
querying for the supported DEV/REGION values of devlink devices.
The support is both for doit and dumpit.
Reply includes:
BUS_NAME, DEVICE_NAME, REGION_NAME, REGION_SIZE
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
be deleted using the destructor function
when destroying a region or when a snapshot delete command
from devlink user tool.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/net/devlink.h | 13 +++
net/core/devlink.c| 95
Extend the support for DEVLINK_CMD_REGION_GET command to also
return the IDs of the snapshot currently present on the region.
Each reply will include a nested snapshots attribute that
can contain multiple snapshot attributes each with an ID.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
provided a snapshot read
will done.
This is used for both snapshot access and will be used in the same
way to access current data on the region.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 7 ++
net/core/devlink.c | 182
To restrict the driver with the snapshot ID selection a new callback
is introduced for the driver to get the snapshot ID before creating
a new snapshot. This will also allow giving the same ID for multiple
snapshots taken of different regions on the same time.
Signed-off-by: Alex Vesker
Signed
Add support for DEVLINK_CMD_REGION_DEL used
for deleting a snapshot from a region. The snapshot ID is required.
Also added notification support for NEW and DEL of snapshots.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 2 +
net/core/devlink.c
readable data followed by a
lock which is used to block volatile CR space access.
Signed-off-by: Alex Vesker
Signed-off-by: Tariq Toukan
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 5 -
drivers/net/ethernet/mellanox/mlx4/fw.h | 1 +
drivers/net/ethernet/mellanox
address regions are registered on init and snapshots are attached
once a new snapshot is collected by the driver.
Signed-off-by: Alex Vesker
Signed-off-by: Tariq Toukan
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx4/Makefile | 2 +-
drivers/net/ethernet/mellanox/mlx4/catas.c
, register-space.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/net/devlink.h | 22 ++
net/core/devlink.c| 84 +++
2 files changed, 106 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index
Add a parameter to enable devlink region snapshot
-Allocate snapshot memory using kvmalloc
-Introduce destructor function devlink_snapshot_data_dest_t to avoid
double allocation
Alex Vesker (11):
devlink: Add support for creating and destroying regions
devlink: Add callback to query for snaps
region_snapshot - When set enables capturing region snapshots
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
Reviewed-by: Moshe Shemesh
---
include/net/devlink.h | 4
net/core/devlink.c| 5 +
2 files changed, 9 insertions(+)
diff --git a/include/net/devlink.h b/include/net
On 3/31/2018 8:21 PM, David Ahern wrote:
On 3/31/18 9:53 AM, Andrew Lunn wrote:
I want to be able to login to a customer and accessing this snapshot
without any previous configuration from the user and not asking for
enabling the feature and then waiting for a repro...this will help
debugging
On 4/2/2018 12:12 PM, Jiri Pirko wrote:
Fri, Mar 30, 2018 at 05:11:29PM CEST, and...@lunn.ch wrote:
Please see:
http://patchwork.ozlabs.org/project/netdev/list/?series=36524
I bevieve that the solution in the patchset could be used for
your usecase too.
Hi Jiri
https://lkml.org/lkml/2018/3/
On 3/31/2018 1:26 AM, David Ahern wrote:
On 3/30/18 1:39 PM, Alex Vesker wrote:
On 3/30/2018 7:57 PM, David Ahern wrote:
On 3/30/18 8:34 AM, Andrew Lunn wrote:
And it seems to want contiguous pages. How well does that work after
the system has been running for a while and memory is
On 3/30/2018 7:57 PM, David Ahern wrote:
On 3/30/18 8:34 AM, Andrew Lunn wrote:
And it seems to want contiguous pages. How well does that work after
the system has been running for a while and memory is fragmented?
The allocation can be changed, there is no read need for contiguous pages.
It
On 3/29/2018 10:51 PM, Andrew Lunn wrote:
Show all of the exposed regions with region sizes:
$ devlink region show
pci/:00:05.0/cr-space: size 1048576 snapshot [1 2]
So you have 2Mbytes of snapshot data. Is this held in the device, or
kernel memory?
This is allocated in devlink, the maxim
On 3/29/2018 8:13 PM, Andrew Lunn wrote:
On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote:
This is a proposal which will allow access to driver defined address
regions using devlink. Each device can create its supported address
regions and register them. A device which exposes a
, register-space.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/net/devlink.h | 22 ++
net/core/devlink.c| 84 +++
2 files changed, 106 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index
To restrict the driver with the snapshot ID selection a new callback
is introduced for the driver to get the snapshot ID before creating
a new snapshot. This will also allow giving the same ID for multiple
snapshots taken of different regions on the same time.
Signed-off-by: Alex Vesker
Signed
provided a snapshot read
will done.
This is used for both snapshot access and will be used in the same
way to access current data on the region.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 7 ++
net/core/devlink.c | 182
Extend the support for DEVLINK_CMD_REGION_GET command to also
return the IDs of the snapshot currently present on the region.
Each reply will include a nested snapshots attribute that
can contain multiple snapshot attributes each with an ID.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
Add support for DEVLINK_CMD_REGION_GET command which is used for
querying for the supported DEV/REGION values of devlink devices.
The support is both for doit and dumpit.
Reply includes:
BUS_NAME, DEVICE_NAME, REGION_NAME, REGION_SIZE
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
region.
The snapshot are can be deleted from devlink user tool or when
destroying a region.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/net/devlink.h | 9 +
net/core/devlink.c| 99 +++
2 files changed, 108 insertions
readable data followed by a
lock which is used to block volatile CR space access.
Signed-off-by: Alex Vesker
Signed-off-by: Tariq Toukan
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 5 -
drivers/net/ethernet/mellanox/mlx4/fw.h | 1 +
drivers/net/ethernet/mellanox
address regions are registered on init and snapshots are attached
once a new snapshot is collected by the driver.
Signed-off-by: Alex Vesker
Signed-off-by: Tariq Toukan
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx4/Makefile | 2 +-
drivers/net/ethernet/mellanox/mlx4/catas.c
-health snapshot 1 address 0
length 16
0014 95dc 0014 9514 0035 1670 0034 db30
For more information you can check devlink-region.8 man page
Future:
There is a plan to extend the support to include a write command
as well as performing read and dump live region
Alex Vesker
Add support for DEVLINK_CMD_REGION_DEL used
for deleting a snapshot from a region. The snapshot ID is required.
Also added notification support for NEW and DEL of snapshots.
Signed-off-by: Alex Vesker
Signed-off-by: Jiri Pirko
---
include/uapi/linux/devlink.h | 2 +
net/core/devlink.c
On 10/23/2017 6:47 PM, Jason Gunthorpe wrote:
On Sat, Oct 14, 2017 at 11:48:23AM -0700, Saeed Mahameed wrote:
From: Alex Vesker
This change is needed for PKEY support, since the RQs are shared
between the child interface and the parent. The parent is responsible
for NAPI and the precessing
45 matches
Mail list logo
