[PATCH] net: called rtnl_unlock() before runpm resumes devices

2021-04-20 Thread AceLan Kao
From: "Chia-Lin Kao (AceLan)" The rtnl_lock() has been called in rtnetlink_rcv_msg(), and then in __dev_open() it calls pm_runtime_resume() to resume devices, and in some devices' resume function(igb_resum,igc_resume) they calls rtnl_lock() again. That leads to a recursive lock. It should leave

[PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

2020-07-07 Thread AceLan Kao
) I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) Signed-off-by: AceLan Kao --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 31b1d4b959f6..07c42c0719f5 100644 --- a/drivers/net/usb

Re: [PATCH v2] Revert "alx: remove WoL support"

2018-05-27 Thread AceLan Kao
ot;wake up twice" bug, but with recent kernel version, I don't have this issue anymore. I can't tell which version actually fix the bug (I don't remember..). Best regards, AceLan Kao. 2018-05-21 11:18 GMT+08:00 David Miller : > From: AceLan Kao > Date: Mon, 21 May 2018 11:14

Re: [PATCH v2] Revert "alx: remove WoL support"

2018-05-20 Thread AceLan Kao
d you let me know which solution is more feasible for you? Thanks. Best regards, AceLan Kao. 2018-05-14 21:35 GMT+08:00 David Miller : > From: AceLan Kao > Date: Mon, 14 May 2018 11:28:39 +0800 > >> This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. >> >> The Wo

[PATCH v2] Revert "alx: remove WoL support"

2018-05-13 Thread AceLan Kao
hen WoL is enabled. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651 Signed-off-by: AceLan Kao --- drivers/net/ethernet/atheros/alx/ethtool.c | 36 + drivers/net/ethernet/atheros/alx/hw.c | 154 - drivers/net/ethernet/atheros/alx/hw.h | 5 + d

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-13 Thread AceLan Kao
Okay, I'll submit a new patch with some more description of why we need this feature. Thanks. 2018-05-10 20:34 GMT+08:00 Andrew Lunn : > On Thu, May 10, 2018 at 01:58:24PM +0800, AceLan Kao wrote: >> Hi Andrew, >> >> We have some machines using Qualcomm Atheros Killer

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-09 Thread AceLan Kao
g the feature has been removed for 5 years into account, I doubt if we still can reproduce this issue, but again, to verify this issue we need to add back this feature first. Set WoL disabled by default won't introduce any regression but give users and developers a chance to fix it. Best regards,

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-08 Thread AceLan Kao
1 Best regards, AceLan Kao. 2018-04-24 11:45 GMT+08:00 AceLan Kao : > Hi, > > May I know the final decision of this patch? > Thanks. > > Best regards, > AceLan Kao. > > 2018-04-10 10:40 GMT+08:00 AceLan Kao : >> The problem is I don't have a machine with that w

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-04-23 Thread AceLan Kao
Hi, May I know the final decision of this patch? Thanks. Best regards, AceLan Kao. 2018-04-10 10:40 GMT+08:00 AceLan Kao : > The problem is I don't have a machine with that wakeup issue, and I > need WoL feature. > Instead of spreading "alx with WoL" dkms package every

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-04-09 Thread AceLan Kao
018-04-09 22:50 GMT+08:00 David Miller : > From: Andrew Lunn > Date: Mon, 9 Apr 2018 14:39:10 +0200 > >> On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: >>> The WoL feature was reported broken and will lead to >>> the system resume immediately after suspend

[PATCH 1/2] Revert "alx: remove WoL support"

2018-04-09 Thread AceLan Kao
This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. There are still many people need this feature, so try adding it back. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651 Signed-off-by: AceLan Kao --- drivers/net/ethernet/atheros/alx/ethtool.c | 36 +++ drivers/net

[PATCH 2/2] alx: add disable_wol paramenter

2018-04-09 Thread AceLan Kao
?id=61651 Signed-off-by: AceLan Kao --- drivers/net/ethernet/atheros/alx/ethtool.c | 7 ++- drivers/net/ethernet/atheros/alx/main.c| 5 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/alx/ethtool.c b/drivers/net/ethernet/atheros/alx

[PATCH] ath9k: add a quirk to set use_msi automatically

2018-01-08 Thread AceLan Kao
Dell Vostro 15-3572 Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 53 +++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index 43adead..e479fae 100644 --- a

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-10-12 Thread AceLan Kao
Hi Daniel, After applied the 2 commits you mentioned in the email, ath9k works. https://marc.info/?l=linux-wireless&m=150631274108016&w=2 https://github.com/endlessm/linux/commit/739c7a924db8f4434a9617657 Best regards, AceLan Kao. 2017-10-05 14:39 GMT+08:00 AceLan Kao : > Hi all,

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-10-04 Thread AceLan Kao
Hi all, Please drop my patches, Qualcomm is working internally and will submit the MSI patch by themselves. Thanks. Hi Daniel, I'll try your patches tomorrow. Best regards, AceLan Kao. 2017-10-02 12:21 GMT+08:00 Daniel Drake : > Hi AceLan, > > On Thu, Sep 28, 2017 at 4:28

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-09-28 Thread AceLan Kao
ros QCA9565 / AR9565 Wireless Network Adapter [168c:0036] (rev 01) Subsystem: Dell QCA9565 / AR9565 Wireless Network Adapter [1028:020e] Kernel driver in use: ath9k Kernel modules: ath9k Do you have a chance to see if my patch works on your side? Best regards, AceLan Kao. 201

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-09-26 Thread AceLan Kao
017 at 02:41:35PM +0800, AceLan Kao wrote: >> Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI >> for WLAN device. So adding a quirk to list those machines and set >> use_msi automatically. >> Adding Dell Inspiron 24-3460 to the quirk. > > Huh?

[PATCH 1/6] ath9k: add MSI support and use_msi parameter

2017-09-25 Thread AceLan Kao
Adding MSI support for ath9k devices. This patch is originally from Qualcomm, but they have no intention of submitting and maintaining ath9k driver now. The credit should go to Qualcomm. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/hw.c | 33 ++-- drivers

[PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-09-25 Thread AceLan Kao
Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI for WLAN device. So adding a quirk to list those machines and set use_msi automatically. Adding Dell Inspiron 24-3460 to the quirk. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 21

[PATCH 4/6] ath9k: set use_msi=1 on Dell Inspiron 3472

2017-09-25 Thread AceLan Kao
BIOS on Dell Inspiron 3472 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath

[PATCH 3/6] ath9k: set use_msi=1 on Dell Vostro 3262

2017-09-25 Thread AceLan Kao
BIOS on Dell Vostro 3262 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k

[PATCH 6/6] ath9k: set use_msi=1 on Dell Inspiron 14-3473

2017-09-25 Thread AceLan Kao
BIOS on Dell Inspiron 14-3473 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath

[PATCH 5/6] ath9k: set use_msi=1 on Dell Vostro 15-3572

2017-09-25 Thread AceLan Kao
BIOS on Dell Vostro 15-3572 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath