RE: [net-next 1/2] dummy: add device MTU validation check

2017-09-22 Thread
> -Original Message- > From: Sabrina Dubroca [mailto:s...@queasysnail.net] > Sent: 2017年9月22日 20:23 > To: Eric Dumazet > Cc: Jarod Wilson ; Zhang Shengju > ; da...@davemloft.net; > will...@google.com; step...@networkplumber.org; > netdev@vger.kernel.org > Subject: Re: [net-next 1/2] dummy:

RE: [net-next 2/2] ifb: add device MTU validation check

2017-09-21 Thread
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: 2017年9月21日 23:10 > To: Zhang Shengju > Cc: da...@davemloft.net; will...@google.com; netdev@vger.kernel.org > Subject: Re: [net-next 2/2] ifb: add device MTU validation check > > On Thu, 21 Sep 2017

RE: [net-next 1/2] dummy: add device MTU validation check

2017-09-21 Thread
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: 2017年9月21日 23:02 > To: Zhang Shengju > Cc: da...@davemloft.net; will...@google.com; > step...@networkplumber.org; netdev@vger.kernel.org > Subject: Re: [net-next 1/2] dummy: add device MTU validation check >

RE: [net-next] macvlan: propagate the mac address change status for lowerdev

2017-06-14 Thread
> -Original Message- > From: Yuval Shaia [mailto:yuval.sh...@oracle.com] > Sent: Wednesday, June 14, 2017 4:34 AM > To: Zhang Shengju > Cc: da...@davemloft.net; f...@48lvckh6395k16k5.yundunddos.com; > vyase...@redhat.com; netdev@vger.kernel.org > Subject: Re: [net-next] macvlan: propagate

RE: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-05 Thread
> -Original Message- > From: Pravin Shelar [mailto:pshe...@ovn.org] > Sent: Monday, June 05, 2017 10:30 AM > To: 张胜举 > Cc: Pravin Shelar ; Linux Kernel Network Developers > ; David S. Miller > Subject: Re: [net-next] openvswitch: add macro > MODULE_ALIAS_VPORT_T

RE: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, June 05, 2017 4:13 AM > To: pshe...@ovn.org > Cc: zhangshen...@cmss.chinamobile.com; pshe...@nicira.com; > netdev@vger.kernel.org > Subject: Re: [net-next] openvswitch: add macro > MODULE_ALIAS_VPORT_TYPE

RE: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread
> -Original Message- > From: Pravin Shelar [mailto:pshe...@ovn.org] > Sent: Sunday, June 04, 2017 1:58 PM > To: Zhang Shengju > Cc: Pravin Shelar ; Linux Kernel Network Developers > ; David S. Miller > Subject: Re: [net-next] openvswitch: add macro > MODULE_ALIAS_VPORT_TYPE for vport type

RE: [net-next] net: remove duplicate add_device_randomness() call

2017-05-04 Thread
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, May 04, 2017 11:13 PM > To: zhangshen...@cmss.chinamobile.com > Cc: netdev@vger.kernel.org; eduma...@google.com > Subject: Re: [net-next] net: remove duplicate add_device_randomness() call > > From: Zh

RE: [iproute2] iplink: add support for IFLA_CARRIER attribute

2017-04-26 Thread
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, April 26, 2017 11:08 PM > To: Zhang Shengju > Cc: netdev@vger.kernel.org > Subject: Re: [iproute2] iplink: add support for IFLA_CARRIER attribute > > On Wed, 26 Apr 2017 15:08:39 +0800 >

RE: [net-next] icmp: correct return value of icmp_rcv()

2016-12-07 Thread
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, December 07, 2016 10:18 PM > To: Zhang Shengju > Cc: netdev@vger.kernel.org > Subject: Re: [net-next] icmp: correct return value of icmp_rcv() > > On Wed, 2016-12-07 at 14:52 +0800, Zhang Shengju

RE: [net-next] neigh: remove duplicate check for same neigh

2016-11-29 Thread
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Wednesday, November 30, 2016 12:23 AM > To: Zhang Shengju ; > netdev@vger.kernel.org > Subject: Re: [net-next] neigh: remove duplicate check for same neigh > > On 11/29/16 1:22 AM, Zhang Shengju wrote: > > @

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 1:07 PM > To: 张胜举 ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 9:50 PM, 张胜举 wrote: &

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 11:10 AM > To: 张胜举 ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 7:56 PM, David Ahern

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 10:39 AM > To: 张胜举 ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 7:34 PM, 张胜举 wrote: &g

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 10:10 AM > To: Zhang Shengju ; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump > > On 11/27/16 6:32 PM, Zhang Shengju wrote: > > Loop

RE: [net-next] rtnl: fix the loop index update error in rtnl_dump_ifinfo()

2016-11-20 Thread
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Sunday, November 20, 2016 11:15 AM > To: zhangshen...@cmss.chinamobile.com > Cc: netdev@vger.kernel.org; d...@cumulusnetworks.com > Subject: Re: [net-next] rtnl: fix the loop index update error in > rtnl_dump_ifi

Re: [net-next] bond: output message before setting slave to inactive

2016-03-30 Thread
> From: Zhang Shengju > Date: Tue, 29 Mar 2016 06:32:57 + > > > This patch moves output message before setting slave to inactive, this > > will print the correct status of slave device. > > > > Signed-off-by: Zhang Shengju > > I think the message is in the appropriate spot wrt. state, so I

Re: [net-next 1/2] bonding: remove duplicate set of flag IFF_MULTICAST

2016-03-19 Thread
> On 03/16/2016 10:59 AM, Zhang Shengju wrote: > > Remove unnecessary set of flag IFF_MULTICAST, since ether_setup > > already does this. > > > > Signed-off-by: Zhang Shengju > > --- > > drivers/net/bonding/bond_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > There're a

RE: [net-next,iproute2] netconf: add support for ignore route attribute

2016-03-14 Thread
> On Mon, 14 Mar 2016 04:55:36 + > Zhang Shengju wrote: > > > Add support for ignore_routes_with_linkdown attribute. > > > > Signed-off-by: Zhang Shengju > > --- > > ip/ipnetconf.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/ip/ipnetconf.c b/ip/ipnetconf.c index eca6e

Re: [net-next] arp: correct return value of arp_rcv

2016-03-03 Thread
> From: Zhang Shengju > Date: Tue, 1 Mar 2016 07:24:42 + > > > Currently, arp_rcv() always return zero on a packet delivery upcall. > > > > To make its behavior more compliant with the way this API should be > > used, this patch changes this to let it return NET_RX_SUCCESS when the > > packe

Re: [net] net: fix double free issue of skbuff

2016-02-29 Thread
> On Mon, 2016-02-29 at 12:22 +, Zhang Shengju wrote: > > If skb_reorder_vlan_header() failed, skb is freed and NULL is returned. > > Then at skb_vlan_untag(), it will free skbuff again which cause double > > free. > > On skb_reorder_vlan_header() failure, skb_vlan_untag() will call > kfree_sk

Re: [net] net: fix double free issue of skbuff

2016-02-29 Thread
> Hello. > > On 2/29/2016 3:22 PM, Zhang Shengju wrote: > > > If skb_reorder_vlan_header() failed, skb is freed and NULL is returned. > > Then at skb_vlan_untag(), it will free skbuff again which cause double > > free. > > > > This patch removes kfree_skb() call in function > skb_reorder_vlan_hea

Re: [net-next] vlan: change return type of vlan_proc_rem_dev

2016-02-17 Thread
> > On Wed, Feb 17, 2016 at 3:44 AM, Zhang Shengju > wrote: > > Since function vlan_proc_rem_dev() will only return 0, it's better to > > return void instead of int. > > > > Signed-off-by: Zhang Shengju > > --- > > net/8021q/vlanproc.c | 3 +-- > > net/8021q/vlanproc.h | 2 +- > > 2 files chang

Reply: [net] bonding: use return instead of goto

2016-02-06 Thread
> On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote: > > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > > > Replace 'goto' with 'return' to remove unnecessary check at label: > > > > err_undo_flags. > > >

Reply: [PATCH iproute2] ip-link: remove warning message

2016-02-04 Thread
> On Thu, 21 Jan 2016 02:23:49 + > Zhang Shengju wrote: > > > the warning was: > > iproute.c:301:12: warning: 'val' may be used uninitialized in this > > function [-Wmaybe-uninitialized] > >features &= ~RTAX_FEATURE_ECN; > > ^ > > iproute.c:575:10: note: 'val' was declared her

Reply: [net] bonding: use return instead of goto

2016-02-04 Thread
> On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > Replace 'goto' with 'return' to remove unnecessary check at label: > > err_undo_flags. > > I think you're going to have to explain how you came to the conclusion that > the check isn't necessary. > > -- > Jarod Wilson > ja...@re

RE: [PATCH iproute2] ip: replace exit with return

2015-08-12 Thread
> > From: netdev-ow...@vger.kernel.org > > Sent: 11 August 2015 10:40 > > In our manual, we have this description of 'EXIT STATUS': > > Exit status is 0 if command was successful, and 1 if there is a syntax > > error. > > > > But we exit in command functions with code -1 when there is a syntax err