Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Eric Dumazet
On Tue, Feb 4, 2025 at 10:30 PM Jakub Kicinski wrote: > > On Tue, 4 Feb 2025 13:17:08 -0800 Paul E. McKenney wrote: > > > > TBH I'm slightly confused by this, and the previous warnings. > > > > > > > > The previous one was from a timer callback. > > > > > > > > This one is with BH disabled. > > >

Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Paul E. McKenney
On Tue, Feb 04, 2025 at 01:30:25PM -0800, Jakub Kicinski wrote: > On Tue, 4 Feb 2025 13:17:08 -0800 Paul E. McKenney wrote: > > > > TBH I'm slightly confused by this, and the previous warnings. > > > > > > > > The previous one was from a timer callback. > > > > > > > > This one is with BH disabled.

Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Jakub Kicinski
On Tue, 4 Feb 2025 13:17:08 -0800 Paul E. McKenney wrote: > > > TBH I'm slightly confused by this, and the previous warnings. > > > > > > The previous one was from a timer callback. > > > > > > This one is with BH disabled. > > > > > > I thought BH implies RCU protection. We certainly depend on tha

Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Paul E. McKenney
On Tue, Feb 04, 2025 at 10:06:15PM +0100, Eric Dumazet wrote: > On Tue, Feb 4, 2025 at 10:00 PM Jakub Kicinski wrote: > > > > On Tue, 4 Feb 2025 21:10:59 +0100 Eric Dumazet wrote: > > > > Test output: > > > > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/61-l2tp-sh/ > > > > Decoded

Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Jakub Kicinski
On Tue, 4 Feb 2025 21:10:59 +0100 Eric Dumazet wrote: > > Test output: > > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/61-l2tp-sh/ > > Decoded: > > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/vm-crash-thr2-0 > > > > Oh well. So many bugs. TBH I'm slightly co

Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()

2025-02-04 Thread Eric Dumazet
On Tue, Feb 4, 2025 at 10:00 PM Jakub Kicinski wrote: > > On Tue, 4 Feb 2025 21:10:59 +0100 Eric Dumazet wrote: > > > Test output: > > > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/61-l2tp-sh/ > > > Decoded: > > > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/vm-c