[PATCH net-next v4 09/13] virtio_net: xsk: bind/unbind xsk for tx

2024-11-11 Thread Xuan Zhuo
This patch implement the logic of bind/unbind xsk pool to sq and rq. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 53 1 file changed, 53 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index

[PATCH net-next v4 11/13] virtio_net: xsk: tx: support xmit xsk buffer

2024-11-11 Thread Xuan Zhuo
The driver's tx napi is very important for XSK. It is responsible for obtaining data from the XSK queue and sending it out. At the beginning, we need to trigger tx napi. virtnet_free_old_xmit distinguishes three type ptr(skb, xdp frame, xsk buffer) by the last bits of the pointer. Signed-off-by:

[PATCH net-next v4 10/13] virtio_net: xsk: prevent disable tx napi

2024-11-11 Thread Xuan Zhuo
Since xsk's TX queue is consumed by TX NAPI, if sq is bound to xsk, then we must stop tx napi from being disabled. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/

[PATCH net-next v4 13/13] virtio_net: xdp_features add NETDEV_XDP_ACT_XSK_ZEROCOPY

2024-11-11 Thread Xuan Zhuo
Now, we support AF_XDP(xsk). Add NETDEV_XDP_ACT_XSK_ZEROCOPY to xdp_features. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7db586770249..

[PATCH net-next v4 06/13] virtio-net: rq submits premapped per-buffer

2024-11-11 Thread Xuan Zhuo
virtio-net rq submits premapped per-buffer by setting sg page to NULL; Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c inde

[PATCH net-next v4 12/13] virtio_net: update tx timeout record

2024-11-11 Thread Xuan Zhuo
If send queue sent some packets, we update the tx timeout record to prevent the tx timeout. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 57642bd83b7

[PATCH net-next v4 01/13] virtio_ring: introduce vring_need_unmap_buffer

2024-11-11 Thread Xuan Zhuo
To make the code readable, introduce vring_need_unmap_buffer() to replace do_unmap. use_dma_api premapped -> vring_need_unmap_buffer() 1. false falsefalse 2. truefalsetrue 3. truetrue false Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drive

[PATCH net-next v4 05/13] virtio_ring: introduce add api for premapped

2024-11-11 Thread Xuan Zhuo
Two APIs are introduced to submit premapped per-buffers. int virtqueue_add_inbuf_premapped(struct virtqueue *vq, struct scatterlist *sg, unsigned int num, void *data, void *ctx,

[PATCH net-next v4 04/13] virtio_ring: perform premapped operations based on per-buffer

2024-11-11 Thread Xuan Zhuo
The current configuration sets the virtqueue (vq) to premapped mode, implying that all buffers submitted to this queue must be mapped ahead of time. This presents a challenge for the virtnet send queue (sq): the virtnet driver would be required to keep track of dma information for vq size * 17, whi

[PATCH net-next v4 08/13] virtio_net: refactor the xmit type

2024-11-11 Thread Xuan Zhuo
Because the af-xdp will introduce a new xmit type, so I refactor the xmit type mechanism first. We know both xdp_frame and sk_buff are at least 4 bytes aligned. For the xdp tx, we do not pass any pointer to virtio core as data, we just need to pass the len of the packet. So we will push len to the

[PATCH net-next v4 00/13] virtio-net: support AF_XDP zero copy (tx)

2024-11-11 Thread Xuan Zhuo
v4: 1. rebase net-next 2. update the kdoc for the new APIs v3: 1. use sg_dma_address/length api to set the premapped sg 2. remove 'premapped' parameter from the new APIs 3. tweak the comment of commit #2,#3 v2: 1. use new api to submit premapped buffer instead of using sgs

[PATCH net-next v4 07/13] virtio_ring: remove API virtqueue_set_dma_premapped

2024-11-11 Thread Xuan Zhuo
Now, this API is useless. remove it. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 13 -- drivers/virtio/virtio_ring.c | 48 include/linux/virtio.h | 2 -- 3 files changed, 63 deletions(-) diff --git a/drive

[PATCH net-next v4 02/13] virtio_ring: split: record extras for indirect buffers

2024-11-11 Thread Xuan Zhuo
The subsequent commit needs to know whether every indirect buffer is premapped or not. So we need to introduce an extra struct for every indirect buffer to record this info. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/virtio/virtio_ring.c | 112 ---

[PATCH net-next v4 03/13] virtio_ring: packed: record extras for indirect buffers

2024-11-11 Thread Xuan Zhuo
The subsequent commit needs to know whether every indirect buffer is premapped or not. So we need to introduce an extra struct for every indirect buffer to record this info. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/virtio/virtio_ring.c | 60 +---

Re: [PATCH net-next v3 05/13] virtio_ring: introduce add api for premapped

2024-11-11 Thread Jakub Kicinski
On Thu, 7 Nov 2024 16:54:56 +0800 Xuan Zhuo wrote: > + * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO). > + * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO). Looks like we need a rebase, doesn't apply any more. When you rebase please correct the kdoc, looks like the off

Re: [PATCH net v2 2/3] vsock: Fix sk_error_queue memory leak

2024-11-11 Thread Arseniy Krasnov
On 07.11.2024 23:46, Michal Luczaj wrote: > Kernel queues MSG_ZEROCOPY completion notifications on the error queue. > Where they remain, until explicitly recv()ed. To prevent memory leaks, > clean up the queue when the socket is destroyed. > > unreferenced object 0x8881028beb00 (size 224):

Re: [PATCH net v2 3/3] virtio/vsock: Improve MSG_ZEROCOPY error handling

2024-11-11 Thread Arseniy Krasnov
On 07.11.2024 23:46, Michal Luczaj wrote: > Add a missing kfree_skb() to prevent memory leaks. > > Fixes: 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support") > Reviewed-by: Stefano Garzarella > Signed-off-by: Michal Luczaj > --- > net/vmw_vsock/virtio_transport_common.c | 1 + > 1 file

Re: [PATCH net 3/4] virtio/vsock: Improve MSG_ZEROCOPY error handling

2024-11-11 Thread Arseniy Krasnov
On 06.11.2024 20:51, Michal Luczaj wrote: > Add a missing kfree_skb() to prevent memory leaks. > > Fixes: 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support") > Signed-off-by: Michal Luczaj > --- > net/vmw_vsock/virtio_transport_common.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: