Re: [PATCH net-next v2 06/13] virtio-net: rq submits premapped per-buffer

2024-11-04 Thread Xuan Zhuo
On Tue, 5 Nov 2024 11:23:50 +0800, Jason Wang wrote: > On Wed, Oct 30, 2024 at 4:25 PM Xuan Zhuo wrote: > > > > virtio-net rq submits premapped per-buffer by setting sg page to NULL; > > > > Signed-off-by: Xuan Zhuo > > --- > > drivers/net/virtio_net.c | 24 +--- > > 1 file

Re: [PATCH net-next v1 0/4] virtio_net: enable premapped mode by default

2024-11-04 Thread Jason Wang
Hi Jakub: On Tue, Nov 5, 2024 at 10:46 AM Jakub Kicinski wrote: > > On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > > In the last linux version, we disabled this feature to fix the > > regress[1]. > > > > The patch set is try to fix the problem and re-enable it. > > > > More info: > > http

Re: [PATCH net-next v2 07/13] virtio_ring: remove API virtqueue_set_dma_premapped

2024-11-04 Thread Jason Wang
On Wed, Oct 30, 2024 at 4:25 PM Xuan Zhuo wrote: > > Now, this API is useless. remove it. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Thanks

Re: [PATCH net-next v2 05/13] virtio_ring: introduce add api for premapped

2024-11-04 Thread Jason Wang
On Wed, Oct 30, 2024 at 4:25 PM Xuan Zhuo wrote: > > Two APIs are introduced to submit premapped per-buffers. > > int virtqueue_add_inbuf_premapped(struct virtqueue *vq, > struct scatterlist *sg, unsigned int num, > void *data, >

Re: [PATCH net-next v2 04/13] virtio_ring: perform premapped operations based on per-buffer

2024-11-04 Thread Jason Wang
On Wed, Oct 30, 2024 at 4:25 PM Xuan Zhuo wrote: > > The current configuration sets the virtqueue (vq) to premapped mode, > implying that all buffers submitted to this queue must be mapped ahead > of time. This presents a challenge for the virtnet send queue (sq): the > virtnet driver would be req

Re: [PATCH net-next v2 02/13] virtio_ring: split: record extras for indirect buffers

2024-11-04 Thread Jason Wang
On Wed, Oct 30, 2024 at 4:25 PM Xuan Zhuo wrote: > > The subsequent commit needs to know whether every indirect buffer is > premapped or not. So we need to introduce an extra struct for every > indirect buffer to record this info. > > Signed-off-by: Xuan Zhuo > --- > drivers/virtio/virtio_ring.c

Re: [PATCH net-next v2 06/13] virtio-net: rq submits premapped per-buffer

2024-11-04 Thread Jason Wang
On Wed, Oct 30, 2024 at 4:25 PM Xuan Zhuo wrote: > > virtio-net rq submits premapped per-buffer by setting sg page to NULL; > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 24 +--- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/ne

Re: [PATCH net-next v1 0/4] virtio_net: enable premapped mode by default

2024-11-04 Thread Jakub Kicinski
On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > In the last linux version, we disabled this feature to fix the > regress[1]. > > The patch set is try to fix the problem and re-enable it. > > More info: > http://lore.kernel.org/all/20240820071913.68004-1-xuanz...@linux.alibaba.com Sorry to