Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Xuan Zhuo
On Thu, 29 Aug 2024 12:51:31 +0800, Jason Wang wrote: > On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo wrote: > > > > On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > > > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo > > > wrote: > > > > > > > > leads to regression on VM with the sysctl value of

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Xuan Zhuo
On Wed, 28 Aug 2024 12:57:56 -0700, "Si-Wei Liu" wrote: > Just in case Xuan missed the last email while his email server kept > rejecting incoming emails in the last week.: the patch doesn't seem fix > the regression. > > Xuan, given this is not very hard to reproduce and we have clearly > stated

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Jason Wang
On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo wrote: > > On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo > > wrote: > > > > > > leads to regression on VM with the sysctl value of: > > > > > > - net.core.high_order_alloc_disable=1 > > > > > > which

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Si-Wei Liu
Just in case Xuan missed the last email while his email server kept rejecting incoming emails in the last week.: the patch doesn't seem fix the regression. Xuan, given this is not very hard to reproduce and we have clearly stated how to, could you try to get the patch verified in house before

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Xuan Zhuo
On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo wrote: > > > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M in size > > t