Re: [PATCH net v2] virtio-net: unbreak vq resizing when coalescing is not negotiated

On Thu, Aug 01, 2024 at 02:07:43PM +0800, Heng Qi wrote: > On Wed, 31 Jul 2024 08:46:42 -0400, "Michael S. Tsirkin" > wrote: > > On Wed, Jul 31, 2024 at 08:25:23PM +0800, Heng Qi wrote: > > > On Wed, 31 Jul 2024 08:14:43 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Wed, Jul 31, 2024 at 0

Re: [PATCH net v2] virtio-net: unbreak vq resizing when coalescing is not negotiated

On Wed, 31 Jul 2024 08:46:42 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jul 31, 2024 at 08:25:23PM +0800, Heng Qi wrote: > > On Wed, 31 Jul 2024 08:14:43 -0400, "Michael S. Tsirkin" > > wrote: > > > On Wed, Jul 31, 2024 at 08:07:17PM +0800, Heng Qi wrote: > > > > >From the virtio spec: > > >

Re: [PATCH net v2] virtio-net: unbreak vq resizing when coalescing is not negotiated

On Wed, Jul 31, 2024 at 08:25:23PM +0800, Heng Qi wrote: > On Wed, 31 Jul 2024 08:14:43 -0400, "Michael S. Tsirkin" > wrote: > > On Wed, Jul 31, 2024 at 08:07:17PM +0800, Heng Qi wrote: > > > >From the virtio spec: > > > > > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > > >

Re: [PATCH net v2] virtio-net: unbreak vq resizing when coalescing is not negotiated

On Wed, 31 Jul 2024 08:14:43 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jul 31, 2024 at 08:07:17PM +0800, Heng Qi wrote: > > >From the virtio spec: > > > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET >

Re: [PATCH net v2] virtio-net: unbreak vq resizing when coalescing is not negotiated

On Wed, Jul 31, 2024 at 08:07:17PM +0800, Heng Qi wrote: > >From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not se

[PATCH net v2] virtio-net: unbreak vq resizing when coalescing is not negotiated

>From the virtio spec: The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. The driver must not send vq notification coalescing commands if VIRTIO_NET_F_VQ_NOTF_CO

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

On Tue, 30 Jul 2024 18:20:20 -0700, Jakub Kicinski wrote: > On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > > commands > > subject currently reads like this is an optimization, could you > rephrase? Jason's rephras

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

On Wed, 31 Jul 2024 11:13:03 +0800, Jason Wang wrote: > On Wed, Jul 31, 2024 at 9:20 AM Jakub Kicinski wrote: > > > > On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > > > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > > > commands > > > > subject currently reads li