Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

On Wed, Jul 31, 2024 at 9:20 AM Jakub Kicinski wrote: > > On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > > commands > > subject currently reads like this is an optimization, could you > rephrase? It might be "virti

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

On Mon, Jul 29, 2024 at 8:48 PM Heng Qi wrote: > > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not send v

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > commands subject currently reads like this is an optimization, could you rephrase? > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

On Mon, Jul 29, 2024 at 2:48 PM Heng Qi wrote: > > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not send v