On Tue, 18 Jun 2024 11:10:26 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 9:15 PM Heng Qi wrote:
> >
> > The XDP program can't correctly handle partially checksummed
> > packets, but works fine with fully checksummed packets.
>
> Not sure this is ture, if I was not wrong, XDP can try to ca
On Tue, 18 Jun 2024 11:01:27 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 9:15 PM Heng Qi wrote:
> >
> > In virtio spec 0.95, VIRTIO_NET_F_GUEST_CSUM was designed to handle
> > partially checksummed packets, and the validation of fully checksummed
> > packets by the device is independent of
On Mon, Jun 17, 2024 at 9:15 PM Heng Qi wrote:
>
> The XDP program can't correctly handle partially checksummed
> packets, but works fine with fully checksummed packets.
Not sure this is ture, if I was not wrong, XDP can try to calculate checksum.
Thanks
> If the
> device has already validated
On Mon, Jun 17, 2024 at 9:15 PM Heng Qi wrote:
>
> In virtio spec 0.95, VIRTIO_NET_F_GUEST_CSUM was designed to handle
> partially checksummed packets, and the validation of fully checksummed
> packets by the device is independent of VIRTIO_NET_F_GUEST_CSUM
> negotiation. However, the specificatio
On Tue, 18 Jun 2024 09:06:50 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 3:54 PM Xuan Zhuo wrote:
> >
> > On Mon, 17 Jun 2024 14:30:07 +0800, Jason Wang wrote:
> > > On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > The driver's tx napi is very important for XSK. It
On Tue, 18 Jun 2024 09:04:03 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 3:49 PM Xuan Zhuo wrote:
> >
> > On Mon, 17 Jun 2024 14:19:10 +0800, Jason Wang wrote:
> > > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > This patch implement the logic of bind/unbind xsk
On Tue, 18 Jun 2024 08:57:52 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 3:39 PM Xuan Zhuo wrote:
> >
> > On Mon, 17 Jun 2024 13:00:13 +0800, Jason Wang wrote:
> > > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > If the xsk is enabling, the xsk tx will share the
On Tue, 18 Jun 2024 09:00:56 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 3:41 PM Xuan Zhuo wrote:
> >
> > On Mon, 17 Jun 2024 14:28:05 +0800, Jason Wang wrote:
> > > On Mon, Jun 17, 2024 at 1:00 PM Jason Wang wrote:
> > > >
> > > > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > > > wrot
On Mon, Jun 17, 2024 at 4:08 PM Heng Qi wrote:
>
> On Mon, 17 Jun 2024 12:05:30 +0800, Jason Wang wrote:
> > On Thu, Jun 6, 2024 at 2:15 PM Heng Qi wrote:
> > >
> > > Currently, control vq handles commands synchronously,
> > > leading to increased delays for dim commands during multi-queue
> > >
On Tue, Jun 18, 2024 at 12:16 AM Michael S. Tsirkin wrote:
>
> On Mon, Jun 17, 2024 at 11:30:36AM +0200, Jiri Pirko wrote:
> > Mon, Jun 17, 2024 at 03:44:55AM CEST, jasow...@redhat.com wrote:
> > >On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin
> > >wrote:
> > >>
> > >> On Fri, Jun 07, 2024
On Mon, Jun 17, 2024 at 3:54 PM Xuan Zhuo wrote:
>
> On Mon, 17 Jun 2024 14:30:07 +0800, Jason Wang wrote:
> > On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo
> > wrote:
> > >
> > > The driver's tx napi is very important for XSK. It is responsible for
> > > obtaining data from the XSK queue and sendi
On Mon, Jun 17, 2024 at 3:49 PM Xuan Zhuo wrote:
>
> On Mon, 17 Jun 2024 14:19:10 +0800, Jason Wang wrote:
> > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > wrote:
> > >
> > > This patch implement the logic of bind/unbind xsk pool to sq and rq.
> > >
> > > Signed-off-by: Xuan Zhuo
> > > ---
>
On Mon, Jun 17, 2024 at 3:41 PM Xuan Zhuo wrote:
>
> On Mon, 17 Jun 2024 14:28:05 +0800, Jason Wang wrote:
> > On Mon, Jun 17, 2024 at 1:00 PM Jason Wang wrote:
> > >
> > > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > If the xsk is enabling, the xsk tx will share the
On Tue, Jun 18, 2024 at 8:57 AM Jason Wang wrote:
>
> On Mon, Jun 17, 2024 at 3:39 PM Xuan Zhuo wrote:
> >
> > On Mon, 17 Jun 2024 13:00:13 +0800, Jason Wang wrote:
> > > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > If the xsk is enabling, the xsk tx will share the se
On Mon, Jun 17, 2024 at 3:39 PM Xuan Zhuo wrote:
>
> On Mon, 17 Jun 2024 13:00:13 +0800, Jason Wang wrote:
> > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > wrote:
> > >
> > > If the xsk is enabling, the xsk tx will share the send queue.
> > > But the xsk requires that the send queue use the pr
On Mon, Jun 17, 2024 at 5:18 PM Jiri Pirko wrote:
>
> Mon, Jun 17, 2024 at 04:34:26AM CEST, jasow...@redhat.com wrote:
> >On Thu, Jun 13, 2024 at 1:09 AM Jiri Pirko wrote:
> >>
> >> From: Jiri Pirko
> >>
> >> Add support for Byte Queue Limits (BQL).
> >>
> >> Tested on qemu emulated virtio_net d
On Mon, Jun 17, 2024 at 5:30 PM Jiri Pirko wrote:
>
> Mon, Jun 17, 2024 at 03:44:55AM CEST, jasow...@redhat.com wrote:
> >On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin wrote:
> >>
> >> On Fri, Jun 07, 2024 at 01:30:34PM +0200, Jiri Pirko wrote:
> >> > Fri, Jun 07, 2024 at 12:23:37PM CEST, m
On Mon, Jun 17, 2024 at 5:15 PM Jiri Pirko wrote:
>
> Fri, Jun 14, 2024 at 11:54:04AM CEST, kerneljasonx...@gmail.com wrote:
> >Hello Jiri,
> >
> >On Thu, Jun 13, 2024 at 1:08 AM Jiri Pirko wrote:
> >>
> >> From: Jiri Pirko
> >>
> >> Add support for Byte Queue Limits (BQL).
> >>
> >> Tested on q
On Mon, Jun 17, 2024 at 11:30:36AM +0200, Jiri Pirko wrote:
> Mon, Jun 17, 2024 at 03:44:55AM CEST, jasow...@redhat.com wrote:
> >On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin wrote:
> >>
> >> On Fri, Jun 07, 2024 at 01:30:34PM +0200, Jiri Pirko wrote:
> >> > Fri, Jun 07, 2024 at 12:23:37PM
On Mon, Jun 17, 2024 at 09:44:55AM +0800, Jason Wang wrote:
> Probably, but do we need to define a bar here? Looking at git history,
> we didn't ask a full benchmark for a lot of commits that may touch
> performance.
There's no may here and we even got a report from a real user.
--
MST
On Wed, Jun 12, 2024 at 07:08:51PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Add support for Byte Queue Limits (BQL).
>
> Tested on qemu emulated virtio_net device with 1, 2 and 4 queues.
> Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is
> running in background. Netpe
Mon, Jun 17, 2024 at 03:15:23PM CEST, hen...@linux.alibaba.com wrote:
>In virtio spec 0.95, VIRTIO_NET_F_GUEST_CSUM was designed to handle
>partially checksummed packets, and the validation of fully checksummed
>packets by the device is independent of VIRTIO_NET_F_GUEST_CSUM
>negotiation. However,
Hello,
thanks for working on this! I have some minor thoughts.
On Fri, Jun 14, 2024 at 03:55:43PM +0200, Luigi Leonardi wrote:
> From: Marco Pinna
>
> This introduces an optimization in virtio_transport_send_pkt:
> when the work queue (send_pkt_queue) is empty the packet is
> put directly in th
The XDP program can't correctly handle partially checksummed
packets, but works fine with fully checksummed packets. If the
device has already validated fully checksummed packets, then
the driver doesn't need to re-validate them, saving CPU resources.
Additionally, the driver does not drop all par
This series of patches aim to address two specific issues identified in
the virtio_net driver related to checksum offloading and XDP processing of
fully checksummed packets.
The first patch corrects the handling of checksum offloading in the driver.
The second patch addresses an issue where the XD
In virtio spec 0.95, VIRTIO_NET_F_GUEST_CSUM was designed to handle
partially checksummed packets, and the validation of fully checksummed
packets by the device is independent of VIRTIO_NET_F_GUEST_CSUM
negotiation. However, the specification erroneously stated:
"If VIRTIO_NET_F_GUEST_CSUM is no
Mon, Jun 17, 2024 at 03:44:55AM CEST, jasow...@redhat.com wrote:
>On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin wrote:
>>
>> On Fri, Jun 07, 2024 at 01:30:34PM +0200, Jiri Pirko wrote:
>> > Fri, Jun 07, 2024 at 12:23:37PM CEST, m...@redhat.com wrote:
>> > >On Fri, Jun 07, 2024 at 11:57:37AM
Mon, Jun 17, 2024 at 04:34:26AM CEST, jasow...@redhat.com wrote:
>On Thu, Jun 13, 2024 at 1:09 AM Jiri Pirko wrote:
>>
>> From: Jiri Pirko
>>
>> Add support for Byte Queue Limits (BQL).
>>
>> Tested on qemu emulated virtio_net device with 1, 2 and 4 queues.
>> Tested with fq_codel and pfifo_fast.
Fri, Jun 14, 2024 at 11:54:04AM CEST, kerneljasonx...@gmail.com wrote:
>Hello Jiri,
>
>On Thu, Jun 13, 2024 at 1:08 AM Jiri Pirko wrote:
>>
>> From: Jiri Pirko
>>
>> Add support for Byte Queue Limits (BQL).
>>
>> Tested on qemu emulated virtio_net device with 1, 2 and 4 queues.
>> Tested with fq_
On Mon, 17 Jun 2024 12:05:30 +0800, Jason Wang wrote:
> On Thu, Jun 6, 2024 at 2:15 PM Heng Qi wrote:
> >
> > Currently, control vq handles commands synchronously,
> > leading to increased delays for dim commands during multi-queue
> > VM configuration and directly impacting dim performance.
> >
On Mon, 17 Jun 2024 15:10:48 +0800, Jason Wang wrote:
> On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote:
> >
> > The virtnet_xdp_handler() is re-used. But
> >
> > 1. We need to copy data to create skb for XDP_PASS.
> > 2. We need to call xsk_buff_free() to release the buffer.
> > 3. The handle fo
On Mon, 17 Jun 2024 14:30:07 +0800, Jason Wang wrote:
> On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo wrote:
> >
> > The driver's tx napi is very important for XSK. It is responsible for
> > obtaining data from the XSK queue and sending it out.
> >
> > At the beginning, we need to trigger tx napi.
>
On Mon, 17 Jun 2024 14:19:10 +0800, Jason Wang wrote:
> On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote:
> >
> > This patch implement the logic of bind/unbind xsk pool to sq and rq.
> >
> > Signed-off-by: Xuan Zhuo
> > ---
> > drivers/net/virtio_net.c | 201 +
On Mon, 17 Jun 2024 13:00:13 +0800, Jason Wang wrote:
> On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote:
> >
> > If the xsk is enabling, the xsk tx will share the send queue.
> > But the xsk requires that the send queue use the premapped mode.
> > So the send queue must support premapped mode whe
On Mon, 17 Jun 2024 14:28:05 +0800, Jason Wang wrote:
> On Mon, Jun 17, 2024 at 1:00 PM Jason Wang wrote:
> >
> > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo
> > wrote:
> > >
> > > If the xsk is enabling, the xsk tx will share the send queue.
> > > But the xsk requires that the send queue use the
On Mon, 17 Jun 2024 13:00:11 +0800, Jason Wang wrote:
> On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo wrote:
> >
> > Because the af-xdp and sq premapped mode will introduce two
> > new xmit type, so I refactor the xmit type mechanism first.
> >
> > We use the last two bits of the pointer to distingui
On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote:
>
> The virtnet_xdp_handler() is re-used. But
>
> 1. We need to copy data to create skb for XDP_PASS.
> 2. We need to call xsk_buff_free() to release the buffer.
> 3. The handle for xdp_buff is difference.
>
> If we pushed this logic into existing r
37 matches
Mail list logo
