On Wed, 12 Jun 2024 19:41:51 -0400, "Michael S. Tsirkin"
wrote:
> On Tue, Jun 11, 2024 at 07:41:40PM +0800, Xuan Zhuo wrote:
> > If the xsk is enabling, the xsk tx will share the send queue.
> > But the xsk requires that the send queue use the premapped mode.
> > So the send queue must support pr
On Wed, 12 Jun 2024 19:43:01 -0400, "Michael S. Tsirkin"
wrote:
> On Tue, Jun 11, 2024 at 07:41:41PM +0800, Xuan Zhuo wrote:
> > This patch implement the logic of bind/unbind xsk pool to sq and rq.
> >
> > Signed-off-by: Xuan Zhuo
>
> I'd just squash with previous patch. This one is hard to revi
On Wed, 12 Jun 2024 16:25:05 -0700, Jakub Kicinski wrote:
> On Tue, 11 Jun 2024 19:41:43 +0800 Xuan Zhuo wrote:
> > @@ -534,10 +534,13 @@ enum virtnet_xmit_type {
> > VIRTNET_XMIT_TYPE_SKB,
> > VIRTNET_XMIT_TYPE_XDP,
> > VIRTNET_XMIT_TYPE_DMA,
> > + VIRTNET_XMIT_TYPE_XSK,
>
> Again,
On Wed, 12 Jun 2024 16:23:37 -0700, Jakub Kicinski wrote:
> On Tue, 11 Jun 2024 19:41:40 +0800 Xuan Zhuo wrote:
> > +static int virtnet_sq_set_premapped(struct send_queue *sq, bool premapped)
>
> Could you try to add __maybe_unused or some such and then remove it
> in the patch which calls this fu
On Wed, 12 Jun 2024 16:20:11 -0700, Jakub Kicinski wrote:
> On Tue, 11 Jun 2024 19:41:33 +0800 Xuan Zhuo wrote:
> > +/**
> > + * virtqueue_dma_map_page_attrs - map DMA for _vq
> > + * @_vq: the struct virtqueue we're talking about.
> > + * @page: the page to do dma
> > + * @offset: the offset insi
On Wed, Jun 12, 2024 at 04:25:05PM -0700, Jakub Kicinski wrote:
> On Tue, 11 Jun 2024 19:41:43 +0800 Xuan Zhuo wrote:
> > @@ -534,10 +534,13 @@ enum virtnet_xmit_type {
> > VIRTNET_XMIT_TYPE_SKB,
> > VIRTNET_XMIT_TYPE_XDP,
> > VIRTNET_XMIT_TYPE_DMA,
> > + VIRTNET_XMIT_TYPE_XSK,
>
> A
On Tue, Jun 11, 2024 at 07:41:41PM +0800, Xuan Zhuo wrote:
> This patch implement the logic of bind/unbind xsk pool to sq and rq.
>
> Signed-off-by: Xuan Zhuo
I'd just squash with previous patch. This one is hard to review in
isolation.
> ---
> drivers/net/virtio_net.c | 199 ++
On Tue, Jun 11, 2024 at 07:41:40PM +0800, Xuan Zhuo wrote:
> If the xsk is enabling, the xsk tx will share the send queue.
> But the xsk requires that the send queue use the premapped mode.
> So the send queue must support premapped mode when it is bound to
> af-xdp.
>
> * virtnet_sq_set_premapped
On Tue, 11 Jun 2024 19:41:43 +0800 Xuan Zhuo wrote:
> @@ -534,10 +534,13 @@ enum virtnet_xmit_type {
> VIRTNET_XMIT_TYPE_SKB,
> VIRTNET_XMIT_TYPE_XDP,
> VIRTNET_XMIT_TYPE_DMA,
> + VIRTNET_XMIT_TYPE_XSK,
Again, would be great to avoid the transient warning (if it can be done
c
On Tue, 11 Jun 2024 19:41:40 +0800 Xuan Zhuo wrote:
> +static int virtnet_sq_set_premapped(struct send_queue *sq, bool premapped)
Could you try to add __maybe_unused or some such and then remove it
in the patch which calls this function? Having warnings during
bisection is not great.
On Tue, 11 Jun 2024 19:41:33 +0800 Xuan Zhuo wrote:
> +/**
> + * virtqueue_dma_map_page_attrs - map DMA for _vq
> + * @_vq: the struct virtqueue we're talking about.
> + * @page: the page to do dma
> + * @offset: the offset inside the page
> + * @size: the size of the page to do dma
> + * @dir: DMA
On Wed, Jun 12, 2024 at 07:08:51PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Add support for Byte Queue Limits (BQL).
>
> Tested on qemu emulated virtio_net device with 1, 2 and 4 queues.
> Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is
> running in background. Netpe
From: Jiri Pirko
Add support for Byte Queue Limits (BQL).
Tested on qemu emulated virtio_net device with 1, 2 and 4 queues.
Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is
running in background. Netperf TCP_RR results:
NOBQL FQC 1q: 159.56 159.33 158.50 154.31agv:
13 matches
Mail list logo
