Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-15 Thread Jason Wang
On Wed, May 15, 2024 at 8:54 PM Jiri Pirko wrote: > > Wed, May 15, 2024 at 12:12:51PM CEST, j...@resnulli.us wrote: > >Wed, May 15, 2024 at 10:20:04AM CEST, m...@redhat.com wrote: > >>On Wed, May 15, 2024 at 09:34:08AM +0200, Jiri Pirko wrote: > >>> Fri, May 10, 2024 at 01:27:08PM CEST, m...@redha

Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Jason Wang
On Thu, May 16, 2024 at 12:32 AM Daniel Jurgens wrote: > > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > Also changed the allocation to GFP_KERNEL. > > Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") > Reported-by: Eric Dumazet > Link: > https:

Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Michael S. Tsirkin
On Wed, May 15, 2024 at 11:31:25AM -0500, Daniel Jurgens wrote: > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > Also changed the allocation to GFP_KERNEL. > > Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") > Reported-by: Eric Dumazet > Link: >

Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Michael S. Tsirkin
On Wed, May 15, 2024 at 11:31:25AM -0500, Daniel Jurgens wrote: > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > Also changed the allocation to GFP_KERNEL. > > Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") > Reported-by: Eric Dumazet > Link: >

Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Eric Dumazet
On Wed, May 15, 2024 at 6:32 PM Daniel Jurgens wrote: > > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > Also changed the allocation to GFP_KERNEL. > > Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") > Reported-by: Eric Dumazet > Link: > https:/

Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Brett Creeley
On 5/15/2024 9:31 AM, Daniel Jurgens wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. The rtnl_lock would stay locked if allocating promisc_allmulti failed. Also changed the allocation to GFP_KERNEL.

[PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Daniel Jurgens
The rtnl_lock would stay locked if allocating promisc_allmulti failed. Also changed the allocation to GFP_KERNEL. Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") Reported-by: Eric Dumazet Link: https://lore.kernel.org/netdev/cann89ilazvaucvhpm6rpjj0owra_ofnx7fhc8d60gv-65

Re: [PATCH v2] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Eric Dumazet
On Wed, May 15, 2024 at 5:12 PM Daniel Jurgens wrote: > > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > > Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") > Reported-by: Eric Dumazet > Link: > https://lore.kernel.org/netdev/cann89ilazvaucvhpm6rp

[PATCH v2] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Daniel Jurgens
The rtnl_lock would stay locked if allocating promisc_allmulti failed. Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf") Reported-by: Eric Dumazet Link: https://lore.kernel.org/netdev/cann89ilazvaucvhpm6rpjj0owra_ofnx7fhc8d60gv-65ad...@mail.gmail.com/ Signed-off-by: Daniel

Re: [PATCH] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Michael S. Tsirkin
On Wed, May 15, 2024 at 09:31:20AM -0500, Daniel Jurgens wrote: > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > > Reported-by: Eric Dumazet > Link: > https://lore.kernel.org/netdev/cann89ilazvaucvhpm6rpjj0owra_ofnx7fhc8d60gv-65ad...@mail.gmail.com/ > Signed-off-by: Dan

[PATCH] virtio_net: Fix missed rtnl_unlock

2024-05-15 Thread Daniel Jurgens
The rtnl_lock would stay locked if allocating promisc_allmulti failed. Reported-by: Eric Dumazet Link: https://lore.kernel.org/netdev/cann89ilazvaucvhpm6rpjj0owra_ofnx7fhc8d60gv-65ad...@mail.gmail.com/ Signed-off-by: Daniel Jurgens --- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 inser

RE: [PATCH net-next v6 2/6] virtio_net: Remove command data from control_buf

2024-05-15 Thread Dan Jurgens
> From: Eric Dumazet > Sent: Wednesday, May 15, 2024 7:45 AM > To: Dan Jurgens > Cc: netdev@vger.kernel.org; m...@redhat.com; jasow...@redhat.com; > xuanz...@linux.alibaba.com; virtualizat...@lists.linux.dev; > da...@davemloft.net; k...@kernel.org; pab...@redhat.com; Jiri Pirko > > Subject: Re:

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-15 Thread Jiri Pirko
Wed, May 15, 2024 at 12:12:51PM CEST, j...@resnulli.us wrote: >Wed, May 15, 2024 at 10:20:04AM CEST, m...@redhat.com wrote: >>On Wed, May 15, 2024 at 09:34:08AM +0200, Jiri Pirko wrote: >>> Fri, May 10, 2024 at 01:27:08PM CEST, m...@redhat.com wrote: >>> >On Fri, May 10, 2024 at 01:11:49PM +0200, J

Re: [PATCH net-next v6 2/6] virtio_net: Remove command data from control_buf

2024-05-15 Thread Eric Dumazet
On Fri, May 3, 2024 at 10:25 PM Daniel Jurgens wrote: > > Allocate memory for the data when it's used. Ideally the struct could > be on the stack, but we can't DMA stack memory. With this change only > the header and status memory are shared between commands, which will > allow using a tighter loc

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-15 Thread Jiri Pirko
Wed, May 15, 2024 at 10:20:04AM CEST, m...@redhat.com wrote: >On Wed, May 15, 2024 at 09:34:08AM +0200, Jiri Pirko wrote: >> Fri, May 10, 2024 at 01:27:08PM CEST, m...@redhat.com wrote: >> >On Fri, May 10, 2024 at 01:11:49PM +0200, Jiri Pirko wrote: >> >> Fri, May 10, 2024 at 12:52:52PM CEST, m...@

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-15 Thread Michael S. Tsirkin
On Wed, May 15, 2024 at 09:34:08AM +0200, Jiri Pirko wrote: > Fri, May 10, 2024 at 01:27:08PM CEST, m...@redhat.com wrote: > >On Fri, May 10, 2024 at 01:11:49PM +0200, Jiri Pirko wrote: > >> Fri, May 10, 2024 at 12:52:52PM CEST, m...@redhat.com wrote: > >> >On Fri, May 10, 2024 at 12:37:15PM +0200,

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-15 Thread Jiri Pirko
Fri, May 10, 2024 at 01:27:08PM CEST, m...@redhat.com wrote: >On Fri, May 10, 2024 at 01:11:49PM +0200, Jiri Pirko wrote: >> Fri, May 10, 2024 at 12:52:52PM CEST, m...@redhat.com wrote: >> >On Fri, May 10, 2024 at 12:37:15PM +0200, Jiri Pirko wrote: >> >> Thu, May 09, 2024 at 04:28:12PM CEST, m...@