Re: [patch net-next v4 1/6] virtio: add debugfs infrastructure to allow to debug virtio features

2024-04-19 Thread kernel test robot
Hi Jiri, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Jiri-Pirko/virtio-add-debugfs-infrastructure-to-allow-to-debug-virtio-features/20240419-004913 base: net-next/main patch link

Re: [patch net-next v4 2/6] selftests: forwarding: move initial root check to the beginning

2024-04-19 Thread Jiri Pirko
Thu, Apr 18, 2024 at 08:48:20PM CEST, benjamin.poir...@gmail.com wrote: >On 2024-04-18 18:08 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This check can be done at the very beginning of the script. >> As the follow up patch needs to add early code that needs to be executed >> after the chec

Re: [PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-19 Thread Pavel Begunkov
On 4/19/24 12:08, Pavel Begunkov wrote: Please, don't take directly, conflicts with io_uring. When everyone is happy with the patches, Jens and Jakub will hopefully help to merge them. E.g. first staging net/ specific changes [1] and then handling all conflicts on the io_uring side. [1] https:

[PATCH io_uring-next/net-next v2 4/4] io_uring/notif: implement notification stacking

2024-04-19 Thread Pavel Begunkov
The network stack allows only one ubuf_info per skb, and unlike MSG_ZEROCOPY, each io_uring zerocopy send will carry a separate ubuf_info. That means that send requests can't reuse a previosly allocated skb and need to get one more or more of new ones. That's fine for large sends, but otherwise it

[PATCH io_uring-next/net-next v2 3/4] io_uring/notif: simplify io_notif_flush()

2024-04-19 Thread Pavel Begunkov
io_notif_flush() is partially duplicating io_tx_ubuf_complete(), so instead of duplicating it, make the flush call io_tx_ubuf_complete. Reviewed-by: Jens Axboe Signed-off-by: Pavel Begunkov --- io_uring/notif.c | 6 +++--- io_uring/notif.h | 9 +++-- 2 files changed, 6 insertions(+), 9 dele

[PATCH io_uring-next/net-next v2 2/4] net: add callback for setting a ubuf_info to skb

2024-04-19 Thread Pavel Begunkov
At the moment an skb can only have one ubuf_info associated with it, which might be a performance problem for zerocopy sends in cases like TCP via io_uring. Add a callback for assigning ubuf_info to skb, this way we will implement smarter assignment later like linking ubuf_info together. Note, it'

[PATCH io_uring-next/net-next v2 1/4] net: extend ubuf_info callback to ops structure

2024-04-19 Thread Pavel Begunkov
We'll need to associate additional callbacks with ubuf_info, introduce a structure holding ubuf_info callbacks. Apart from a more smarter io_uring notification management introduced in next patches, it can be used to generalise msg_zerocopy_put_abort() and also store ->sg_from_iter, which is curren

[PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-19 Thread Pavel Begunkov
Please, don't take directly, conflicts with io_uring. To have per request buffer notifications each zerocopy io_uring send request allocates a new ubuf_info. However, as an skb can carry only one uarg, it may force the stack to create many small skbs hurting performance in many ways. The patchset

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-19 Thread Xuan Zhuo
On Fri, 19 Apr 2024 16:12:15 +0800, Jason Wang wrote: > On Fri, Apr 19, 2024 at 3:28 PM Xuan Zhuo wrote: > > > > On Fri, 19 Apr 2024 15:24:25 +0800, Jason Wang wrote: > > > On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang >

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-19 Thread Jason Wang
On Fri, Apr 19, 2024 at 3:28 PM Xuan Zhuo wrote: > > On Fri, 19 Apr 2024 15:24:25 +0800, Jason Wang wrote: > > On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo > > wrote: > > > > > > On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang > > > wrote: > > > > On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo > >

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-19 Thread Xuan Zhuo
On Fri, 19 Apr 2024 15:24:25 +0800, Jason Wang wrote: > On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo wrote: > > > > On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang wrote: > > > On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 19 Apr 2024 08:43:43 +0800, Jason Wang

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-19 Thread Xuan Zhuo
On Fri, 19 Apr 2024 15:24:25 +0800, Jason Wang wrote: > On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo wrote: > > > > On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang wrote: > > > On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 19 Apr 2024 08:43:43 +0800, Jason Wang

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-19 Thread Jason Wang
On Fri, Apr 19, 2024 at 3:07 PM Xuan Zhuo wrote: > > On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang wrote: > > On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo > > wrote: > > > > > > On Fri, 19 Apr 2024 08:43:43 +0800, Jason Wang > > > wrote: > > > > On Thu, Apr 18, 2024 at 4:35 PM Xuan Zhuo > >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-19 Thread Xuan Zhuo
On Thu, 18 Apr 2024 22:19:33 +0200, Jesper Dangaard Brouer wrote: > > > On 17/04/2024 10.20, Xuan Zhuo wrote: > > On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote: > >> On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo > >> wrote: > >>> > >>> On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang > >>>

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-19 Thread Xuan Zhuo
On Fri, 19 Apr 2024 13:46:25 +0800, Jason Wang wrote: > On Fri, Apr 19, 2024 at 12:23 PM Xuan Zhuo wrote: > > > > On Fri, 19 Apr 2024 08:43:43 +0800, Jason Wang wrote: > > > On Thu, Apr 18, 2024 at 4:35 PM Xuan Zhuo > > > wrote: > > > > > > > > On Thu, 18 Apr 2024 14:25:06 +0800, Jason Wang