Re: [PATCH vhost v4 10/10] virtio_ring: virtqueue_set_dma_premapped support disable

2024-03-20 Thread Jason Wang
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote: > > Now, the API virtqueue_set_dma_premapped just support to > enable premapped mode. > > If we allow enabling the premapped dynamically, we should > make this API to support disable the premapped mode. > > Signed-off-by: Xuan Zhuo > --- > driver

Re: [PATCH vhost v4 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-20 Thread Jason Wang
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote: > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > multiple checks are made whether unmap is performed and whether it is > INDIRECT. > > These two functions are usually called in a loop, and we should put the > check outsi

Re: [PATCH vhost v4 03/10] virtio_ring: packed: structure the indirect desc table

2024-03-20 Thread Jason Wang
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote: > > This commit structure the indirect desc table. > Then we can get the desc num directly when doing unmap. > > And save the dma info to the struct, then the indirect > will not use the dma fields of the desc_extra. The subsequent > commits will m

Re: [PATCH vhost v4 00/10] virtio: drivers maintain dma info for premapped vq

2024-03-20 Thread Jason Wang
On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo wrote: > > As discussed: > > http://lore.kernel.org/all/cacgkmevq0no8qgc46u4mgsmtud44fd_cflcpavmj3rhyqrz...@mail.gmail.com > > If the virtio is premapped mode, the driver should manage the dma info by > self. > So the virtio core should not store the dma

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-20 Thread Xuan Zhuo
On Wed, 20 Mar 2024 20:38:01 -0700, Jakub Kicinski wrote: > On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > > I have a question regarding the workflow for feature discussions. If we > > consistently engage in discussions about a particular feature, this may > > result > > in the submission

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-20 Thread Jakub Kicinski
On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > I have a question regarding the workflow for feature discussions. If we > consistently engage in discussions about a particular feature, this may result > in the submission of multiple patch sets. In light of this, should we modify > the > usag

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-20 Thread Jiri Pirko
Wed, Mar 20, 2024 at 09:04:21AM CET, xuanz...@linux.alibaba.com wrote: >On Tue, 19 Mar 2024 11:12:23 +0100, Paolo Abeni wrote: >> On Mon, 2024-03-18 at 13:19 +0100, Jiri Pirko wrote: >> > Mon, Mar 18, 2024 at 12:53:38PM CET, xuanz...@linux.alibaba.com wrote: >> > > On Mon, 18 Mar 2024 12:52:18 +01

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-20 Thread Xuan Zhuo
Hope this in your list. Thanks.

Re: REGRESSION: RIP: 0010:skb_release_data+0xb8/0x1e0 in vhost/tun

2024-03-20 Thread Jason Wang
On Tue, Mar 19, 2024 at 9:15 PM Igor Raits wrote: > > Hello Stefan, > > On Tue, Mar 19, 2024 at 2:12 PM Stefan Hajnoczi wrote: > > > > On Tue, Mar 19, 2024 at 10:00:08AM +0100, Igor Raits wrote: > > > Hello, > > > > > > We have started to observe kernel crashes on 6.7.y kernels (atm we > > > have

Re: [PATCH vhost v4 00/10] virtio: drivers maintain dma info for premapped vq

2024-03-20 Thread Jason Wang
On Tue, Mar 19, 2024 at 2:56 PM Michael S. Tsirkin wrote: > > On Tue, Mar 12, 2024 at 11:35:47AM +0800, Xuan Zhuo wrote: > > As discussed: > > > > http://lore.kernel.org/all/cacgkmevq0no8qgc46u4mgsmtud44fd_cflcpavmj3rhyqrz...@mail.gmail.com > > > > If the virtio is premapped mode, the driver shoul

Re: [PATCH net-next v4 3/8] virtio_net: support device stats

2024-03-20 Thread Xuan Zhuo
On Tue, 19 Mar 2024 10:15:25 -0700, Jakub Kicinski wrote: > On Fri, 15 Mar 2024 16:05:40 +0800 Xuan Zhuo wrote: > > > Don't duplicate the stats which get reported via the netlink API in > > > ethtool. Similar story to the rtnl stats: > > > > > > https://docs.kernel.org/next/networking/statistics.h

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-20 Thread Xuan Zhuo
On Tue, 19 Mar 2024 11:12:23 +0100, Paolo Abeni wrote: > On Mon, 2024-03-18 at 13:19 +0100, Jiri Pirko wrote: > > Mon, Mar 18, 2024 at 12:53:38PM CET, xuanz...@linux.alibaba.com wrote: > > > On Mon, 18 Mar 2024 12:52:18 +0100, Jiri Pirko wrote: > > > > Mon, Mar 18, 2024 at 12:05:53PM CET, xuanz..