Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-18 Thread Rasmus Villemoes
On 18/04/2021 23.26, Christophe JAILLET wrote: > Improve 'create_workqueue', 'create_freezable_workqueue' and > 'create_singlethread_workqueue' so that they accept a format > specifier and a variable number of arguments. > > This will put these macros more in line with 'alloc_ordered_workqueue' an

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-18 Thread Lorenzo Bianconi
> On Sun, Apr 18, 2021 at 6:18 PM Jesper Dangaard Brouer > wrote: > > > > On Fri, 16 Apr 2021 16:27:18 +0200 > > Magnus Karlsson wrote: > > > > > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi > > > wrote: > > > > > > > > This series introduce XDP multi-buffer support. The mvneta driver is > >

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Kurt Kanzenbach
On Fri Apr 16 2021, Yangbo Lu wrote: > Optimization could be done on dsa_skb_tx_timestamp(), and dsa device > drivers should adapt to it. > > - Check SKBTX_HW_TSTAMP request flag at the very beginning, instead of in > port_txtstamp, so that most skbs not requiring tx timestamp just return. > > -

RE: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Alice Guo (OSS)
> -Original Message- > From: Leon Romanovsky > Sent: 2021年4月19日 13:02 > To: Alice Guo (OSS) > Cc: gre...@linuxfoundation.org; raf...@kernel.org; Horia Geanta > ; Aymen Sghaier ; > herb...@gondor.apana.org.au; da...@davemloft.net; t...@atomide.com; > geert+rene...@glider.be; mturque...@b

RE: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-18 Thread Alice Guo (OSS)
> -Original Message- > From: Dominique MARTINET > Sent: 2021年4月19日 12:49 > To: Alice Guo (OSS) > Cc: gre...@linuxfoundation.org; raf...@kernel.org; Horia Geanta > ; Aymen Sghaier ; > herb...@gondor.apana.org.au; da...@davemloft.net; t...@atomide.com; > geert+rene...@glider.be; mturque...

[PATCH V4 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-18 Thread Zhu Lingshan
get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan Reviewed-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/

[PATCH V4 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-18 Thread Zhu Lingshan
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan Reviewed-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++- drivers/vdpa/ifcvf/ifcvf_main.c | 19 ++- 2 files changed, 25 insertions(

[PATCH V4 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-18 Thread Zhu Lingshan
This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 1 + d

[PATCH V4 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk

2021-04-18 Thread Zhu Lingshan
This series enabled Intel FGPA SmartNIC C5000X-PL virtio-blk for vDPA. This series requires: Stefano's vdpa block patchset: https://lkml.org/lkml/2021/3/15/2113 my patchset to enable Intel FGPA SmartNIC C5000X-PL virtio-net for vDPA: https://lkml.org/lkml/2021/3/17/432 changes from V3: remove (pd

Re: [Resend RFC PATCH V2 07/12] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM

2021-04-18 Thread Christoph Hellwig
On Thu, Apr 15, 2021 at 04:24:15PM -0400, Konrad Rzeszutek Wilk wrote: > So you are exposing these two: > EXPORT_SYMBOL_GPL(get_vm_area); > EXPORT_SYMBOL_GPL(ioremap_page_range); > > But if you used vmap wouldn't you get the same thing for free? Yes, this needs to go into some vmap version, pre

Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-18 Thread Marion et Christophe JAILLET
  > Message du 19/04/21 01:03 > De : "Bart Van Assche" > A : "Christophe JAILLET" , t...@kernel.org, jiangshan...@gmail.com, > sae...@nvidia.com, l...@kernel.org, da...@davemloft.net, k...@kernel.org, > "Tejun Heo" > Copie à : netdev@vger.kernel.org, linux-r...@vger.kernel.org, > linux-ker...

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-18 Thread Christoph Hellwig
On Fri, Apr 16, 2021 at 04:27:55PM +0100, Matthew Wilcox wrote: > On Thu, Apr 15, 2021 at 08:08:32PM +0200, Jesper Dangaard Brouer wrote: > > See below patch. Where I swap32 the dma address to satisfy > > page->compound having bit zero cleared. (It is the simplest fix I could > > come up with). >

Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC

2021-04-18 Thread Bjørn Mork
Ilya Lipnitskiy writes: > Add missing binding documentation for SoC support that has been in place > since v5.1 > > Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet > hardware") > Cc: Bjørn Mork > Signed-off-by: Ilya Lipnitskiy > --- > Documentation/devicetree/bindin

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-18 Thread Magnus Karlsson
On Sun, Apr 18, 2021 at 6:18 PM Jesper Dangaard Brouer wrote: > > On Fri, 16 Apr 2021 16:27:18 +0200 > Magnus Karlsson wrote: > > > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi wrote: > > > > > > This series introduce XDP multi-buffer support. The mvneta driver is > > > the first to support t

Re: [PATCH net-next 1/2] nexthop: Restart nexthop dump based on last dumped nexthop identifier

2021-04-18 Thread Ido Schimmel
On Sun, Apr 18, 2021 at 10:06:41AM -0700, David Ahern wrote: > On 4/16/21 8:55 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Currently, a multi-part nexthop dump is restarted based on the number of > > nexthops that have been dumped so far. This can result in a lot of > > nexthops not be

Re: [PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-18 Thread Ilias Apalodimas
On Wed, Apr 14, 2021 at 01:09:47PM -0700, Shakeel Butt wrote: > On Wed, Apr 14, 2021 at 12:42 PM Jesper Dangaard Brouer > wrote: > > > [...] > > > > > > > > Can this page_pool be used for TCP RX zerocopy? If yes then PageType > > > > can not be used. > > > > > > Yes it can, since it's going to be

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Dominique MARTINET
Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:22PM +0800: > From: Alice Guo > > Update all the code that use soc_device_match A single patch might be difficult to accept for all components, a each maintainer will probably want to have a say on their subsystem? I would suggest to split the

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Leon Romanovsky
On Mon, Apr 19, 2021 at 12:27:22PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- > drivers/bus/ti-sysc.c | 2 +- >

Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-18 Thread Dominique MARTINET
First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/v...@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021

[RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-18 Thread Alice Guo (OSS)
From: Alice Guo Update all the code that use soc_device_match because add support for soc_device_match returning -EPROBE_DEFER. Signed-off-by: Alice Guo --- drivers/bus/ti-sysc.c | 2 +- drivers/clk/renesas/r8a7795-cpg-mssr.c| 4 +++- drivers/clk/renesas/rcar-

[RFC v1 PATCH 2/3] caam: add defer probe when the caam driver cannot identify SoC

2021-04-18 Thread Alice Guo (OSS)
From: Alice Guo When imx8_soc_info_driver uses module_platform_driver() to regitser itself, the caam driver cannot identify the SoC in the machine because the SoC driver is probed later, so that add return -EPROBE_DEFER. Signed-off-by: Alice Guo --- drivers/crypto/caam/ctrl.c | 3 +++ 1 file c

[RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-18 Thread Alice Guo (OSS)
From: Alice Guo In i.MX8M boards, the registration of SoC device is later than caam driver which needs it. Caam driver needs soc_device_match to provide -EPROBE_DEFER when no SoC device is registered and no early_soc_dev_attr. Signed-off-by: Alice Guo --- drivers/base/soc.c | 5 + 1 file c

[RFC v1 PATCH 0/3] support soc_device_match to return -EPROBE_DEFER

2021-04-18 Thread Alice Guo (OSS)
From: Alice Guo In patch "soc: imx8m: change to use platform driver", change soc-imx8m.c to use module platform driver and use NVMEM APIs to ocotp register, the reason is that directly reading ocotp egister causes kexec kernel hang because kernel will disable unused clks after kernel boots up. Th

[PATCH net-next 2/2] net: ethernet: mediatek: support custom GMAC label

2021-04-18 Thread Ilya Lipnitskiy
The MAC device name can now be set within DTS file instead of always being "ethX". This is helpful for DSA to clearly label the DSA master device and distinguish it from DSA slave ports. For example, some devices, such as the Ubiquiti EdgeRouter X, may have ports labeled ethX. Labeling the master

[PATCH net-next 1/2] dt-bindings: net: mediatek: add optional GMAC labels

2021-04-18 Thread Ilya Lipnitskiy
Document the mediatek ethernet driver change that adds support for custom labels and provide an example. Signed-off-by: Ilya Lipnitskiy --- Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/media

[PATCH net-next 0/2] net: ethernet: mediatek: support custom GMAC label

2021-04-18 Thread Ilya Lipnitskiy
Add support for specifying GMAC label via DTS. Useful when it is desired to use a master DSA interface name that is different from the "eth%d" pattern. Ilya Lipnitskiy (2): dt-bindings: net: mediatek: add optional GMAC labels net: ethernet: mediatek: support custom GMAC label Documentation/d

[PATCH] dt-bindings: net: mediatek: support MT7621 SoC

2021-04-18 Thread Ilya Lipnitskiy
Add missing binding documentation for SoC support that has been in place since v5.1 Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware") Cc: Bjørn Mork Signed-off-by: Ilya Lipnitskiy --- Documentation/devicetree/bindings/net/mediatek-net.txt | 1 + 1 file chang

Re: [PATCH V3 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-18 Thread Jason Wang
在 2021/4/16 下午3:16, Zhu Lingshan 写道: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

Re: [PATCH V3 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-18 Thread Jason Wang
在 2021/4/16 下午3:16, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++- drivers/vdpa/ifcvf/ifcvf_main.c | 19 ++- 2 files change

Re: [PATCH V3 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-18 Thread Jason Wang
在 2021/4/16 下午3:16, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan ---

Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-18 Thread Jason Wang
在 2021/4/16 下午5:16, Xuan Zhuo 写道: In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. Here, if the payload of the received packag

Re: [PATCH net-next v4 09/10] virtio-net: xsk zero copy xmit implement wakeup and xmit

2021-04-18 Thread Jason Wang
在 2021/4/16 下午2:29, Xuan Zhuo 写道: On Fri, 16 Apr 2021 13:35:33 +0800, Jason Wang wrote: 在 2021/4/15 下午6:27, Xuan Zhuo 写道: On Wed, 14 Apr 2021 13:46:45 +0800, Jason Wang wrote: 在 2021/4/13 上午11:15, Xuan Zhuo 写道: This patch implements the core part of xsk zerocopy xmit. When the user calls

Re: [PATCH] net: fix a data race when get vlan device

2021-04-18 Thread Yunsheng Lin
On 2021/4/17 20:33, zhudi (J) wrote: >> On 2021/4/16 11:27, zhudi (J) wrote: dependencyOn 2021/4/15 11:35, zhudi wrote: > From: Di Zhu > > We encountered a crash: in the packet receiving process, we got an > illegal VLAN device address, but the VLAN device address saved in >>>

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-18 Thread Yunsheng Lin
On 2021/4/19 6:59, Michal Kubecek wrote: > On Thu, Mar 25, 2021 at 11:13:11AM +0800, Yunsheng Lin wrote: >> Lockless qdisc has below concurrent problem: >> cpu0 cpu1 >> . . >> q->enqueue . >> . . >> qdisc_run_begi

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-18 Thread Larry Finger
On 4/18/21 7:32 PM, Pkshih wrote: -Original Message- From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name] Sent: Sunday, April 18, 2021 2:08 AM To: Pkshih Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; johan...@sipsolutions.net; kv...@

drivers/net/ethernet/mediatek/mtk_ppe_offload.c - suspicious code?

2021-04-18 Thread Valdis Klētnieks
While doing some code auditing for -Woverride_init, I spotted some questionable code commit 502e84e2382d92654a2ecbc52cdbdb5a11cdcec7 Author: Felix Fietkau Date: Wed Mar 24 02:30:54 2021 +0100 net: ethernet: mtk_eth_soc: add flow offloading support In drivers/net/ethernet/mediatek/mtk_ppe

RE: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-04-18 Thread Dongseok Yi
On Sat, Apr 17, 2021 at 11:44:35AM +0800, Yunsheng Lin wrote: > > On 2021/1/6 11:32, Dongseok Yi wrote: > > On 2021-01-06 12:07, Willem de Bruijn wrote: > >> > >> On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > >>> > >>> On 2021-01-05 06:03, Willem de Bruijn wrote: > > On Mon, Jan 4

RE: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-18 Thread Pkshih
> -Original Message- > From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name] > Sent: Sunday, April 18, 2021 2:08 AM > To: Pkshih > Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; > johan...@sipsolutions.net; kv...@codeaurora.org; Larry F

Re: [PATCH net-next v2 8/9] bnxt: implement ethtool standard stats

2021-04-18 Thread Michael Chan
On Fri, Apr 16, 2021 at 12:27 PM Jakub Kicinski wrote: > > Most of the names seem to strongly correlate with names from > the standard and RFC. Whether ..+good_frames are indeed Frames..OK > I'm the least sure of. The mapping looks correct to me. These counters can also be mapped: rx_fcs_err_fr

Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-18 Thread Bart Van Assche
On 4/18/21 2:26 PM, Christophe JAILLET wrote: > Improve 'create_workqueue', 'create_freezable_workqueue' and > 'create_singlethread_workqueue' so that they accept a format > specifier and a variable number of arguments. > > This will put these macros more in line with 'alloc_ordered_workqueue' and

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-18 Thread Michal Kubecek
On Thu, Mar 25, 2021 at 11:13:11AM +0800, Yunsheng Lin wrote: > Lockless qdisc has below concurrent problem: > cpu0 cpu1 > . . > q->enqueue . > . . > qdisc_run_begin() . > . . > d

Re: [PATCH] bpf: fix errno code for unsupported batch ops

2021-04-18 Thread Alexei Starovoitov
On Sun, Apr 18, 2021 at 1:03 PM Pedro Tammela wrote: > > ENOTSUPP is not a valid userland errno[1], which is annoying for > userland applications that implement a fallback to iterative, report > errors via 'strerror()' or both. > > The batched ops return this errno whenever an operation > is not i

[PATCH v6 net-next 09/10] net: korina: Make driver COMPILE_TESTable

2021-04-18 Thread Thomas Bogendoerfer
Move structs/defines for ethernet/dma register into driver, since they are only used for this driver and remove any MIPS specific includes. This makes it possible to COMPILE_TEST the driver. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 2 +- drivers/net/ethernet/korin

[PATCH v6 net-next 10/10] dt-bindings: net: korina: Add DT bindings for IDT 79RC3243x SoCs

2021-04-18 Thread Thomas Bogendoerfer
Add device tree bindings for ethernet controller integrated into IDT 79RC3243x SoCs. Signed-off-by: Thomas Bogendoerfer --- .../bindings/net/idt,3243x-emac.yaml | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/idt,3243x

[PATCH v6 net-next 08/10] net: korina: Get mdio input clock via common clock framework

2021-04-18 Thread Thomas Bogendoerfer
With device tree clock is provided via CCF. For non device tree use a maximum clock value to not overclock the PHY. The non device tree usage will go away after platform is converted to DT. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 21 +++-- 1 file ch

[PATCH v6 net-next 06/10] net: korina: Only pass mac address via platform data

2021-04-18 Thread Thomas Bogendoerfer
Get rid of access to struct korina_device by just passing the mac address via platform data and use drvdata for passing netdev to remove function. Signed-off-by: Thomas Bogendoerfer --- arch/mips/rb532/devices.c | 5 +++-- drivers/net/ethernet/korina.c | 11 ++- 2 files changed, 9 i

[PATCH v6 net-next 04/10] net: korina: Remove nested helpers

2021-04-18 Thread Thomas Bogendoerfer
Remove helpers, which are only used in one call site. Reviewed-by: Andrew Lunn Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ether

[PATCH v6 net-next 07/10] net: korina: Add support for device tree

2021-04-18 Thread Thomas Bogendoerfer
If there is no mac address passed via platform data try to get it via device tree and fall back to a random mac address, if all fail. Signed-off-by: Thomas Bogendoerfer --- arch/mips/rb532/devices.c | 20 +--- drivers/net/ethernet/korina.c | 32 +--

[PATCH v6 net-next 05/10] net: korina: Use DMA API

2021-04-18 Thread Thomas Bogendoerfer
Instead of messing with MIPS specific macros use DMA API for mapping descriptors and skbs. Reviewed-by: Andrew Lunn Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 158 +- 1 file changed, 98 insertions(+), 60 deletions(-) diff --git a/driv

[PATCH v6 net-next 02/10] net: korina: Use devres functions

2021-04-18 Thread Thomas Bogendoerfer
Simplify probe/remove code by using devm_ functions. Reviewed-by: Andrew Lunn Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 64 --- 1 file changed, 21 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/ne

[PATCH v6 net-next 03/10] net: korina: Remove not needed cache flushes

2021-04-18 Thread Thomas Bogendoerfer
Descriptors are mapped uncached so there is no need to do any cache handling for them. Reviewed-by: Andrew Lunn Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/kori

[PATCH v6 net-next 00/10] net: Korina improvements

2021-04-18 Thread Thomas Bogendoerfer
While converting Mikrotik RB532 support to use device tree I stumbled over the korina ethernet driver, which used way too many MIPS specific hacks. This series cleans this all up and adds support for device tree. Changes in v6: - remove korina from resource names and adapt DT binding to it - rem

[PATCH v6 net-next 01/10] net: korina: Fix MDIO functions

2021-04-18 Thread Thomas Bogendoerfer
Fixed MDIO functions to work reliable and not just by accident. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/korina.c | 56 +++ 2 files changed, 38 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethern

linux-next: Fixes tag needs some work in the net-next tree

2021-04-18 Thread Stephen Rothwell
Hi all, In commit 0e672f306a28 ("veth: check for NAPI instead of xdp_prog before xmit of XDP frame") Fixes tag Fixes: 6788fa154546 ("veth: allow enabling NAPI even without XDP") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: d3256efd8e8b ("veth: allow enabl

Re: [PATCH] net/mlx5: Use kasprintf instead of hand-writing it

2021-04-18 Thread Christophe JAILLET
Le 18/04/2021 à 22:03, Bart Van Assche a écrit : On 4/17/21 12:16 AM, Christophe JAILLET wrote: 'kasprintf()' can replace a kmalloc/strcpy/strcat sequence. It is less verbose and avoid the use of a magic number (64). Anyway, the underlying 'alloc_workqueue()' would only keep the 24 first chars

[PATCH 2/2] net/mlx5: Simplify workqueue name creation

2021-04-18 Thread Christophe JAILLET
There is no need to explicitly allocate, populate and free some memory just to pass a workqueue name to 'create_singlethread_workqueue()'. This macro can do all this for us, so keep the code simple. Signed-off-by: Christophe JAILLET --- A similar patch has also been sent. It was replacing the km

[PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-18 Thread Christophe JAILLET
Improve 'create_workqueue', 'create_freezable_workqueue' and 'create_singlethread_workqueue' so that they accept a format specifier and a variable number of arguments. This will put these macros more in line with 'alloc_ordered_workqueue' and the underlying 'alloc_workqueue()' function. This will

[PATCH 0/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-18 Thread Christophe JAILLET
Improve 'create_workqueue', 'create_freezable_workqueue' and 'create_singlethread_workqueue' so that they accept a format specifier and a variable number of arguments. This will put these macros more in line with 'alloc_ordered_workqueue' and the underlying 'alloc_workqueue()' function. This will

[PATCH net-next 3/3] net: ethernet: mtk_eth_soc: handle VLAN pop action

2021-04-18 Thread Pablo Neira Ayuso
Do not hit EOPNOTSUPP when flowtable offload provides a VLAN pop action. Fixes: efce49dfe6a8 ("netfilter: flowtable: add vlan pop action offload support") Signed-off-by: Pablo Neira Ayuso --- efce49dfe6a8 is coming in the nf-next PR for net-next. drivers/net/ethernet/mediatek/mtk_ppe_offload.c

[PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-18 Thread Pablo Neira Ayuso
Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and stats to different workqueues") splits the workqueue per event type. Add a mutex to serialize updates. Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support") Reported-by: Frank Wunderlich Signed-off-

[PATCH net-next 0/3] mtk_ppe_offload fixes

2021-04-18 Thread Pablo Neira Ayuso
Hi, A few incremental fixes for the initial flowtable offload support and this driver: 1) Fix undefined reference to `dsa_port_from_netdev' due to missing dependencies in Kconfig, reported by Kbuild robot. 2) Missing mutex to serialize flow events via workqueue to the driver. 3) Handle FLOW_

[PATCH net-next 1/3] net: ethernet: mtk_eth_soc: fix undefined reference to `dsa_port_from_netdev'

2021-04-18 Thread Pablo Neira Ayuso
Caused by: CONFIG_NET_DSA=m CONFIG_NET_MEDIATEK_SOC=y mtk_ppe_offload.c:undefined reference to `dsa_port_from_netdev' Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support") Reported-by: kernel test robot Signed-off-by: Pablo Neira Ayuso --- drivers/net/ethernet/medi

[PATCH net-next 14/14] netfilter: nftables: counter hardware offload support

2021-04-18 Thread Pablo Neira Ayuso
This patch adds the .offload_stats operation to synchronize hardware stats with the expression data. Update the counter expression to use this new interface. The hardware stats are retrieved from the netlink dump path via FLOW_CLS_STATS command to the driver. Signed-off-by: Pablo Neira Ayuso ---

[PATCH net-next 13/14] selftests: fib_tests: Add test cases for interaction with mangling

2021-04-18 Thread Pablo Neira Ayuso
From: Ido Schimmel Test that packets are correctly routed when netfilter mangling rules are present. Without previous patch: # ./fib_tests.sh -t ipv4_mangle IPv4 mangling tests TEST: Connection with correct parameters[ OK ] TEST: Connection with inco

[PATCH net-next 11/14] netfilter: nftables_offload: special ethertype handling for VLAN

2021-04-18 Thread Pablo Neira Ayuso
The nftables offload parser sets FLOW_DISSECTOR_KEY_BASIC .n_proto to the ethertype field in the ethertype frame. However: - FLOW_DISSECTOR_KEY_BASIC .n_proto field always stores either IPv4 or IPv6 ethertypes. - FLOW_DISSECTOR_KEY_VLAN .vlan_tpid stores either the 802.1q and 802.1ad ethertype

[PATCH net-next 09/14] netfilter: nft_payload: fix C-VLAN offload support

2021-04-18 Thread Pablo Neira Ayuso
- add another struct flow_dissector_key_vlan for C-VLAN - update layer 3 dependency to allow to match on IPv4/IPv6 Fixes: 89d8fd44abfb ("netfilter: nft_payload: add C-VLAN offload support") Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables_offload.h | 1 + net/netfilter/nft_pa

[PATCH net-next 10/14] netfilter: nftables_offload: VLAN id needs host byteorder in flow dissector

2021-04-18 Thread Pablo Neira Ayuso
The flow dissector representation expects the VLAN id in host byteorder. Add the NFT_OFFLOAD_F_NETWORK2HOST flag to swap the bytes from nft_cmp. Fixes: a82055af5959 ("netfilter: nft_payload: add VLAN offload support") Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables_offload.h

[PATCH net-next 12/14] netfilter: Dissect flow after packet mangling

2021-04-18 Thread Pablo Neira Ayuso
From: Ido Schimmel Netfilter tries to reroute mangled packets as a different route might need to be used following the mangling. When this happens, netfilter does not populate the IP protocol, the source port and the destination port in the flow key. Therefore, FIB rules that match on these field

[PATCH net-next 04/14] netfilter: conntrack: move autoassign_helper sysctl to net_generic data

2021-04-18 Thread Pablo Neira Ayuso
From: Florian Westphal While at it, make it an u8, no need to use an integer for a boolean. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_conntrack.h| 1 + net/netfilter/nf_conntrack_helper.c | 6 -- net/netfilter/nf_conntrack_standa

[PATCH net-next 02/14] netfilter: flowtable: add vlan pop action offload support

2021-04-18 Thread Pablo Neira Ayuso
From: wenxu This patch adds vlan pop action offload in the flowtable offload. Signed-off-by: wenxu Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_flow_table_offload.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfi

[PATCH net-next 07/14] netfilter: conntrack: convert sysctls to u8

2021-04-18 Thread Pablo Neira Ayuso
From: Florian Westphal log_invalid sysctl allows values of 0 to 255 inclusive so we no longer need a range check: the min/max values can be removed. This also removes all member variables that were moved to net_generic data in previous patches. This reduces size of netns_ct struct by one cache

[PATCH net-next 01/14] netfilter: flowtable: add vlan match offload support

2021-04-18 Thread Pablo Neira Ayuso
From: wenxu This patch adds support for vlan_id, vlan_priority and vlan_proto match for flowtable offload. Signed-off-by: wenxu Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_flow_table.h | 2 ++ net/netfilter/nf_flow_table_offload.c | 37 +++ 2 files c

[PATCH net-next 08/14] netfilter: flowtable: Add FLOW_OFFLOAD_XMIT_UNSPEC xmit type

2021-04-18 Thread Pablo Neira Ayuso
From: Roi Dayan It could be xmit type was not set and would default to FLOW_OFFLOAD_XMIT_NEIGH and in this type the gc expect to have a route info. Fix that by adding FLOW_OFFLOAD_XMIT_UNSPEC which defaults to 0. Fixes: 8b9229d15877 ("netfilter: flowtable: dst_check() from garbage collector pat

[PATCH net-next 06/14] netfilter: conntrack: move ct counter to net_generic data

2021-04-18 Thread Pablo Neira Ayuso
From: Florian Westphal Its only needed from slowpath (sysctl, ctnetlink, gc worker) and when a new conntrack object is allocated. Furthermore, each write dirties the otherwise read-mostly pernet data in struct net.ct, which are accessed from packet path. Move it to the net_generic data. This m

[PATCH net-next 05/14] netfilter: conntrack: move expect counter to net_generic data

2021-04-18 Thread Pablo Neira Ayuso
From: Florian Westphal Creation of a new conntrack entry isn't a frequent operation (compared to 'ct entry already exists'). Creation of a new entry that is also an expected (related) connection even less so. Place this counter in net_generic data. A followup patch will also move the conntrack

[PATCH net-next 03/14] netfilter: conntrack: move autoassign warning member to net_generic data

2021-04-18 Thread Pablo Neira Ayuso
From: Florian Westphal Not accessed in fast path, place this is generic_net data instead. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_conntrack.h | 4 net/netfilter/nf_conntrack_helper.c | 9 ++--- 2 files changed, 10 insertions(+),

[PATCH net-next 00/14] Netfilter updates for net-next

2021-04-18 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter updates for net-next: 1) Add vlan match and pop actions to the flowtable offload, patches from wenxu. 2) Reduce size of the netns_ct structure, which itself is embedded in struct net Make netns_ct a read-mostly structure. Patches from Floria

Re: [PATCH] net/mlx5: Use kasprintf instead of hand-writing it

2021-04-18 Thread Bart Van Assche
On 4/17/21 12:16 AM, Christophe JAILLET wrote: > 'kasprintf()' can replace a kmalloc/strcpy/strcat sequence. > It is less verbose and avoid the use of a magic number (64). > > Anyway, the underlying 'alloc_workqueue()' would only keep the 24 first > chars (i.e. sizeof(struct workqueue_struct->name

[PATCH] bpf: fix errno code for unsupported batch ops

2021-04-18 Thread Pedro Tammela
ENOTSUPP is not a valid userland errno[1], which is annoying for userland applications that implement a fallback to iterative, report errors via 'strerror()' or both. The batched ops return this errno whenever an operation is not implemented for kernels that implement batched ops. In older kernel

Re: [PATCH v2 3/6] kunit: ext4: adhear to KUNIT formatting standard

2021-04-18 Thread Theodore Ts'o
On Wed, Apr 14, 2021 at 04:58:06AM -0400, Nico Pache wrote: > Drop 'S' from end of CONFIG_EXT4_KUNIT_TESTS inorder to adhear to the KUNIT > *_KUNIT_TEST config name format. Another spelling nit, that should be "in order". This will break people who have existing .kunitconfig files, but if we are

Re: [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-18 Thread Theodore Ts'o
On Wed, Apr 14, 2021 at 04:58:03AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. The word "standard" seems to be over-stating things. The docum

[PATCH] net: ethernet: ixp4xx: Set the DMA masks explicitly

2021-04-18 Thread Linus Walleij
The former fix only papered over the actual problem: the ethernet core expects the netdev .dev member to have the proper DMA masks set, or there will be BUG_ON() triggered in kernel/dma/mapping.c. Fix this by simply copying dma_mask and dma_mask_coherent from the parent device. Fixes: e45d0fad4a5

Re: Different behavior wrt VRF and no VRF - packet Tx

2021-04-18 Thread David Ahern
On 4/15/21 8:57 PM, Bala Sajja wrote: >please find the ip link show output(for ifindex) and ping and > its corresponding perf fib events output. OIF seems MGMT(ifindex 5) > always, not enslaved interfaces ? that is the reason it does not work.

Re: [PATCH iproute2] ip: drop 2-char command assumption

2021-04-18 Thread David Ahern
On 4/17/21 8:49 PM, Tony Ambardar wrote: > The 'ip' utility hardcodes the assumption of being a 2-char command, where > any follow-on characters are passed as an argument: > > $ ./ip-full help > Object "-full" is unknown, try "ip help". > > This confusing behaviour isn't seen with 'tc' for ex

Re: [PATCH net-next 2/2] selftests: fib_nexthops: Test large scale nexthop flushing

2021-04-18 Thread David Ahern
On 4/16/21 8:55 AM, Ido Schimmel wrote: > From: Ido Schimmel > > Test that all the nexthops are flushed when a multi-part nexthop dump is > required for the flushing. > > Without previous patch: > > # ./fib_nexthops.sh > TEST: Large scale nexthop flushing [FAI

Re: [PATCH net-next 1/2] nexthop: Restart nexthop dump based on last dumped nexthop identifier

2021-04-18 Thread David Ahern
On 4/16/21 8:55 AM, Ido Schimmel wrote: > From: Ido Schimmel > > Currently, a multi-part nexthop dump is restarted based on the number of > nexthops that have been dumped so far. This can result in a lot of > nexthops not being dumped when nexthops are simultaneously deleted: > > # ip nexthop |

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-18 Thread Jesper Dangaard Brouer
On Fri, 16 Apr 2021 16:27:18 +0200 Magnus Karlsson wrote: > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi wrote: > > > > This series introduce XDP multi-buffer support. The mvneta driver is > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > please focus on how thes

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimir Oltean wrote: > > How about not passing "clone" back to DSA as an argument by reference, > but instead require the driver to populate DSA_SKB_CB(skb)->clone if it > needs to do so? > > Also, how about changing the return type to void? Returning t

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
On Fri, Apr 16, 2021 at 08:36:53PM +0800, Yangbo Lu wrote: > @@ -628,9 +620,7 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, > struct net_device *dev) > > DSA_SKB_CB(skb)->clone = NULL; > > - /* Identify PTP protocol packets, clone them, and pass them to the > - * swi

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
On Fri, Apr 16, 2021 at 08:36:53PM +0800, Yangbo Lu wrote: > Optimization could be done on dsa_skb_tx_timestamp(), and dsa device > drivers should adapt to it. > > - Check SKBTX_HW_TSTAMP request flag at the very beginning, instead of in > port_txtstamp, so that most skbs not requiring tx timest

Re: [PATCH RESEND net-next] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-18 Thread Jonathon Reinhart
Hi Dave, It looks like this patch is on "net", "net-next", and Linus' tree (as commit 97684f0970f6). Additionally, gregkh has queued it up for the 5.10 and 5.11 stable trees. But it still shows up in Patchwork as "Needs ACK". Is there anything I need to do? Thanks, Jonathon

Re: PROBLEM: DoS Attack on Fragment Cache

2021-04-18 Thread Matt Corallo
Should the default, though, be so low? If someone is still using a old modem they can crank up the sysctl, it does seem like such things are pretty rare these days :). Its rather trivial to, without any kind of attack, hit 1Mbps of lost fragments in today's networks, at which point all fragments

[PATCH rdma-next 0/2] Two fixes to -next

2021-04-18 Thread Leon Romanovsky
From: Leon Romanovsky The two fixes are targeted to the -next. Maor's change fixes DM code that was accepted in this cycle and Parav's change doesn't qualify urgency of -rc8. Thanks Maor Gottlieb (1): RDMA/mlx5: Fix type assignment for ICM DM Parav Pandit (1): IB/mlx5: Set right RoCE l3 ty

[PATCH mlx5-next 1/2] IB/mlx5: Set right RoCE l3 type and roce version while deleting GID

2021-04-18 Thread Leon Romanovsky
From: Parav Pandit Currently when GID is deleted, it zero out all the fields of the RoCE address in the SET_ROCE_ADDRESS command for a specified index. roce_version = 0 means RoCEv1 in the SET_ROCE_ADDRESS command. This assumes that device has RoCEv1 always enabled which is not always correct.

Re: [PATCH iproute2] rdma: stat: fix return code

2021-04-18 Thread Leon Romanovsky
On Sun, Apr 18, 2021 at 02:56:30PM +0200, Andrea Claudi wrote: > libmnl defines MNL_CB_OK as 1 and MNL_CB_ERROR as -1. rdma uses these > return codes, and stat_qp_show_parse_cb() should do the same. > > Fixes: 16ce4d23661a ("rdma: stat: initialize ret in stat_qp_show_parse_cb()") > Reported-by: Le

[PATCH iproute2] rdma: stat: fix return code

2021-04-18 Thread Andrea Claudi
libmnl defines MNL_CB_OK as 1 and MNL_CB_ERROR as -1. rdma uses these return codes, and stat_qp_show_parse_cb() should do the same. Fixes: 16ce4d23661a ("rdma: stat: initialize ret in stat_qp_show_parse_cb()") Reported-by: Leon Romanovsky Signed-off-by: Andrea Claudi --- rdma/stat.c | 2 +- 1 f

Aw: [PATCH][net-next] net: mediatek: add flow offload for mt7623

2021-04-18 Thread Frank Wunderlich
Hi, any comment? regards Frank > Gesendet: Mittwoch, 31. März 2021 um 15:34 Uhr > Von: "Frank Wunderlich" > Betreff: [PATCH][net-next] net: mediatek: add flow offload for mt7623 > > mt7623 uses offload version 2 too > > tested on Bananapi-R2

Re: [PATCH iproute2] rdma: stat: initialize ret in stat_qp_show_parse_cb()

2021-04-18 Thread Leon Romanovsky
On Sun, Apr 18, 2021 at 02:00:38PM +0200, Andrea Claudi wrote: > On Sun, Apr 18, 2021 at 1:07 PM Leon Romanovsky wrote: > > > > On Wed, Apr 14, 2021 at 12:50:57AM +0200, Andrea Claudi wrote: > > > In the unlikely case in which the mnl_attr_for_each_nested() cycle is > > > not executed, this functi

Re: [PATCH v2 bpf-next 0/2] xsk: introduce generic almost-zerocopy xmit

2021-04-18 Thread Alexander Lobakin
From: Magnus Karlsson Date: Tue, 13 Apr 2021 09:14:02 +0200 Hi! I've finally done with a kinda comfy setup after moving to another country and can finally continue working on patches and stuff. > On Tue, Apr 13, 2021 at 3:49 AM Xuan Zhuo wrote: > > > > On Mon, 12 Apr 2021 16:13:12 +0200, Magnu

[PATCH iproute2-next 5/6] bridge: vlan: add support for the new rtm dump call

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Use the new bridge vlan rtm dump helper to dump all of the available vlan information when -details (-d) is used with vlan show. It is also capable of dumping vlan stats if -statistics (-s) is added. Currently this is the only interface capable of dumping per-vlan option

  1   2   >