Re: [PATCH net-next v3 6/8] virtio-net: xsk zero copy xmit kick by threshold

2021-04-05 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: After testing, the performance of calling kick every time is not stable. And if all the packets are sent and kicked again, the performance is not good. So add a module parameter to specify how many packets are sent to call a kick. 8 is a relatively stable valu

Re: [PATCH net-next v3 5/8] virtio-net: xsk zero copy xmit support xsk unaligned mode

2021-04-05 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: In xsk unaligned mode, the frame pointed to by desc may span two consecutive pages, but not more than two pages. Signed-off-by: Xuan Zhuo Reviewed-by: Dust Li I'd squash this patch into patch 4. --- drivers/net/virtio_net.c | 30 +

Re: [PATCH] ibmvnic: Continue with reset if set link down failed

2021-04-05 Thread Lijun Pan
> On Apr 5, 2021, at 10:47 PM, Dany Madden wrote: > > When an adapter is going thru a reset, it maybe in an unstable state that > makes a request to set link down fail. In such a case, the adapter needs > to continue on with reset to bring itself back to a stable state. > > Fixes: ed651a10875

Re: [PATCHv4 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-05 Thread Hangbin Liu
On Mon, Apr 05, 2021 at 05:24:48PM -0700, John Fastabend wrote: > Hangbin Liu wrote: > > This patch add two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend > > xdp_redirect_map for broadcast support. > > > > Keep the general data path in net/core/filter.c and the native data > > path in

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Heiner Kallweit
On 06.04.2021 04:07, Joakim Zhang wrote: > > Hi Heiner, > >> -Original Message- >> From: Heiner Kallweit >> Sent: 2021年4月5日 20:10 >> To: christian.me...@t2data.com; Joakim Zhang ; >> and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; >> k...@kernel.org >> Cc: netdev@vger.kernel.

[PATCH] net/Bluetooth - use the correct print format

2021-04-05 Thread Kai Ye
Use the correct print format. Printing an unsigned int value should use %u instead of %d. For details, please read document: Documentation/core-api/printk-formats.rst Signed-off-by: Kai Ye --- net/bluetooth/l2cap_core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

Re: [PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 02:01:16PM -0400, Tom Talpey wrote: > On 4/5/2021 1:23 AM, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Enable Relaxed Ordering in __ib_alloc_pd() allocation of the > > local_dma_lkey. > > > > This will take effect only for devices that don't pre-allocate the lke

Re: [PATCH net-next v3 4/8] virtio-net: xsk zero copy xmit implement wakeup and xmit

2021-04-05 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: When the user calls sendto to consume the data in the xsk tx queue, virtnet_xsk_wakeup will be called. In wakeup, it will try to send a part of the data directly, the quantity is operated by the module parameter xsk_budget. Any reason that we can't use NAPI

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

2021-04-05 Thread Song Liu
> On Apr 5, 2021, at 6:24 PM, Cong Wang wrote: > > On Mon, Apr 5, 2021 at 6:08 PM Song Liu wrote: >> >> >> >>> On Apr 5, 2021, at 4:49 PM, Cong Wang wrote: >>> >>> On Fri, Apr 2, 2021 at 4:31 PM Song Liu wrote: > On Apr 2, 2021, at 1:57 PM, Cong Wang wrote: >

Re: [PATCH net-next v5] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-04-05 Thread Martin Schiller
On 2021-04-05 21:34, Xie He wrote: Hi Martin, Could you ack? Thanks! Acked-by: Martin Schiller Just for the record: I'm certainly not always the fastest, but I don't work holidays or weekends. So you also need to have some patience.

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 07:27:17AM +0200, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 08:23:28AM +0300, Leon Romanovsky wrote: > > The same proposal (enable unconditionally) was raised during > > submission preparations and we decided to follow same pattern > > as other verbs objects which r

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Christoph Hellwig
On Tue, Apr 06, 2021 at 08:23:28AM +0300, Leon Romanovsky wrote: > The same proposal (enable unconditionally) was raised during > submission preparations and we decided to follow same pattern > as other verbs objects which receive flag parameter. A flags argument can be added when it actually is n

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 03:46:18PM +0200, Christoph Hellwig wrote: > On Mon, Apr 05, 2021 at 08:23:55AM +0300, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Add access flags parameter to ib_alloc_mr() and to ib_mr_pool_init(), > > and refactor relevant code. This parameter is used to pass

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 08:27:16AM -0700, Bart Van Assche wrote: > On 4/4/21 10:23 PM, Leon Romanovsky wrote: > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > > index bed4cfe50554..59138174affa 100644 > > --- a/include/rdma/ib_verbs.h > > +++ b/include/rdma/ib_verbs.h > > @@ -24

RE: [PATCH bpf-next 2/3] libbpf: selftests: refactor 'BPF_PERCPU_TYPE()' and 'bpf_percpu()' macros

2021-04-05 Thread John Fastabend
Pedro Tammela wrote: > This macro was refactored out of the bpf selftests. > > Since percpu values are rounded up to '8' in the kernel, a careless > user in userspace might encounter unexpected values when parsing the > output of the batched operations. > > Now that both array and hash maps have

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Mon, Apr 05, 2021 at 11:42:31PM +, Chuck Lever III wrote: > > > > On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > >>> From: Leon Romanovsk

Re: [PATCH] ibmvnic: Continue with reset if set link down failed

2021-04-05 Thread Rick Lindsley
On 4/5/21 8:47 PM, Dany Madden wrote: When an adapter is going thru a reset, it maybe in an unstable state that makes a request to set link down fail. In such a case, the adapter needs to continue on with reset to bring itself back to a stable state. Fixes: ed651a10875f ("ibmvnic: Updated reset

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 10:37:38AM +0800, Honggang LI wrote: > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > From Avihai, > > > > Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering > > imposed on PCI transactions, and thus,

Re: [PATCH linux-next v2 1/1] phy: Sparx5 Eth SerDes: Use direct register operations

2021-04-05 Thread Vinod Koul
On 29-03-21, 16:13, Steen Hegelund wrote: > Use direct register operations instead of a table of register > information to lower the stack usage. Applied, thanks -- ~Vinod

Re: [PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings

2021-04-05 Thread Martin K. Petersen
On Mon, 22 Mar 2021 17:02:38 +0100, Arnd Bergmann wrote: > The coming gcc release introduces a new warning for string operations > reading beyond the end of a fixed-length object. After testing > randconfig kernels for a while, think I have patches for any such > warnings that came up on x86, arm

Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Grant Grundler
On Tue, Apr 6, 2021 at 12:09 AM Andrew Lunn wrote: > > On Mon, Apr 05, 2021 at 04:13:40PM -0700, Grant Grundler wrote: > > This series introduces support for USB network devices that report > > speed as a part of their protocol, not emulating an MII to be accessed > > over MDIO. > > > > v2: rebase

[PATCH] pcnet32: Use pci_resource_len to validate PCI resource

2021-04-05 Thread Guenter Roeck
pci_resource_start() is not a good indicator to determine if a PCI resource exists or not, since the resource may start at address 0. This is seen when trying to instantiate the driver in qemu for riscv32 or riscv64. pci :00:01.0: reg 0x10: [io 0x-0x001f] pci :00:01.0: reg 0x14: [mem

Re: [PATCH net-next v3 3/8] virtio-net: xsk zero copy xmit setup

2021-04-05 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: xsk is a high-performance packet receiving and sending technology. This patch implements the binding and unbinding operations of xsk and the virtio-net queue for xsk zero copy xmit. The xsk zero copy xmit depends on tx napi. So if tx napi is not opened, an er

[PATCH] ibmvnic: Continue with reset if set link down failed

2021-04-05 Thread Dany Madden
When an adapter is going thru a reset, it maybe in an unstable state that makes a request to set link down fail. In such a case, the adapter needs to continue on with reset to bring itself back to a stable state. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden -

linux-next: manual merge of the net-next tree with the net tree

2021-04-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en_main.c between commit: 3ff3874fa0b2 ("net/mlx5e: Guarantee room for XSK wakeup NOP on async ICOSQ") from the net tree and commits: c276aae8c19d ("net/mlx5: Move mlx5e hw r

[PATCH] sunrpc: Remove unused function ip_map_lookup

2021-04-05 Thread Jiapeng Chong
Fix the following clang warnings: net/sunrpc/svcauth_unix.c:306:30: warning: unused function 'ip_map_lookup' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- net/sunrpc/svcauth_unix.c | 9 - 1 file changed, 9 deletions(-) diff --git a/net/sunrpc/svcauth_u

[PATCH v2] qtnfmac: remove meaningless goto statement and labels

2021-04-05 Thread samirweng1979
From: wengjianfeng some function's label meaningless, the label statement follows the goto statement, no other statements, so just remove it. Reported-by: kernel test robot Signed-off-by: wengjianfeng --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 67 --- 1 file c

[PATCH RESEND] qtnfmac: remove meaningless labels

2021-04-05 Thread samirweng1979
From: wengjianfeng some function's label meaningless, the return statement follows the goto statement, so just remove it. Signed-off-by: wengjianfeng --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 27 +-- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git

[PATCH net-next] mt76: mt7921: remove unneeded semicolon

2021-04-05 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/net/wireless/mediatek/mt76/mt7921/mac.c:1402:2-3: Unneeded semicolon Signed-off-by: Qiheng Lin --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediate

[PATCH net-next] netdevsim: remove unneeded semicolon

2021-04-05 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/net/netdevsim/fib.c:569:2-3: Unneeded semicolon Signed-off-by: Qiheng Lin --- drivers/net/netdevsim/fib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c index fda6f

[syzbot] KASAN: use-after-free Write in sk_psock_stop

2021-04-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f07669df libbpf: Remove redundant semi-colon git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=1564f0e2d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f dashboard link: htt

[PATCH net-next] net: ethernet: mtk_eth_soc: remove unneeded semicolon

2021-04-05 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/net/ethernet/mediatek/mtk_ppe.c:270:2-3: Unneeded semicolon Signed-off-by: Qiheng Lin --- drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.c b/dr

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-05 Thread Yunsheng Lin
On 2021/4/6 9:49, Cong Wang wrote: > On Sat, Apr 3, 2021 at 5:23 AM Jiri Kosina wrote: >> >> I am still planning to have Yunsheng Lin's (CCing) fix [1] tested in the >> coming days. If it works, then we can consider proceeding with it, >> otherwise I am all for reverting the whole NOLOCK stuff. >>

[PATCH net] tipc: increment the tmp aead refcnt before attaching it

2021-04-05 Thread Xin Long
Li Shuang found a NULL pointer dereference crash in her testing: [] BUG: unable to handle kernel NULL pointer dereference at 0020 [] RIP: 0010:tipc_crypto_rcv_complete+0xc8/0x7e0 [tipc] [] Call Trace: [] [] tipc_crypto_rcv+0x2d9/0x8f0 [tipc] [] tipc_rcv+0x2fc/0x1120 [ti

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Honggang LI
On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > From Avihai, > > Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering > imposed on PCI transactions, and thus, can improve performance. > > Until now, relaxed ordering could be set only

Re: [PATCH V2 1/1] mm:improve the performance during fork

2021-04-05 Thread jun qian
Andrew Morton 于2021年3月31日周三 下午1:44写道: > > On Mon, 29 Mar 2021 20:36:35 +0800 qianjun.ker...@gmail.com wrote: > > > From: jun qian > > > > In our project, Many business delays come from fork, so > > we started looking for the reason why fork is time-consuming. > > I used the ftrace with function_g

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月5日 20:10 > To: christian.me...@t2data.com; Joakim Zhang ; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > > S

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Charistian, > -Original Message- > From: Christian Melki > Sent: 2021年4月5日 16:44 > To: Heiner Kallweit ; Joakim Zhang > ; and...@lunn.ch; li...@armlinux.org.uk; > da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > > Subject

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-05 Thread Jason Wang
在 2021/4/2 下午7:00, Xuan Zhuo 写道: On Fri, 2 Apr 2021 10:52:12 +0800, Jason Wang wrote: So I wonder something like the following like this help. We know the frag size, that means, if we know there's sufficient tailroom we can use build_skb() without reserving dedicated room for skb_shared_info.

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-05 Thread Jason Wang
在 2021/4/2 下午9:26, Eric Dumazet 写道: From: Eric Dumazet Xuan Zhuo reported that commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for tiny skbs") brought a ~10% performance drop. The reason for the performance drop was that GRO was forced to chain sk_buff (using skb_shinfo(skb)

[PATCH v2] nfc: s3fwrn5: remove unnecessary label

2021-04-05 Thread samirweng1979
From: wengjianfeng In function s3fwrn5_nci_post_setup, the variable ret is assigned then goto out label, which just return ret, so we use return to replace it. Other goto sentences are similar, we use return sentences to replace goto sentences and delete out label. Signed-off-by: wengjianfeng -

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-05 Thread Cong Wang
On Sat, Apr 3, 2021 at 5:23 AM Jiri Kosina wrote: > > I am still planning to have Yunsheng Lin's (CCing) fix [1] tested in the > coming days. If it works, then we can consider proceeding with it, > otherwise I am all for reverting the whole NOLOCK stuff. > > [1] > https://lore.kernel.org/linux-ca

RE: [PATCH bpf-next 1/3] bpf: add batched ops support for percpu array

2021-04-05 Thread John Fastabend
Pedro Tammela wrote: > Suggested-by: Jamal Hadi Salim > Signed-off-by: Pedro Tammela > --- A commit message describing some of the change details and a note it uses the for-each cpu copies (same as normal syscall on percpu map) and not the per-cpu ones would be nice. I at least had to go and che

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月5日 6:49 > To: Joakim Zhang ; and...@lunn.ch; > li...@armlinux.org.uk; da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; christian.me...@t2data.com > Subj

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
Hi Heiner, Thanks for your comments. > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月4日 22:09 > To: Joakim Zhang ; and...@lunn.ch; > li...@armlinux.org.uk; da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; chris

[PATCH v3] ip-nexthop: support flush by id

2021-04-05 Thread Chunmei Xu
since id is unique for nexthop, it is heavy to dump all nexthops. use existing delete_nexthop to support flush by id Signed-off-by: Chunmei Xu --- ip/ipnexthop.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/ip/ipnexthop.c b/ip/ipnexthop.c index 0263307

[PATCH v2 net-next] stmmac: intel: Enable SERDES PHY rx clk for PSE

2021-04-05 Thread Voon Weifeng
EHL PSE SGMII mode requires to ungate the SERDES PHY rx clk for power up sequence and vice versa. Signed-off-by: Voon Weifeng --- Changes: v1 -> v2 -change subject from "net: intel" to "stmmac: intel" --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 10 ++ drivers/net/ethernet/s

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

2021-04-05 Thread Cong Wang
On Mon, Apr 5, 2021 at 6:08 PM Song Liu wrote: > > > > > On Apr 5, 2021, at 4:49 PM, Cong Wang wrote: > > > > On Fri, Apr 2, 2021 at 4:31 PM Song Liu wrote: > >> > >> > >> > >>> On Apr 2, 2021, at 1:57 PM, Cong Wang wrote: > >>> > >>> Ideally I even prefer to create timers in kernel-space too,

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

2021-04-05 Thread Song Liu
> On Apr 5, 2021, at 4:49 PM, Cong Wang wrote: > > On Fri, Apr 2, 2021 at 4:31 PM Song Liu wrote: >> >> >> >>> On Apr 2, 2021, at 1:57 PM, Cong Wang wrote: >>> >>> Ideally I even prefer to create timers in kernel-space too, but as I already >>> explained, this seems impossible to me. >>

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-05 Thread Yunsheng Lin
On 2021/4/3 20:23, Jiri Kosina wrote: > On Sat, 3 Apr 2021, Hillf Danton wrote: > > Sure. Seems they crept in over time. I had some plans to write a > lockless HTB implementation. But with fq+EDT with BPF it seems that > it is no longer needed, we have a more generic/better solution.

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

2021-04-05 Thread Cong Wang
On Fri, Apr 2, 2021 at 4:45 PM Alexei Starovoitov wrote: > > On Fri, Apr 02, 2021 at 02:24:51PM -0700, Cong Wang wrote: > > > > where the key is the timer ID and the value is the timer expire > > > > timer. > > > > > > The timer ID is unnecessary. We cannot introduce new IDR for every new > > > bp

RE: [PATCHv4 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-05 Thread John Fastabend
Hangbin Liu wrote: > This patch add two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend > xdp_redirect_map for broadcast support. > > Keep the general data path in net/core/filter.c and the native data > path in kernel/bpf/devmap.c so we can use direct calls to get better > performace. >

Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Andrew Lunn
On Mon, Apr 05, 2021 at 04:13:40PM -0700, Grant Grundler wrote: > This series introduces support for USB network devices that report > speed as a part of their protocol, not emulating an MII to be accessed > over MDIO. > > v2: rebased on recent upstream changes > v3: incorporated hints on naming a

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Keith Busch
On Mon, Apr 05, 2021 at 11:42:31PM +, Chuck Lever III wrote: > > On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > >>> From: Leon Romanovsky > >>> >

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

2021-04-05 Thread Cong Wang
On Fri, Apr 2, 2021 at 4:31 PM Song Liu wrote: > > > > > On Apr 2, 2021, at 1:57 PM, Cong Wang wrote: > > > > Ideally I even prefer to create timers in kernel-space too, but as I already > > explained, this seems impossible to me. > > Would hrtimer (include/linux/hrtimer.h) work? By impossible,

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Chuck Lever III
> On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: >>> From: Leon Romanovsky >>> From Avihai, >>> >>> Relaxed Ordering is a PCIe mechanism that r

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Florian Fainelli
On 4/5/2021 7:58 AM, Heiner Kallweit wrote: > On 05.04.2021 15:53, Christian Melki wrote: >> On 4/5/21 2:09 PM, Heiner Kallweit wrote: >>> On 05.04.2021 10:43, Christian Melki wrote: On 4/5/21 12:48 AM, Heiner Kallweit wrote: > On 04.04.2021 16:09, Heiner Kallweit wrote: >> On 04.04

Re: [PATCHv4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Grant Grundler
On Tue, Mar 30, 2021 at 2:17 AM Grant Grundler wrote: > > This series introduces support for USB network devices that report > speed as a part of their protocol, not emulating an MII to be accessed > over MDIO. > > v2: rebased on recent upstream changes > v3: incorporated hints on naming and comme

[PATCH net-next v4 4/4] net: cdc_ether: record speed in status method

2021-04-05 Thread Grant Grundler
Until very recently, the usbnet framework only had support functions for devices which reported the link speed by explicitly querying the PHY over a MDIO interface. However, the cdc_ether devices send notifications when the link state or link speeds change and do not expose the PHY (or modem) direc

[PATCH net-next v4 2/4] usbnet: add method for reporting speed without MII

2021-04-05 Thread Grant Grundler
From: Oliver Neukum The old method for reporting link speed assumed a driver uses the generic phy (mii) MDIO read/write functions. CDC devices don't expose the phy. Add a primitive internal version reporting back directly what the CDC notification/status operations recorded. v2: rebased on upst

[PATCH net-next v4 3/4] net: cdc_ncm: record speed in status method

2021-04-05 Thread Grant Grundler
From: Oliver Neukum Until very recently, the usbnet framework only had support functions for devices which reported the link speed by explicitly querying the PHY over a MDIO interface. However, the cdc_ncm devices send notifications when the link state or link speeds change and do not expose the

[PATCH net-next v4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings

2021-04-05 Thread Grant Grundler
From: Oliver Neukum The generic functions assumed devices provided an MDIO interface (accessed via older mii code, not phylib). This is true only for genuine ethernet. Devices with a higher level of abstraction or based on different technologies do not have MDIO. To support this case, first rena

[PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Grant Grundler
This series introduces support for USB network devices that report speed as a part of their protocol, not emulating an MII to be accessed over MDIO. v2: rebased on recent upstream changes v3: incorporated hints on naming and comments v4: fix misplaced hunks; reword some commit messages; add sa

Re: stmmac: zero udp checksum

2021-04-05 Thread Jakub Kicinski
On Mon, 5 Apr 2021 18:42:53 +0200 Andrew Lunn wrote: > > But was is still a bit strange to me is that it seems like the stmmac driver > > behaves different than other ethernet drivers which do not drop UDP packets > > with zero checksums when rx checksumming is enabled. > > To answer that, you n

Re: [PATCH RFC 2/4] net: sched: fix err handler in tcf_action_init()

2021-04-05 Thread Cong Wang
On Sat, Apr 3, 2021 at 3:01 AM Vlad Buslov wrote: > So, the following happens in reproduction provided in commit message > when executing "tc actions add action simple sdata \"1\" index 1 > action simple sdata \"2\" index 2" command: > > 1. tcf_action_init() is called with batch of two actions of

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-05 Thread Danilo Krummrich
On Mon, Apr 05, 2021 at 09:27:44PM +0200, Andrew Lunn wrote: > > Now, instead of encoding this information of the bus' capabilities at both > > places, I'd propose just checking the mii_bus->capabilities field in the > > mdiobus_c45_*() functions. IMHO this would be a little cleaner, than having >

Re: [PATCH v2] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 5 Apr 2021 19:16:50 +0900 you wrote: > KMSAN found uninitialized value at batadv_tt_prepare_tvlv_local_data() > [1], for commit ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 > in TT code") inserted 'reserve

Re: [PATCH] net: Allow to specify ifindex when device is moved to another namespace

2021-04-05 Thread Jakub Kicinski
On Mon, 5 Apr 2021 00:12:23 -0700 Andrei Vagin wrote: > Currently, we can specify ifindex on link creation. This change allows > to specify ifindex when a device is moved to another network namespace. > > Even now, a device ifindex can be changed if there is another device > with the same ifindex

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-05 Thread Andrew Lunn
On Mon, Apr 05, 2021 at 11:46:04PM +0200, Michael Walle wrote: > Hi Andrew, > > Am 2021-04-05 23:34, schrieb Andrew Lunn: > > > -static int of_get_mac_addr_nvmem(struct device_node *np, u8 addr) > > > +static int of_get_mac_addr_nvmem(struct device_node *np, u8 *addr) > > > { > > > struct platf

Re: [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 20:15:48 +0200 you wrote: > The driver can match via multiple methods. Its acpi_device_id table is > referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds: > > drivers/net/ethernet/s

Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 18:28:25 +0100 you wrote: > Limiting the scope of the variable vector_ring_chain to the block where it > is used. > > Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for > hip08 So

Re: [PATCH V2 net 0/2] Misc. fixes for hns3 driver

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 5 Apr 2021 18:06:43 +0100 you wrote: > Fixes for the miscellaneous problems found during the review of the code. > > Change Summary: > Patch 1/2, Change V1->V2: >[1] Fixed comments from Leon Romanovsky >Li

Re: [PATCH] net: Allow to specify ifindex when device is moved to another namespace

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 00:12:23 -0700 you wrote: > Currently, we can specify ifindex on link creation. This change allows > to specify ifindex when a device is moved to another network namespace. > > Even now, a device ifinde

Re: [PATCH] net-ipv6: bugfix - raw & sctp - switch to ipv6_can_nonlocal_bind()

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 5 Apr 2021 00:06:52 -0700 you wrote: > From: Maciej Żenczykowski > > Found by virtue of ipv6 raw sockets not honouring the per-socket > IP{,V6}_FREEBIND setting. > > Based on hits found via: > git grep '[.]ip_nonlo

Re: [PATCH net] openvswitch: fix send of uninitialized stack memory in ct limit reply

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 4 Apr 2021 19:50:31 +0200 you wrote: > 'struct ovs_zone_limit' has more members than initialized in > ovs_ct_limit_get_default_limit(). The rest of the memory is a random > kernel stack content that ends up being sent

[syzbot] WARNING: suspicious RCU usage in tcp_bpf_update_proto

2021-04-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:514e1150 net: x25: Queue received packets in the drivers i.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=112a8831d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f das

Re: [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK processing

2021-04-05 Thread David Miller
From: Phillip Potter Date: Mon, 5 Apr 2021 12:35:55 +0100 > When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len > to match the appropriate type, using new tun_get_addr_len utility function > which returns appropriate address length for given type. Fixes a > KMSAN-found unini

Re: [RFC PATCH bpf-next 1/4] bpf: Allow trampoline re-attach

2021-04-05 Thread Jiri Olsa
On Mon, Apr 05, 2021 at 04:15:54PM +0200, Toke Høiland-Jørgensen wrote: > Jiri Olsa writes: > > > On Sat, Apr 03, 2021 at 11:21:55AM -0700, Alexei Starovoitov wrote: > >> On Sat, Apr 03, 2021 at 01:24:12PM +0200, Toke Høiland-Jørgensen wrote: > >> > >if (!prog->aux->dst_trampoline && !tgt

Re: [PATCH] net: nfc: Fix spelling errors in net/nfc module

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 18:54:35 +0800 you wrote: > These patches fix a series of spelling errors in net/nfc module. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > --- > net/nfc/digital_dep.c | 2 +- > net/nfc/

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-05 Thread Michael Walle
Hi Andrew, Am 2021-04-05 23:34, schrieb Andrew Lunn: -static int of_get_mac_addr_nvmem(struct device_node *np, u8 addr) +static int of_get_mac_addr_nvmem(struct device_node *np, u8 *addr) { struct platform_device *pdev = of_find_device_by_node(np); + struct nvmem_cell *cell; +

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-05 Thread Andrew Lunn
Hi Michael > -static int of_get_mac_addr_nvmem(struct device_node *np, u8 addr) > +static int of_get_mac_addr_nvmem(struct device_node *np, u8 *addr) > { > struct platform_device *pdev = of_find_device_by_node(np); > + struct nvmem_cell *cell; > + const void *mac; > + size_t len

Re: [PATCH 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-05 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 03:19:11AM +0800, kernel test robot wrote: > Hi Michael, > > I love your patch! Yet something to improve: Looks correct. You missed the #else case for #ifdef CONFIG_OF in stmmac_platform.c Lets see what else 0-day finds before i start reviewing. Andrew

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-05 Thread Russell King - ARM Linux admin
On Mon, Apr 05, 2021 at 08:58:07PM +0200, Danilo Krummrich wrote: > On Mon, Apr 05, 2021 at 03:33:55PM +0200, Andrew Lunn wrote: > However, this was about something else - Russell wrote: > > > > We have established that MDIO drivers need to reject accesses for > > > > reads/writes that they do not

Re: [PATCH rdma-next 02/10] RDMA/core: Enable Relaxed Ordering in __ib_alloc_pd()

2021-04-05 Thread Adit Ranadive
On 4/5/21 11:01 AM, Tom Talpey wrote: > On 4/5/2021 1:23 AM, Leon Romanovsky wrote: >> From: Avihai Horon >> >> Enable Relaxed Ordering in __ib_alloc_pd() allocation of the >> local_dma_lkey. >> >> This will take effect only for devices that don't pre-allocate the lkey >> but allocate it per PD al

RE: [Patch bpf-next] udp_bpf: remove some pointless comments

2021-04-05 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > These comments in udp_bpf_update_proto() are copied from the > original TCP code and apparently do not apply to UDP. Just > remove them. > > Reported-by: Jakub Sitnicki > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Lorenz Bauer > Signed-off-by: Cong

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Jason Gunthorpe
On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > >From Avihai, > > > > Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering > > imposed on PCI transactions, and

Re: [PATCH net-next] tipc: Fix a kernel-doc warning in name_table.c

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 22:23:15 +0800 you wrote: > Fix kernel-doc warning: > > Documentation/networking/tipc:66: /home/sfr/next/next/net/tipc/name_table.c > :558: WARNING: Unexpected indentation. > Documentation/networking/t

Re: [PATCH v2 net-next] mld: change lockdep annotation for ip6_sf_socklist and ipv6_mc_socklist

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 13:38:23 + you wrote: > struct ip6_sf_socklist and ipv6_mc_socklist are per-socket MLD data. > These data are protected by rtnl lock, socket lock, and RCU. > So, when these are used, it verifies whet

Re: [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 14:42:44 +0200 you wrote: > This ++ is confusing. It looks duplicated with the one already performed in > 'skb_fill_page_desc()'. > > In fact, it is harmless. 'nr_frags' is written twice with the same

[PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-05 Thread Pavel Skripkin
syzbot reported shift-out-of-bounds in nl802154_new_interface. The problem was in signed representation of enum nl802154_iftype enum nl802154_iftype { /* for backwards compatibility TODO */ NL802154_IFTYPE_UNSPEC = -1, ... Since, enum has negative value in it, objects of this type

[PATCH] inode: Remove second initialization of the bpf_preload_lock

2021-04-05 Thread Muhammad Usama Anjum
bpf_preload_lock is already defined with DEFINE_MUTEX. There is no need to initialize it again. Remove the extraneous initialization. Signed-off-by: Muhammad Usama Anjum --- kernel/bpf/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c index 1576

Re: [PATCH net-next v5] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-04-05 Thread Xie He
Hi Martin, Could you ack? Thanks!

Re: stmmac: zero udp checksum

2021-04-05 Thread Julian Labus
On 05.04.21 18:42, Andrew Lunn wrote: Have you looked at where it actually drops the packet? Is it one of https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/stmicro/stmmac/norm_desc.c#L95 or https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/stmicro/stmmac/enh

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-05 Thread Andrew Lunn
> Now, instead of encoding this information of the bus' capabilities at both > places, I'd propose just checking the mii_bus->capabilities field in the > mdiobus_c45_*() functions. IMHO this would be a little cleaner, than having > two > places where this information is stored. What do you think a

Re: [PATCH 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-05 Thread kernel test robot
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on next-20210401] [cannot apply to sunxi/sunxi/for-next xlnx/master wireless-drivers-next/master wireless-drivers/master robh/for-next linus/master v5.12-rc6 v5.12-rc5 v5.12-rc4 v5.12-rc6] [If your patch is applied

Re: [PATCH] sfc: Use 'skb_add_rx_frag()' instead of hand coding it

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 11:45:11 +0200 you wrote: > Some lines of code can be merged into an equivalent 'skb_add_rx_frag()' > call which is less verbose. > > Signed-off-by: Christophe JAILLET > --- > UNTESTED. Compile tested

Re: [PATCH] net: ag71xx: Slightly simplify 'ag71xx_rx_packets()'

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 08:33:44 +0200 you wrote: > There is no need to use 'list_for_each_entry_safe' here, as nothing is > removed from the list in the 'for' loop. > Use 'list_for_each_entry' instead, it is slightly less verb

Re: [PATCH] ibmvnic: Use 'skb_frag_address()' instead of hand coding it

2021-04-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 10:54:37 +0200 you wrote: > 'page_address(skb_frag_page()) + skb_frag_off()' can be replaced by an > equivalent 'skb_frag_address()' which is less verbose. > > Signed-off-by: Christophe JAILLET > --- >

Re: [PATCH AUTOSEL 5.10 09/33] net: correct sk_acceptq_is_full()

2021-04-05 Thread Marcelo Ricardo Leitner
On Mon, Mar 29, 2021 at 06:21:57PM -0400, Sasha Levin wrote: > From: liuyacan > > [ Upstream commit f211ac154577ec9ccf07c15f18a6abf0d9bdb4ab ] > > The "backlog" argument in listen() specifies > the maximom length of pending connections, > so the accept queue should be considered full > if there

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-05 Thread Danilo Krummrich
On Mon, Apr 05, 2021 at 03:33:55PM +0200, Andrew Lunn wrote: > On Sun, Apr 04, 2021 at 09:23:55PM +0200, Danilo Krummrich wrote: > > So currently every driver should check for the flag MII_ADDR_C45 and report > > an > > error in case it's unsupported. > > > > What do you think about checking the

  1   2   >