Re: [PATCHv3 3/3] CDC-NCM: record speed in status method

2021-03-19 Thread Grant Grundler
On Mon, Feb 22, 2021 at 10:14 AM Oliver Neukum wrote: > > Am Freitag, den 19.02.2021, 07:30 + schrieb Grant Grundler: > > On Thu, Feb 18, 2021 at 10:21 AM Oliver Neukum wrote: > > Hi, > > > Since this patch is missing the hunks that landed in the previous > > patch and needs a v4, I'll offer

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread David Ahern
On 3/19/21 6:53 PM, Willem de Bruijn wrote: > On Fri, Mar 19, 2021 at 7:54 PM David Ahern wrote: >> >> On 3/19/21 10:11 AM, Ishaan Gandhi wrote: >>> Thank you. Would it be better to do instead: >>> >>> + if_index = skb->skb_iif; >>> >>> or >>> >>> + if_index = ip_version == 4 ? inet_iif(sk

Re: [PATCH v7 bpf-next 09/14] bpd: add multi-buffer support to xdp copy helpers

2021-03-19 Thread kernel test robot
Hi Lorenzo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mvneta-introduce-XDP-multi-buffer-support/20210320-055103 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf

Re: [PATCH v7 bpf-next 10/14] bpf: add new frame_length field to the XDP ctx

2021-03-19 Thread David Ahern
On 3/19/21 3:47 PM, Lorenzo Bianconi wrote: > diff --git a/include/net/xdp.h b/include/net/xdp.h > index 19cd6642e087..e47d9e8da547 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -75,6 +75,10 @@ struct xdp_buff { > struct xdp_txq_info *txq; > u32 frame_sz:31; /* frame s

Re: [PATCH 2/2] net: phy: dp83867: add support for changing LED modes

2021-03-19 Thread kernel test robot
Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net/master ipvs/master net-next/master v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

RE: [Patch bpf-next v5 04/11] skmsg: avoid lock_sock() in sk_psock_backlog()

2021-03-19 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > We do not have to lock the sock to avoid losing sk_socket, > instead we can purge all the ingress queues when we close > the socket. Sending or receiving packets after orphaning > socket makes no sense. > > We do purge these queues when psock refcnt reaches

Re: [PATCH bpf] bpf: use NOP_ATOMIC5 instead of emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Fri, 19 Mar 2021 17:00:01 -0700 you wrote: > __bpf_arch_text_poke does rewrite only for atomic nop5, emit_nops(xxx, 5) > emits non-atomic one which breaks fentry/fexit with k8 atomics: > > P6_NOP5 == P6_NOP5_ATOMIC (0f1f44

Re: [PATCH bpf] bpf: use NOP_ATOMIC5 instead of emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG

2021-03-19 Thread Alexei Starovoitov
On Fri, Mar 19, 2021 at 6:40 PM Stanislav Fomichev wrote: > > On Fri, Mar 19, 2021 at 5:33 PM Alexei Starovoitov > wrote: > > > > On Fri, Mar 19, 2021 at 5:25 PM Stanislav Fomichev wrote: > > > > > > On Fri, Mar 19, 2021 at 5:14 PM Alexei Starovoitov > > > wrote: > > > > > > > > On Fri, Mar 19,

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-19 Thread Alexei Starovoitov
On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote: > Add ability to skip BTF generation for some BPF object files. This is done > through using a convention of .nobtf.c file name suffix. > > Also add third statically linked file to static_linked selftest. This file has > no BTF, caus

Re: [PATCH V3] ethernet: sun: Fix a typo

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/serisouly/seriously/ ...plus the sentence construction for better readability. Signed-off-by: Bhaskar Chowdhury --- Changes from V2: Missed the subject line labeling ..so added drivers/net/ethernet/sun/sungem.c | 4 ++-- 1 file changed, 2 i

Re: [PATCH] selftests: net: forwarding: Fix a typo

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/verfied/verified/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- tools/testing/selftests/net/forwarding/fib_offload_lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/forwar

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread Willem de Bruijn
On Fri, Mar 19, 2021 at 7:54 PM David Ahern wrote: > > On 3/19/21 10:11 AM, Ishaan Gandhi wrote: > > Thank you. Would it be better to do instead: > > > > + if_index = skb->skb_iif; > > > > or > > > > + if_index = ip_version == 4 ? inet_iif(skb) : skb->skb_iif; > > > > If the packet comes i

Re: [PATCH v7 bpf-next 09/14] bpd: add multi-buffer support to xdp copy helpers

2021-03-19 Thread kernel test robot
Hi Lorenzo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mvneta-introduce-XDP-multi-buffer-support/20210320-055103 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf

Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

2021-03-19 Thread Florian Fainelli
On 3/19/2021 3:54 PM, Marek Behún wrote: > On Fri, 19 Mar 2021 15:14:52 -0700 > Florian Fainelli wrote: > >> On 3/19/2021 12:47 PM, Marek Behún wrote: >>> On Fri, 19 Mar 2021 20:58:20 +0200 >>> Vladimir Oltean wrote: >>> On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote: >

Re: [PATCH 2/2] net: phy: dp83867: add support for changing LED modes

2021-03-19 Thread kernel test robot
Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net/master ipvs/master net-next/master v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH bpf] bpf: use NOP_ATOMIC5 instead of emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG

2021-03-19 Thread Alexei Starovoitov
On Fri, Mar 19, 2021 at 5:25 PM Stanislav Fomichev wrote: > > On Fri, Mar 19, 2021 at 5:14 PM Alexei Starovoitov > wrote: > > > > On Fri, Mar 19, 2021 at 5:00 PM Stanislav Fomichev wrote: > > > > > > __bpf_arch_text_poke does rewrite only for atomic nop5, emit_nops(xxx, 5) > > > emits non-atomic

Re: [PATCH bpf] bpf: use NOP_ATOMIC5 instead of emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG

2021-03-19 Thread Alexei Starovoitov
On Fri, Mar 19, 2021 at 5:00 PM Stanislav Fomichev wrote: > > __bpf_arch_text_poke does rewrite only for atomic nop5, emit_nops(xxx, 5) > emits non-atomic one which breaks fentry/fexit with k8 atomics: > > P6_NOP5 == P6_NOP5_ATOMIC (0f1f44 == 0f1f44) > K8_NOP5 != K8_NOP5_ATOMIC (906690

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Martin KaFai Lau
On Fri, Mar 19, 2021 at 04:02:27PM -0700, Andrii Nakryiko wrote: > On Fri, Mar 19, 2021 at 3:45 PM Martin KaFai Lau wrote: > > > > On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > > > On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > > > > > > > On Fri, Mar 19, 2021 at

[PATCH net-next 1/2] ip: Treat IPv4 segment's lowest address as unicast

2021-03-19 Thread Seth David Schoen
Treat the lowest-numbered address in each IPv4 network segment as unicast, not broadcast. Signed-off-by: Seth David Schoen Suggested-by: John Gilmore Acked-by: Dave Taht --- net/ipv4/fib_frontend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/fib_frontend.c b

[PATCH net-next 0/2] Treat IPv4 lowest address as ordinary unicast address

2021-03-19 Thread Seth David Schoen
Treat the lowest address in a subnet (the address within the subnet which contains all 0 bits) as an ordinary unicast address instead of as a potential second broadcast address. For example, in subnet 192.168.17.24/29, which contains 8 addresses, make address 192.168.17.24 usable as a normal unica

[PATCH net-next 2/2] selftests: Lowest IPv4 address in a subnet is valid

2021-03-19 Thread Seth David Schoen
Expect the lowest IPv4 address in a subnet to be assignable and addressable as a unicast (non-broadcast) address on a local network segment. Signed-off-by: Seth David Schoen Acked-by: Dave Taht --- .../testing/selftests/net/unicast_extensions.sh | 17 + 1 file changed, 9 inserti

Re: [PATCH bpf-next 03/15] bpf: Refactor btf_check_func_arg_match

2021-03-19 Thread Alexei Starovoitov
On 3/19/21 2:51 PM, Andrii Nakryiko wrote: It's a matter of taste, I suppose. I'd probably disagree with you on the readability of those verifier parts ;) So it's up to you, of course, but for me this code pattern: for (...) { if (A) { handleA; } else if (B) { handle

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread David Ahern
On 3/19/21 10:11 AM, Ishaan Gandhi wrote: > Thank you. Would it be better to do instead: > > + if_index = skb->skb_iif; > > or > > + if_index = ip_version == 4 ? inet_iif(skb) : skb->skb_iif; > If the packet comes in via an interface assigned to a VRF, skb_iif is most likely the VRF in

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 3:45 PM Martin KaFai Lau wrote: > > On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > > On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > > > > > On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > > > > On Thu, Mar 18, 2021 at 10:

Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

2021-03-19 Thread Marek Behún
On Fri, 19 Mar 2021 15:14:52 -0700 Florian Fainelli wrote: > On 3/19/2021 12:47 PM, Marek Behún wrote: > > On Fri, 19 Mar 2021 20:58:20 +0200 > > Vladimir Oltean wrote: > > > >> On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote: > >>> We know that the `lane == MV88E6393X_PORT0_LAN

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Martin KaFai Lau
On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > > > On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > > > On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > > > > > > > On Thu, Mar 18, 2021 a

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 3:19 PM Martin KaFai Lau wrote: > > On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > > On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > > > > > On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > > > > On Thu, Mar 18, 2021 at 4:

Re: macb broken on HiFive Unleashed

2021-03-19 Thread Yixun Lan
HI Andreas, Zong: On Fri, Mar 19, 2021 at 4:51 PM Andreas Schwab wrote: > > On Mär 19 2021, Yixun Lan wrote: > > > what's the exact root cause? and any solution? > > Try reverting the five commits starting with > 732374a0b440d9a79c8412f318a25cd37ba6f4e2. > I confirm reverting those five patches m

Re: [RFC PATCH v2 net-next 10/16] net: dsa: replay VLANs installed on port when joining the bridge

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently this simple setup: > > ip link add br0 type bridge vlan_filtering 1 > ip link add bond0 type bond > ip link set bond0 master br0 > ip link set swp0 master bond0 > > will not work because the bridge has created

Re: [RFC PATCH v2 net-next 08/16] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > I have udhcpcd in my system and this is configured to bring interfaces > up as soon as they are created. > > I create a bridge as follows: > > ip link add br0 type bridge > > As soon as I create the bridge and udhcpcd

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Martin KaFai Lau
On Fri, Mar 19, 2021 at 02:27:13PM -0700, Andrii Nakryiko wrote: > On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > > > On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > > > On Thu, Mar 18, 2021 at 4:39 PM Martin KaFai Lau wrote: > > > > > > > > On Thu, Mar 18, 2021 a

Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

2021-03-19 Thread Florian Fainelli
On 3/19/2021 12:47 PM, Marek Behún wrote: > On Fri, 19 Mar 2021 20:58:20 +0200 > Vladimir Oltean wrote: > >> On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote: >>> We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane` >>> to mv88e6390_serdes_read() instead of MV88E6

Re: [PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-03-19 Thread Aaron Conole
Aaron Conole writes: > When a user instructs a flow pipeline to perform connection tracking, > there is an implicit L3 operation that occurs - namely the IP fragments > are reassembled and then processed as a single unit. After this, new > fragments are generated and then transmitted, with the h

Re: [RFC PATCH v2 net-next 07/16] net: dsa: sync ageing time when joining the bridge

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is only emitted from: > > sysfs/ioctl/netlink > -> br_set_ageing_time >-> __set_ageing_time > > therefore not at bridge port creation time, so: > (a) drivers had to

Re: [RFC PATCH v2 net-next 06/16] net: dsa: sync multicast router state when joining the bridge

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Make sure that the multicast router setting of the bridge is picked up > correctly by DSA when joining, regardless of whether there are > sandwiched interfaces or not. The SWITCHDEV_ATTR_ID_BRIDGE_MROUTER port > attribute

Re: [RFC PATCH v2 net-next 05/16] net: dsa: sync up VLAN filtering state when joining the bridge

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This is the same situation as for other switchdev port attributes: if we > join an already-created bridge port, such as a bond master interface, > then we can miss the initial switchdev notification emitted by the > bridg

Re: [RFC PATCH v2 net-next 04/16] net: dsa: sync up with bridge port's STP state when joining

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > It may happen that we have the following topology: > > ip link add br0 type bridge stp_state 1 > ip link add bond0 type bond > ip link set bond0 master br0 > ip link set swp0 master bond0 > ip link set swp1 master bond0

Re: [PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 18 Mar 2021 10:48:51 +0800 you wrote: > Two insn_buf[16] variables are declared in the function, which act on > function scope and block scope respectively. > The statement in the inner blocks is redundant, so remove i

Re: [RFC PATCH v2 net-next 03/16] net: dsa: inherit the actual bridge port flags at join time

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > DSA currently assumes that the bridge port starts off with this > constellation of bridge port flags: > > - learning on > - unicast flooding on > - multicast flooding on > - broadcast flooding on > > just by virtue of c

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

2021-03-19 Thread J. Bruce Fields
On Fri, Mar 19, 2021 at 02:58:14PM +, Chuck Lever III wrote: > Hi Chris- > > > On Mar 19, 2021, at 10:54 AM, Chris Down wrote: > > > > The reclen is taken directly from the first four bytes of the message > > with the highest bit stripped, which makes it ripe for protocol mixups. > > For exa

Re: [RFC PATCH v2 net-next 02/16] net: dsa: pass extack to dsa_port_{bridge,lag}_join

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This is a pretty noisy change that was broken out of the larger change > for replaying switchdev attributes and objects at bridge join time, > which is when these extack objects are actually used. > > Signed-off-by: Vlad

Re: [RFC PATCH v2 net-next 01/16] net: dsa: call dsa_port_bridge_join when joining a LAG that is already in a bridge

2021-03-19 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > DSA can properly detect and offload this sequence of operations: > > ip link add br0 type bridge > ip link add bond0 type bond > ip link set swp0 master bond0 > ip link set bond0 master br0 > > But not this one: > > ip

Re: [PATCH bpf-next 03/15] bpf: Refactor btf_check_func_arg_match

2021-03-19 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 12:32 PM Martin KaFai Lau wrote: > > On Thu, Mar 18, 2021 at 04:32:47PM -0700, Andrii Nakryiko wrote: > > On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > > > > > This patch refactors the core logic of "btf_check_func_arg_match()" > > > into a new function "do_

Re: [PATCH 1/2] dt-bindings: dp83867: Add binding for LED mode configuration

2021-03-19 Thread Rob Herring
On Fri, 19 Mar 2021 16:57:09 +0100, Michael Tretter wrote: > The DP83867 supports four configurable LED pins. Describe the > multiplexing of functions to the LEDs via device tree. > > Signed-off-by: Michael Tretter > --- > .../devicetree/bindings/net/ti,dp83867.yaml | 24 +++ >

[PATCH v7 bpf-next 13/14] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature

2021-03-19 Thread Lorenzo Bianconi
introduce xdp_shared_info pointer in bpf_test_finish signature in order to copy back paged data from a xdp multi-buff frame to userspace buffer Signed-off-by: Lorenzo Bianconi --- net/bpf/test_run.c | 48 ++ 1 file changed, 40 insertions(+), 8 deletion

[PATCH v7 bpf-next 14/14] bpf: update xdp_adjust_tail selftest to include multi-buffer

2021-03-19 Thread Lorenzo Bianconi
From: Eelco Chaudron This change adds test cases for the multi-buffer scenarios when shrinking and growing. Signed-off-by: Eelco Chaudron Signed-off-by: Lorenzo Bianconi --- .../bpf/prog_tests/xdp_adjust_tail.c | 105 ++ .../bpf/progs/test_xdp_adjust_tail_grow.c |

[PATCH v7 bpf-next 12/14] bpf: introduce multibuff support to bpf_prog_test_run_xdp()

2021-03-19 Thread Lorenzo Bianconi
Introduce the capability to allocate a xdp multi-buff in bpf_prog_test_run_xdp routine. This is a preliminary patch to introduce the selftests for new xdp multi-buff ebpf helpers Signed-off-by: Lorenzo Bianconi --- net/bpf/test_run.c | 52 +++--- 1 file ch

[PATCH v7 bpf-next 10/14] bpf: add new frame_length field to the XDP ctx

2021-03-19 Thread Lorenzo Bianconi
From: Eelco Chaudron This patch adds a new field to the XDP context called frame_length, which will hold the full length of the packet, including fragments if existing. eBPF programs can determine if fragments are present using something like: if (ctx->data_end - ctx->data < ctx->frame_length

[PATCH v7 bpf-next 11/14] bpf: move user_size out of bpf_test_init

2021-03-19 Thread Lorenzo Bianconi
Rely on data_size_in in bpf_test_init routine signature. This is a preliminary patch to introduce xdp multi-buff selftest Signed-off-by: Lorenzo Bianconi --- net/bpf/test_run.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/bpf/test_run.c b/net/bpf/test_run

[PATCH v7 bpf-next 09/14] bpd: add multi-buffer support to xdp copy helpers

2021-03-19 Thread Lorenzo Bianconi
From: Eelco Chaudron This patch adds support for multi-buffer for the following helpers: - bpf_xdp_output() - bpf_perf_event_output() Signed-off-by: Eelco Chaudron Signed-off-by: Lorenzo Bianconi --- net/core/filter.c | 60 - .../selftests/bpf/prog_tes

[PATCH v7 bpf-next 08/14] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API

2021-03-19 Thread Lorenzo Bianconi
From: Eelco Chaudron This change adds support for tail growing and shrinking for XDP multi-buff. Signed-off-by: Eelco Chaudron Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 5 net/core/filter.c | 63 +++ 2 files changed, 68 insertion

[PATCH v7 bpf-next 06/14] net: mvneta: enable jumbo frames for XDP

2021-03-19 Thread Lorenzo Bianconi
Enable the capability to receive jumbo frames even if the interface is running in XDP mode Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvel

[PATCH v7 bpf-next 07/14] net: xdp: add multi-buff support to xdp_build_skb_from_fram

2021-03-19 Thread Lorenzo Bianconi
Introduce xdp multi-buff support to __xdp_build_skb_from_frame/xdp_build_skb_from_fram utility routines. Signed-off-by: Lorenzo Bianconi --- net/core/xdp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/net/core/xdp.c b/net/core/xdp.c index 430f516259d9..7388bc6d

[PATCH v7 bpf-next 03/14] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer

2021-03-19 Thread Lorenzo Bianconi
Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and XDP remote drivers if this is a "non-linear" XDP buffer. Access xdp_shared_info only if xdp_buff mb is set. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 26 -- 1 file chan

[PATCH v7 bpf-next 04/14] xdp: add multi-buff support to xdp_return_{buff/frame}

2021-03-19 Thread Lorenzo Bianconi
Take into account if the received xdp_buff/xdp_frame is non-linear recycling/returning the frame memory to the allocator or into xdp_frame_bulk. Introduce xdp_return_num_frags_from_buff to return a given number of fragments from a xdp multi-buff starting from the tail. Signed-off-by: Lorenzo Bianc

[PATCH v7 bpf-next 05/14] net: mvneta: add multi buffer support to XDP_TX

2021-03-19 Thread Lorenzo Bianconi
Introduce the capability to map non-linear xdp buffer running mvneta_xdp_submit_frame() for XDP_TX and XDP_REDIRECT Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 91 --- 1 file changed, 55 insertions(+), 36 deletions(-) diff --git a/drivers/

[PATCH v7 bpf-next 02/14] xdp: add xdp_shared_info data structure

2021-03-19 Thread Lorenzo Bianconi
Introduce xdp_shared_info data structure to contain info about "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info allowing to keep most of the frags in the same cache-line. Introduce some xdp_shared_info helpers aligned to skb_frag* ones Signed-off-by: Lorenzo Bianconi --- driver

[PATCH v7 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2021-03-19 Thread Lorenzo Bianconi
Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data structure in order to specify if this is a linear buffer (mb = 0) or a multi-buffer frame (mb = 1). In the latter case the shared_info area at the end of the first buffer will be properly initialized to link together subsequent buffers.

[PATCH v7 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-03-19 Thread Lorenzo Bianconi
This series introduce XDP multi-buffer support. The mvneta driver is the first to support these new "non-linear" xdp_{buff,frame}. Reviewers please focus on how these new types of xdp_{buff,frame} packets traverse the different layers and the layout design. It is on purpose that BPF-helpers are kep

Re: [PATCH net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2021-03-19

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 14:17:18 -0700 you wrote: > This series contains updates to igc and e1000e drivers. > > Sasha removes unused defines in igc driver. > > Jiapeng Zhong changes bool assignments from 0/1 to false/true fo

Re: [PATCH bpf-next 12/15] libbpf: Support extern kernel function

2021-03-19 Thread Andrii Nakryiko
On Thu, Mar 18, 2021 at 10:06 PM Martin KaFai Lau wrote: > > On Thu, Mar 18, 2021 at 09:11:39PM -0700, Andrii Nakryiko wrote: > > On Tue, Mar 16, 2021 at 12:02 AM Martin KaFai Lau wrote: > > > > > > This patch is to make libbpf able to handle the following extern > > > kernel function declaration

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Andrew Lunn
On Fri, Mar 19, 2021 at 04:18:32PM -0500, Alex Elder wrote: > On 3/19/21 1:32 PM, Andrew Lunn wrote: > > > @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version > > > version) > > > BCR_HOLB_DROP_L2_IRQ_FMASK | > > > BCR_DUAL_TX_

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-19 Thread Andrii Nakryiko
On Thu, Mar 18, 2021 at 10:29 PM Martin KaFai Lau wrote: > > On Thu, Mar 18, 2021 at 09:13:56PM -0700, Andrii Nakryiko wrote: > > On Thu, Mar 18, 2021 at 4:39 PM Martin KaFai Lau wrote: > > > > > > On Thu, Mar 18, 2021 at 03:53:38PM -0700, Andrii Nakryiko wrote: > > > > On Tue, Mar 16, 2021 at 12

Re: [PATCH v3] bpf: Fix memory leak in copy_process()

2021-03-19 Thread Daniel Borkmann
On 3/17/21 4:09 AM, qiang.zh...@windriver.com wrote: From: Zqiang The syzbot report a memleak follow: BUG: memory leak unreferenced object 0x888101b41d00 (size 120): comm "kworker/u4:0", pid 8, jiffies 4294944270 (age 12.780s) backtrace: [] alloc_pid+0x66/0x560 [] copy_proce

Re: [PATCH bpf-next 2/3] libbpf: skip BTF fixup if object file has no BTF

2021-03-19 Thread Jiri Olsa
On Fri, Mar 19, 2021 at 01:59:08PM -0700, Andrii Nakryiko wrote: > Skip BTF fixup step when input object file is missing BTF altogether. > > Reported-by: Jiri Olsa > Fixes: 8fd27bf69b86 ("libbpf: Add BPF static linker BTF and BTF.ext support") > Signed-off-by: Andrii Nakryiko Tested-by: Jiri Ol

Re: [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree

2021-03-19 Thread Andrew Lunn
On Fri, Mar 19, 2021 at 04:57:08PM +0100, Michael Tretter wrote: > Hello, > > The dp83867 has 4 LED pins, which can be multiplexed with different functions > of the phy. > > This series adds a device tree binding to describe the multiplexing of the > functions to the LEDs and implements the bindi

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Alex Elder
On 3/19/21 1:32 PM, Andrew Lunn wrote: @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version version) BCR_HOLB_DROP_L2_IRQ_FMASK | BCR_DUAL_TX_FMASK; - /* assert(version != IPA_VERSION_4_5); */ + ipa_assert(NULL, version !

[PATCH net-next 1/5] igc: Remove unused MII_CR_RESET

2021-03-19 Thread Tony Nguyen
From: Sasha Neftin MII_CR_RESET mask not in use in i225 device and can be removed Signed-off-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i

[PATCH net-next 5/5] e1000e: Mark e1000e_pm_prepare() as __maybe_unused

2021-03-19 Thread Tony Nguyen
From: Wei Yongjun The function e1000e_pm_prepare() may have no callers depending on configuration, so it must be marked __maybe_unused to avoid harmless warning: drivers/net/ethernet/intel/e1000e/netdev.c:6926:12: warning: 'e1000e_pm_prepare' defined but not used [-Wunused-function] 6926 | sta

[PATCH net-next 3/5] igc: Remove unused MII_CR_LOOPBACK

2021-03-19 Thread Tony Nguyen
From: Sasha Neftin MII_CR_LOOPBACK masks not in use in i225 device and can be removed. Signed-off-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/in

[PATCH net-next 2/5] igc: Remove unused MII_CR_SPEED

2021-03-19 Thread Tony Nguyen
From: Sasha Neftin Force PHY speed not supported for i225 devices. MII_CR_SPEED masks not in use in i225 device and can be removed. Signed-off-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_defines.h | 3 --- 1 file changed, 3 de

[PATCH net-next 4/5] igc: Assign boolean values to a bool variable

2021-03-19 Thread Tony Nguyen
From: Jiapeng Zhong Fix the following coccicheck warnings: ./drivers/net/ethernet/intel/igc/igc_main.c:4961:2-14: WARNING: Assignment of 0/1 to bool variable. ./drivers/net/ethernet/intel/igc/igc_main.c:4955:2-14: WARNING: Assignment of 0/1 to bool variable. ./drivers/net/ethernet/intel/igc/ig

[PATCH net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2021-03-19

2021-03-19 Thread Tony Nguyen
This series contains updates to igc and e1000e drivers. Sasha removes unused defines in igc driver. Jiapeng Zhong changes bool assignments from 0/1 to false/true for igc. Wei Yongjun marks e1000e_pm_prepare() as __maybe_unused to resolve a defined but not used warning under certain configuration

Re: [PATCH v2] selinux: vsock: Set SID for socket returned by accept()

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 19 Mar 2021 13:05:41 + you wrote: > For AF_VSOCK, accept() currently returns sockets that are unlabelled. > Other socket families derive the child's SID from the SID of the parent > and the SID of the incoming packet

Re: [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2021-03-19

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 19 Mar 2021 09:19:54 -0700 you wrote: > This series contains updates to e1000e and igb drivers. > > Tom Seewald fixes duplicate guard issues by including the driver name in > the guard for e1000e and igb. > > Jesse ad

Re: [PATCH net] mptcp: Change mailing list address

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 19 Mar 2021 11:33:02 -0700 you wrote: > The mailing list for MPTCP maintenance has moved to the > kernel.org-supported mp...@lists.linux.dev address. > > Complete, combined archives for both lists are now hosted at > ht

Re: [PATCH net] selftests: forwarding: vxlan_bridge_1d: Fix vxlan ecn decapsulate value

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 19 Mar 2021 22:33:14 +0800 you wrote: > The ECN bit defines ECT(1) = 1, ECT(0) = 2. So inner 0x02 + outer 0x01 > should be inner ECT(0) + outer ECT(1). Based on the description of > __INET_ECN_decapsulate, the final deca

[PATCH bpf-next 2/3] libbpf: skip BTF fixup if object file has no BTF

2021-03-19 Thread Andrii Nakryiko
Skip BTF fixup step when input object file is missing BTF altogether. Reported-by: Jiri Olsa Fixes: 8fd27bf69b86 ("libbpf: Add BPF static linker BTF and BTF.ext support") Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/linker.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/lib/b

[PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-19 Thread Andrii Nakryiko
Add ability to skip BTF generation for some BPF object files. This is done through using a convention of .nobtf.c file name suffix. Also add third statically linked file to static_linked selftest. This file has no BTF, causing resulting object file to have only some of DATASEC BTF types. It also i

[PATCH bpf-next 1/3] bpftool: improve skeleton generation for objects without BTF

2021-03-19 Thread Andrii Nakryiko
If BPF object file is using global variables, but is compiled without BTF or ends up having only some of DATASEC types due to static linking, generated skeleton won't compile, as some parts of skeleton would assume memory-mapped struct definitions for each special data section. Fix this by generat

[PATCH bpf-next 0/3] Handle no-BTF object files better

2021-03-19 Thread Andrii Nakryiko
Fix two issues caused by BPF object files with missing BTF type information: 1. BPF skeleton generated for BPF object files that use global variables but are compiled without BTF won't compile. 2. BPF static linker will crash attempting to fix up BTF for input object file with no BTF.

Re: [PATCH] net: stmmac: dwmac-sun8i: Provide TX and RX fifo sizes

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 19 Mar 2021 13:44:22 + you wrote: > MTU cannot be changed on dwmac-sun8i. (ip link set eth0 mtu xxx returning > EINVAL) > This is due to tx_fifo_size being 0, since this value is used to compute valid > MTU range. >

[PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-03-19 Thread Aaron Conole
When a user instructs a flow pipeline to perform connection tracking, there is an implicit L3 operation that occurs - namely the IP fragments are reassembled and then processed as a single unit. After this, new fragments are generated and then transmitted, with the hint that they should be fragmen

Re: [PATCH net-next 0/5] net: ipa: update configuration data

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 10:24:17 -0500 you wrote: > Each IPA version has a "data" file defining how various things are > configured. This series gathers a few updates to this information: > - The first patch makes all confi

Re: [PATCH bpf-next 04/15] bpf: Support bpf program calling kernel function

2021-03-19 Thread Martin KaFai Lau
On Thu, Mar 18, 2021 at 06:03:49PM -0700, Andrii Nakryiko wrote: > On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > > > This patch adds support to BPF verifier to allow bpf program calling > > kernel function directly. > > > > The use case included in this set is to allow bpf-tcp-cc to

Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

2021-03-19 Thread Marek Behún
On Fri, 19 Mar 2021 20:58:20 +0200 Vladimir Oltean wrote: > On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote: > > We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane` > > to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE. > > > > All other occurances in th

Re: [Linuxarm] [PATCH net] net: sched: fix packet stuck problem for lockless qdisc

2021-03-19 Thread Cong Wang
On Fri, Mar 19, 2021 at 2:25 AM Yunsheng Lin wrote: > I had done some performance test to see if there is value to > fix the packet stuck problem and support lockless qdisc bypass, > here is some result using pktgen in 'queue_xmit' mode on a dummy > device as Paolo Abeni had done in [1], and using

Re: [PATCH net] net: sched: fix packet stuck problem for lockless qdisc

2021-03-19 Thread Cong Wang
On Wed, Mar 17, 2021 at 11:52 PM Yunsheng Lin wrote: > > Lockless qdisc has below concurrent problem: > cpu0 cpu1 > . . > q->enqueue . > . . >qdisc_run_begin(). > .

Re: [PATCH bpf-next 03/15] bpf: Refactor btf_check_func_arg_match

2021-03-19 Thread Martin KaFai Lau
On Thu, Mar 18, 2021 at 04:32:47PM -0700, Andrii Nakryiko wrote: > On Tue, Mar 16, 2021 at 12:01 AM Martin KaFai Lau wrote: > > > > This patch refactors the core logic of "btf_check_func_arg_match()" > > into a new function "do_btf_check_func_arg_match()". > > "do_btf_check_func_arg_match()" will

Re: [PATCH net-next v2 0/3] Fixes applied to VCS8584 family

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 14:29:02 +0100 you wrote: > Three different fixes applied to VSC8584 family: > 1. LCPLL reset > 2. Serdes calibration > 3. Coma mode disabled > > The same fixes has already been applied to VSC8514 > an

Re: [PATCH][next] octeontx2-pf: Fix spelling mistake "ratelimitter" -> "ratelimiter"

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 09:54:53 + you wrote: > From: Colin Ian King > > There is a spelling mistake in an error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/marvell/octeontx2/nic/otx

Re: [PATCH net-next] octeontx2-pf: Fix missing spin_lock_init() in otx2_tc_add_flow()

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 09:41:03 + you wrote: > From: Wei Yongjun > > The driver allocates the spinlock but not initialize it. > Use spin_lock_init() on it to initialize it correctly. > > Fixes: d8ce30e0cf76 ("octeontx2-

Re: [PATCH net-next] net: enetc: teardown CBDR during PF/VF unbind

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 12:08:06 +0200 you wrote: > From: Vladimir Oltean > > Michael reports that after the blamed patch, unbinding a VF would cause > these transactions to remain pending, and trigger some warnings with the

Re: [PATCH net-next] atl1c: switch to napi_gro_receive

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 11:59:22 +0800 you wrote: > Changing to napi_gro_receive() improves efficiency significantly. Tested > on Intel Core2-based motherboards and iperf3. > > Signed-off-by: Sieng Piaw Liew > --- > drivers/

Re: [PATCH] atl1c: use napi_alloc_skb

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 12:13:22 +0800 you wrote: > Using napi_alloc_skb in NAPI context avoids enable/disable IRQs, which > increases iperf3 result by a few Mbps. Since napi_alloc_skb() uses > NET_IP_ALIGN, convert other alloc

Re: [PATCH v2 net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 18 Mar 2021 20:44:31 +0100 you wrote: > Here is what Vladimir says about it: > > at803x_aneg_done() keeps the aneg reporting as "not done" even when > the copper-side link was reported as up, but the in-band au

Re: [PATCH net-next 0/4] net: hinic; make some cleanup for hinic

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 14:36:21 +0800 you wrote: > This set try to remove the unnecessary output message, add a blank line, > remove the dupliate word and change the deprecated strlcp functions in > hinic driver, for details,

Re: [PATCH net-next] r8169: use lower_32_bits/upper_32_bits macros

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 19 Mar 2021 09:58:36 +0100 you wrote: > Use the lower_32_bits/upper_32_bits macros to simplify the code. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_main.c | 6 ++ > 1 file c

Re: [PATCH net-next 0/1] taprio: Handle short intervals and large packets

2021-03-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 18 Mar 2021 08:34:54 +0100 you wrote: > Hi, > > there is a problem with the software implementation of TAPRIO and TCP > communication. When using short intervals e.g. below one millisecond, large > packets won't be

Re: [PATCH net] mptcp: Change mailing list address

2021-03-19 Thread Matthieu Baerts
Hi Mat, On 19/03/2021 19:33, Mat Martineau wrote: The mailing list for MPTCP maintenance has moved to the kernel.org-supported mp...@lists.linux.dev address. Complete, combined archives for both lists are now hosted at https://lore.kernel.org/mptcp Cc: Matthieu Baerts Signed-off-by: Mat Marti

  1   2   3   >