[RESEND net 1/3] net: hns3: fix error mask definition of flow director

2021-02-26 Thread Huazhong Tan
From: Jian Shen Currently, some bit filed definitions of flow director TCAM configuration command are incorrect. Since the wrong MSB is always 0, and these fields are assgined in order, so it still works. Fix it by redefine them. Fixes: 117328680288 ("net: hns3: Add input key and action config

[RESEND net 3/3] net: hns3: fix bug when calculating the TCAM table info

2021-02-26 Thread Huazhong Tan
From: Jian Shen The function hclge_fd_convert_tuple() is used to convert tuples and tuples mask to TCAM x and y. But it misuses the source mac as source mac mask when convert INNER_SRC_MAC, which may cause the flow director rule works unexpectedly. So fix it. Fixes: 117328680288 ("net: hns3: Ad

[RESEND net 0/3] net: hns3: fixes fot -net

2021-02-26 Thread Huazhong Tan
The patchset includes some fixes for the HNS3 ethernet driver. Jian Shen (3): net: hns3: fix error mask definition of flow director net: hns3: fix query vlan mask value error for flow director net: hns3: fix bug when calculating the TCAM table info drivers/net/ethernet/hisilicon/hns3/hns3p

[RESEND net 2/3] net: hns3: fix query vlan mask value error for flow director

2021-02-26 Thread Huazhong Tan
From: Jian Shen Currently, the driver returns VLAN_VID_MASK for vlan mask field, when get flow director rule information for rule doesn't use vlan. It may cause the vlan mask value display as 0xf000 in this case, like below: estuary:/$ ethtool -u eth1 50 RX rings available Total 1 rules Filter:

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-02-26 Thread Kalle Valo
Nathan Chancellor writes: > On Tue, Feb 23, 2021 at 02:00:39PM +, Wei Yongjun wrote: >> Make sure dmi_system_id tables are NULL terminated. >> >> Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG >> feature") >> Reported-by: Hulk Robot >> Signed-off-by: Wei Yongjun

BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low! (2)

2021-02-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:557c223b selftests/bpf: No need to drop the packet when th.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=156409a8d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b8307379601586a dashboar

Re: [PATCH net 0/3] net: hns3: fixes fot -net

2021-02-26 Thread Huazhong Tan
Sorry, please ignore this series, will resend it later. On 2021/2/27 11:34, Huazhong Tan wrote: The patchset includes some fixes for the HNS3 ethernet driver. Jian Shen (3): net: hns3: fix error mask definition of flow director net: hns3: fix query vlan mask value error for flow director

[PATCH net 2/3] net: hns3: fix query vlan mask value error for flow director

2021-02-26 Thread Huazhong Tan
From: Jian Shen Currently, the driver returns VLAN_VID_MASK for vlan mask field, when get flow director rule information for rule doesn't use vlan. It may cause the vlan mask value display as 0xf000 in this case, like below: estuary:/$ ethtool -u eth1 50 RX rings available Total 1 rules Filter:

[PATCH net 0/3] net: hns3: fixes fot -net

2021-02-26 Thread Huazhong Tan
The patchset includes some fixes for the HNS3 ethernet driver. Jian Shen (3): net: hns3: fix error mask definition of flow director net: hns3: fix query vlan mask value error for flow director net: hns3: fix bug when calculating the TCAM table info drivers/net/ethernet/hisilicon/hns3/hns3p

[PATCH net 1/3] net: hns3: fix error mask definition of flow director

2021-02-26 Thread Huazhong Tan
From: Jian Shen Currently, some bit filed definitions of flow director TCAM configuration command are incorrect. Since the wrong MSB is always 0, and these fields are assgined in order, so it still works. Fix it by redefine them. fixes: 11732868 ("net: hns3: Add input key and action config supp

[PATCH net 3/3] net: hns3: fix bug when calculating the TCAM table info

2021-02-26 Thread Huazhong Tan
From: Jian Shen The function hclge_fd_convert_tuple() is used to convert tuples and tuples mask to TCAM x and y. But it misuses the source mac as source mac mask when convert INNER_SRC_MAC, which may cause the flow director rule works unexpectedly. So fix it. Fixes: 117328680288 ("net: hns3: Ad

[PATCH V2 net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Huazhong Tan
From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s because phydev->speed has been set to 50 and no update later. And duplex setting has same problem too.

RE: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-02-26 Thread Don Bollinger
On Fri, Feb 26, 2021 at 2:35 PM -0800, Andrew Lunn wrote: > On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > > optoe is an i2c based driver that supports read/write access to all > > the pages (tables) of MSA standard SFP and similar devices (conforming > > to the SFF-8472 spec), MS

Re: sk_lookup + test_bprm = huge delay

2021-02-26 Thread Alexei Starovoitov
On Fri, Feb 26, 2021 at 5:59 PM Alexei Starovoitov wrote: > > Crazy ideas are welcome :) So it was my .bashrc. Something in it was causing a delay. I've added this line to choke it for non-interactive shell: [ -z "$PS1" ] && return

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-26 Thread Kefeng Wang
On 2021/2/27 4:19, Cong Wang wrote: On Thu, Feb 25, 2021 at 5:39 PM Kefeng Wang wrote: On 2021/2/26 5:22, Cong Wang wrote: On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONF

Re: [PATCH v2] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 7:40 PM Jason A. Donenfeld wrote: > > There were a few remaining tunnel drivers that didn't receive the prior > conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to > memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from > icmp{,v6}_ndo_send

Re: [PATCH net v2] net: fix race between napi kthread mode and busy poll

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 17:35:21 -0800 Wei Wang wrote: > On Fri, Feb 26, 2021 at 5:22 PM Jakub Kicinski wrote: > > > > On Fri, 26 Feb 2021 17:02:17 -0800 Wei Wang wrote: > > > static int napi_thread_wait(struct napi_struct *napi) > > > { > > > + bool woken = false; > > > + > > > set_

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 7:42 PM Jason A. Donenfeld wrote: > > On Sat, Feb 27, 2021 at 12:29 AM Willem de Bruijn > wrote: > > > > On Fri, Feb 26, 2021 at 5:39 PM Jason A. Donenfeld wrote: > > > > > > On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn > > > wrote: > > > > > > > > On Thu, Feb 25, 2

sk_lookup + test_bprm = huge delay

2021-02-26 Thread Alexei Starovoitov
Hi KP, Lorenz, I need your help to debug a huge delay I'm seeing while running the test_progs. To debug it I've added the following printf-s: diff --git a/tools/testing/selftests/bpf/prog_tests/test_bprm_opts.c b/tools/testing/selftests/bpf/prog_tests/test_bprm_opts.c index 2559bb775762..cdd2182

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Huazhong Tan
On 2021/2/27 8:53, Andrew Lunn wrote: On Fri, Feb 26, 2021 at 03:44:42PM +0800, Huazhong Tan wrote: From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Huazhong Tan
On 2021/2/27 7:56, Jakub Kicinski wrote: On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote: From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s bec

Re: [PATCH net v2] net: fix race between napi kthread mode and busy poll

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 17:02:17 -0800 Wei Wang wrote: > static int napi_thread_wait(struct napi_struct *napi) > { > + bool woken = false; > + > set_current_state(TASK_INTERRUPTIBLE); > > while (!kthread_should_stop() && !napi_disable_pending(napi)) { > - if (test

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Andrew Lunn
On Fri, Feb 26, 2021 at 03:44:42PM +0800, Huazhong Tan wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0" shows speed is 50Mb/s because phydev->speed > has been

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 04:45:19PM -0800, Jakub Kicinski wrote: > I see, so this is indeed of practical importance to NXP. > > Would you mind re-spinning with an expanded justification? Sure, I'll do that tomorrow. Thanks.

Re: [PATCH net v2] net: fix race between napi kthread mode and busy poll

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 16:30:47 -0800 Wei Wang wrote: > thread = READ_ONCE(napi->thread); > if (thread) { > + set_bit(NAPI_STATE_SCHED_THREADED, &napi->state); > wake_up_process(thread); What about the version which checks RUNNING?

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Jakub Kicinski
On Sat, 27 Feb 2021 02:16:51 +0200 Vladimir Oltean wrote: > On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > > What I'm fixing is unexpected behavior, according to the applicable > > > standards I could find. If I do

[PATCH v2] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jason A. Donenfeld
There were a few remaining tunnel drivers that didn't receive the prior conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending") for details), there's even more imperative to have

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jason A. Donenfeld
On Sat, Feb 27, 2021 at 12:29 AM Willem de Bruijn wrote: > > On Fri, Feb 26, 2021 at 5:39 PM Jason A. Donenfeld wrote: > > > > On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn > > wrote: > > > > > > On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld > > > wrote: > > > > > > > > There were a f

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > > > I don't understand what you're fixing tho. > > > > > > Are we trying to establish vlan-filter-on as t

Re: [PATCH bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-02-26 Thread Daniel Borkmann
On 2/17/21 2:56 PM, Lorenzo Bianconi wrote: We want to change the current ndo_xdp_xmit drop semantics because it will allow us to implement better queue overflow handling. This is working towards the larger goal of a XDP TX queue-hook. Move XDP_REDIRECT error path handling from each XDP ethernet

[PATCH v3 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
Adds defines for lock state returns from lock_is_held_type() based on Johannes Berg's suggestions as it make it easier to read and maintain the lock states. These are defines and a enum to avoid changes to lock_is_held_type() and lockdep_is_held() return types. Updates to lock_is_held_type() and

[PATCH v3 3/3] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-26 Thread Shuah Khan
ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add call to lockdep_assert_not_held() on conf_mutex to detect if conf_mutex is held by the caller. The idea for this patch stemmed from coming across the comment block above the ath10k_drain_tx() while reviewin

[PATCH v3 0/3] Add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
Some kernel functions must not be called holding a specific lock. Doing so could lead to locking problems. Currently these routines call lock_is_held() to check for lock hold followed by WARN_ON. Adding a common lockdep interface will help reduce the duplication of this logic in the rest of the ke

[PATCH v3 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
Some kernel functions must be called without holding a specific lock. Add lockdep_assert_not_held() to be used in these functions to detect incorrect calls while holding a lock. lockdep_assert_not_held() provides the opposite functionality of lockdep_assert_held() which is used to assert calls tha

Re: [PATCH net 0/2] bnxt_en: Error recovery bug fixes.

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 26 Feb 2021 04:43:08 -0500 you wrote: > Two error recovery related bug fixes for 2 corner cases. > > Please queue patch #2 for -stable. Thanks. > > Edwin Peer (1): > bnxt_en: reliably allocate IRQ table on reset to

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0" shows speed is 50Mb/s because phydev->speed > has been set to

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 18:28:56 -0500 Willem de Bruijn wrote: > Please cc: the maintainers for patches that are meant to be merged, btw. I was about to say. Please repost.

Re: [net] tcp: Fix sign comparison bug in getsockopt(TCP_ZEROCOPY_RECEIVE)

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 15:26:28 -0800 you wrote: > From: Arjun Roy > > getsockopt(TCP_ZEROCOPY_RECEIVE) has a bug where we read a > user-provided "len" field of type signed int, and then compare the > value to the result of an "o

Re: [PATCH net 0/3] mlxsw: Various fixes

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 18:57:18 +0200 you wrote: > From: Ido Schimmel > > This patchset contains various fixes for mlxsw. > > Patch #1 fixes a race condition in a selftest. The race and fix are > explained in detail in the chan

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Jakub Kicinski
On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > > I don't understand what you're fixing tho. > > > > Are we trying to establish vlan-filter-on as the expected behavior? > > What I'm fixing is unexpected behavior, accor

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 07:23:31 -0800 Richard Cochran wrote: > On Thu, Feb 25, 2021 at 10:15:16PM +0100, Heiko Thiery wrote: > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > > This is only the case when the interface is down. This can be reproduced > > by reading with 'phc

Re: [PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 23:53:20 +0100 Andrew Lunn wrote: > On Thu, Feb 25, 2021 at 03:57:27PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_PM_SLEEP is disabled, the compiler warns about unused > > functions: > > > > drivers/net/phy/phy_device.c:273:12: error: unused funct

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > I don't understand what you're fixing tho. > > Are we trying to establish vlan-filter-on as the expected behavior? What I'm fixing is unexpected behavior, according to the applicable standards I could find. If I don't mark this chan

Re: [PATCH V5 net 0/5] ethernet: fixes for stmmac driver

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 17:01:09 +0800 you wrote: > Fixes for stmmac driver. > > --- > ChangeLogs: > V1->V2: > * subject prefix: ethernet: stmmac: -> net: stmmac: > * use dma_addr_t instead of unsigned int for physical

Re: [PATCH net] net: dsa: mt7530: don't build GPIO support if !GPIOLIB

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 26 Feb 2021 14:32:26 +0800 you wrote: > The new GPIO support may be optional at runtime, but it requires > building against gpiolib: > > ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] > undefined! > ERR

Re: [PATCH bpf-next V2 1/2] bpf: BPF-helper for MTU checking add length input

2021-02-26 Thread Daniel Borkmann
On 2/18/21 12:49 PM, Jesper Dangaard Brouer wrote: The FIB lookup example[1] show how the IP-header field tot_len (iph->tot_len) is used as input to perform the MTU check. This patch extend the BPF-helper bpf_check_mtu() with the same ability to provide the length as user parameter input, via mt

Re: [PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 15:38:31 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this option, the driver fails to link: > > ld.lld: error: undefined symbol: devlink_sb_register > [...] > > Fixes: f59fd9cab730 ("net: mscc: ocelot: configure watermarks using > devlink-sb") > Signed-o

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 5:39 PM Jason A. Donenfeld wrote: > > On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn > wrote: > > > > On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > > > > > There were a few remaining tunnel drivers that didn't receive the prior > > > conversion to icmp{

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 14:18:34 +0200 Vladimir Oltean wrote: > Quoting from the blamed commit: > > In promiscuous mode, it is more intuitive that all traffic is received, > including VLAN tagged traffic. It appears that it is necessary to set > the flag in PSIPVMR for that to be the case,

Re: pull-request: wireless-drivers-2021-02-26

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Fri, 26 Feb 2021 16:44:11 + (UTC) you wrote: > Hi, > > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. > > Kalle > > [...] Here is the summary with links:

Re: [RFC PATCH net-next 02/12] Documentation: networking: dsa: rewrite chapter about tagging protocol

2021-02-26 Thread Tobias Waldekranz
On Fri, Feb 26, 2021 at 20:12, Vladimir Oltean wrote: > On Thu, Feb 25, 2021 at 09:29:21PM +0100, Tobias Waldekranz wrote: >> This is not strictly true for mv88e6xxx. The connection between the tree >> and the CPU may use Ethertyped DSA tags, while inter-switch links use >> regular DSA tags. >> >

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 14:24:29 -0800 Wei Wang wrote: > > I'm not sure this takes care of rapid: > > > > dev_set_threaded(0) > > # NAPI gets sent to sirq > > dev_set_threaded(1) > > > > since subsequent set_threaded(1) doesn't spawn the thread "afresh". > > I think the race between softirq and kthre

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-26 Thread Xie He
On Fri, Feb 26, 2021 at 6:21 AM Martin Schiller wrote: > > I have now had a look at it. It works as expected. > I just wonder if it would not be more appropriate to call > the lapb_register() already in x25_hdlc_open(), so that the layer2 > (lapb) can already "work" before the hdlc_x25 interface i

Re: [PATCH] igb: unbreak I2C bit-banging on i350

2021-02-26 Thread Jesse Brandeburg
Jan Kundrát wrote: > The driver tried to use Linux' native software I2C bus master > (i2c-algo-bits) for exporting the I2C interface that talks to the SFP > cage(s) towards userspace. As-is, however, the physical SCL/SDA pins > were not moving at all, staying at logical 1 all the time. > > The ma

Re: [RFC PATCH v2 net-next 06/17] net: dsa: add addresses obtained from RX filtering to host addresses

2021-02-26 Thread Tobias Waldekranz
On Fri, Feb 26, 2021 at 15:28, Vladimir Oltean wrote: > On Fri, Feb 26, 2021 at 11:59:36AM +0100, Tobias Waldekranz wrote: >> On Wed, Feb 24, 2021 at 13:43, Vladimir Oltean wrote: >> > From: Vladimir Oltean >> > >> > In case we have ptp4l running on a bridged DSA switch interface, the PTP >> > t

Re: [PATCH 0/2] More strict error checking in bpf_asm (v3).

2021-02-26 Thread Ian Denhardt
Quoting Daniel Borkmann (2021-02-26 17:00:58) > Applied, thanks! You're welcome!

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-02-26 Thread Andrew Lunn
On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > optoe is an i2c based driver that supports read/write access to all > the pages (tables) of MSA standard SFP and similar devices (conforming > to the SFF-8472 spec), MSA standard QSFP and similar devices (conforming > to the SFF-8636

Re: [PATCH bpf-next V2 0/2] bpf: Updates for BPF-helper bpf_check_mtu

2021-02-26 Thread Daniel Borkmann
On 2/19/21 7:36 AM, Jesper Dangaard Brouer wrote: On Thu, 18 Feb 2021 12:49:53 +0100 Jesper Dangaard Brouer wrote: The FIB lookup example[1] show how the IP-header field tot_len (iph->tot_len) is used as input to perform the MTU check. The recently added MTU check helper bpf_check_mtu() should

Re: [PATCH net 2/2] igb: Fix duplicate include guard

2021-02-26 Thread Jesse Brandeburg
Tom Seewald wrote: > The include guard "_E1000_HW_H_" is used by two separate header files in > two different drivers (e1000/e1000_hw.h and igb/e1000_hw.h). Using the > same include guard macro in more than one header file may cause > unexpected behavior from the compiler. Fix this by renaming the

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Jason A. Donenfeld
On Fri, Feb 26, 2021 at 10:25 PM Willem de Bruijn wrote: > > On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > > > There were a few remaining tunnel drivers that didn't receive the prior > > conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to > > memory corrution (se

Re: [PATCH 0/2] More strict error checking in bpf_asm (v3).

2021-02-26 Thread Daniel Borkmann
On 2/24/21 10:24 PM, Ian Denhardt wrote: Gah, managed to typo my own name in the v2 patch >.< This one should be good :/ Ian Denhardt (2): tools, bpf_asm: Hard error on out of range jumps. tools, bpf_asm: exit non-zero on errors. tools/bpf/bpf_exp.y | 14 -- 1 file changed

Re: [PATCH bpf-next v4 1/2] bpf, xdp: make bpf_redirect_map() a map operation

2021-02-26 Thread Daniel Borkmann
On 2/26/21 12:23 PM, Björn Töpel wrote: From: Björn Töpel Currently the bpf_redirect_map() implementation dispatches to the correct map-lookup function via a switch-statement. To avoid the dispatching, this change adds bpf_redirect_map() as a map operation. Each map provides its bpf_redirect_ma

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-02-26 Thread vic . michel . web
This fixes a BUG triggered when loading the iwlwifi driver, which reproduces consistently when I compile the kernel with LTO_CLANG_THIN. Tested-by: Victor Michel

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 10:28:00 -0800 Wei Wang wrote: > Hi Martin, > Could you help try the following new patch on your setup and let me > know if there are still issues? FWIW your email got line wrapped for me. > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index ddf4cfc1261

[PATCH ipsec 0/2] vti(6): fix ipv4 pmtu check to honor ip header df

2021-02-26 Thread Eyal Birger
This series aligns vti(6) handling of non-df IPv4 packets exceeding the size of the tunnel MTU to avoid sending "Frag needed" and instead fragment the packets after encapsulation. Eyal Birger (2): vti: fix ipv4 pmtu check to honor ip header df vti6: fix ipv4 pmtu check to honor ip header df

[PATCH ipsec 1/2] vti: fix ipv4 pmtu check to honor ip header df

2021-02-26 Thread Eyal Birger
Frag needed should only be sent if the header enables DF. This fix allows packets larger than MTU to pass the vti interface and be fragmented after encapsulation, aligning behavior with non-vti xfrm. Fixes: d6af1a31cc72 ("vti: Add pmtu handling to vti_xmit.") Signed-off-by: Eyal Birger --- net/

[PATCH ipsec 2/2] vti6: fix ipv4 pmtu check to honor ip header df

2021-02-26 Thread Eyal Birger
Frag needed should only be sent if the header enables DF. This fix allows IPv4 packets larger than MTU to pass the vti6 interface and be fragmented after encapsulation, aligning behavior with non-vti6 xfrm. Fixes: ccd740cbc6e0 ("vti6: Add pmtu handling to vti6_xmit.") Signed-off-by: Eyal Birger

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-26 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When the ocelot driver code is in a library, the dsa tag > code cannot be built-in: > > ld.lld: error: undefined symbol: ocelot_can_inject > >>> referenced by tag_ocelot_8021q.c > >>> dsa/tag_o

Re: [PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-26 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 3:15 PM Cong Wang wrote: > > On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang wrote: > > v3: > > - Fix the code format. > > > > v2: > > Suggested-by: Willem de Bruijn > > - Add a new flag to specify the type of the inner packet. > > These need to be moved after '---', otherwi

Re: [PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

2021-02-26 Thread Willem de Bruijn
On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > There were a few remaining tunnel drivers that didn't receive the prior > conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to > memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from > icmp{,v6}_ndo_send

[PATCH net] net: Fix gro aggregation for udp encaps with zero csum

2021-02-26 Thread Daniel Borkmann
We noticed a GRO issue for UDP-based encaps such as vxlan/geneve when the csum for the UDP header itself is 0. In that case, GRO aggregation does not take place on the phys dev, but instead is deferred to the vxlan/geneve driver (see trace below). The reason is essentially that GRO aggregation bai

Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
On 2/26/21 2:07 PM, Peter Zijlstra wrote: On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote: + /* avoid false negative lockdep_assert_not_held() +* and lockdep_assert_held() +*/ That's a coding style fail. Checkpatch didn't complain. Wh

Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Peter Zijlstra
On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote: > + /* avoid false negative lockdep_assert_not_held() > + * and lockdep_assert_held() > + */ That's a coding style fail.

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-02-26 Thread Nathan Chancellor
On Tue, Feb 23, 2021 at 02:00:39PM +, Wei Yongjun wrote: > Make sure dmi_system_id tables are NULL terminated. > > Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG > feature") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun We received a report about a crash

Re: [PATCH bpf-next v2 0/5] PROG_TEST_RUN support for sk_lookup programs

2021-02-26 Thread Alexei Starovoitov
On Fri, Feb 26, 2021 at 2:31 AM Lorenz Bauer wrote: > > We don't have PROG_TEST_RUN support for sk_lookup programs at the > moment. So far this hasn't been a problem, since we can run our > tests in a separate network namespace. For benchmarking it's nice > to have PROG_TEST_RUN, so I've gone and

Re: [Patch bpf-next v7 0/9] sock_map: clean up and refactor code for BPF_SK_SKB_VERDICT

2021-02-26 Thread Alexei Starovoitov
On Tue, Feb 23, 2021 at 10:51 AM Cong Wang wrote: > > From: Cong Wang > > This patchset is the first series of patches separated out from > the original large patchset, to make reviews easier. This patchset > does not add any new feature or change any functionality but merely > cleans up the exis

Re: [PATCH v4] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

2021-02-26 Thread Marcel Holtmann
Hi Miao-chen, > This moves msft_do_close() from hci_dev_do_close() to > hci_unregister_dev() to avoid clearing MSFT extension info. This also > re-reads MSFT info upon every msft_do_open() even if MSFT extension has > been initialized. > > The following test steps were performed. > (1) boot the t

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-26 Thread Cong Wang
On Thu, Feb 25, 2021 at 5:39 PM Kefeng Wang wrote: > > > On 2021/2/26 5:22, Cong Wang wrote: > > On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang > > wrote: > >> HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move > >> 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE inste

Re: [PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-26 Thread Cong Wang
On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang wrote: > v3: > - Fix the code format. > > v2: > Suggested-by: Willem de Bruijn > - Add a new flag to specify the type of the inner packet. These need to be moved after '---', otherwise it would be merged into the final git log. > > Suggested-by: Will

Re: [PATCH v6 bpf-next 0/6] bpf: enable task local storage for tracing programs

2021-02-26 Thread Alexei Starovoitov
On Thu, Feb 25, 2021 at 4:04 PM Martin KaFai Lau wrote: > > On Thu, Feb 25, 2021 at 03:43:13PM -0800, Song Liu wrote: > > This set enables task local storage for non-BPF_LSM programs. > > > > It is common for tracing BPF program to access per-task data. Currently, > > these data are stored in hash

Re: [PATCH bpf-next] bpf: fix missing * in bpf.h

2021-02-26 Thread Andrii Nakryiko
On Fri, Feb 26, 2021 at 8:50 AM Quentin Monnet wrote: > > 2021-02-24 10:59 UTC-0800 ~ Andrii Nakryiko > > On Wed, Feb 24, 2021 at 7:55 AM Daniel Borkmann > > wrote: > >> > >> On 2/23/21 3:43 PM, Jesper Dangaard Brouer wrote: > >>> On Tue, 23 Feb 2021 20:45:54 +0800 > >>> Hangbin Liu wrote: > >

[PATCH] net/core/skbuff.c: __netdev_alloc_skb fix when len is greater than KMALLOC_MAX_SIZE

2021-02-26 Thread Pavel Skripkin
syzbot found WARNING in __alloc_pages_nodemask()[1] when order >= MAX_ORDER. It was caused by __netdev_alloc_skb(), which doesn't check len value after adding NET_SKB_PAD. Order will be >= MAX_ORDER and passed to __alloc_pages_nodemask() if size > KMALLOC_MAX_SIZE. static void *kmalloc_large_nod

Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

2021-02-26 Thread Bjorn Helgaas
On Fri, Feb 26, 2021 at 02:31:31PM +0100, Heiner Kallweit wrote: > On 26.02.2021 13:18, Kai-Heng Feng wrote: > > On Fri, Feb 26, 2021 at 8:10 PM Heiner Kallweit > > wrote: > >> > >> On 26.02.2021 08:12, Kalle Valo wrote: > >>> Kai-Heng Feng writes: > >>> > Now we have a generic D3 shutdown

Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
On 2/26/21 11:03 AM, Johannes Berg wrote: @@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map *lock, int read) /* avoid false negative lockdep_assert_not_held() * and lockdep_assert_held() */ - return -1;

Re: [PATCH net-next 4/4] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge

2021-02-26 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 08:25:23PM +0100, Tobias Waldekranz wrote: > On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > DSA has gained the recent ability to deal gracefully with upper > > interfaces it cannot offload, such as the bridge, bonding or team > > dr

Re: [RFC PATCH net-next 02/12] Documentation: networking: dsa: rewrite chapter about tagging protocol

2021-02-26 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 09:29:21PM +0100, Tobias Waldekranz wrote: > This is not strictly true for mv88e6xxx. The connection between the tree > and the CPU may use Ethertyped DSA tags, while inter-switch links use > regular DSA tags. > > However, I think it is better to keep this definition short,

Re: [RFC PATCH v2 net-next 15/17] net: dsa: replay port and local fdb entries when joining the bridge

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 01:23:23PM +0100, Tobias Waldekranz wrote: > If VLAN filtering is enabled, we would also have to replay that. Port > attributes also, right? > > I like the pull model, because it saves the bridge from doing lots of > dumpster diving. However, should there be a single `bridg

Re: [RFC PATCH net-next 08/12] Documentation: networking: dsa: add paragraph for the LAG offload

2021-02-26 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 09:42:28PM +0100, Tobias Waldekranz wrote: > On Sun, Feb 21, 2021 at 23:33, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Add a short summary of the methods that a driver writer must implement > > for offloading a link aggregation group, and what is still missin

Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Johannes Berg
> @@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map > *lock, int read) > /* avoid false negative lockdep_assert_not_held() >* and lockdep_assert_held() >*/ > - return -1; > + return LOCK_STATE_UNKNOW

Re: [PATCH 5/5] ath10k: reduce invalid ht params rate message noise

2021-02-26 Thread Shuah Khan
On 2/11/21 4:24 AM, Kalle Valo wrote: Shuah Khan writes: On 2/10/21 1:28 AM, Kalle Valo wrote: Wen Gong writes: On 2021-02-10 08:42, Shuah Khan wrote: ath10k_mac_get_rate_flags_ht() floods dmesg with the following messages, when it fails to find a match for mcs=7 and rate=1440. supported

[PATCH v2 3/3] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-26 Thread Shuah Khan
ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add call to lockdep_assert_not_held() on conf_mutex to detect if conf_mutex is held by the caller. The idea for this patch stemmed from coming across the comment block above the ath10k_drain_tx() while reviewin

[PATCH v2 2/3] lockdep: add lockdep lock state defines

2021-02-26 Thread Shuah Khan
Adds defines for lock state returns from lock_is_held_type() based on Johannes Berg's suggestions as it make it easier to read and maintain the lock states. These are defines and a enum to avoid changes to lock_is_held_type() and lockdep_is_held() return types. Link: https://lore.kernel.org/lkml/

[PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
Some kernel functions must be called without holding a specific lock. Add lockdep_assert_not_held() to be used in these functions to detect incorrect calls while holding a lock. lockdep_assert_not_held() provides the opposite functionality of lockdep_assert_held() which is used to assert calls tha

[PATCH v2 0/3] Add lockdep_assert_not_held()

2021-02-26 Thread Shuah Khan
Some kernel functions must not be called holding a specific lock. Doing so could lead to locking problems. Currently these routines call lock_is_held() to check for lock hold followed by WARN_ON. Adding a common lockdep interface will help reduce the duplication of this logic in the rest of the ke

Re: [PATCH net v4 1/1] can: can_skb_set_owner(): fix ref counting if socket was closed before setting skb ownership

2021-02-26 Thread Oliver Hartkopp
On 26.02.21 10:24, Oleksij Rempel wrote: There are two ref count variables controlling the free()ing of a socket: - struct sock::sk_refcnt - which is changed by sock_hold()/sock_put() - struct sock::sk_wmem_alloc - which accounts the memory allocated by the skbs in the send path. In case t

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Florian Fainelli
On 2/26/2021 8:14 AM, Daniel González Cabanelas wrote: > I could update the BCM5365 phy_id in the downstream B53 driver to fix > it and avoid any kind of future conflicts if the driver is upstreamed. > Accordingly to documentation the whole BCM5365 UID (not masked) is > 0x00406370. > PHYID HIGH[

Re: [PATCH bpf-next] bpf: fix missing * in bpf.h

2021-02-26 Thread Quentin Monnet
2021-02-24 10:59 UTC-0800 ~ Andrii Nakryiko > On Wed, Feb 24, 2021 at 7:55 AM Daniel Borkmann wrote: >> >> On 2/23/21 3:43 PM, Jesper Dangaard Brouer wrote: >>> On Tue, 23 Feb 2021 20:45:54 +0800 >>> Hangbin Liu wrote: >>> Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") lost a

Re: Spurious TCP retransmissions on ack vs kfree_skb reordering

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 17:35:11 +0100 Eric Dumazet wrote: > On Fri, Feb 26, 2021 at 5:09 PM Jakub Kicinski wrote: > > On Fri, 26 Feb 2021 11:41:22 +0100 Eric Dumazet wrote: > > > Yes, this packetdrill test confirms TCP INFO stuff seems correct . > > > > Looks like it's TcpExtTCPSpuriousRtxHostQue

pull-request: wireless-drivers-2021-02-26

2021-02-26 Thread Kalle Valo
Hi, here's a pull request to net tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit 773dc50d71690202afd7b5017c060c6ca8c75dd9: Merge branch 'Xilinx-axienet-updates' (2021-02-12 17:38:53 -0800) are available in the git repository at:

Re: TCP stall issue

2021-02-26 Thread Gil Pedersen
> On 26 Feb 2021, at 15.39, David Laight wrote: > > Some thoughts... > > Does a non-android linux system behave correctly through the same NAT > gateways? > Particularly with a similar kernel version. > > If you have a USB OTG cable and USB ethernet dongle you may be able to get > android to

  1   2   >