Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-15 Thread Felix Fietkau
On 2021-02-16 08:03, Kalle Valo wrote: > Shuah Khan wrote: > >> ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() >> return pointer (sta) outside null check. Fix it by moving the code >> block under the null check. >> >> This problem was found while reviewing code to debug RCU

Re: [PATCH v2] fix coding style in driver/staging/qlge/qlge_main.c

2021-02-15 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 03:35:26PM +0800, Du Cheng wrote: > align * in block comments on each line > > Signed-off-by: Du Cheng > --- > drivers/staging/qlge/qlge_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c > b/drivers/stagin

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 11:30:25PM -0800, Xie He wrote: > On Mon, Feb 15, 2021 at 10:04 PM Leon Romanovsky wrote: > > > > On Mon, Feb 15, 2021 at 11:08:02AM -0800, Xie He wrote: > > > On Mon, Feb 15, 2021 at 10:54 AM Leon Romanovsky wrote: > > > > > > > > On Mon, Feb 15, 2021 at 09:23:32AM -0800,

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > > > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well > > > in mlx5v_remove(). > > > >

[PATCH v2] fix coding style in driver/staging/qlge/qlge_main.c

2021-02-15 Thread Du Cheng
align * in block comments on each line Signed-off-by: Du Cheng --- drivers/staging/qlge/qlge_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 5516be3af898..2682a0e474bd 100644 --- a/drivers/stag

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 03:01:06PM -0600, Bjorn Helgaas wrote: > On Tue, Feb 09, 2021 at 03:34:42PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Extend PCI sysfs interface with a new callback that allows configuration > > of the number of MSI-X vectors for specific SR-IOV VF. Th

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Xie He
On Mon, Feb 15, 2021 at 10:04 PM Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 11:08:02AM -0800, Xie He wrote: > > On Mon, Feb 15, 2021 at 10:54 AM Leon Romanovsky wrote: > > > > > > On Mon, Feb 15, 2021 at 09:23:32AM -0800, Xie He wrote: > > > > On Mon, Feb 15, 2021 at 1:25 AM Leon Romanovs

Re: [PATCH] fix coding style in driver/staging/qlge/qlge_main.c

2021-02-15 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 03:18:49PM +0800, Du Cheng wrote: > align * in block comments on each line > > Signed-off-by: Du Cheng > --- > drivers/staging/qlge/qlge_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/qlge/qlge_main.c > b/drivers/staging/

linux-next: manual merge of the gpio-brgl tree with the arm-soc, net-next trees

2021-02-15 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the gpio-brgl tree got a conflict in: arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts between commits: 4fd18fc38757 ("arm64: dts: visconti: Add watchdog support for TMPV7708 SoC") 0109a17564fc ("arm: dts: visconti: Add DT support for Toshiba Visconti5

linux-next: manual merge of the gpio-brgl tree with the net-next tree

2021-02-15 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the gpio-brgl tree got a conflict in: MAINTAINERS between commit: df53e4f48e8d ("MAINTAINERS: Add entries for Toshiba Visconti ethernet controller") from the net-next tree and commit: 5103c90d133c ("MAINTAINERS: Add entries for Toshiba Visconti GPIO

[PATCH] fix coding style in driver/staging/qlge/qlge_main.c

2021-02-15 Thread Du Cheng
align * in block comments on each line Signed-off-by: Du Cheng --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 5516be3af898..bfd7217f3953 100644 --- a/drivers/stagin

Re: [PATCH][next] ath11k: debugfs: Fix spelling mistake "Opportunies" -> "Opportunities"

2021-02-15 Thread Kalle Valo
Colin King wrote: > There is a spelling mistake in some debug text, fix this. > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 9c349dbd0752 ath11k: debugfs: Fix spelling mistake "Opportunies" -> "Opportunities" -- https://p

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-15 Thread Kalle Valo
Shuah Khan wrote: > ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() > return pointer (sta) outside null check. Fix it by moving the code > block under the null check. > > This problem was found while reviewing code to debug RCU warn from > ath10k_wmi_tlv_parse_peer_stats_info()

Re: [RFC PATCH v4 02/17] af_vsock: separate wait data loop

2021-02-15 Thread Arseny Krasnov
On 11.02.2021 18:11, Jorgen Hansen wrote: >> On 7 Feb 2021, at 16:14, Arseny Krasnov wrote: >> >> This moves wait loop for data to dedicated function, because later >> it will be used by SEQPACKET data receive loop. >> >> Signed-off-by: Arseny Krasnov >> --- >> net/vmw_vsock/af_vsock.c | 158 ++

[Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to skb

2021-02-15 Thread Cong Wang
From: Cong Wang Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly does not work for any other non-TCP protocols. We can move them to skb ext, but it introduces a memory allocation on fast path. Fortunately, we only need to a word-size to store all the information, because the flag

[Patch bpf-next v4 5/5] sock_map: rename skb_parser and skb_verdict

2021-02-15 Thread Cong Wang
From: Cong Wang These two eBPF programs are tied to BPF_SK_SKB_STREAM_PARSER and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact they are only used for TCP. And save the name 'skb_verdict' for general use later. Cc: Daniel Borkmann Cc: Jakub Sitnicki Reviewed-by: Lorenz Bauer Acked

[Patch bpf-next v4 3/5] bpf: compute data_end dynamically with JIT code

2021-02-15 Thread Cong Wang
From: Cong Wang Currently, we compute ->data_end with a compile-time constant offset of skb. But as Jakub pointed out, we can actually compute it in eBPF JIT code at run-time, so that we can competely get rid of ->data_end. This is similar to skb_shinfo(skb) computation in bpf_convert_shinfo_acce

[Patch bpf-next v4 1/5] bpf: clean up sockmap related Kconfigs

2021-02-15 Thread Cong Wang
From: Cong Wang As suggested by John, clean up sockmap related Kconfigs: Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream parser, to reflect its name. Make the rest sockmap code simply depend on CONFIG_BPF_SYSCALL. And leave CONFIG_NET_SOCK_MSG untouched, as it is used by non-soc

[Patch bpf-next v4 2/5] skmsg: get rid of struct sk_psock_parser

2021-02-15 Thread Cong Wang
From: Cong Wang struct sk_psock_parser is embedded in sk_psock, it is unnecessary as skb verdict also uses ->saved_data_ready. We can simply fold these fields into sk_psock, and get rid of ->enabled. Cc: Daniel Borkmann Cc: Lorenz Bauer Acked-by: John Fastabend Acked-by: Jakub Sitnicki Signe

[Patch bpf-next v4 0/5] sock_map: clean up and refactor code for BPF_SK_SKB_VERDICT

2021-02-15 Thread Cong Wang
From: Cong Wang This patchset is the first series of patches separated out from the original large patchset, to make reviews easier. This patchset does not add any new feature or change any functionality but merely cleans up the existing sockmap and skmsg code and refactors it, to prepare for the

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Eli Cohen
On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well > > in mlx5v_remove(). > > > > Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well > in mlx5v_remove(). > > Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus") > Signed-off-by: Eli Cohen > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c |

Re: [PATCH iproute2-rc] rdma: Fix statistics bind/unbing argument handling

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 06:56:26PM -0700, David Ahern wrote: > On 2/14/21 10:40 PM, Leon Romanovsky wrote: > > On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote: > >> what does iproute2-rc mean? > > > > Patch target is iproute2.git: > > https://git.kernel.org/pub/scm/network/iproute2/ipro

Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 11:08:02AM -0800, Xie He wrote: > On Mon, Feb 15, 2021 at 10:54 AM Leon Romanovsky wrote: > > > > On Mon, Feb 15, 2021 at 09:23:32AM -0800, Xie He wrote: > > > On Mon, Feb 15, 2021 at 1:25 AM Leon Romanovsky wrote: > > > > > > > > > + /* When transmitting data: > > > >

[PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Eli Cohen
struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well in mlx5v_remove(). Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus") Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-15 Thread Eli Cohen
struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well in mlx5v_remove(). Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus") Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] ionic: Remove unused function pointer typedef ionic_reset_cb

2021-02-15 Thread Chen Lin
From: Chen Lin Remove the 'ionic_reset_cb' typedef as it is not used. Signed-off-by: Chen Lin --- drivers/net/ethernet/pensando/ionic/ionic_lif.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.h b/drivers/net/ethernet/pensando/ionic/ionic

[PATCH] cw1200: Remove unused function pointer typedef wsm_*

2021-02-15 Thread Chen Lin
From: Chen Lin Remove the 'wsm_*' typedef as it is not used. Signed-off-by: Chen Lin --- drivers/net/wireless/st/cw1200/wsm.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/wsm.h b/drivers/net/wireless/st/cw1200/wsm.h index 1ffa479..89fdc91 1

[PATCH] cw1200: Remove unused function pointer typedef cw1200_wsm_handler

2021-02-15 Thread Chen Lin
From: Chen Lin Remove the 'cw1200_wsm_handler' typedef as it is not used. Signed-off-by: Chen Lin --- drivers/net/wireless/st/cw1200/bh.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/bh.c b/drivers/net/wireless/st/cw1200/bh.c index c364a39..8bade5d 1

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread Cong Wang
On Mon, Feb 15, 2021 at 5:50 PM John Fastabend wrote: > > Cong Wang wrote: > > On Mon, Feb 15, 2021 at 4:54 PM John Fastabend > > wrote: > > > > > > Cong Wang wrote: > > > > On Mon, Feb 15, 2021 at 3:57 PM John Fastabend > > > > wrote: > > > > > > > > > > For TCP case we can continue to use CB

Re: [PATCH bpf-next 2/3] libbpf: clear map_info before each bpf_obj_get_info_by_fd

2021-02-15 Thread Maciej Fijalkowski
On Mon, Feb 15, 2021 at 12:33:37PM -0800, John Fastabend wrote: > Maciej Fijalkowski wrote: > > xsk_lookup_bpf_maps, based on prog_fd, looks whether current prog has a > > reference to XSKMAP. BPF prog can include insns that work on various BPF > > maps and this is covered by iterating through map_

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Maciej Fijalkowski
On Mon, Feb 15, 2021 at 12:49:27PM -0800, John Fastabend wrote: > Maciej Fijalkowski wrote: > > Currently, if there are multiple xdpsock instances running on a single > > interface and in case one of the instances is terminated, the rest of > > them are left in an inoperable state due to the fact o

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Maciej Fijalkowski
On Mon, Feb 15, 2021 at 04:18:28PM -0800, John Fastabend wrote: > Toke Høiland-Jørgensen wrote: > > John Fastabend writes: > > > > >> > However, in libxdp we can solve the original problem in a different > > >> > way, > > >> > and in fact I already suggested to Magnus that we should do this (see

RE: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-15 Thread nobuhiro1.iwamatsu
Hi, > -Original Message- > From: Stephen Rothwell [mailto:s...@canb.auug.org.au] > Sent: Tuesday, February 16, 2021 11:05 AM > To: David Miller ; Networking ; > Olof Johansson ; Arnd > Bergmann ; ARM > Cc: Bartosz Golaszewski ; Linux Kernel Mailing > List ; Linux > Next Mailing List ; i

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Maciej Fijalkowski
On Mon, Feb 15, 2021 at 12:22:36PM -0800, John Fastabend wrote: > Björn Töpel wrote: > > On 2021-02-15 18:07, Toke Høiland-Jørgensen wrote: > > > Maciej Fijalkowski writes: > > > > > >> Currently, if there are multiple xdpsock instances running on a single > > >> interface and in case one of the

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Maciej Fijalkowski
On Mon, Feb 15, 2021 at 08:35:29PM +0100, Toke Høiland-Jørgensen wrote: > Björn Töpel writes: > > > On 2021-02-15 18:07, Toke Høiland-Jørgensen wrote: > >> Maciej Fijalkowski writes: > >> > >>> Currently, if there are multiple xdpsock instances running on a single > >>> interface and in case on

linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-15 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts arch/arm64/boot/dts/toshiba/tmpv7708.dtsi between commits: 4fd18fc38757 ("arm64: dts: visconti: Add watchdog support for TMPV7708 SoC") 0109a17564fc ("arm: dts: visco

Re: [PATCH iproute2-rc] rdma: Fix statistics bind/unbing argument handling

2021-02-15 Thread David Ahern
On 2/14/21 10:40 PM, Leon Romanovsky wrote: > On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote: >> what does iproute2-rc mean? > > Patch target is iproute2.git: > https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/ so you are asking them to be committed for the 5.11 release?

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread John Fastabend
Cong Wang wrote: > On Mon, Feb 15, 2021 at 4:54 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > On Mon, Feb 15, 2021 at 3:57 PM John Fastabend > > > wrote: > > > > > > > > For TCP case we can continue to use CB and not pay the price. For UDP > > > > and AF_UNIX we can do the extra all

[PATCH net-next v3 5/5] TEST ONLY: lan743x: skb_trim failure test

2021-02-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Simulate low-memory in lan743x_rx_trim_skb(): fail one allocation in every 100. Signed-off-by: Sven Van Asbroeck --- To: Bryan Whitehead To: unglinuxdri...@microchip.com To: "David S. Miller" To: Jakub Kicinski Cc: Andrew Lunn Cc: Alexey Denisov Cc: Sergej Bauer C

[PATCH net-next v3 4/5] TEST ONLY: lan743x: skb_alloc failure test

2021-02-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Simulate low-memory in lan743x_rx_allocate_skb(): fail 10 allocations in a row in every 100. Signed-off-by: Sven Van Asbroeck --- To: Bryan Whitehead To: unglinuxdri...@microchip.com To: "David S. Miller" To: Jakub Kicinski Cc: Andrew Lunn Cc: Alexey Denisov Cc: Se

[PATCH net-next v3 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck On cpu architectures w/o dma cache snooping, dma_unmap() is a is a very expensive operation, because its resulting sync needs to invalidate cpu caches. Increase efficiency/performance by syncing only those sections of the lan743x's rx ring buffers that are actually in use

[PATCH net-next v3 3/5] TEST ONLY: lan743x: limit rx ring buffer size to 500 bytes

2021-02-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Signed-off-by: Sven Van Asbroeck --- To: Bryan Whitehead To: unglinuxdri...@microchip.com To: "David S. Miller" To: Jakub Kicinski Cc: Andrew Lunn Cc: Alexey Denisov Cc: Sergej Bauer Cc: Tim Harvey Cc: Anders Rønningen Cc: Hillf Danton Cc: Christoph Hellwig Cc:

[PATCH net-next v3 0/5] lan743x speed boost

2021-02-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git # 9ec5eea5b6ac v2 -> v3: - Bryan Whitehead: + add Bryan's reviewed-by tag to patch 1/5. + Only use FRAME_LENGTH if the LS bit is checked. If set use the smaller of FRAME_LENGTH or buff

[PATCH net-next v3 1/5] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck The buffers in the lan743x driver's receive ring are always 9K, even when the largest packet that can be received (the mtu) is much smaller. This performs particularly badly on cpu archs without dma cache snooping (such as ARM): each received packet results in a 9K dma_{ma

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread Cong Wang
On Mon, Feb 15, 2021 at 4:54 PM John Fastabend wrote: > > Cong Wang wrote: > > On Mon, Feb 15, 2021 at 3:57 PM John Fastabend > > wrote: > > > > > > For TCP case we can continue to use CB and not pay the price. For UDP > > > and AF_UNIX we can do the extra alloc. > > > > I see your point, but sp

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread John Fastabend
Cong Wang wrote: > On Mon, Feb 15, 2021 at 3:57 PM John Fastabend > wrote: > > > > For TCP case we can continue to use CB and not pay the price. For UDP > > and AF_UNIX we can do the extra alloc. > > I see your point, but specializing TCP case does not give much benefit > here, the skmsg code wo

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread Cong Wang
On Mon, Feb 15, 2021 at 3:57 PM John Fastabend wrote: > > For TCP case we can continue to use CB and not pay the price. For UDP > and AF_UNIX we can do the extra alloc. I see your point, but specializing TCP case does not give much benefit here, the skmsg code would have to check skb->protocol et

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread John Fastabend
Toke Høiland-Jørgensen wrote: > John Fastabend writes: > > >> > However, in libxdp we can solve the original problem in a different way, > >> > and in fact I already suggested to Magnus that we should do this (see > >> > [1]); so one way forward could be to address it during the merge in > >> > l

pull-request: bpf-next 2021-02-16

2021-02-15 Thread Daniel Borkmann
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net-next* tree. There's a small merge conflict between 7eeba1706eba ("tcp: Add receive timestamp support for receive zerocopy.") from net-next tree and 9cacf81f8161 ("bpf: Remove extra lock_sock for TCP_ZEROCOPY_RECEIV

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread John Fastabend
Cong Wang wrote: > On Mon, Feb 15, 2021 at 11:20 AM John Fastabend > wrote: > > > > Cong Wang wrote: > > > From: Cong Wang > > > > > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > > > does not work for any other non-TCP protocols. We can move them to > > > skb ext instead of

Re: KASAN: null-ptr-deref Read in tcf_idrinfo_destroy

2021-02-15 Thread Cong Wang
On Wed, Feb 10, 2021 at 9:53 PM syzbot wrote: > > syzbot has found a reproducer for the following issue on: > > HEAD commit:291009f6 Merge tag 'pm-5.11-rc8' of git://git.kernel.org/p.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14470d18d0 > kerne

Re: [PATCH net-next] ibmvnic: simplify reset_long_term_buff function

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 20:36:10 -0600 you wrote: > The only thing reset_long_term_buff() should do is set > buffer to zero. After doing that, it is not necessary to > send_request_map again to VIOS since it actually does not >

Re: [PATCH 5.12] net: broadcom: bcm4908_enet: set MTU on open & on request

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 16:21:35 +0100 you wrote: > From: Rafał Miłecki > > Hardware comes up with default max frame size set to 1518. When using it > with switch it results in actual Ethernet MTU 1492: > 1518 - 14 (Ethernet

Re: [PATCH] i40e: Fix incorrect use of ip6src due to copy-paste coding error

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 15 Feb 2021 16:19:23 + you wrote: > From: Colin Ian King > > It appears that the call of ipv6_add_any for the destination address > is using ip6src instead of ip6dst, this looks like a copy-paste > coding erro

Re: [PATCH net-next v2 0/3] net: phy: broadcom: Cleanups and APD

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 19:46:29 -0800 you wrote: > This patch series cleans up the brcmphy.h header and its numerous unused > phydev->dev_flags, fixes the RXC/TXC clock disabling bit and allows the > BCM54210E PHY to utilize

Re: [PATCH net-next] ibmvnic: substitute mb() with dma_wmb() for send_*crq* functions

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 20:36:46 -0600 you wrote: > The CRQ and subCRQ descriptors are DMA mapped, so dma_wmb(), > though weaker, is good enough to protect the data structures. > > Signed-off-by: Lijun Pan > Acked-by: Thomas

Re: [PATCH net] ibmvnic: add memory barrier to protect long term buffer

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Feb 2021 20:48:40 -0600 you wrote: > dma_rmb() barrier is added to load the long term buffer before copying > it to socket buffer; and dma_wmb() barrier is added to update the > long term buffer before it being access

Re: [PATCH net 1/1] ibmvnic: serialize access to work queue on remove

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Feb 2021 20:42:50 -0800 you wrote: > The work queue is used to queue reset requests like CHANGE-PARAM or > FAILOVER resets for the worker thread. When the adapter is being removed > the adapter state is set to VNIC_RE

Re: [PATCH net] ibmvnic: skip send_request_unmap for timeout reset

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Feb 2021 20:49:00 -0600 you wrote: > Timeout reset will trigger the VIOS to unmap it automatically, > similarly as FAILVOER and MOBILITY events. If we unmap it > in the linux side, we will see errors like > "3003:

Re: [PATCH v4 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 16 Feb 2021 00:24:34 +0900 you wrote: > Hi, > > This series is the ethernet driver for Toshiba's ARM SoC, Visconti[0]. > This provides DT binding documentation, device driver, MAINTAINER files, > and updates to DT

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-15 Thread Cong Wang
On Mon, Feb 15, 2021 at 11:20 AM John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > > does not work for any other non-TCP protocols. We can move them to > > skb ext instead of playing with skb cb, which is hard

Re: [PATCHv19 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2021-02-15 Thread Daniel Borkmann
On 2/8/21 11:47 AM, Hangbin Liu wrote: Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Acked-by: Toke Høiland-Jørgensen Acked-by: Joh

[PATCH net] net: ipa: initialize all resources

2021-02-15 Thread Alex Elder
We configure the minimum and maximum number of various types of IPA resources in ipa_resource_config(). It iterates over resource types in the configuration data and assigns resource limits to each resource group for each type. Unfortunately, we are repeatedly initializing the resource data for t

Re: [PATCH net-next 0/2] Fixing build breakage after "Merge branch 'Propagate-extack-for-switchdev-LANs-from-DSA'"

2021-02-15 Thread Nikolay Aleksandrov
On 15/02/2021 23:09, Vladimir Oltean wrote: > From: Vladimir Oltean > > There were two build issues in the 'Propagate extack for switchdev VLANs > from DSA', both related to function prototypes not updated for some stub > definitions when CONFIG_SWITCHDEV=n and CONFIG_BRIDGE_VLAN_FILTERING=n. >

Re: [net-next] net: mvpp2: Add TX flow control support for jumbo frames

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 15 Feb 2021 17:23:42 +0200 you wrote: > From: Stefan Chulski > > With MTU less than 1500B on all ports, the driver uses per CPU pool mode. > If one of the ports set to jumbo frame MTU size, all ports move > to sha

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread Toke Høiland-Jørgensen
John Fastabend writes: >> > However, in libxdp we can solve the original problem in a different way, >> > and in fact I already suggested to Magnus that we should do this (see >> > [1]); so one way forward could be to address it during the merge in >> > libxdp? It should be possible to address th

Re: [net-next] net: mvpp2: reduce tx-fifo for loopback port

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 14 Feb 2021 16:10:03 +0200 you wrote: > From: Stefan Chulski > > 1KB is enough for loopback port, so 2KB can be distributed > between other ports. > > Signed-off-by: Stefan Chulski > > [...] Here is the summar

Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-15 Thread Vladimir Oltean
On Sun, Feb 14, 2021 at 09:48:53PM +0100, Michael Walle wrote: > Am 2021-02-14 03:24, schrieb Vladimir Oltean: > > On Sun, Feb 14, 2021 at 03:18:49AM +0100, Michael Walle wrote: > > > Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean > > > : > > > >Hi Michael, > > > > > > > >On Sun, Feb 14,

Re: [PATCH net-next] tcp: tcp_data_ready() must look at SOCK_DONE

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 13 Feb 2021 06:26:34 -0800 you wrote: > From: Eric Dumazet > > My prior cleanup missed that tcp_data_ready() has to look at SOCK_DONE. > Otherwise, an application using SO_RCVLOWAT will not get EPOLLIN event > if

Re: [PATCH net-next] net: caif: Use netif_rx_any_context().

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 13 Feb 2021 18:05:14 +0100 you wrote: > The usage of in_interrupt() in non-core code is phased out. Ideally the > information of the calling context should be passed by the callers or the > functions be split as appropri

Re: [PATCH net-next] net: dsa: sja1105: make devlink property best_effort_vlan_filtering true by default

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 13 Feb 2021 22:46:32 +0200 you wrote: > From: Vladimir Oltean > > The sja1105 driver has a limitation, extensively described under > Documentation/networking/dsa/sja1105.rst and > Documentation/networking/devlink/

Re: [PATCH net-next 0/2] Fixing build breakage after "Merge branch 'Propagate-extack-for-switchdev-LANs-from-DSA'"

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 15 Feb 2021 23:09:10 +0200 you wrote: > From: Vladimir Oltean > > There were two build issues in the 'Propagate extack for switchdev VLANs > from DSA', both related to function prototypes not updated for some stu

Re: [PATCH] net: wan/lmc: unregister device when no matching device is found

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 15 Feb 2021 14:17:56 -0500 you wrote: > lmc set sc->lmc_media pointer when there is a matching device. > However, when no matching device is found, this pointer is NULL > and the following dereference will result in a nu

[PATCH net-next 1/2] net: bridge: fix switchdev_port_attr_set stub when CONFIG_SWITCHDEV=n

2021-02-15 Thread Vladimir Oltean
From: Vladimir Oltean The switchdev_port_attr_set function prototype was updated only for the case where CONFIG_SWITCHDEV=y|m, leaving a prototype mismatch with the stub definition for the disabled case. This results in a build error, so update that function too. Fixes: dcbdf1350e33 ("net: bridg

[PATCH net-next 2/2] net: bridge: fix br_vlan_filter_toggle stub when CONFIG_BRIDGE_VLAN_FILTERING=n

2021-02-15 Thread Vladimir Oltean
From: Vladimir Oltean The prototype of br_vlan_filter_toggle was updated to include a netlink extack, but the stub definition wasn't, which results in a build error when CONFIG_BRIDGE_VLAN_FILTERING=n. Fixes: 9e781401cbfc ("net: bridge: propagate extack through store_bridge_parm") Signed-off-by:

[PATCH net-next 0/2] Fixing build breakage after "Merge branch 'Propagate-extack-for-switchdev-LANs-from-DSA'"

2021-02-15 Thread Vladimir Oltean
From: Vladimir Oltean There were two build issues in the 'Propagate extack for switchdev VLANs from DSA', both related to function prototypes not updated for some stub definitions when CONFIG_SWITCHDEV=n and CONFIG_BRIDGE_VLAN_FILTERING=n. Vladimir Oltean (2): net: bridge: fix switchdev_port_a

[PATCH net-next v2 2/3] net: phy: mscc: improved serdes calibration applied to VSC8514

2021-02-15 Thread Bjarni Jonasson
The current IB serdes calibration algorithm (performed by the onboard 8051) has proven to be unstable for the VSC8514 QSGMII phy. A new algorithm has been developed based on 'Frequency-offset Jittered-Injection' or 'FoJi' method which solves all known issues. This patch disables the 8051 algorithm

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-15 Thread Bjorn Helgaas
On Tue, Feb 09, 2021 at 03:34:42PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Extend PCI sysfs interface with a new callback that allows configuration > of the number of MSI-X vectors for specific SR-IOV VF. This is needed > to optimize the performance of VFs devices by allocating

[PATCH net-next v2 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-15 Thread Bjarni Jonasson
At Power-On Reset, transients may cause the LCPLL to lock onto a clock that is momentarily unstable. This is normally seen in QSGMII setups where the higher speed 6G SerDes is being used. This patch adds an initial LCPLL Reset to the PHY (first instance) to avoid this issue. Signed-off-by: Steen H

[PATCH net-next v2 3/3] net: phy: mscc: coma mode disabled for VSC8514

2021-02-15 Thread Bjarni Jonasson
The 'coma mode' (configurable through sw or hw) provides an optional feature that may be used to control when the PHYs become active. The typical usage is to synchronize the link-up time across all PHY instances. This patch releases coma mode if not done by hardware, otherwise the phys will not lin

Re: [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam()

2021-02-15 Thread David Miller
From: Dan Carpenter Date: Mon, 15 Feb 2021 18:56:46 +0300 > The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX". > > I did some cleanup in this function to hopefully make the code a bit > clearer. There was no blank line after the declaration block. The > closing curly brace on the f

Re: [PATCH net-next] net: mscc: ocelot: avoid type promotion when calling ocelot_ifh_set_dest

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 15 Feb 2021 15:31:43 +0200 you wrote: > From: Vladimir Oltean > > Smatch is confused by the fact that a 32-bit BIT(port) macro is passed > as argument to the ocelot_ifh_set_dest function and warns: > > ocelot_xmi

RE: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread John Fastabend
Maciej Fijalkowski wrote: > Currently, if there are multiple xdpsock instances running on a single > interface and in case one of the instances is terminated, the rest of > them are left in an inoperable state due to the fact of unloaded XDP > prog from interface. > > To address that, step away fr

Re: [PATCH] b43: N-PHY: Fix the update of coef for the PHY revision >= 3case

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 15 Feb 2021 12:05:32 + you wrote: > From: Colin Ian King > > The documentation for the PHY update [1] states: > > Loop 4 times with index i > > If PHY Revision >= 3 > Copy table[i] to coef[i] > Ot

Re: [PATCH net] cxgb4/chtls/cxgbit: Keeping the max ofld immediate data size same in cxgb4 and ulds

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 15 Feb 2021 17:12:26 +0530 you wrote: > The Max imm data size in cxgb4 is not similar to the max imm data size > in the chtls. This caused an mismatch in output of is_ofld_imm() of > cxgb4 and chtls. So fixed this by kee

Re: [PATCH v1] atm: idt77252: fix build broken on amd64

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 14 Feb 2021 18:43:08 -0500 you wrote: > idt77252 is broken and wont load on amd64 systems > modprobe idt77252 shows the following > > idt77252_init: skb->cb is too small (48 < 56) > > Add packed attribute to st

Re: [PATCH net-next 0/5] Propagate extack for switchdev VLANs from DSA

2021-02-15 Thread Vladimir Oltean
On Mon, Feb 15, 2021 at 08:40:08PM +, patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This series was applied to netdev/net-next.git (refs/heads/master): > > On Sat, 13 Feb 2021 22:43:14 +0200 you wrote: > > From: Vladimir Oltean > > > > This series moves the restriction messages pr

Re: [PATCH net-next 0/5] Propagate extack for switchdev VLANs from DSA

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 13 Feb 2021 22:43:14 +0200 you wrote: > From: Vladimir Oltean > > This series moves the restriction messages printed by the DSA core, and > by some individual device drivers, into the netlink extended ack > struc

Re: [net-next 0/4] net: mvpp2: Minor non functional driver code improvements

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 14 Feb 2021 15:38:33 +0200 you wrote: > From: Stefan Chulski > > The patch series contains minor code improvements and did not change any > functionality. > > Stefan Chulski (4): > net: mvpp2: simplify PPv2 v

Re: [PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery

2021-02-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 14 Feb 2021 17:38:30 +0100 you wrote: > Armin reported that after referenced commit his RTL8105e is dead when > resuming from suspend and machine runs on battery. This patch has been > confirmed to fix the issue. >

RE: [PATCH bpf-next 2/3] libbpf: clear map_info before each bpf_obj_get_info_by_fd

2021-02-15 Thread John Fastabend
Maciej Fijalkowski wrote: > xsk_lookup_bpf_maps, based on prog_fd, looks whether current prog has a > reference to XSKMAP. BPF prog can include insns that work on various BPF > maps and this is covered by iterating through map_ids. > > The bpf_map_info that is passed to bpf_obj_get_info_by_fd for

RE: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-02-15 Thread Stefan Chulski
> > > > > I discussed it with Andrew earlier last year, and his response was: > > > > > > > > > > DT configuration of pause for fixed link probably is > > > > > sufficient. I don't remember it ever been really discussed for > > > > > DSA. It was a Melanox discussion about limiting pause for the

RE: [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock

2021-02-15 Thread John Fastabend
Maciej Fijalkowski wrote: > With the introduction of bpf_link in xsk's libbpf part, there's no > further need for explicit unload of prog on xdpsock's termination. When > process dies, the bpf_link's refcount will be decremented and resources > will be unloaded/freed under the hood in case when the

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-15 Thread John Fastabend
Björn Töpel wrote: > On 2021-02-15 18:07, Toke Høiland-Jørgensen wrote: > > Maciej Fijalkowski writes: > > > >> Currently, if there are multiple xdpsock instances running on a single > >> interface and in case one of the instances is terminated, the rest of > >> them are left in an inoperable sta

Re: [PATCH net-next v2 3/3] net: phy: mscc: coma mode disabled for VSC8514

2021-02-15 Thread Heiner Kallweit
On 15.02.2021 17:58, Bjarni Jonasson wrote: > The 'coma mode' (configurable through sw or hw) provides an > optional feature that may be used to control when the PHYs become active. > The typical usage is to synchronize the link-up time across > all PHY instances. This patch releases coma mode if n

Re: [PATCH net-next v2 2/3] net: phy: mscc: improved serdes calibration applied to VSC8514

2021-02-15 Thread Heiner Kallweit
On 15.02.2021 17:57, Bjarni Jonasson wrote: > The current IB serdes calibration algorithm (performed by the onboard 8051) > has proven to be unstable for the VSC8514 QSGMII phy. > A new algorithm has been developed based on > 'Frequency-offset Jittered-Injection' or 'FoJi' method which solves > all

Re: [PATCH net-next v2 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-15 Thread Heiner Kallweit
On 15.02.2021 17:57, Bjarni Jonasson wrote: > At Power-On Reset, transients may cause the LCPLL to lock onto a > clock that is momentarily unstable. This is normally seen in QSGMII > setups where the higher speed 6G SerDes is being used. > This patch adds an initial LCPLL Reset to the PHY (first in

Re: [PATCH net] cxgb4/chtls/cxgbit: Keeping the max ofld immediate data size same in cxgb4 and ulds

2021-02-15 Thread Jakub Kicinski
On Mon, 15 Feb 2021 17:12:26 +0530 Ayush Sawal wrote: > The Max imm data size in cxgb4 is not similar to the max imm data size > in the chtls. This caused an mismatch in output of is_ofld_imm() of > cxgb4 and chtls. So fixed this by keeping the max wreq size of imm data > same in both chtls and cxg

Re: [PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-15 Thread Jakub Kicinski
On Sat, 13 Feb 2021 00:06:04 -0500 vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > Part of the device initialization aligns the rising edge of the output > clock to the internal 1 PPS clock. If the system APLL and DPLL is not > locked, then the alignment will fail and there will be

  1   2   3   >