On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote:
> On 2/11/21 2:10 PM, Boris Pismenny wrote:
> > @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct
> > nvme_tcp_request *req,
> > return nvme_tcp_pdu_data_left(req) <= len;
> > }
Hi Dave,
Thanks for the continuous f
Hi,
Thanks for your review.
On Mon, Feb 15, 2021 at 08:07:21AM +0200, Leon Romanovsky wrote:
> On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote:
> > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs.
> > This patch contains only the basic function of the device
When sending packets, we will first hand over the (L3) packets to the
LAPB module. The LAPB module will then hand over the corresponding LAPB
(L2) frames back to us for us to transmit.
The LAPB module can also emit LAPB (L2) frames at any time, even without
an (L3) packet currently being sent on t
On Wed, 10 Feb 2021, Reindl Harald wrote:
> > > why is that still not part of 5.10.14 given how old that issue is
> > >
> > > https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.10.14
> >
> > Probably we missed the window when patches were accepted for the new
> > release. That's all
>
>
From: Nathan Rossi
The documentation for MDIO bindings describes the "broken-turn-around",
"reset-assert-us", and "reset-deassert-us" properties such that any MDIO
device can define them. Other MDIO devices may require these properties
in order to correctly function on the MDIO bus.
Enable the p
On Sun, Feb 14, 2021 at 10:27 PM Martin Schiller wrote:
>
> At first glance, the patch looks quite reasonable. The only thing I
> noticed right away is that you also included the changes of your patch
> "Return meaningful error code in x25_open".
Thanks! It was because this patch was sent before
On 2021-02-10 18:35, Xie He wrote:
When sending packets, we will first hand over the (L3) packets to the
LAPB module, then the LAPB module will hand over the corresponding LAPB
(L2) frames back to us for us to transmit.
The LAPB module can also emit LAPB (L2) frames at any time without an
(L3) p
From: Nathan Rossi
The mv88e6xxx devices cannot automatically select between 1000BASE-X and
2500BASE-X and rely on configuration (gpio pins Px_SMODE/S_MODE and/or
OF phy-mode) to select between the two modes.
However when configuring a cpu/dsa port as 1000BASE-X with a inband or
fixed link phy t
On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote:
> Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs.
> This patch contains only the basic function of the device. There is no
> clock control, PM, etc. yet. These will be added in the future.
>
> Signed-off-by: No
On Mon, Feb 08, 2021 at 03:31:11PM +, Russell King - ARM Linux admin wrote:
> On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote:
> > +int phylink_fwnode_phy_connect(struct phylink *pl,
> > + struct fwnode_handle *fwnode,
> > + u32 f
On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote:
> what does iproute2-rc mean?
Patch target is iproute2.git:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/
vs -next repo:
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/
How do you want me to mark the p
CONTATE URGENTEMENTE O DIRETOR DO BANCO ORA..docx
Description: MS-Word 2007 document
Hello:
This patch was applied to iproute2/iproute2-next.git (refs/heads/main):
On Sun, 14 Feb 2021 01:09:13 -0700 you wrote:
> Doh! Sorry about that, here it is with the sign-off.
>
> -- >8 --
>
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":"
On 2/14/21 1:09 AM, Thayne McCombs wrote:
> Doh! Sorry about that, here it is with the sign-off.
>
> -- >8 --
Don't put text here.
>
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":" at the beginning of the port when only a
> port was provided
Add the ethernet controller node in Toshiba Visconti5 SoC-specific DT file.
And enable this node in TMPV7708 RM main board's board-specific DT file.
Signed-off-by: Nobuhiro Iwamatsu
---
.../boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 18 +
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
Hi,
This series is the ethernet driver for Toshiba's ARM SoC, Visconti[0].
This provides DT binding documentation, device driver, MAINTAINER files,
and updates to DT files.
Best regards,
Nobuhiro
[0]:
https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-
Add device tree bindings for ethernet controller of Toshiba Visconti
TMPV7700 SoC series.
Signed-off-by: Nobuhiro Iwamatsu
---
.../bindings/net/toshiba,visconti-dwmac.yaml | 85 +++
1 file changed, 85 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/toshi
Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs.
This patch contains only the basic function of the device. There is no
clock control, PM, etc. yet. These will be added in the future.
Signed-off-by: Nobuhiro Iwamatsu
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 +
Add entries for Toshiba Visconti ethernet controller binding and driver.
Signed-off-by: Nobuhiro Iwamatsu
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cbf4b94f89d4..6be4bdaabf32 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2641,8 +2641,1
Hi,
On Sun, Feb 14, 2021 at 08:23:25AM +0200, Leon Romanovsky wrote:
> On Fri, Feb 12, 2021 at 11:58:04AM +0900, Nobuhiro Iwamatsu wrote:
> > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs.
> > This patch contains only the basic function of the device. There is no
> > clock c
On 2/13/2021 2:42 AM, Vladimir Oltean wrote:
> On Fri, Feb 12, 2021 at 07:46:32PM -0800, Florian Fainelli wrote:
>> BCM54210E/BCM50212E has been verified to work correctly with the
>> auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it
>> to the list of PHYs working.
>>
>> Wh
what does iproute2-rc mean?
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sun, 14 Feb 2021 18:04:54 -0500 you wrote:
> This series implements some optimizations to error recovery. One
> patch adds an echo/reply mechanism with firmware to enhance error
> detection. The other patches speed up
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sun, 14 Feb 2021 00:37:49 +0200 you wrote:
> From: Vladimir Oltean
>
> Changes in v2:
> Add stub definition for ocelot_port_inject_frame when switch driver is
> not compiled in.
>
> This is part two of the errata wor
Hi all,
Today's linux-next merge of the net-next tree got conflicts in:
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
between commit:
e4484d9df500 ("net/mlx5e: Enable striding RQ for Connect-X IPsec capable
devices")
from the net tree
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
tools/testing/selftests/net/forwarding/tc_flower.sh
between commit:
d2126838050c ("flow_dissector: fix TTL and TOS dissection on IPv4 fragments")
from the net tree and commits:
203ee5cd7235 ("selftests: tc: Add bas
> > Does this even need to be configurable? What is the cost of turning it on?
> > How does having less pools affect the system? Does average latency go up?
> > When would i consider an underrun actually a good thing?
> >
> > Maybe it should just be hard coded on? Or we should try to detect when
>
> According to Errata #23 "The per-CPU GbE interrupt is limited to Core
> 0", we can't use the per-cpu interrupt mechanism on the Armada 3700
> familly.
>
> This is correctly checked for RSS configuration, but the initial queue
> mapping is still done by having the queues spread across all the CPU
idt77252 is broken and wont load on amd64 systems
modprobe idt77252 shows the following
idt77252_init: skb->cb is too small (48 < 56)
Add packed attribute to struct idt77252_skb_prv and struct atm_skb_data
so that the total size can be <= sizeof(skb->cb)
Also convert runtime size ch
During some fatal firmware error conditions, the PCI config space
register 0x2e which normally contains the subsystem ID will become
0x. This register will revert back to the normal value after
the chip has completed core reset. If we detect this condition,
we can poll this config register im
We currently only log the error recovery settings if it is enabled.
In some cases, firmware disables error recovery after it was
initially enabled. Without logging anything, the user will not be
aware of this change in setting.
Log it when error recovery is disabled. Also, change the reset count
This is a new async message that the firmware can send to check if it
can communicate with the driver. This is an added error detection
scheme that firmware can use if it suspects errors in the PCIe
interface. When the driver receives this async message, it will reply
back echoing some data in th
If firmware provides the offset to the "context kind" field of the
relevant context memory blocks, we'll initialize just that field for
each block instead of initializing all of context memory.
Populate the bnxt_mem_init structure with the proper offset returned
by firmware. If it is older firmwa
The main changes are the echo request/response from firmware for error
detection and the NO_FCS feature to transmit frames without FCS.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 105 --
Currently, the driver calls memset() to set all relevant context memory
used by the chip to the initial value. This can take many milliseconds
with the potentially large number of context pages allocated for the
chip.
To make this faster, we only need to initialize the "context kind" field
of eac
From: Edwin Peer
Newer devices may have local context memory instead of relying on the
host for backing store. In these cases, HWRM_FUNC_BACKING_STORE_QCAPS
will return a zero entry size to indicate contexts for which the host
should not allocate backing store.
Selectively allocate context memor
This series implements some optimizations to error recovery. One
patch adds an echo/reply mechanism with firmware to enhance error
detection. The other patches speed up the recovery process by
polling config space earlier and to selectively initialize
context memory during re-initialization.
Edw
Hi Arjun,
On Sun, 14 Feb 2021 13:40:38 -0800 Arjun Roy wrote:
>
> Sorry, I was confused from the prior email. Is any action required at
> the moment, or not?
No. This is just something that the net-next and bpf-next maintainers
need to sort out when they merge their trees.
--
Cheers,
Stephen
On Wed, Feb 10, 2021 at 03:48:35PM +0200, Danielle Ratson wrote:
> Currently, there is no way of knowing how many lanes will be use to
> achieve a wanted speed.
> For example, 100G speed can be achieved using: 2X50 or 4X25.
>
> In order to solve that, extend ethtool uAPI with lanes as a new link
>
Hi all,
On Mon, 25 Jan 2021 11:12:23 +1100 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the bpf-next tree got a conflict in:
>
> net/ipv4/tcp.c
>
> between commit:
>
> 7eeba1706eba ("tcp: Add receive timestamp support for receive zerocopy.")
>
> from the net-next tree and com
Hi all,
On Thu, 21 Jan 2021 13:26:45 +1100 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the devicetree tree got a conflict in:
>
> Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
>
> between commit:
>
> 19d9a846d9fc ("dt-binding: net: ti: k3-am654-cpsw-nuss: u
Am 2021-02-14 03:24, schrieb Vladimir Oltean:
On Sun, Feb 14, 2021 at 03:18:49AM +0100, Michael Walle wrote:
Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean
:
>Hi Michael,
>
>On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote:
>> at803x_aneg_done() checks if auto-negotiation
On Sun, Feb 14, 2021 at 03:16:23PM +0100, Heiner Kallweit wrote:
> Some internal PHY's have their events like link change reported by the
> MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario.
> I'm not too happy with this name. We don't ignore interrupts, typically
> there is no
On 2/11/21 2:10 PM, Boris Pismenny wrote:
>
> +static int nvme_tcp_teardown_ddp(struct nvme_tcp_queue *queue,
> + u16 command_id,
> + struct request *rq)
> +{
> + struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq);
> + struct net_
On 2/11/21 2:10 PM, Boris Pismenny wrote:
> @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct
> nvme_tcp_request *req,
> return nvme_tcp_pdu_data_left(req) <= len;
> }
>
> +#ifdef CONFIG_TCP_DDP
> +
> +static bool nvme_tcp_resync_request(struct sock *sk, u32 seq, u3
On Fri, Feb 12, 2021 at 04:28:42PM -0700, Shuah Khan wrote:
> +#define lockdep_assert_not_held(l) do {\
> + WARN_ON(debug_locks && lockdep_is_held(l)); \
> + } while (0)
> +
This thing isn't as straight forward as you might think, but it'll
mostly work.
On 2/14/21 4:40 AM, Taehee Yoo wrote:
>
>
> On 21. 2. 14. 오전 4:58, David Ahern wrote:
>> your patches still show up as 8 individual emails.
>>
>> Did you use 'git send-email --thread --no-chain-reply-to' as Jakub
>> suggested? Please read the git-send-email man page for what the
>> options do.
>>
On 2/14/2021 6:16 AM, Heiner Kallweit wrote:
> Some internal PHY's have their events like link change reported by the
> MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario.
> I'm not too happy with this name. We don't ignore interrupts, typically
> there is no interrupt expose
Hi Nikolay,
On Sun, Feb 14, 2021 at 12:45:11PM +0200, Nikolay Aleksandrov wrote:
> On 13/02/2021 22:43, Vladimir Oltean wrote:
> > From: Vladimir Oltean
> >
> > The benefit is the ability to propagate errors from switchdev drivers
> > for the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING and
> > SWITCH
Armin reported that after referenced commit his RTL8105e is dead when
resuming from suspend and machine runs on battery. This patch has been
confirmed to fix the issue.
Fixes: e80bd76fbf56 ("r8169: work around power-saving bug on some chip
versions")
Reported-by: Armin Wolf
Tested-by: Armin Wolf
Armin reported that after referenced commit his RTL8105e is dead when
resuming from suspend and machine runs on battery. This patch has been
confirmed to fix the issue.
Fixes: e80bd76fbf56 ("r8169: work around power-saving bug on some chip
versions")
Reported-by: Armin Wolf
Tested-by: Armin Wolf
On Sun, Feb 14, 2021 at 03:16:23PM +0100, Heiner Kallweit wrote:
> Some internal PHY's have their events like link change reported by the
> MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario.
> I'm not too happy with this name. We don't ignore interrupts, typically
> there is no
On Sun, Feb 14, 2021 at 05:53:22PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> As was discussed here:
> https://patchwork.kernel.org/project/netdevbpf/patch/20201202091356.24075-3-tob...@waldekranz.com/
>
> it is desirable to not reject a LAG interface (bonding, team) even if
> the
From: Vladimir Oltean
Due to a mistake, the driver always sets the address learning flag to
the previously stored value, and not to the currently configured one.
The bug is visible only in standalone ports mode, because when the port
is bridged, the issue is masked by .port_stp_state_set which ov
From: Vladimir Oltean
Quite embarrasingly, I managed to fool myself into thinking that the
flooding domain of sja1105 source ports is restricted by the forwarding
domain, which it isn't. Frames which match an FDB entry are forwarded
towards that entry's DESTPORTS restricted by REACH_PORT[SRC_PORT
From: Vladimir Oltean
While testing the "Software fallback for bridging in DSA" on sja1105, I
discovered that I managed to introduce two bugs in a single patch
submitted recently to net-next.
Vladimir Oltean (2):
net: dsa: sja1105: fix configuration of source address learning
net: dsa: sja11
From: Vladimir Oltean
Starting with commit 058102a6e9eb ("net: dsa: Link aggregation support"),
DSA warns that certain configurations of upper interfaces are not offloaded
to hardware. When a DSA port does not offload a LAG interface, the
dp->lag_dev pointer is always NULL. However the same canno
From: Vladimir Oltean
DSA has gained the recent ability to deal gracefully with upper
interfaces it cannot offload, such as the bridge, bonding or team
drivers. When such uppers exist, the ports are still in standalone mode
as far as the hardware is concerned.
But when we deliver packets to the
From: Vladimir Oltean
The dsa_port_offloads_netdev check is inside dsa_slave_vlan_{add,del},
but outside dsa_port_mdb_{add,del}. We can reduce the number of
occurrences of dsa_port_offloads_netdev by checking only once, at the
beginning of dsa_slave_port_obj_add and dsa_slave_port_obj_del.
Signe
From: Vladimir Oltean
There is currently some provisioning for DSA to use the software
fallback for link aggregation, but only if the .port_lag_join is
implemented but it fails (for example because there are more link
aggregation groups than the switch supports, or because the xmit hash
policy ca
From: Vladimir Oltean
As was discussed here:
https://patchwork.kernel.org/project/netdevbpf/patch/20201202091356.24075-3-tob...@waldekranz.com/
it is desirable to not reject a LAG interface (bonding, team) even if
the switch isn't able to offload bridging towards that link aggregation
group. At
>
> By the way, if you do not use a delay, you can just use regular work.
>
The regular workqueue API couldn't be used in an atomic context, So I
used delayed_work.
If 0 delay is passed to delayed_work, it internally calls regular workqueue.
So, I think there is no actual difference.
Thanks!
Some internal PHY's have their events like link change reported by the
MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario.
I'm not too happy with this name. We don't ignore interrupts, typically
there is no interrupt exposed at a PHY level. So let's rename it to
PHY_MAC_INTERRUP
From: Stefan Chulski
1KB is enough for loopback port, so 2KB can be distributed
between other ports.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 4 ++--
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 10 +-
2 files changed, 7 insertions(+), 7
From: Stefan Chulski
GENCONF_CTRL0_PORTX naming improved.
Non functional change.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 6 +++---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8
2 files changed, 7 insertions(+), 7 deletions(-)
diff --
From: Stefan Chulski
Use PTR_ERR_OR_ZERO instead of IS_ERR and PTR_ERR.
Non functional change.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.
From: Stefan Chulski
Use >= MVPP22 instead of != MVPP21.
Non functional change.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_
From: Stefan Chulski
PPv2.1 contain 0 in Version ID register, priv->hw_version check
can be removed.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mv
From: Stefan Chulski
The patch series contains minor code improvements and did not change any
functionality.
Stefan Chulski (4):
net: mvpp2: simplify PPv2 version ID read
net: mvpp2: improve Packet Processor version check
net: mvpp2: improve mvpp2_get_sram return
net: mvpp2: improve Net
On Sun, Feb 14, 2021 at 01:10:14PM +0200, Vladimir Oltean wrote:
> On Sun, Feb 14, 2021 at 10:35:29AM +, Russell King - ARM Linux admin
> wrote:
> > As mentioned in this thread, we have at least one PHY which is unable
> > to provide the inband signalling in any mode (BCM84881). Currently,
> >
On 21. 2. 14. 오전 4:58, David Ahern wrote:
your patches still show up as 8 individual emails.
Did you use 'git send-email --thread --no-chain-reply-to' as Jakub
suggested? Please read the git-send-email man page for what the options do.
I sent all patches individually with these options.
gi
On 21. 2. 14. 오전 4:18, Cong Wang wrote:
> On Sat, Feb 13, 2021 at 9:52 AM Taehee Yoo wrote:
>>
>> The goal of mc_delrec_work delayed work is to call mld_clear_delrec().
>> The mld_clear_delrec() is called under both data path and control path.
>> So, the context of mld_clear_delrec() can be atomi
On 21. 2. 14. 오전 4:41, kernel test robot wrote:
Hi Taehee,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210214-015930
base
On Sun, Feb 14, 2021 at 10:35:29AM +, Russell King - ARM Linux admin wrote:
> > + if (ret && ret != -EOPNOTSUPP) {
> > + phylink_warn(pl, "failed to configure PHY in-band autoneg:
> > %d\n",
> > +ret);
>
> Please use %pe and ERR_PTR(ret) so we can get a sym
On 21. 2. 14. 오전 4:07, Cong Wang wrote:
> On Sat, Feb 13, 2021 at 9:51 AM Taehee Yoo wrote:
>> -static void mld_dad_start_timer(struct inet6_dev *idev, unsigned
long delay)
>> +static void mld_dad_start_work(struct inet6_dev *idev, unsigned
long delay)
>> {
>> unsigned long tv =
On 13/02/2021 22:43, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The benefit is the ability to propagate errors from switchdev drivers
> for the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING and
> SWITCHDEV_ATTR_ID_BRIDGE_VLAN_PROTOCOL attributes.
>
> Signed-off-by: Vladimir Oltean
> ---
> in
On 13/02/2021 22:43, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The bridge sysfs interface stores parameters for the STP, VLAN,
> multicast etc subsystems using a predefined function prototype.
> Sometimes the underlying function being called supports a netlink
> extended ack message, and
On Fri, Feb 12, 2021 at 07:23:40PM +0200, Vladimir Oltean wrote:
> + ret = phy_config_inband_aneg(phy,
> + (pl->cur_link_an_mode == MLO_AN_INBAND));
Please use phylink_autoneg_inband(pl->cur_link_an_mode) here.
> + if (ret && ret != -EOPNOTSUPP) {
> +
On 13/02/2021 22:43, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> This function is identical with br_vlan_filter_toggle.
>
> Signed-off-by: Vladimir Oltean
> ---
> net/bridge/br_netlink.c | 2 +-
> net/bridge/br_private.h | 5 ++---
> net/bridge/br_vlan.c| 7 +--
> 3 files change
> > On Sun, Jan 31, 2021 at 11:12:14AM +, Russell King - ARM Linux admin
> wrote:
> > > I discussed it with Andrew earlier last year, and his response was:
> > >
> > > DT configuration of pause for fixed link probably is sufficient. I
> > > don't remember it ever been really discussed for DSA
> > > Or we have also found out, that pushing back on parameters like
> > > this, the developers goes back and looks at the code, and sometimes
> > > figures out a way to automatically do the right thing, removing the
> > > configuration knob, and just making it all simpler for the user to
> > >
From: Ido Kalir
The dump isn't supported for the statistics bind/unbind commands
because they operate on specific QP counters. This is different
from query commands that can operate on many objects at the same
time.
Let's check the user input and ensure that arguments are valid.
Fixes: a6d0773e
Doh! Sorry about that, here it is with the sign-off.
-- >8 --
The sport and dport conditions in expressions were inconsistent on
whether there should be a ":" at the beginning of the port when only a
port was provided depending on the family. The link and netlink
families required a ":" to work.
84 matches
Mail list logo
