Re: [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping

2021-02-12 Thread kernel test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd0

[PATCH v2 net-next 3/3] ptp: ptp_clockmatrix: Remove unused header declarations.

2021-02-12 Thread vincent.cheng.xh
From: Vincent Cheng Removed unused header declarations. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clockmatrix.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ptp/ptp_clockmatrix.h b/drivers/ptp/ptp_clockmatrix.h index 0233236..fb32327 100644 --- a/drivers/ptp/ptp_clockmat

[PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-12 Thread vincent.cheng.xh
From: Vincent Cheng Part of the device initialization aligns the rising edge of the output clock to the internal 1 PPS clock. If the system APLL and DPLL is not locked, then the alignment will fail and there will be a fixed offset between the internal 1 PPS clock and the output clock. After load

[PATCH v2 net-next 0/3] ptp: ptp_clockmatrix: Fix output 1 PPS alignment.

2021-02-12 Thread vincent.cheng.xh
From: Vincent Cheng This series fixes a race condition that may result in the output clock not aligned to internal 1 PPS clock. Part of device initialization is to align the rising edge of output clocks to the internal rising edge of the 1 PPS clock. If the system APLL and DPLL are not locked w

[PATCH v2 net-next 2/3] ptp: ptp_clockmatrix: Add alignment of 1 PPS to idtcm_perout_enable.

2021-02-12 Thread vincent.cheng.xh
From: Vincent Cheng When enabling output using PTP_CLK_REQ_PEROUT, need to align the output clock to the internal 1 PPS clock. Signed-off-by: Vincent Cheng Acked-by: Richard Cochran --- drivers/ptp/ptp_clockmatrix.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff

Re: [PATCH net-next 0/8] mptcp: Add genl events for connection info

2021-02-12 Thread Mat Martineau
On Fri, 12 Feb 2021, Mat Martineau wrote: On Fri, 12 Feb 2021, Mat Martineau wrote: This series from the MPTCP tree adds genl multicast events that are important for implementing a userspace path manager. In MPTCP, a path manager is responsible for adding or removing additional subflows on e

Re: [PATCH net-next 0/8] mptcp: Add genl events for connection info

2021-02-12 Thread Mat Martineau
On Fri, 12 Feb 2021, Mat Martineau wrote: This series from the MPTCP tree adds genl multicast events that are important for implementing a userspace path manager. In MPTCP, a path manager is responsible for adding or removing additional subflows on each MPTCP connection. The in-kernel path manag

[PATCH net 1/1] ibmvnic: serialize access to work queue on remove

2021-02-12 Thread Sukadev Bhattiprolu
The work queue is used to queue reset requests like CHANGE-PARAM or FAILOVER resets for the worker thread. When the adapter is being removed the adapter state is set to VNIC_REMOVING and the work queue is flushed so no new work is added. However the check for adapter being removed is racy in that t

Re: [PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-12 Thread Vincent Cheng
On Fri, Feb 12, 2021 at 10:31:40AM EST, Richard Cochran wrote: >On Thu, Feb 11, 2021 at 11:38:44PM -0500, vincent.cheng...@renesas.com wrote: > >> +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) >> +{ >> +char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL state %d"; > >P

[PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-12 Thread Florian Fainelli
BCM54210E/BCM50212E has been verified to work correctly with the auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it to the list of PHYs working. While we are at it, provide an appropriate name for the bit we are changing which disables the RXC and TXC during auto-power down wh

[PATCH net-next v2 1/3] net: phy: broadcom: Avoid forward for bcm54xx_config_clock_delay()

2021-02-12 Thread Florian Fainelli
Avoid a forward declaration by moving the callers of bcm54xx_config_clock_delay() below its body. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 74 +++--- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/net/phy/broadcom.c

[PATCH net-next v2 2/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
We have a number of unused flags defined today and since we are scarce on space and may need to introduce new flags in the future remove and shift every existing flag down into a contiguous assignment. PHY_BCM_FLAGS_MODE_1000BX was only used internally for the BCM54616S PHY, so we allocate a driver

[PATCH net-next v2 0/3] net: phy: broadcom: Cleanups and APD

2021-02-12 Thread Florian Fainelli
This patch series cleans up the brcmphy.h header and its numerous unused phydev->dev_flags, fixes the RXC/TXC clock disabling bit and allows the BCM54210E PHY to utilize APD. Changes in v2: - dropped the patch that attempted to fix a possible discrepancy between the datasheet and the actual har

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Florian Fainelli wrote: > > > On 2/12/2021 5:11 PM, Vladimir Oltean wrote: >> On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: >>> When support for optionally disabling the TXC was introduced, bit 2 was >>> used to do that operation but the datasheet for

Re: [PATCH net-next 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:45 PM, Robert Hancock wrote: > On Fri, 2021-02-12 at 17:26 -0800, Florian Fainelli wrote: >> >> On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL >> wrote: >>> The default configuration for the BCM54616S PHY may not match the desired >>> mode when using 1000B

Re: [PATCH net-next v2 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Florian Fainelli
On 2/12/2021 6:18 PM, Robert Hancock wrote: > The default configuration for the BCM54616S PHY may not match the desired > mode when using 1000BaseX or SGMII interface modes, such as when it is on > an SFP module. Add code to explicitly set the correct mode using > programming sequences provided

Re: [PATCH net-next v2 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Florian Fainelli
On 2/12/2021 6:18 PM, Robert Hancock wrote: > bcm54xx_config_init was modifying the PHY LED configuration to enable link > and activity indications. However, some SFP modules (such as Bel-Fuse > SFP-1GBT-06) have no LEDs but use the LED outputs to control the SFP LOS > signal, and modifying the

[PATCH net] ibmvnic: skip send_request_unmap for timeout reset

2021-02-12 Thread Lijun Pan
Timeout reset will trigger the VIOS to unmap it automatically, similarly as FAILVOER and MOBILITY events. If we unmap it in the linux side, we will see errors like "3003: Error 4 in REQUEST_UNMAP_RSP". So, don't call send_request_unmap for timeout reset. Fixes: ed651a10875f ("ibmvnic: Updated

[PATCH net] ibmvnic: add memory barrier to protect long term buffer

2021-02-12 Thread Lijun Pan
dma_rmb() barrier is added to load the long term buffer before copying it to socket buffer; and dma_wmb() barrier is added to update the long term buffer before it being accessed by VIOS (virtual i/o server). Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol") Signed-off-by: Lijun Pan

[PATCH net-next] ibmvnic: substitute mb() with dma_wmb() for send_*crq* functions

2021-02-12 Thread Lijun Pan
The CRQ and subCRQ descriptors are DMA mapped, so dma_wmb(), though weaker, is good enough to protect the data structures. Signed-off-by: Lijun Pan Acked-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/

[PATCH net-next] ibmvnic: simplify reset_long_term_buff function

2021-02-12 Thread Lijun Pan
The only thing reset_long_term_buff() should do is set buffer to zero. After doing that, it is not necessary to send_request_map again to VIOS since it actually does not change the mapping. So, keep memset function and remove all others. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmv

[PATCH net-next v2 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Robert Hancock
bcm54xx_config_init was modifying the PHY LED configuration to enable link and activity indications. However, some SFP modules (such as Bel-Fuse SFP-1GBT-06) have no LEDs but use the LED outputs to control the SFP LOS signal, and modifying the LED settings will cause the LOS output to malfunction.

[PATCH net-next v2 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Robert Hancock
The default configuration for the BCM54616S PHY may not match the desired mode when using 1000BaseX or SGMII interface modes, such as when it is on an SFP module. Add code to explicitly set the correct mode using programming sequences provided by Bel-Fuse: https://www.belfuse.com/resources/datashe

[PATCH net-next v2 0/2] Broadcom PHY driver updates

2021-02-12 Thread Robert Hancock
Updates to the Broadcom PHY driver related to use with copper SFP modules. Changed since v1: -Reversed conditional to reduce indentation -Added missing setting of MII_BCM54XX_AUXCTL_MISC_WREN in MII_BCM54XX_AUXCTL_SHDWSEL_MISC register Robert Hancock (2): net: phy: broadcom: Set proper 1000Bas

Re: [Patch bpf-next v2 2/5] skmsg: get rid of struct sk_psock_parser

2021-02-12 Thread Cong Wang
On Fri, Feb 12, 2021 at 11:09 AM Cong Wang wrote: > > On Fri, Feb 12, 2021 at 2:56 AM Lorenz Bauer wrote: > > > > On Wed, 10 Feb 2021 at 02:21, Cong Wang wrote: > > > > > > From: Cong Wang > > > > > > struct sk_psock_parser is embedded in sk_psock, it is > > > unnecessary as skb verdict also us

Re: [PATCH net] net: axienet: Handle deferred probe on clock properly

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Feb 2021 18:17:48 -0600 you wrote: > This driver is set up to use a clock mapping in the device tree if it is > present, but still work without one for backward compatibility. However, > if getting the clock returns -

Re: [PATCH net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2021-02-12

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 14:39:41 -0800 you wrote: > This series contains updates to i40e, ice, and ixgbe drivers. > > Maciej does cleanups on the following drivers. > For i40e, removes redundant check for XDP prog, cleans up

Re: [PATCH net-next 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Robert Hancock
On Fri, 2021-02-12 at 17:26 -0800, Florian Fainelli wrote: > > On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL > wrote: > > The default configuration for the BCM54616S PHY may not match the desired > > mode when using 1000BaseX or SGMII interface modes, such as when it is o

Re: [PATCH net-next 0/3] Xilinx axienet updates

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 18:23:53 -0600 you wrote: > Updates to the Xilinx AXI Ethernet driver to add support for an additional > ethtool operation, and to support dynamic switching between 1000BaseX and > SGMII interface modes

Re: [PATCH net-next 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 05:17:53PM -0800, Florian Fainelli wrote: > On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL > wrote: > > bcm54xx_config_init was modifying the PHY LED configuration to enable link > > and activity indications. However, some SFP modules (such as Bel-Fu

Re: [PATCH v3 net-next 4/5] net: ipa: introduce ipa_table_hash_support()

2021-02-12 Thread Alex Elder
On 2/12/21 7:05 PM, Alexander Duyck wrote: On Fri, Feb 12, 2021 at 6:40 AM Alex Elder wrote: Introduce a new function to abstract the knowledge of whether hashed routing and filter tables are supported for a given IPA instance. IPA v4.2 is the only one that doesn't support hashed tables (now

Re: [PATCH net-next] net: phy: marvell: Ensure SGMII auto-negotiation is enabled for 88E1111

2021-02-12 Thread Robert Hancock
On Sat, 2021-02-13 at 01:09 +, Russell King - ARM Linux admin wrote: > On Fri, Feb 12, 2021 at 06:26:29PM -0600, Robert Hancock wrote: > > When 88E111 is operating in SGMII mode, auto-negotiation should be enabled > > 88E. yup.. > > > on the SGMII side so that the link will come up prop

Re: [PATCH net-next 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > The default configuration for the BCM54616S PHY may not match the desired > mode when using 1000BaseX or SGMII interface modes, such as when it is on > an SFP module. Add code to explicitly set the correct mode usin

Re: [PATCH net-next 02/11] i40e: drop misleading function comments

2021-02-12 Thread Alexander Duyck
On Fri, Feb 12, 2021 at 2:46 PM Tony Nguyen wrote: > > From: Maciej Fijalkowski > > i40e_cleanup_headers has a statement about check against skb being > linear or not which is not relevant anymore, so let's remove it. > > Same case for i40e_can_reuse_rx_page, it references things that are not > p

Re: [PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 17:15:50 +0200 you wrote: > From: Vladimir Oltean > > The initial goal of this series was to have better support for > standalone ports mode on the DSA drivers like ocelot/felix and sja1105. > This tu

Re: [PATCH net V2] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Feb 2021 15:16:30 -0500 you wrote: > The supported indirect subcrq entries on Power8 is 16. Power9 > supports 128. Redefined this value to 16 to minimize the driver from > having to reset when migrating between Power9

Re: [PATCH net-next 0/2] selftests: tc: Test tc-flower's MPLS features

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 20:05:33 +0100 you wrote: > A couple of patches for exercising the MPLS filters of tc-flower. > > Patch 1 tests basic MPLS matching features: those that only work on the > first label stack entry (that

Re: [PATCH net-next 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > bcm54xx_config_init was modifying the PHY LED configuration to enable link > and activity indications. However, some SFP modules (such as Bel-Fuse > SFP-1GBT-06) have no LEDs but use the LED outputs to control the S

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: >> That's right, tg3 drove a lot of the Broadcom PHY driver changes back >> then, I also would like to rework the way we pass flags towards PHY >> drivers because tg3 is basically the

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: > That's right, tg3 drove a lot of the Broadcom PHY driver changes back > then, I also would like to rework the way we pass flags towards PHY > drivers because tg3 is basically the only driver doing it right, where > it checks the PH

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:11 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: >> When support for optionally disabling the TXC was introduced, bit 2 was >> used to do that operation but the datasheet for 50610M from 2009 does >> not show bit 2 as being defined.

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: > When support for optionally disabling the TXC was introduced, bit 2 was > used to do that operation but the datasheet for 50610M from 2009 does > not show bit 2 as being defined. Bit 8 is the one that allows automatic > disabling o

Re: [PATCH net-next] net: phy: marvell: Ensure SGMII auto-negotiation is enabled for 88E1111

2021-02-12 Thread Russell King - ARM Linux admin
On Fri, Feb 12, 2021 at 06:26:29PM -0600, Robert Hancock wrote: > When 88E111 is operating in SGMII mode, auto-negotiation should be enabled 88E. > on the SGMII side so that the link will come up properly with PCSes which > normally have auto-negotiation enabled. This is normally the case whe

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:56 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:19PM -0800, Florian Fainelli wrote: >> We have a number of unused flags defined today and since we are scarce >> on space and may need to introduce new flags in the future remove and >> shift every existing flag down in

Re: [PATCH v3 net-next 4/5] net: ipa: introduce ipa_table_hash_support()

2021-02-12 Thread Alexander Duyck
On Fri, Feb 12, 2021 at 6:40 AM Alex Elder wrote: > > Introduce a new function to abstract the knowledge of whether hashed > routing and filter tables are supported for a given IPA instance. > > IPA v4.2 is the only one that doesn't support hashed tables (now > and for the foreseeable future), but

Re: pull-request: mac80211-next 2021-02-12

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 14:55:50 +0100 you wrote: > Hi, > > This is almost certainly a last update for net-next, and > it's not very big - the biggest chunk here is minstrel > improvements from Felix, to lower overhead.

Re: [PATCH v3 net-next 0/5] net: ipa: some more cleanup

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 08:33:57 -0600 you wrote: > Version 3 of this series uses dev_err_probe() in the second patch, > as suggested by Heiner Kallweit. > > Version 2 was sent to ensure the series was based on current > net-

[PATCH net-next] net: phy: marvell: Ensure SGMII auto-negotiation is enabled for 88E1111

2021-02-12 Thread Robert Hancock
When 88E111 is operating in SGMII mode, auto-negotiation should be enabled on the SGMII side so that the link will come up properly with PCSes which normally have auto-negotiation enabled. This is normally the case when the PHY defaults to SGMII mode at power-up, however if we switched it from some

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 12:57:19PM -0800, Florian Fainelli wrote: > We have a number of unused flags defined today and since we are scarce > on space and may need to introduce new flags in the future remove and > shift every existing flag down into a contiguous assignment. No > functional change. >

[PATCH net-next 2/3] dt-bindings: net: xilinx_axienet: add xlnx,switch-x-sgmii attribute

2021-02-12 Thread Robert Hancock
Document the new xlnx,switch-x-sgmii attribute which is used to indicate that the Ethernet core supports dynamic switching between 1000BaseX and SGMII. Signed-off-by: Robert Hancock --- Documentation/devicetree/bindings/net/xilinx_axienet.txt | 4 1 file changed, 4 insertions(+) diff --git

[PATCH net-next 1/3] net: axienet: hook up nway_reset ethtool operation

2021-02-12 Thread Robert Hancock
Hook up the nway_reset ethtool operation to the corresponding phylink function so that "ethtool -r" can be supported. Signed-off-by: Robert Hancock --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/xilinx/xilinx

[PATCH net-next 0/2] Broadcom PHY driver updates

2021-02-12 Thread Robert Hancock
Updates to the Broadcom PHY driver related to use with copper SFP modules. Robert Hancock (2): net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S net: phy: broadcom: Do not modify LED configuration for SFP module PHYs drivers/net/phy/broadcom.c | 109

[PATCH net-next 3/3] net: axienet: Support dynamic switching between 1000BaseX and SGMII

2021-02-12 Thread Robert Hancock
Newer versions of the Xilinx AXI Ethernet core (specifically version 7.2 or later) allow the core to be configured with a PHY interface mode of "Both", allowing either 1000BaseX or SGMII modes to be selected at runtime. Add support for this in the driver to allow better support for applications whi

[PATCH net-next] mptcp: add local addr info in mptcp_info

2021-02-12 Thread Mat Martineau
From: Geliang Tang Add mptcpi_local_addr_used and mptcpi_local_addr_max in struct mptcp_info. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- include/uapi/linux/mptcp.h | 2 ++ net/mptcp/mptcp_diag.c | 2 ++ net/mptcp/pm_netlink.c | 3 ++- net/mptcp/protocol.h | 1 +

Re: pull-request: wireless-drivers-next-2021-02-12

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 10:59:33 + (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with

Re: [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 13:48:14 +0300 you wrote: > As udp_port_cfg struct changes its members with dependency on IPv6 > configuration, the code in rxrpc should also check for IPv6. > > Fixes: 1a9b86c9fd95 ("rxrpc: use udp tun

Re: [PATCH] appletalk: Fix skb allocation size in loopback case

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 11 Feb 2021 21:27:54 -0800 you wrote: > If a DDP broadcast packet is sent out to a non-gateway target, it is > also looped back. There is a potential for the loopback device to have a > longer hardware header length than

RE: [PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-12 Thread Bryan.Whitehead
Hi Sven, see below. > + if (buffer_info->dma_ptr) { > + /* unmap from dma */ > + packet_length = RX_DESC_DATA0_FRAME_LENGTH_GET_ > + (le32_to_cpu(descriptor->data0)); > + if (packet_length == 0 || > + p

Re: [PATCH net-next v2 0/4] add HSR offloading support for DSA switches

2021-02-12 Thread Vladimir Oltean
On Sat, Feb 13, 2021 at 12:52:36AM +0100, Tobias Waldekranz wrote: > On Wed, Feb 10, 2021 at 23:55, Vladimir Oltean wrote: > > On Wed, Feb 10, 2021 at 10:10:14PM +0100, Tobias Waldekranz wrote: > >> This whole thing sounds an awful lot like an FDB. I suppose an option > >> would be to implement th

Re: [PATCH net-next 0/4] mptcp: Selftest enhancement and fixes

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 15:20:26 -0800 you wrote: > This is a collection of selftest updates from the MPTCP tree. > > Patch 1 uses additional 'ss' command line parameters and 'nstat' to > improve output when certain MPTCP tes

Re: [PATCH net-next 1/2] net: phylink: explicitly configure in-band autoneg for PHYs that support it

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 11:40:59PM +0100, Michael Walle wrote: > Am 2021-02-12 18:23, schrieb Vladimir Oltean: > > From: Vladimir Oltean > > > > Currently Linux has no control over whether a MAC-to-PHY interface uses > > in-band signaling or not, even though phylink has the > > managed = "in-

[PATCH net-next 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Robert Hancock
bcm54xx_config_init was modifying the PHY LED configuration to enable link and activity indications. However, some SFP modules (such as Bel-Fuse SFP-1GBT-06) have no LEDs but use the LED outputs to control the SFP LOS signal, and modifying the LED settings will cause the LOS output to malfunction.

[PATCH net-next 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Robert Hancock
The default configuration for the BCM54616S PHY may not match the desired mode when using 1000BaseX or SGMII interface modes, such as when it is on an SFP module. Add code to explicitly set the correct mode using programming sequences provided by Bel-Fuse: https://www.belfuse.com/resources/datashe

RE: [PATCH net-next v2 1/5] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-12 Thread Bryan.Whitehead
Hi Sven, > Subject: [PATCH net-next v2 1/5] lan743x: boost performance on cpu archs > w/o dma cache snooping > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Sven Van Asbroeck > > The buffers in the lan743x driver's receive ring are alw

[PATCH net] net: axienet: Handle deferred probe on clock properly

2021-02-12 Thread Robert Hancock
This driver is set up to use a clock mapping in the device tree if it is present, but still work without one for backward compatibility. However, if getting the clock returns -EPROBE_DEFER, then we need to abort and return that error from our driver initialization so that the probe can be retried l

[PATCH net-next 0/3] Xilinx axienet updates

2021-02-12 Thread Robert Hancock
Updates to the Xilinx AXI Ethernet driver to add support for an additional ethtool operation, and to support dynamic switching between 1000BaseX and SGMII interface modes. Robert Hancock (3): net: axienet: hook up nway_reset ethtool operation dt-bindings: net: xilinx_axienet: add xlnx,switch-x

Re: [PATCH bpf-next V16 0/7] bpf: New approach for BPF MTU handling

2021-02-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 09 Feb 2021 14:38:04 +0100 you wrote: > This patchset drops all the MTU checks in TC BPF-helpers that limits > growing the packet size. This is done because these BPF-helpers doesn't > take redirect into account, whic

Re: [PATCH net-next 1/2] net: phylink: explicitly configure in-band autoneg for PHYs that support it

2021-02-12 Thread Russell King - ARM Linux admin
On Fri, Feb 12, 2021 at 11:40:59PM +0100, Michael Walle wrote: > Fun fact, now it may be the other way around. If the bootloader doesn't > configure it and the PHY isn't reset by the hardware, it won't work in > the bootloader after a reboot ;) If we start messing around with the configuration of

[PATCH net-next 11/12] net: dsa: felix: setup MMIO filtering rules for PTP when using tag_8021q

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean Since the tag_8021q tagger is software-defined, it has no means by itself for retrieving hardware timestamps of PTP event messages. Because we do want to support PTP on ocelot even with tag_8021q, we need to use the CPU port module for that. The RX timestamp is present in t

RE: [PATCH net-next v2 0/5] lan743x speed boost

2021-02-12 Thread Bryan.Whitehead
Hi Sven, see below > - Bryan Whitehead: > + multi-buffer patch concept "looks good". > As a result, I will squash the intermediate "dma buffer only" patch > which > demonstrated the speed boost using an inflexible solution > (w/o multi-buffers). > + Rename lan743x_rx_pr

[PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean On TX, use the result of the ptp_classify_raw() BPF classifier from dsa_skb_tx_timestamp() to divert some frames over to the MMIO-based injection registers. On RX, set up a VCAP IS2 rule that redirects the frames with an EtherType for 1588 to the CPU port module (for MMIO b

[PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The ocelot tagger is a hot mess currently, it relies on memory initialized by the attached driver for basic frame transmission. This is against all that DSA tagging protocols stand for, which is that the transmission and reception of a DSA-tagged frame, the data path, should

[PATCH net-next 10/12] net: mscc: ocelot: refactor ocelot_xtr_irq_handler into ocelot_xtr_poll

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean Since the felix DSA driver will need to poll the CPU port module for extracted frames as well, let's create some common functions that read an Extraction Frame Header, and then an skb, from a CPU extraction group. We abuse the struct ocelot_ops :: port_to_netdev function a

[PATCH net-next 07/12] net: mscc: ocelot: use common tag parsing code with DSA

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The Injection Frame Header and Extraction Frame Header that the switch prepends to frames over the NPI port is also prepended to frames delivered over the CPU port module's queues. Let's unify the handling of the frame headers by making the ocelot driver call some helpers e

[PATCH net-next 08/12] net: dsa: tag_ocelot: single out PTP-related transmit tag processing

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean There is one place where we cannot avoid accessing driver data, and that is 2-step PTP TX timestamping, since the switch wants us to provide a timestamp request ID through the injection header, which naturally must come from a sequence number kept by the driver (it is genera

[PATCH net-next 06/12] net: dsa: tag_ocelot: avoid accessing ds->priv in ocelot_rcv

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean Taggers should be written to do something valid irrespective of the switch driver that they are attached to. This is even more true now, because since the introduction of the .change_tag_protocol method, a certain tagger is not necessarily strictly associated with a driver a

[PATCH net-next 05/12] net: mscc: ocelot: refactor ocelot_port_inject_frame out of ocelot_port_xmit

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The felix DSA driver will inject some frames through register MMIO, same as ocelot switchdev currently does. So we need to be able to reuse the common code. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot.c | 80 + drivers/n

[PATCH net-next 02/12] net: mscc: ocelot: only drain extraction queue on error

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean It appears that the intention of this snippet of code is to not exit ocelot_xtr_irq_handler() while in the middle of extracting a frame. The problem in extracting it word by word is that future extraction attempts are really easy to get desynchronized, since the IRQ handler

[PATCH net-next 03/12] net: mscc: ocelot: better error handling in ocelot_xtr_irq_handler

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The ocelot_rx_frame_word() function can return a negative error code, however this isn't being checked for consistently. Errors being ignored have not been seen in practice though. Also, some constructs can be simplified by using "goto" instead of repeated "break" statement

[PATCH net-next 01/12] net: mscc: ocelot: stop returning IRQ_NONE in ocelot_xtr_irq_handler

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean Since the xtr (extraction) IRQ of the ocelot switch is not shared, then if it fired, it means that some data must be present in the queues of the CPU port module. So simplify the code. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- drivers/net/ethernet/

[PATCH net-next 04/12] net: mscc: ocelot: use DIV_ROUND_UP helper in ocelot_port_inject_frame

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean This looks a bit nicer than the open-coded "(x + 3) % 4" idiom. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/msc

[PATCH net-next 00/12] PTP for DSA tag_ocelot_8021q

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean This is part two of the errata workaround begun here: https://patchwork.kernel.org/project/netdevbpf/cover/20210129010009.3959398-1-olte...@gmail.com/ Now that we have basic traffic support when we operate the Ocelot DSA switches without an NPI port, it would be nice to reg

[PATCH net-next 8/8] mptcp: add netlink event support

2021-02-12 Thread Mat Martineau
From: Florian Westphal Allow userspace (mptcpd) to subscribe to mptcp genl multicast events. This implementation reuses the same event API as the mptcp kernel fork to ease integration of existing tools, e.g. mptcpd. Supported events include: 1. start and close of an mptcp connection 2. start and

pull-request: bpf 2021-02-13

2021-02-12 Thread Daniel Borkmann
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net* tree. We've added 2 non-merge commits during the last 3 day(s) which contain a total of 2 files changed, 9 insertions(+), 11 deletions(-). The main changes are: 1) Fix mod32 truncation handling in verifier, from

[PATCH net-next 2/8] mptcp: split __mptcp_close_ssk helper

2021-02-12 Thread Mat Martineau
From: Florian Westphal Prepare for subflow close events: When mptcp connection is torn down its enough to send the mptcp socket close notification rather than a subflow close event for all of the subflows followed by the mptcp close event. This splits the helper: mptcp_close_ssk() will emit the

[PATCH net-next 6/8] mptcp: avoid lock_fast usage in accept path

2021-02-12 Thread Mat Martineau
From: Florian Westphal Once event support is added this may need to allocate memory while msk lock is held with softirqs disabled. Not using lock_fast also allows to do the allocation with GFP_KERNEL. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 5 +

[PATCH net-next 3/8] mptcp: schedule worker when subflow is closed

2021-02-12 Thread Mat Martineau
From: Florian Westphal When remote side closes a subflow we should schedule the worker to dispose of the subflow in a timely manner. Otherwise, SF_CLOSED event won't be generated until the mptcp socket itself is closing or local side is closing another subflow. Signed-off-by: Florian Westphal

[PATCH net-next 1/8] mptcp: move pm netlink work into pm_netlink

2021-02-12 Thread Mat Martineau
From: Florian Westphal Allows to make some functions static and avoids acquire of the pm spinlock in protocol.c. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 45 +- net/mptcp/protocol.c | 33 +--

[PATCH net-next 5/8] mptcp: pass subflow socket to a few helpers

2021-02-12 Thread Mat Martineau
From: Florian Westphal Pass the first/initial subflow to the existing functions so they can pass this on to the notification handler that is added later in the series. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/options.c | 2 +- net/mptcp/pm.c | 4 ++--

[PATCH net-next 4/8] mptcp: move subflow close loop after sk close check

2021-02-12 Thread Mat Martineau
From: Florian Westphal In case mptcp socket is already dead the entire mptcp socket will be freed. We can avoid the close check in this case. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH net-next 0/8] mptcp: Add genl events for connection info

2021-02-12 Thread Mat Martineau
This series from the MPTCP tree adds genl multicast events that are important for implementing a userspace path manager. In MPTCP, a path manager is responsible for adding or removing additional subflows on each MPTCP connection. The in-kernel path manager (already part of the kernel) is a better f

Re: [PATCH net-next v2 0/4] add HSR offloading support for DSA switches

2021-02-12 Thread Tobias Waldekranz
On Wed, Feb 10, 2021 at 23:55, Vladimir Oltean wrote: > On Wed, Feb 10, 2021 at 10:10:14PM +0100, Tobias Waldekranz wrote: >> On Tue, Feb 09, 2021 at 11:04, George McCollister >> wrote: >> >> > It also doesn't implement a ProxyNodeTable (though that actually >> >> > wouldn't matter if you were o

[PATCH 2/2] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-12 Thread Shuah Khan
ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add call to lockdep_assert_not_held() on conf_mutex to detect if conf_mutex is held by the caller. The idea for this patch stemmed from coming across the comment block above the ath10k_drain_tx() while reviewin

[PATCH 0/2] Add lockdep_assert_not_held()

2021-02-12 Thread Shuah Khan
Some kernel functions must not be called holding a specific lock. Doing so could lead to locking problems. Currently these routines call lock_is_held() to check for lock hold followed by WARN_ON. Adding a common lockdep interface will help reduce the duplication of this logic in the rest of the ke

[PATCH 1/2] lockdep: add lockdep_assert_not_held()

2021-02-12 Thread Shuah Khan
Some kernel functions must not be called holding a specific lock. Doing so could lead to locking problems. Currently these routines call lock_is_held() to check for lock hold followed by WARN_ON. Adding a common lockdep interface will help reduce the duplication of this logic in the rest of the ke

[PATCH net-next 4/4] selftests: mptcp: fail if not enough SYN/3rd ACK

2021-02-12 Thread Mat Martineau
From: Matthieu Baerts If we receive less MPCapable SYN or 3rd ACK than expected, we now mark the test as failed. On the other hand, if we receive more, we keep the warning but we add a hint that it is probably due to retransmissions and that's why we don't mark the test as failed. Closes: https

[PATCH net-next 3/4] selftests: mptcp: display warnings on one line

2021-02-12 Thread Mat Martineau
From: Matthieu Baerts Before we had this in case of SYN retransmissions: (...) # ns4 MPTCP -> ns2 (10.0.1.2:10034 ) MPTCP (duration 1201ms) [ OK ] # ns4 MPTCP -> ns2 (dead:beef:1::2:10035) MPTCP (duration 1242ms) [ OK ] # ns4 MPTCP -> ns2 (10.0.2.1:10036 ) MPTCP

[PATCH net-next 2/4] selftests: mptcp: fix ACKRX debug message

2021-02-12 Thread Mat Martineau
From: Matthieu Baerts Info from received MPCapable SYN were printed instead of the ones from received MPCapable 3rd ACK. Fixes: fed61c4b584c ("selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally") Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau --- tools/

[PATCH net-next 2/2] tcp: factorize logic into tcp_epollin_ready()

2021-02-12 Thread Eric Dumazet
From: Eric Dumazet Both tcp_data_ready() and tcp_stream_is_readable() share the same logic. Add tcp_epollin_ready() helper to avoid duplication. Signed-off-by: Eric Dumazet Cc: Arjun Roy Cc: Wei Wang --- include/net/tcp.h| 12 net/ipv4/tcp.c | 16 net

[PATCH net-next 1/4] selftests: mptcp: dump more info on errors

2021-02-12 Thread Mat Martineau
From: Paolo Abeni Even if that may sound completely unlikely, the mptcp implementation is not perfect, yet. When the self-tests report an error we usually need more information of what the scripts currently report. iproute allow provides some additional goodies since a few releases, let's dump t

  1   2   3   >