Fix to return negative error code -ENOMEM from the ioremap() error
handling case instead of 0, as done elsewhere in this function.
Fixes: 1958fc2f0712 ("net/mlx5: SF, Add auxiliary device driver")
Reported-by: Hulk Robot
Signed-off-by: Wei Yongjun
---
.../net/ethernet/mellanox/mlx5/core/sf/dev/
From: Hao Chen
hclge_rm_vport_all_mac_table() is bloated, so split it into
separate functions for readability and maintainability.
Signed-off-by: Hao Chen
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 67 ++
1 file changed, 43 inserti
To make it more readable and maintainable, split
hclgevf_set_rss_tuple() into two parts.
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 47 +++---
1 file changed, 32 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/
From: Jian Shen
hclge_dbg_dump_qos_buf_cfg() is bloated, so split it into
separate functions for readability and maintainability.
Signed-off-by: Jian Shen
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 158 +++--
1 file changed, 115 insert
From: Yufeng Mo
hclge_cmd_send() is bloated, so split it into separate
functions for readability and maintainability.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
.../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 100 -
1 file changed, 59 insertions(+), 41 d
From: Jian Shen
To improve code readability and maintainability, separate
the flow type parsing part and the converting part from
bloated hclge_get_rss_tuple().
Signed-off-by: Jian Shen
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 59 ++-
From: Jiaran Zhang
Use common ipv6_addr_any() to determine if an addr is ipv6 any addr.
Signed-off-by: Jiaran Zhang
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers
From: Yufeng Mo
hclgevf_cmd_send() is bloated, so split it into separate
functions for readability and maintainability.
Signed-off-by: Yufeng Mo
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 141 -
1 file changed, 81 insertions(+), 60
From: Peng Li
To improve code readability and maintainability, refactor
hclge_cmd_convert_err_code() with an array of imp_errcode
and common_errno mapping, instead of a bloated switch/case.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
.../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd
To improve code readability and maintainability, the series
refactor out some bloated functions in the HNS3 ethernet driver.
Hao Chen (1):
net: hns3: refactor out hclge_rm_vport_all_mac_table()
Huazhong Tan (2):
net: hns3: refactor out hclge_set_rss_tuple()
net: hns3: refactor out hclgevf_s
From: Jian Shen
To improve code readability and maintainability, separate
the flow type parsing part and the converting part from
bloated hclgevf_get_rss_tuple().
Signed-off-by: Jian Shen
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 67 ++---
From: Peng Li
To improve code readability and maintainability, separate
the command handling part and the status parsing part from
bloated hclge_set_vf_vlan_common().
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 63 +++
From: Peng Li
To improve code readability and maintainability, refactor
hclgevf_cmd_convert_err_code() with an array of imp_errcode
and common_errno mapping, instead of a bloated switch/case.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd
To make it more readable and maintainable, split
hclge_set_rss_tuple() into two parts.
Signed-off-by: Huazhong Tan
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 42 +++---
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hn
From: Peng Li
As more commands are added, hns3_dbg_cmd_write() is going to
get more bloated, so move the part about command check into
a separate function.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 44 +-
1
Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
> WARNING: Comparison of 0/1 to bool variable.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Patch applied to wireless-drivers-next.git, thanks.
8
Jiapeng Chong wrote:
> Fix the follow coccicheck warnings:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27:
> WARNING: Comparison of 0/1 to bool variable.
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26:
> WARNING: Comparison of 0/1 to bool variable.
>
>
Fix to return negative error code from the mlx5e_tc_tun_init() error
handling case instead of 0, as done elsewhere in this function.
This commit also using 0 instead of 'ret' when success since it is
always equal to 0.
Fixes: 8914add2c9e5 ("net/mlx5e: Handle FIB events to update tunnel endpoint
>From f6a04bc0abfae1065577888fc6467f9f162863f6 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu
Date: Wed, 3 Feb 2021 13:15:23 -0800
Subject: [PATCH net] ibmvnic: Set to CLOSED state even on error
If set_link_state() fails for any reason, we still cleanup the adapter
state and cannot recover
>From 0d6616e843973d2f052ea09237c16667802b52e3 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu
Date: Wed, 20 Jan 2021 21:10:15 -0800
Subject: [PATCH net v3] ibmvnic: fix a race between open and reset
__ibmvnic_reset() currently reads the adapter->state before getting the
rtnl and saves that
On 09.02.2021 17:40, Michael Walle wrote:
> Registers >= 16 are paged. Be sure to set the page. It seems this was
> working for now, because the default is correct for the registers used
> in the driver at the moment. But this will also assume, nobody will
> change the page select register before l
From: huangxuesen
bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
encapsulation. But that is not appropriate when pushing Ethernet header.
Add an option to further specify encap L2 type and set the inner_protocol
as ETH_P_TEB.
Suggested-by: Willem de Bruijn
Signed-off-
On 10.02.2021 01:32, Stephen Hemminger wrote:
> On Tue, 9 Feb 2021 18:35:54 +0100
> Anton Hvornum wrote:
>
>> Hi.
>>
>> I am a bit new to ethtool, kernel drivers and all the surrounding aspects.
>> I also recognize that my use case is of low priority and a bit niche,
>> but any response would be
Hi,
On Mon, 8 Feb 2021 16:56:00 +0300 Serge Semin wrote:
>
> Since commit bb3222f71b57 ("net: stmmac: platform: use optional clk/reset
> get APIs") a manual implementation of the optional device reset control
> functionality has been replaced with using the
> devm_reset_control_get_optional() m
On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote:
> On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote:
> > This may be a stupid suggestion, but would the integration look less a
> > backdoor if it would have been named "mhi_wwan" and it exposed already
> > all the AT+DIAG+QMI
On Tue, Feb 09, 2021 at 12:27:01PM +0100, Marco Elver wrote:
> For double-checked locking in bpf_common_lru_push_free(), node->type is
> read outside the critical section and then re-checked under the lock.
> However, concurrent writes to node->type result in data races.
>
> For example, the follo
On Fri, 2021-02-05 at 10:55 +0100, Lukas Bulwahn wrote:
> Commit 142d93d12dc1 ("net/mlx5: Add devlink subfunction port
> documentation") refers to a section 'mlx5 port function' in the table
> of
> contents, but includes a section 'mlx5 function attributes' instead.
>
> Hence, make htmldocs warns:
On Tue, 2021-02-09 at 11:49 -0800, Jonathan Lemon wrote:
> On mlx5e fails to compile on the latesst net-next:
>
> CC drivers/net/ethernet/mellanox/mlx5/core/en_main.o
> In file included from
> ../drivers/net/ethernet/mellanox/mlx5/core/en_tc.h:40,
> from
> ../drivers/net/et
On Wed, 2021-02-10 at 10:50 +0530, Naresh Kamboju wrote:
> While building Linux next tag 20210209 s390 (defconfig) with gcc-9
> make modules failed.
>
...
> Reported-by: Naresh Kamboju
>
Thanks for the report a patch was already posted earlier today
https://patchwork.ker
While building Linux next tag 20210209 s390 (defconfig) with gcc-9
make modules failed.
- s390 (defconfig) with gcc-8 - FAILED
- s390 (defconfig) with gcc-9 - FAILED
- s390 (defconfig) with gcc-10 - FAILED
make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH
Linux next tag 20210209 arm omap2plus_defconfig make modules failed.
- arm (omap2plus_defconfig) with gcc-10 - FAILED
- arm (omap2plus_defconfig) with gcc-9 - FAILED
- arm (omap2plus_defconfig) with gcc-8 - FAILED
make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds
On 2/9/21 4:46 PM, Arjun Roy wrote:
> On Tue, Feb 9, 2021 at 8:59 AM Jakub Kicinski wrote:
>>
>> On Mon, 8 Feb 2021 20:20:29 -0700 David Ahern wrote:
>>> On 2/8/21 7:53 PM, Jakub Kicinski wrote:
On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote:
> That would be the case for new userspac
On 2021/2/10 上午10:36, Willem de Bruijn wrote:
On Tue, Feb 9, 2021 at 11:39 AM Michael S. Tsirkin wrote:
On Tue, Feb 09, 2021 at 01:45:11PM +0800, Jason Wang wrote:
On 2021/2/9 上午2:55, Willem de Bruijn wrote:
From: Willem de Bruijn
Add optional PTP hardware tx timestamp offload for virtio-n
On 2021/2/10 上午12:38, Michael S. Tsirkin wrote:
On Tue, Feb 09, 2021 at 01:45:11PM +0800, Jason Wang wrote:
On 2021/2/9 上午2:55, Willem de Bruijn wrote:
From: Willem de Bruijn
Add optional PTP hardware tx timestamp offload for virtio-net.
Accurate RTT measurement requires timestamps close to
On 2021/2/9 下午9:53, Willem de Bruijn wrote:
On Mon, Feb 8, 2021 at 11:13 PM Jason Wang wrote:
On 2021/2/9 上午2:55, Willem de Bruijn wrote:
From: Willem de Bruijn
Add optional PTP hardware rx timestamp offload for virtio-net.
Accurate RTT measurement requires timestamps close to the wire.
On 2/9/2021 5:02 PM, George McCollister wrote:
> Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
> forwarding and duplication supported by the xrs7000 series switches.
>
> Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR
> v0 is not).
>
> Signed-off-
On 2/9/2021 5:02 PM, George McCollister wrote:
> Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion
> tag removal, duplicate generation and forwarding on DSA switches.
>
> Add DSA_NOTIFIER_HSR_JOIN and DSA_NOTIFIER_HSR_LEAVE which trigger calls
> to .port_hsr_join and .port_hsr_l
On 2021/2/10 上午8:26, Si-Wei Liu wrote:
On 2/8/2021 7:37 PM, Jason Wang wrote:
On 2021/2/6 下午8:29, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from device. The saved avail_index is used
to restat
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote:
On 2021/2/8 下午6:04, Eli Cohen wrote:
On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote:
On 2021/2/8 下
Another pile of networing fixes:
1) ath9k build error fix from Arnd Bergmann
2) dma memory leak fix in mediatec driver from Lorenzo Bianconi.
3) bpf int3 kprobe fix from Alexei Starovoitov.
4) bpf stackmap integer overflow fix from Bui Quang Minh.
5) Add usb device ids for Cinterion MV31 to
On 2/9/21 2:08 PM, Song Liu wrote:
On Feb 9, 2021, at 1:30 PM, Alexei Starovoitov
wrote:
On Mon, Feb 08, 2021 at 02:52:52PM -0800, Song Liu wrote:
Introduce task_vma bpf_iter to print memory information of a process. It
can be used to print customized information similar to /proc//maps.
C
> +static inline u32 enet_read(struct bcm4908_enet *enet, u16 offset)
> +{
> + return readl(enet->base + offset);
> +}
No inline functions in C files please. Let the compiler decide.
> +static int bcm4908_dma_alloc_buf_descs(struct bcm4908_enet *enet,
> +st
On Tue, Feb 9, 2021 at 11:39 AM Michael S. Tsirkin wrote:
>
> On Tue, Feb 09, 2021 at 01:45:11PM +0800, Jason Wang wrote:
> >
> > On 2021/2/9 上午2:55, Willem de Bruijn wrote:
> > > From: Willem de Bruijn
> > >
> > > Add optional PTP hardware tx timestamp offload for virtio-net.
> > >
> > > Accurat
On 2021-02-10 08:42, Shuah Khan wrote:
ath10k_mac_get_rate_flags_ht() floods dmesg with the following
messages,
when it fails to find a match for mcs=7 and rate=1440.
supported_ht_mcs_rate_nss2:
{7, {1300, 2700, 1444, 3000} }
ath10k_pci :02:00.0: invalid ht params rate 1440 100kbps nss 2
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote:
On 2021/2/8 下午6:04, Eli Cohen wrote:
On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote:
On 2021/2/8 下午2:37, Eli Cohen wrote:
On Mon, Feb 08, 2
Remove NULL checks before vfree() to fix these warnings:
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3558:2-8: WARNING: NULL
check before some freeing functions is not needed.
Signed-off-by: Tian Tao
---
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 3 +--
1 file changed, 1 insertion(+), 2
From: Cong Wang
Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly
does not work for any other non-TCP protocols. We can move them to
skb ext instead of playing with skb cb, which is harder to make
correct.
Cc: John Fastabend
Cc: Daniel Borkmann
Cc: Jakub Sitnicki
Cc: Lorenz Bau
From: Cong Wang
These two eBPF programs are tied to BPF_SK_SKB_STREAM_PARSER
and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact
they are only used for TCP. And save the name 'skb_verdict' for
general use later.
Cc: John Fastabend
Cc: Daniel Borkmann
Cc: Jakub Sitnicki
Cc: Lorenz B
From: Cong Wang
struct sk_psock_parser is embedded in sk_psock, it is
unnecessary as skb verdict also uses ->saved_data_ready.
We can simply fold these fields into sk_psock, and get rid
of ->enabled.
Cc: John Fastabend
Cc: Daniel Borkmann
Cc: Jakub Sitnicki
Cc: Lorenz Bauer
Signed-off-by: Co
From: Cong Wang
Currently, we compute ->data_end with a compile-time constant
offset of skb. But as Jakub pointed out, we can actually compute
it in eBPF JIT code at run-time, so that we can competely get
rid of ->data_end. This is similar to skb_shinfo(skb) computation
in bpf_convert_shinfo_acce
From: Cong Wang
This patchset is the first series of patches separated out from
the original large patchset, to make reviews easier. This patchset
does not add any new feature but merely cleans up the existing
sockmap and skmsg code and refactors it, to prepare for the patches
followed up. This p
From: Cong Wang
As suggested by John, clean up sockmap related Kconfigs:
Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream
parser, to reflect its name.
Make the rest sockmap code simply depend on CONFIG_BPF_SYSCALL.
And leave CONFIG_NET_SOCK_MSG untouched, as it is used by
non-soc
On 09.02.2021 22:43, Rob Herring wrote:
On Sun, Feb 07, 2021 at 11:26:31PM +0100, Rafał Miłecki wrote:
From: Rafał Miłecki
BCM4908 is a family of SoCs with integrated Ethernet controller.
Signed-off-by: Rafał Miłecki
---
.../bindings/net/brcm,bcm4908enet.yaml| 45 ++
On Tue, Feb 09, 2021 at 05:40:51PM +0100, Michael Walle wrote:
> Implement the operations to set desired mode and retrieve the current
> mode.
>
> This feature was tested with an IP101G.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:40:50PM +0100, Michael Walle wrote:
> The IP101G provides three counters: RX packets, CRC errors and symbol
> errors. The error counters can be configured to clear automatically on
> read. Unfortunately, this isn't true for the RX packet counter. Because
> of this and bec
On Tue, Feb 09, 2021 at 05:40:49PM +0100, Michael Walle wrote:
> Registers >= 16 are paged. Be sure to set the page. It seems this was
> working for now, because the default is correct for the registers used
> in the driver at the moment. But this will also assume, nobody will
> change the page sel
On Tue, Feb 09, 2021 at 05:40:48PM +0100, Michael Walle wrote:
> This bit is reserved as 'always-write-1'. While this is not a particular
> error, because we are only setting it, guard it by checking the model to
> prevent errors in the future.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andre
On Tue, Feb 09, 2021 at 05:40:46PM +0100, Michael Walle wrote:
> The PHY core already resets the PHY before .config_init() if a
> .soft_reset() op is registered. Drop the open-coded ip1xx_reset().
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:40:45PM +0100, Michael Walle wrote:
> Don't sometimes use the address operator and sometimes not. Drop it and
> make the code look uniform.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:40:44PM +0100, Michael Walle wrote:
> According to the datasheet of the IP101A/G there is no revision field
> and MII_PHYSID2 always reads as 0x0c54. Use PHY_ID_MATCH_EXACT() then.
>
> Signed-off-by: Michael Walle
Lets hope the datasheet is correct and up to date, beca
On Tue, Feb 09, 2021 at 05:40:43PM +0100, Michael Walle wrote:
> Simpify the initializations of the structures. There is no functional
> change.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:38:52PM +0100, Michael Walle wrote:
> At the moment, PORT_MII is reported in the ethtool ops. This is odd
> because it is an interface between the MAC and the PHY and no external
> port. Some network card drivers will overwrite the port to twisted pair
> or fiber, though.
> @@ -1552,6 +1552,7 @@ static int marvell_read_status_page(struct phy_device
> *phydev, int page)
> phydev->asym_pause = 0;
> phydev->speed = SPEED_UNKNOWN;
> phydev->duplex = DUPLEX_UNKNOWN;
> + phydev->port = fiber ? PORT_FIBRE : PORT_TP;
>
> if (phydev->autoneg ==
From: Corinna Vinschen
commit 2643e6e90210e16c978919617170089b7c2164f7 upstream
TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
secs on 80576 (45 bit SYSTIM).
This wrap event sets the TSICR.SysWrap bit uncondi
> -Original Message-
> From: Punit Agrawal
> Sent: Tuesday, February 09, 2021 5:35 PM
> To: netdev@vger.kernel.org
> Cc: Brandeburg, Jesse ; Nguyen, Anthony L
> ; daichi1.fu...@toshiba.co.jp;
> nobuhiro1.iwama...@toshiba.co.jp; Corinna Vinschen ;
> Keller, Jacob E ; Brown, Aaron F
> ; J
Hello,
syzbot found the following issue on:
HEAD commit:dd86e7fa Merge tag 'pci-v5.11-fixes-2' of git://git.kernel..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=105930c4d0
kernel config: https://syzkaller.appspot.com/x/.config?x=266a5362c89c8127
das
Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
forwarding and duplication supported by the xrs7000 series switches.
Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR
v0 is not).
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c
Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion
tag removal, duplicate generation and forwarding on DSA switches.
Add DSA_NOTIFIER_HSR_JOIN and DSA_NOTIFIER_HSR_LEAVE which trigger calls
to .port_hsr_join and .port_hsr_leave in the DSA driver for the switch.
The DSA switch drive
Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion
tag removal, duplicate generation and forwarding.
For HSR, insertion involves the switch adding a 6 byte HSR header after
the 14 byte Ethernet header. For PRP it adds a 6 byte trailer.
Tag removal involves automatically stripping t
For a switch to offload insertion of HSR/PRP tags, frames must not be
sent to the CPU facing switch port with a tag. Generate supervision frames
(eth type ETH_P_PRP) without HSR v1 (ETH_P_HSR)/PRP tag and rely on
create_tagged_frame which inserts it later. This will allow skipping the
tag insertion
Add support for offloading HSR/PRP (IEC 62439-3) tag insertion, tag
removal, forwarding and duplication on DSA switches.
This series adds offloading to the xrs700x DSA driver.
Changes since RFC:
* Split hsr and dsa patches. (Florian Fainelli)
Changes since v1:
* Fixed some typos/wording. (Vladi
Hi David, hi Jakub,
The following pull-request contains BPF updates for your *net* tree.
We've added 5 non-merge commits during the last 8 day(s) which contain
a total of 3 files changed, 22 insertions(+), 21 deletions(-).
The main changes are:
1) Fix missed execution of kprobes BPF progs when
> On 10 Feb 2021, at 01:02, Nathan Chancellor wrote:
>
> On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote:
>> On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote:
>>>
>>> On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote:
On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri O
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect the cases where HW can't implement
the functionality or when SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file changed, 14 inser
This patch extends the br_mrp_switchdev functions to be able to have a
better understanding what cause the issue and if the SW needs to be used
as a backup.
There are the following cases:
- when the code is compiled without CONFIG_NET_SWITCHDEV. In this case
return success so the SW can continue
ath10k_mac_get_rate_flags_ht() floods dmesg with the following messages,
when it fails to find a match for mcs=7 and rate=1440.
supported_ht_mcs_rate_nss2:
{7, {1300, 2700, 1444, 3000} }
ath10k_pci :02:00.0: invalid ht params rate 1440 100kbps nss 2 mcs 7
dev_warn_ratelimited() isn't helpin
ath10k_drain_tx() must not be called with conf_mutex held as workers can
use that also. Add check to detect conf_mutex held calls.
Signed-off-by: Shuah Khan
---
drivers/net/wireless/ath/ath10k/mac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c
b/driv
ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and
the resulting pointer is only valid under RCU lock as well.
Fix ath10k_wmi_tlv_parse_peer_stats_info() to hold RCU lock before it
calls ieee80211_find_sta_by_ifaddr() and release it when the resulting
pointer is no longer needed.
Based on the comment block in this function and the FIXME for this, peer
being present for the offchannel tx is unlikely. Peer is deleted once tx
is complete. Change peer present msg to a warn to detect this condition.
Signed-off-by: Shuah Khan
---
drivers/net/wireless/ath/ath10k/mac.c | 5 ++---
Add basic support for MRP. The HW will just trap all MRP frames on the
ring ports to CPU and allow the SW to process them. In this way it is
possible to for this node to behave both as MRM and MRC.
Current limitations are:
- it doesn't support Interconnect roles.
- it supports only a single ring.
This patch series extends MRP switchdev to allow the SW to have a better
understanding if the HW can implement the MRP functionality or it needs
to help the HW to run it. There are 3 cases:
- when HW can't implement at all the functionality.
- when HW can implement a part of the functionality but n
Add the member sw_backup to the structures switchdev_obj_ring_role_mrp
and switchdev_obj_in_role_mrp. In this way the SW can call the driver in
2 ways, once when sw_backup is set to false, meaning that the driver
should implement this completely in HW. And if that is not supported the
SW will call
ath10k_debug_fw_stats_request() is called ath10k_sta_statistics()
without holding conf_mutex. ath10k_debug_fw_stats_request() simply
returns when CONFIG_ATH10K_DEBUGFS is disabled.
When CONFIG_ATH10K_DEBUGFS is enabled, ath10k_debug_fw_stats_request()
code path isn't protected. This assert is trig
I have been seeing lockdep asserts for a couple of months and finally
found time to debug and fix the problems. The dmesg looks clean with
these fixes.
Enabling LOCKDEP and ATH10K_DEBUGFS triggers the lockdep assert and
RCU warns.
The first two patches in this series are fixes to lockdep assert a
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implementation,
- BR_MRP_HW, continue without SW implementation,
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43 ++
On Tue, 9 Feb 2021 18:35:54 +0100
Anton Hvornum wrote:
> Hi.
>
> I am a bit new to ethtool, kernel drivers and all the surrounding aspects.
> I also recognize that my use case is of low priority and a bit niche,
> but any response would be greatly appreciated.
>
> I'm modifying an existing Inte
> Right at the beginning - we implemented PP function into the Kernel
> driver like the SDMA operation (This is the RX/TX DMA engine).
> We do plan to port more and more PP functions as Kernel drivers
> along the way.
It will be interesting to see how well you manage to handle the 'split
brain' p
On 2/8/2021 7:37 PM, Jason Wang wrote:
On 2021/2/6 下午8:29, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from device. The saved avail_index is used
to restate the virtq once device is started. Co
On Tue, Feb 09, 2021 at 02:37:49PM +0800, we...@ucloud.cn wrote:
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -30,6 +30,11 @@
>
> #include
>
> +#define TCA_FLOWER_KEY_CT_FLAGS_MAX \
> + ((__TCA_FLOWER_KEY_CT_FLAGS_MAX - 1) << 1)
> +#define TCA_FLOWER_KEY_CT_F
On Tue, Feb 09, 2021 at 12:09:31PM -0800, Nick Desaulniers wrote:
> On Tue, Feb 9, 2021 at 11:06 AM Jiri Olsa wrote:
> >
> > On Tue, Feb 09, 2021 at 05:13:42PM +0100, Jiri Olsa wrote:
> > > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote:
> > >
> > > SNIP
> > >
> > > > > > > >
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Tue, 9 Feb 2021 22:35:10 +0100 you wrote:
> From: Florian Westphal
>
> The origin skip check needs to re-test the zone. Else, we might skip
> a colliding tuple in the reply direction.
>
> This only occurs when using 'dir
Thanks Jakub. Overlooked new warnings as I was using C=2 flag.
Will fix it in the next version.
From: Jakub Kicinski
Sent: Monday, February 8, 2021 11:10 PM
To: Geethasowjanya Akula
Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-cry...@v
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Mon, 8 Feb 2021 17:16:24 -0800 you wrote:
> This series contains updates to the ice driver and documentation.
>
> Brett adds a log message when a trusted VF goes in and out of promiscuous
> for consistency with i40e d
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 9 Feb 2021 10:41:50 +0800 you wrote:
> There are some cleanups for the HNS3 ethernet driver.
>
> change log:
> V2: remove previous #3 which should target net.
>
> previous version:
> V1:
> https://patchwork.kern
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Mon, 8 Feb 2021 11:34:07 -0800 you wrote:
> The idea of moving the napi poll process out of softirq context to a
> kernel thread based context is not new.
> Paolo Abeni and Hannes Frederic Sowa have proposed patches to
Oliver,
it's been a few weeks, do you have time to post an updated patchset or
is there someone else you would trust to help land this series?
cheers,
grant
On Fri, Jan 22, 2021 at 2:10 AM Grant Grundler wrote:
>
> On Fri, Jan 22, 2021 at 1:29 AM Andrew Lunn wrote:
> >
> > On Thu, Jan 21, 2021
On 2/9/21 3:29 PM, Bhaskar Chowdhury wrote:
>
> s/configation/configuration/
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
Thanks.
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/n
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 9 Feb 2021 09:52:19 +0100 you wrote:
> In vsock_shutdown() we touched some socket fields without holding the
> socket lock, such as 'state' and 'sk_flags'.
>
> Also, after the introduction of multi-transport, we are ac
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Tue, 9 Feb 2021 17:03:04 +0800 you wrote:
> The parameters sent from vf may be unreliable. If these
> parameters are used directly, memory overwriting may occur.
>
> So this series adds some checks for this case.
>
> Yufen
On 2/9/21 8:38 AM, Michael Walle wrote:
> At the moment, PORT_MII is reported in the ethtool ops. This is odd
> because it is an interface between the MAC and the PHY and no external
> port. Some network card drivers will overwrite the port to twisted pair
> or fiber, though. Even worse, the MDI/MD
1 - 100 of 366 matches
Mail list logo
